{"thread":{"id":"26923","subject":"[PATCH] git-pack-objects.txt: fix grammatical errors","startedAt":"2011-03-30T09:00:06Z","lastAt":"2011-04-02T21:16:07Z","messageCount":4,"participants":["Stephen Boyd","Nicolas Pitre","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"164673","messageId":"1301475606-11339-1-git-send-email-bebarino@gmail.com","threadId":"26923","inReplyTo":null,"subject":"[PATCH] git-pack-objects.txt: fix grammatical errors","fromName":"Stephen Boyd","fromEmail":"bebarino@gmail.com","sentAt":"2011-03-30T09:00:06Z","receivedAt":"2011-03-30T09:00:06Z","isPatch":true,"sender":{"key":"bebarino@gmail.com","avatar":"https://avatars.githubusercontent.com/u/38832?v=4"},"body":"Signed-off-by: Stephen Boyd \n---\n\nThis paragraph might need even more work. Paint away!\n\n Documentation/git-pack-objects.txt | 6 +++---\n 1 files changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/Documentation/git-pack-objects.txt b/Documentation/git-pack-objects.txt\nindex a51071e..442018b 100644\n--- a/Documentation/git-pack-objects.txt\n+++ b/Documentation/git-pack-objects.txt\n@@ -190,9 +190,9 @@ self-contained. Use `git index-pack --fix-thin`\n (see linkgit:git-index-pack[1]) to restore the self-contained property.\n \n --delta-base-offset::\n-\tA packed archive can express base object of a delta as\n-\teither 20-byte object name or as an offset in the\n-\tstream, but older version of git does not understand the\n+\tA packed archive can express the base object of a delta as\n+\teither a 20-byte object name or as an offset in the\n+\tstream, but older versions of git don't understand the\n \tlatter. By default, 'git pack-objects' only uses the\n \tformer format for better compatibility. This option\n \tallows the command to use the latter format for\n-- \n1.7.4.2.422.g537d99\n"},{"id":"164954","messageId":"alpine.LFD.2.00.1104021155230.28032@xanadu.home","threadId":"26923","inReplyTo":"1301475606-11339-1-git-send-email-bebarino@gmail.com","subject":"Re: [PATCH] git-pack-objects.txt: fix grammatical errors","fromName":"Nicolas Pitre","fromEmail":"nico@fluxnic.net","sentAt":"2011-04-02T16:03:11Z","receivedAt":"2011-04-02T16:03:11Z","isPatch":true,"sender":{"key":"nico@fluxnic.net","avatar":"https://avatars.githubusercontent.com/u/702790?v=4"},"body":"On Wed, 30 Mar 2011, Stephen Boyd wrote:\n\n> Signed-off-by: Stephen Boyd \n> ---\n> \n> This paragraph might need even more work. Paint away!\n> \n> Documentation/git-pack-objects.txt | 6 +++---\n> 1 files changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/Documentation/git-pack-objects.txt b/Documentation/git-pack-objects.txt\n> index a51071e..442018b 100644\n> --- a/Documentation/git-pack-objects.txt\n> +++ b/Documentation/git-pack-objects.txt\n> @@ -190,9 +190,9 @@ self-contained. Use `git index-pack --fix-thin`\n> (see linkgit:git-index-pack[1]) to restore the self-contained property.\n> \n> --delta-base-offset::\n> -\tA packed archive can express base object of a delta as\n> -\teither 20-byte object name or as an offset in the\n> -\tstream, but older version of git does not understand the\n> +\tA packed archive can express the base object of a delta as\n> +\teither a 20-byte object name or as an offset in the\n> +\tstream, but older versions of git don't understand the\n> \tlatter. By default, 'git pack-objects' only uses the\n> \tformer format for better compatibility. This option\n> \tallows the command to use the latter format for\n\nThis is misleading and not even true anymore if not using pack-objects. \nMost people are using either 'git repack' or even 'git gc', and the \ndefault is to use this parameter since commit 22c79eab.\n\n\nNicolas\n"},{"id":"164957","messageId":"7vy63sh6p7.fsf@alter.siamese.dyndns.org","threadId":"26923","inReplyTo":"alpine.LFD.2.00.1104021155230.28032@xanadu.home","subject":"Re: [PATCH] git-pack-objects.txt: fix grammatical errors","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-04-02T18:03:00Z","receivedAt":"2011-04-02T18:03:00Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Nicolas Pitre writes:\n\n>> diff --git a/Documentation/git-pack-objects.txt b/Documentation/git-pack-objects.txt\n>> index a51071e..442018b 100644\n>> --- a/Documentation/git-pack-objects.txt\n>> +++ b/Documentation/git-pack-objects.txt\n>> @@ -190,9 +190,9 @@ self-contained. Use `git index-pack --fix-thin`\n>> (see linkgit:git-index-pack[1]) to restore the self-contained property.\n>> \n>> --delta-base-offset::\n>> +\tA packed archive can express the base object of a delta as\n>> +\teither a 20-byte object name or as an offset in the\n>> +\tstream, but older versions of git don't understand the\n>> \tlatter. By default, 'git pack-objects' only uses the\n>> \tformer format for better compatibility. This option\n>> \tallows the command to use the latter format for\n>\n> This is misleading and not even true anymore if not using pack-objects. \n> Most people are using either 'git repack' or even 'git gc', and the \n> default is to use this parameter since commit 22c79eab.\n\nThis page is on the pack-objects plumbing, and in that context there is\nnothing misleading nor false about it.\n\nWe may however want to do something like the attached to help people who\nmight wonder how to pass this option through the Porcelain they use. In\nthe longer term, it probably makes sense to make the option default at a\nversion bump, perhaps at the 1.8.0 boundary.\n\n\n Documentation/git-pack-objects.txt | 7 ++++++-\n 1 files changed, 6 insertions(+), 1 deletions(-)\n\ndiff --git a/Documentation/git-pack-objects.txt b/Documentation/git-pack-objects.txt\nindex a9c373c..96684bc 100644\n--- a/Documentation/git-pack-objects.txt\n+++ b/Documentation/git-pack-objects.txt\n@@ -192,13 +192,18 @@ self-contained. Use `git index-pack --fix-thin`\n --delta-base-offset::\n \tA packed archive can express the base object of a delta as\n \teither a 20-byte object name or as an offset in the\n-\tstream, but older versions of git don't understand the\n+\tstream, but ancient versions of git don't understand the\n \tlatter. By default, 'git pack-objects' only uses the\n \tformer format for better compatibility. This option\n \tallows the command to use the latter format for\n \tcompactness. Depending on the average delta chain\n \tlength, this option typically shrinks the resulting\n \tpackfile by 3-5 per-cent.\n++\n+Note: Porcelain commands such as `git gc` (see linkgit:git-gc[1]),\n+`git repack` (see linkgit:git-repack[1]) pass this option by default\n+in modern git when they put objects in your repository into pack files.\n+So does `git bundle` (see linkgit:git-bundle[1]) when it creates a bundle.\n \n --threads=::\n \tSpecifies the number of threads to spawn when searching for best\n"},{"id":"164964","messageId":"alpine.LFD.2.00.1104021713480.28032@xanadu.home","threadId":"26923","inReplyTo":"7vy63sh6p7.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] git-pack-objects.txt: fix grammatical errors","fromName":"Nicolas Pitre","fromEmail":"nico@fluxnic.net","sentAt":"2011-04-02T21:16:07Z","receivedAt":"2011-04-02T21:16:07Z","isPatch":true,"sender":{"key":"nico@fluxnic.net","avatar":"https://avatars.githubusercontent.com/u/702790?v=4"},"body":"On Sat, 2 Apr 2011, Junio C Hamano wrote:\n\n> Nicolas Pitre writes:\n> \n> >> diff --git a/Documentation/git-pack-objects.txt b/Documentation/git-pack-objects.txt\n> >> index a51071e..442018b 100644\n> >> --- a/Documentation/git-pack-objects.txt\n> >> +++ b/Documentation/git-pack-objects.txt\n> >> @@ -190,9 +190,9 @@ self-contained. Use `git index-pack --fix-thin`\n> >> (see linkgit:git-index-pack[1]) to restore the self-contained property.\n> >> \n> >> --delta-base-offset::\n> >> +\tA packed archive can express the base object of a delta as\n> >> +\teither a 20-byte object name or as an offset in the\n> >> +\tstream, but older versions of git don't understand the\n> >> \tlatter. By default, 'git pack-objects' only uses the\n> >> \tformer format for better compatibility. This option\n> >> \tallows the command to use the latter format for\n> >\n> > This is misleading and not even true anymore if not using pack-objects. \n> > Most people are using either 'git repack' or even 'git gc', and the \n> > default is to use this parameter since commit 22c79eab.\n> \n> This page is on the pack-objects plumbing, and in that context there is\n> nothing misleading nor false about it.\n\nTrue. But...\n\n> We may however want to do something like the attached to help people who\n> might wonder how to pass this option through the Porcelain they use.\n\nThat's the kind of precision I was meaning.\n\n> the longer term, it probably makes sense to make the option default at a\n> version bump, perhaps at the 1.8.0 boundary.\n\nAgreed.\n\n\nNicolas\n"}]}