{"thread":{"id":"26903","subject":"contrib/thunderbird-patch-inline: do not require /bin/bash to run","startedAt":"2011-03-29T07:08:07Z","lastAt":"2011-03-30T18:53:28Z","messageCount":3,"participants":["Maxin john","Drew Northup"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"164539","messageId":"AANLkTinUh0BX3O+2Y1CiUTx7xvzW6ydrAGiGQUx4pbeP@mail.gmail.com","threadId":"26903","inReplyTo":null,"subject":"contrib/thunderbird-patch-inline: do not require /bin/bash to run","fromName":"Maxin john","fromEmail":"maxin@maxinbjohn.info","sentAt":"2011-03-29T07:08:07Z","receivedAt":"2011-03-29T07:08:07Z","isPatch":false,"sender":{"key":"maxin@maxinbjohn.info","avatar":null},"body":"contrib/thunderbird-patch-inline: do not require /bin/bash to run\n\nModified the patch by incorporating the suggestions from Ángel\nGonzález and Junio C Hamano \n\nSigned-off-by: Maxin B. John \n---\ndiff --git a/contrib/thunderbird-patch-inline/appp.sh\nb/contrib/thunderbird-patch-inline/appp.sh\nindex cc518f3..1d109a5 100755\n--- a/contrib/thunderbird-patch-inline/appp.sh\n+++ b/contrib/thunderbird-patch-inline/appp.sh\n@@ -1,8 +1,8 @@\n-#!/bin/bash\n+#!/bin/sh\n # Copyright 2008 Lukas Sandström \n #\n # AppendPatch - A script to be used together with ExternalEditor\n-# for Mozilla Thunderbird to properly include pathes inline i e-mails.\n+# for Mozilla Thunderbird to properly include patches inline in e-mails.\n\n # ExternalEditor can be downloaded at http://globs.org/articles.php?lng=en&pg=2\n\n@@ -16,7 +16,12 @@ else\n cd > /dev/null\n fi\n\n-PATCH=$(zenity --file-selection)\n+#check whether zenity is present\n+if ! type zenity >/dev/null 2>&1 ; then\n+ exit 1\n+fi\n+\n+PATCH=`zenity --file-selection`\n\n if [ \"$?\" != \"0\" ] ; then\n #zenity --error --text \"No patchfile given.\"\n"},{"id":"164700","messageId":"1301507039.22607.33.camel@drew-northup.unet.maine.edu","threadId":"26903","inReplyTo":"AANLkTinUh0BX3O+2Y1CiUTx7xvzW6ydrAGiGQUx4pbeP@mail.gmail.com","subject":"Re: contrib/thunderbird-patch-inline: do not require /bin/bash to run","fromName":"Drew Northup","fromEmail":"drew.northup@maine.edu","sentAt":"2011-03-30T17:43:59Z","receivedAt":"2011-03-30T17:43:59Z","isPatch":false,"sender":{"key":"drew.northup@maine.edu","avatar":"https://avatars.githubusercontent.com/u/18331571?v=4"},"body":"\nOn Tue, 2011-03-29 at 10:08 +0300, Maxin john wrote:\n> contrib/thunderbird-patch-inline: do not require /bin/bash to run\n> \n> Modified the patch by incorporating the suggestions from Ángel\n> González and Junio C Hamano \n> \n> Signed-off-by: Maxin B. John \n> ---\n> diff --git a/contrib/thunderbird-patch-inline/appp.sh\n> b/contrib/thunderbird-patch-inline/appp.sh\n> index cc518f3..1d109a5 100755\n> --- a/contrib/thunderbird-patch-inline/appp.sh\n> +++ b/contrib/thunderbird-patch-inline/appp.sh\n> @@ -1,8 +1,8 @@\n> -#!/bin/bash\n> +#!/bin/sh\n> # Copyright 2008 Lukas Sandström \n> #\n> # AppendPatch - A script to be used together with ExternalEditor\n> -# for Mozilla Thunderbird to properly include pathes inline i e-mails.\n> +# for Mozilla Thunderbird to properly include patches inline in e-mails.\n> \n> # ExternalEditor can be downloaded at http://globs.org/articles.php?lng=en&pg=2\n> \n> @@ -16,7 +16,12 @@ else\n> cd > /dev/null\n> fi\n> \n> -PATCH=$(zenity --file-selection)\n> +#check whether zenity is present\n> +if ! type zenity >/dev/null 2>&1 ; then\n> + exit 1\n> +fi\n> +\n> +PATCH=`zenity --file-selection`\n\nI could be missing something, but I thought we were trying to\nstandardize to the $(....) syntax..., no? I didn't think that was a\nbash-ism.\n\n> if [ \"$?\" != \"0\" ] ; then\n> #zenity --error --text \"No patchfile given.\"\n\n-- \n-Drew Northup\n________________________________________________\n\"As opposed to vegetable or mineral error?\"\n-John Pescatore, SANS NewsBites Vol. 12 Num. 59\n"},{"id":"164708","messageId":"1301511208.22607.38.camel@drew-northup.unet.maine.edu","threadId":"26903","inReplyTo":"1301507039.22607.33.camel@drew-northup.unet.maine.edu","subject":"Re: contrib/thunderbird-patch-inline: do not require /bin/bash to run","fromName":"Drew Northup","fromEmail":"drew.northup@maine.edu","sentAt":"2011-03-30T18:53:28Z","receivedAt":"2011-03-30T18:53:28Z","isPatch":false,"sender":{"key":"drew.northup@maine.edu","avatar":"https://avatars.githubusercontent.com/u/18331571?v=4"},"body":"You can ignore this, I hadn't found the new thread yet....\n\nOn Wed, 2011-03-30 at 13:43 -0400, Drew Northup wrote:\n> On Tue, 2011-03-29 at 10:08 +0300, Maxin john wrote:\n> > contrib/thunderbird-patch-inline: do not require /bin/bash to run\n> > \n> > Modified the patch by incorporating the suggestions from Ángel\n> > González and Junio C Hamano \n> > \n> > Signed-off-by: Maxin B. John \n> > ---\n> > diff --git a/contrib/thunderbird-patch-inline/appp.sh\n> > b/contrib/thunderbird-patch-inline/appp.sh\n> > index cc518f3..1d109a5 100755\n> > --- a/contrib/thunderbird-patch-inline/appp.sh\n> > +++ b/contrib/thunderbird-patch-inline/appp.sh\n> > @@ -1,8 +1,8 @@\n> > -#!/bin/bash\n> > +#!/bin/sh\n> > # Copyright 2008 Lukas Sandström \n> > #\n> > # AppendPatch - A script to be used together with ExternalEditor\n> > -# for Mozilla Thunderbird to properly include pathes inline i e-mails.\n> > +# for Mozilla Thunderbird to properly include patches inline in e-mails.\n> > \n> > # ExternalEditor can be downloaded at http://globs.org/articles.php?lng=en&pg=2\n> > \n> > @@ -16,7 +16,12 @@ else\n> > cd > /dev/null\n> > fi\n> > \n> > -PATCH=$(zenity --file-selection)\n> > +#check whether zenity is present\n> > +if ! type zenity >/dev/null 2>&1 ; then\n> > + exit 1\n> > +fi\n> > +\n> > +PATCH=`zenity --file-selection`\n> \n> I could be missing something, but I thought we were trying to\n> standardize to the $(....) syntax..., no? I didn't think that was a\n> bash-ism.\n> \n> > if [ \"$?\" != \"0\" ] ; then\n> > #zenity --error --text \"No patchfile given.\"\n\n-- \n-Drew Northup\n________________________________________________\n\"As opposed to vegetable or mineral error?\"\n-John Pescatore, SANS NewsBites Vol. 12 Num. 59\n"}]}