{"thread":{"id":"26899","subject":"[BUG] \"git fetch --tags\" seems to be broken with recent change on 'master'","startedAt":"2011-03-29T02:22:04Z","lastAt":"2011-03-29T06:33:22Z","messageCount":2,"participants":["Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"164523","messageId":"7vzkoeu0mr.fsf@alter.siamese.dyndns.org","threadId":"26899","inReplyTo":null,"subject":"[BUG] \"git fetch --tags\" seems to be broken with recent change on 'master'","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-03-29T02:22:04Z","receivedAt":"2011-03-29T02:22:04Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"I haven't started digging this through, but just a heads-up.\n\nOne of the recent changes we made on 'master' (either Shawn's protocol\ntweak or my progressive common commit discovery) seems to have broken \"git\nfetch --tags\" and possibly other forms of fetch, failing with SIGPIPE.\nFrom the stack trace I am guessing that the server side might be closing\nthe connection prematurely while the client still wants to say something\nto it.\n\n#0  0x000000362d80e470 in __write_nocancel () from /lib64/libpthread.so.0\n#1  0x00000000005064de in xwrite (fd=9, buf=0x896480, len=804) at wrapper.c:137\n#2  0x00000000004c6570 in safe_write (fd=9, buf=0x896480, n=804) at pkt-line.c:68\n#3  0x000000000042ada5 in send_request (fd=9, buf=0x7fffffffdd40)\n    at builtin/fetch-pack.c:219\n#4  0x000000000042b458 in find_common (fd=0x7c6740, \n    result_sha1=0x7fffffffde20 \"\\200\\203}\", refs=0x0) at builtin/fetch-pack.c:368\n#5  0x000000000042c48c in do_fetch_pack (fd=0x7c6740, orig_ref=0x7d8460, nr_match=1, \n    match=0x7d8380, pack_lockfile=0x7c6700) at builtin/fetch-pack.c:765\n#6  0x000000000042cd23 in fetch_pack (my_args=0x7fffffffdfc0, fd=0x7c6740, conn=0x7d83a0, \n    ref=0x7d8460, dest=0x7f86d0 \"/pub/scm/git/git.git\", nr_heads=1, heads=0x7d8380, \n    pack_lockfile=0x7c6700) at builtin/fetch-pack.c:985\n#7  0x00000000004f83d0 in fetch_refs_via_pack (transport=0x7c66a0, nr_heads=1, \n    to_fetch=0x7f8600) at transport.c:542\n#8  0x00000000004f9c5c in transport_fetch_refs (transport=0x7c66a0, refs=0x7e5610)\n    at transport.c:1112\n#9  0x000000000042e3aa in fetch_refs (transport=0x7c66a0, ref_map=0x7e5610)\n    at builtin/fetch.c:513\n#10 0x000000000042eb97 in do_fetch (transport=0x7c66a0, refs=0x7c6b80, ref_count=0)\n    at builtin/fetch.c:712\n#11 0x000000000042f431 in fetch_one (remote=0x7c6420, argc=0, argv=0x7fffffffe4e8)\n    at builtin/fetch.c:895\n#12 0x000000000042f6c6 in cmd_fetch (argc=1, argv=0x7fffffffe4e0, prefix=0x0)\n    at builtin/fetch.c:947\n#13 0x000000000040484c in run_builtin (p=0x771de8, argc=3, argv=0x7fffffffe4e0)\n    at git.c:290\n#14 0x00000000004049e8 in handle_internal_command (argc=3, argv=0x7fffffffe4e0)\n    at git.c:448\n#15 0x0000000000404ae2 in run_argv (argcp=0x7fffffffe3cc, argv=0x7fffffffe3c0) at git.c:492\n#16 0x0000000000404c6a in main (argc=3, argv=0x7fffffffe4e0) at git.c:565\n"},{"id":"164532","messageId":"7vsju6tozx.fsf@alter.siamese.dyndns.org","threadId":"26899","inReplyTo":"7vzkoeu0mr.fsf@alter.siamese.dyndns.org","subject":"Re: [BUG] \"git fetch --tags\" seems to be broken with recent change on 'master'","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-03-29T06:33:22Z","receivedAt":"2011-03-29T06:33:22Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"I still haven't pinpointed where things go wrong (I have GIT_TRACE_PACKET\noutput, thanks to Peff, though), but I seem to be reliably able to\nreproduce the issue with 'master' and also reliably able to make the issue\ndisappear with 'master' plus two reverts (\"no-done\" protocol extension).\n\nFor tonight, I'll revert 3e63b21 (upload-pack: Implement no-done\ncapability, 2011-03-14) and 761ecf0 (fetch-pack: Implement no-done\ncapability, 2011-03-14), as I don't want to harm other people with this\nissue.\n"}]}