{"thread":{"id":"26882","subject":"[PATCH] tests: fix overeager scrubbing of environment variables","startedAt":"2011-03-27T21:22:52Z","lastAt":"2011-03-28T21:03:09Z","messageCount":10,"participants":["Jens Lehmann","Jonathan Nieder","Jeff King","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"164395","messageId":"4D8FAAAC.3050905@web.de","threadId":"26882","inReplyTo":null,"subject":"[PATCH] tests: fix overeager scrubbing of environment variables","fromName":"Jens Lehmann","fromEmail":"jens.lehmann@web.de","sentAt":"2011-03-27T21:22:52Z","receivedAt":"2011-03-27T21:22:52Z","isPatch":true,"sender":{"key":"jens.lehmann@web.de","avatar":"https://avatars.githubusercontent.com/u/135220?v=4"},"body":"In commit 95a1d12e9b9f (\"tests: scrub environment of GIT_* variables\") all\nenvironment variables starting with \"GIT_\" were unset for the tests using\na perl script rather than unsetting them one by one. Only three exceptions\nwere made to make them work as before: \"GIT_TRACE*\", \"GIT_DEBUG*\" and\n\"GIT_USE_LOOKUP\".\n\nUnfortunately some environment variables used by the test framework itself\nwere not added to the exceptions and thus stopped working when given\nbefore the make command instead of after it. Those are:\n\n- GIT_SKIP_TESTS\n\n- GIT_TEST*\n\n- GIT_PROVE_OPTS\n\nLet's fix that by adding them to the exception list.\n\nSigned-off-by: Jens Lehmann <Jens.Lehmann@web.de>\n---\n\nI noticed today that skipping a test the way I was used to suddenly failed:\n\nGIT_SKIP_TESTS='t1234' GIT_TEST_OPTS='--root=/dev/shm' make -j10 test\n\nThis should work according to t/README, but didn't anymore.\n\n t/test-lib.sh |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/t/test-lib.sh b/t/test-lib.sh\nindex 7cc9a52..4a8c443 100644\n--- a/t/test-lib.sh\n+++ b/t/test-lib.sh\n@@ -46,7 +46,7 @@ unset VISUAL\n unset EMAIL\n unset $(perl -e '\n \tmy @env = keys %ENV;\n-\tmy @vars = grep(/^GIT_/ && !/^GIT_(TRACE|DEBUG|USE_LOOKUP)/, @env);\n+\tmy @vars = grep(/^GIT_/ && !/^GIT_(TRACE|DEBUG|USE_LOOKUP|SKIP_TESTS|TEST|PROVE_OPTS)/, @env);\n \tprint join(\"\\n\", @vars);\n ')\n GIT_AUTHOR_EMAIL=author@example.com\n-- \n1.7.4.2.407.gac78c\n"},{"id":"164396","messageId":"20110327213756.GD25927@elie","threadId":"26882","inReplyTo":"4D8FAAAC.3050905@web.de","subject":"Re: [PATCH] tests: fix overeager scrubbing of environment variables","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2011-03-27T21:37:56Z","receivedAt":"2011-03-27T21:37:56Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Jens Lehmann wrote:\n\n> - GIT_SKIP_TESTS\n> - GIT_TEST*\n> - GIT_PROVE_OPTS\n>\n> Let's fix that by adding them to the exception list.\n>\n> Signed-off-by: Jens Lehmann <Jens.Lehmann@web.de>\n\nAcked-by: Jonathan Nieder <jrnieder@gmail.com>\n\nIt misses a few, though:\n\n - GIT_REMOTE_SVN_TEST_BIG_FILES\n - GIT_NOTES_TIMING_TESTS\n - GIT_PATCHID_TIMING_TESTS\n - GIT_VALGRIND_OPTIONS\n\nIf we were starting over I suppose those would all be GIT_TEST* but\nthere's something to be said for muscle memory.\n\n> I noticed today that skipping a test the way I was used to suddenly failed:\n>\n> GIT_SKIP_TESTS='t1234' GIT_TEST_OPTS='--root=/dev/shm' make -j10 test\n>\n> This should work according to t/README, but didn't anymore.\n\nI would have just written that in the change description.\n\nGood catch, thanks.\n"},{"id":"164397","messageId":"20110327221753.GB27445@elie","threadId":"26882","inReplyTo":"20110327213756.GD25927@elie","subject":"[PATCH] squash! tests: fix overeager scrubbing of environment variables","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2011-03-27T22:17:53Z","receivedAt":"2011-03-27T22:17:53Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"(+cc: Jeff and Ævar for perl advice)\nJonathan Nieder wrote:\n> Jens Lehmann wrote:\n\n>> - GIT_SKIP_TESTS\n>> - GIT_TEST*\n>> - GIT_PROVE_OPTS\n>>\n>> Let's fix that by adding them to the exception list.\n>>\n>> Signed-off-by: Jens Lehmann <Jens.Lehmann@web.de>\n>\n> Acked-by: Jonathan Nieder <jrnieder@gmail.com>\n>\n> It misses a few, though:\n>\n>  - GIT_REMOTE_SVN_TEST_BIG_FILES\n>  - GIT_NOTES_TIMING_TESTS\n>  - GIT_PATCHID_TIMING_TESTS\n>  - GIT_VALGRIND_OPTIONS\n\nHow about something like this on top?  Would it still be safe on\nplatforms with ancient perl?\n\nSigned-off-by: Jonathan Nieder <jrnieder@gmail.com>\n---\n t/test-lib.sh |   10 +++++++++-\n 1 files changed, 9 insertions(+), 1 deletions(-)\n\ndiff --git a/t/test-lib.sh b/t/test-lib.sh\nindex 4a8c443..d28e647 100644\n--- a/t/test-lib.sh\n+++ b/t/test-lib.sh\n@@ -46,7 +46,15 @@ unset VISUAL\n unset EMAIL\n unset $(perl -e '\n \tmy @env = keys %ENV;\n-\tmy @vars = grep(/^GIT_/ && !/^GIT_(TRACE|DEBUG|USE_LOOKUP|SKIP_TESTS|TEST|PROVE_OPTS)/, @env);\n+\tmy @vars = grep(/^GIT_/ && !m{^GIT_(\n+\t\t\tTRACE |\n+\t\t\tDEBUG |\n+\t\t\tUSE_LOOKUP |\n+\t\t\tTEST |\n+\t\t\t.*_TEST |\n+\t\t\tPROVE |\n+\t\t\tVALGRIND\n+\t\t)}x, @env);\n \tprint join(\"\\n\", @vars);\n ')\n GIT_AUTHOR_EMAIL=author@example.com\n-- \n1.7.4.2\n"},{"id":"164398","messageId":"4D8FB995.20001@web.de","threadId":"26882","inReplyTo":"20110327213756.GD25927@elie","subject":"[PATCH v2] tests: fix overeager scrubbing of environment variables","fromName":"Jens Lehmann","fromEmail":"jens.lehmann@web.de","sentAt":"2011-03-27T22:26:29Z","receivedAt":"2011-03-27T22:26:29Z","isPatch":true,"sender":{"key":"jens.lehmann@web.de","avatar":"https://avatars.githubusercontent.com/u/135220?v=4"},"body":"In commit 95a1d12e9b9f (\"tests: scrub environment of GIT_* variables\") all\nenvironment variables starting with \"GIT_\" were unset for the tests using\na perl script rather than unsetting them one by one. Only three exceptions\nwere made to make them work as before: \"GIT_TRACE*\", \"GIT_DEBUG*\" and\n\"GIT_USE_LOOKUP\".\n\nUnfortunately some environment variables used by the test framework itself\nwere not added to the exceptions and thus stopped working when given\nbefore the make command instead of after it. Those are:\n\n- GIT_NOTES_TIMING_TESTS\n- GIT_PATCHID_TIMING_TESTS\n- GIT_PROVE_OPTS\n- GIT_REMOTE_SVN_TEST_BIG_FILES\n- GIT_SKIP_TESTS\n- GIT_TEST*\n- GIT_VALGRIND_OPTIONS\n\nI noticed that when skipping a test the way I was used to suddenly failed:\n\nGIT_SKIP_TESTS='t1234' GIT_TEST_OPTS='--root=/dev/shm' make -j10 test\n\nThis should work according to t/README, but didn't anymore, so let's fix\nthat by adding them to the exception list.\n\nSigned-off-by: Jens Lehmann <Jens.Lehmann@web.de>\nAcked-by: Jonathan Nieder <jrnieder@gmail.com>\n---\n\nAm 27.03.2011 23:37, schrieb Jonathan Nieder:\n> Jens Lehmann wrote:\n> \n>> - GIT_SKIP_TESTS\n>> - GIT_TEST*\n>> - GIT_PROVE_OPTS\n>>\n>> Let's fix that by adding them to the exception list.\n>>\n>> Signed-off-by: Jens Lehmann <Jens.Lehmann@web.de>\n> \n> Acked-by: Jonathan Nieder <jrnieder@gmail.com>\n\nThanks for your review! (I took the liberty to add your Ack to this updated\nversion, please speak up if you are unhappy with anything in this v2!)\n\n> It misses a few, though:\n> \n>  - GIT_REMOTE_SVN_TEST_BIG_FILES\n>  - GIT_NOTES_TIMING_TESTS\n>  - GIT_PATCHID_TIMING_TESTS\n>  - GIT_VALGRIND_OPTIONS\n\nRight you are, this version includes those too (but - except once for\nGIT_VALGRIND_OPTIONS - none of them are mentioned in t/README, that's why\nI managed to miss them ... maybe they should be documented there?).\n\n> If we were starting over I suppose those would all be GIT_TEST* but\n> there's something to be said for muscle memory.\n\nYeah, I thought the same about GIT_SKIP_TESTS when writing the first version\nof this patch ... ;-)\n\n>> I noticed today that skipping a test the way I was used to suddenly failed:\n>>\n>> GIT_SKIP_TESTS='t1234' GIT_TEST_OPTS='--root=/dev/shm' make -j10 test\n>>\n>> This should work according to t/README, but didn't anymore.\n> \n> I would have just written that in the change description.\n\nYup, did that!\n\n t/test-lib.sh |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/t/test-lib.sh b/t/test-lib.sh\nindex 7cc9a52..f1f6d94 100644\n--- a/t/test-lib.sh\n+++ b/t/test-lib.sh\n@@ -46,7 +46,7 @@ unset VISUAL\n unset EMAIL\n unset $(perl -e '\n \tmy @env = keys %ENV;\n-\tmy @vars = grep(/^GIT_/ && !/^GIT_(TRACE|DEBUG|USE_LOOKUP)/, @env);\n+\tmy @vars = grep(/^GIT_/ && !/^GIT_(TRACE|DEBUG|USE_LOOKUP|NOTES_TIMING_TESTS|PATCHID_TIMING_TESTS|PROVE_OPTS|REMOTE_SVN_TEST_BIG_FILES|SKIP_TESTS|TEST|VALGRIND_OPTIONS)/, @env);\n \tprint join(\"\\n\", @vars);\n ')\n GIT_AUTHOR_EMAIL=author@example.com\n-- \n1.7.4.2.407.gac78c\n"},{"id":"164399","messageId":"20110327230025.GD27445@elie","threadId":"26882","inReplyTo":"4D8FB995.20001@web.de","subject":"[PATCH/RFC] tests: use the --long-tests facility to toggle some slow tests","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2011-03-27T23:00:25Z","receivedAt":"2011-03-27T23:00:25Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"The GIT_TEST_LONG facility (v1.6.0-rc0~246, 2008-06-17) was added to\nsupport tests for a gitweb caching engine that was never merged.\nSo --long-tests has been a no-op for years.\n\nSince then, some other expensive tests have sprouted up that fit its\ndescription pretty well, namely:\n\n - GIT_NOTES_TIMING_TESTS\n - GIT_PATCHID_TIMING_TESTS\n - GIT_REMOTE_SVN_TEST_BIG_FILES\n\nAll of these are not part of the default test run because they are\nexpensive.  Let's replace their existing, undocumented triggers with\nGIT_TEST_LONG, so now you can do\n\n sh t3302-notes-index-expensive.sh -l -v\n\nto get a sanity check for notes lookup performance scalability.\n\nSigned-off-by: Jonathan Nieder <jrnieder@gmail.com>\n---\nJens Lehmann wrote:\n\n> Right you are, this version includes those too (but - except once for\n> GIT_VALGRIND_OPTIONS - none of them are mentioned in t/README, that's why\n> I managed to miss them ... maybe they should be documented there?).\n\nGood idea.  See below for a possible sneaky way to document three of\nthem.\n\n> --- a/t/test-lib.sh\n> +++ b/t/test-lib.sh\n> @@ -46,7 +46,7 @@ unset VISUAL\n>  unset EMAIL\n>  unset $(perl -e '\n>  \tmy @env = keys %ENV;\n> -\tmy @vars = grep(/^GIT_/ && !/^GIT_(TRACE|DEBUG|USE_LOOKUP)/, @env);\n> +\tmy @vars = grep(/^GIT_/ && !/^GIT_(TRACE|DEBUG|USE_LOOKUP|NOTES_TIMING_TESTS|PATCHID_TIMING_TESTS|PROVE_OPTS|REMOTE_SVN_TEST_BIG_FILES|SKIP_TESTS|TEST|VALGRIND_OPTIONS)/, @env);\n\nMy poor terminal. :)  I sent a possible more invasive change that\nbreaks this into multiple lines but it looks like our mails crossed.\nAnyway, I have no serious complaint; it might be that this one is the\nbest way to go.  \n\n t/t0081-line-buffer.sh           |    2 +-\n t/t3302-notes-index-expensive.sh |    2 +-\n t/t3419-rebase-patch-id.sh       |    2 +-\n 3 files changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/t/t0081-line-buffer.sh b/t/t0081-line-buffer.sh\nindex 1dbe1c9..099abe0 100755\n--- a/t/t0081-line-buffer.sh\n+++ b/t/t0081-line-buffer.sh\n@@ -12,7 +12,7 @@ correctly.\n \"\n . ./test-lib.sh\n \n-test -n \"$GIT_REMOTE_SVN_TEST_BIG_FILES\" && test_set_prereq EXPENSIVE\n+test -n \"$GIT_TEST_LONG\" && test_set_prereq EXPENSIVE\n \n generate_tens_of_lines () {\n \ttens=$1 &&\ndiff --git a/t/t3302-notes-index-expensive.sh b/t/t3302-notes-index-expensive.sh\nindex e35d781..62820d0 100755\n--- a/t/t3302-notes-index-expensive.sh\n+++ b/t/t3302-notes-index-expensive.sh\n@@ -8,7 +8,7 @@ test_description='Test commit notes index (expensive!)'\n . ./test-lib.sh\n \n test_set_prereq NOT_EXPENSIVE\n-test -n \"$GIT_NOTES_TIMING_TESTS\" && test_set_prereq EXPENSIVE\n+test -n \"$GIT_TEST_LONG\" && test_set_prereq EXPENSIVE\n test -x /usr/bin/time && test_set_prereq USR_BIN_TIME\n \n create_repo () {\ndiff --git a/t/t3419-rebase-patch-id.sh b/t/t3419-rebase-patch-id.sh\nindex bd8efaf..0419e81 100755\n--- a/t/t3419-rebase-patch-id.sh\n+++ b/t/t3419-rebase-patch-id.sh\n@@ -5,7 +5,7 @@ test_description='git rebase - test patch id computation'\n . ./test-lib.sh\n \n test_set_prereq NOT_EXPENSIVE\n-test -n \"$GIT_PATCHID_TIMING_TESTS\" && test_set_prereq EXPENSIVE\n+test -n \"$GIT_TEST_LONG\" && test_set_prereq EXPENSIVE\n test -x /usr/bin/time && test_set_prereq USR_BIN_TIME\n \n count()\n-- \n1.7.4.2\n"},{"id":"164432","messageId":"20110328135803.GA14763@sigill.intra.peff.net","threadId":"26882","inReplyTo":"20110327221753.GB27445@elie","subject":"Re: [PATCH] squash! tests: fix overeager scrubbing of environment variables","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2011-03-28T13:58:03Z","receivedAt":"2011-03-28T13:58:03Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Sun, Mar 27, 2011 at 05:17:53PM -0500, Jonathan Nieder wrote:\n\n> How about something like this on top?  Would it still be safe on\n> platforms with ancient perl?\n> \n> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>\n> ---\n>  t/test-lib.sh |   10 +++++++++-\n>  1 files changed, 9 insertions(+), 1 deletions(-)\n> \n> diff --git a/t/test-lib.sh b/t/test-lib.sh\n> index 4a8c443..d28e647 100644\n> --- a/t/test-lib.sh\n> +++ b/t/test-lib.sh\n> @@ -46,7 +46,15 @@ unset VISUAL\n>  unset EMAIL\n>  unset $(perl -e '\n>  \tmy @env = keys %ENV;\n> -\tmy @vars = grep(/^GIT_/ && !/^GIT_(TRACE|DEBUG|USE_LOOKUP|SKIP_TESTS|TEST|PROVE_OPTS)/, @env);\n> +\tmy @vars = grep(/^GIT_/ && !m{^GIT_(\n> +\t\t\tTRACE |\n> +\t\t\tDEBUG |\n> +\t\t\tUSE_LOOKUP |\n> +\t\t\tTEST |\n> +\t\t\t.*_TEST |\n> +\t\t\tPROVE |\n> +\t\t\tVALGRIND\n> +\t\t)}x, @env);\n\nI think that should be fine. The most exotic thing you use is /x. I\ndon't know when it was introduced, but perl5004delta refers to it as\nsomething that was already around before then.\n\nI think it might be a little more readable to get rid of the \"|\" on each\nline like this:\n\n    my $ok = join(\"|\", qw(\n      TRACE\n      DEBUG\n      USE_LOOKUP\n      TEST\n      .*_TEST\n      PROVE\n      VALGRIND\n    ));\n    my @vars = grep(/^GIT_/ && !/^GIT_($ok)/o) @env;\n\nwhich is a little simpler syntax, and makes patches nicer (you don't\nhave to add a trailing \"|\" on the line before). But that is a minor nit.\n\n-Peff\n"},{"id":"164463","messageId":"7v4o6n18oy.fsf@alter.siamese.dyndns.org","threadId":"26882","inReplyTo":"20110327213756.GD25927@elie","subject":"Re: [PATCH] tests: fix overeager scrubbing of environment variables","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-03-28T17:00:45Z","receivedAt":"2011-03-28T17:00:45Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jonathan Nieder <jrnieder@gmail.com> writes:\n\n> Jens Lehmann wrote:\n>\n>> - GIT_SKIP_TESTS\n>> - GIT_TEST*\n>> - GIT_PROVE_OPTS\n>>\n>> Let's fix that by adding them to the exception list.\n>>\n>> Signed-off-by: Jens Lehmann <Jens.Lehmann@web.de>\n>\n> Acked-by: Jonathan Nieder <jrnieder@gmail.com>\n>\n> It misses a few, though:\n>\n>  - GIT_REMOTE_SVN_TEST_BIG_FILES\n>  - GIT_NOTES_TIMING_TESTS\n>  - GIT_PATCHID_TIMING_TESTS\n>  - GIT_VALGRIND_OPTIONS\n>\n> If we were starting over I suppose those would all be GIT_TEST* but\n> there's something to be said for muscle memory.\n\nI don't think muscle memory matters as much in this case as the usual\nend-user facing interfaces.  These are only for people who build and test\ngit, not for our end users.\n\nI think it is Ok to do this (yes I am trying to avoid doing this myself,\nas I am a bit behind and also am lazy) just as a single patch to rename\nthe environment variables, and filter them with a single GIT_TEST_*\npattern at the same time.\n\nThanks.\n"},{"id":"164482","messageId":"4D90DE79.7000103@web.de","threadId":"26882","inReplyTo":"7v4o6n18oy.fsf@alter.siamese.dyndns.org","subject":"[PATCH v3] tests: fix overeager scrubbing of environment variables","fromName":"Jens Lehmann","fromEmail":"jens.lehmann@web.de","sentAt":"2011-03-28T19:16:09Z","receivedAt":"2011-03-28T19:16:09Z","isPatch":true,"sender":{"key":"jens.lehmann@web.de","avatar":"https://avatars.githubusercontent.com/u/135220?v=4"},"body":"In commit 95a1d12e9b9f (\"tests: scrub environment of GIT_* variables\") all\nenvironment variables starting with \"GIT_\" were unset for the tests using\na perl script rather than unsetting them one by one. Only three exceptions\nwere made to make them work as before: \"GIT_TRACE*\", \"GIT_DEBUG*\" and\n\"GIT_USE_LOOKUP\".\n\nUnfortunately some environment variables used by the test framework itself\nwere not added to the exceptions and thus stopped working when given\nbefore the make command instead of after it. Those are:\n\n- GIT_NOTES_TIMING_TESTS\n- GIT_PATCHID_TIMING_TESTS\n- GIT_PROVE_OPTS\n- GIT_REMOTE_SVN_TEST_BIG_FILES\n- GIT_SKIP_TESTS\n- GIT_TEST*\n- GIT_VALGRIND_OPTIONS\n\nI noticed that when skipping a test the way I was used to suddenly failed:\n\nGIT_SKIP_TESTS='t1234' GIT_TEST_OPTS='--root=/dev/shm' make -j10 test\n\nThis should work according to t/README, but didn't anymore, so let's fix\nthat by adding them to the exception list. And to avoid having a long\nregexp put the exceptions in a separate variable using nicer formatting.\n\nSigned-off-by: Jens Lehmann <Jens.Lehmann@web.de>\nAcked-by: Jonathan Nieder <jrnieder@gmail.com>\nThanks-to: Jeff King <peff@peff.net>\n---\n\n\nAm 28.03.2011 19:00, schrieb Junio C Hamano:\n> I think it is Ok to do this (yes I am trying to avoid doing this myself,\n> as I am a bit behind and also am lazy) just as a single patch to rename\n> the environment variables, and filter them with a single GIT_TEST_*\n> pattern at the same time.\n\nAgreed, that would be the best solution. But I got sidetracked by this\nissue while trying to fix something else, so I would rather want to\navoid doing the whole exercise myself. So here is v3 of my patch which\njust makes these variables work again.\n\n\n t/test-lib.sh |   11 ++++++++++-\n 1 files changed, 10 insertions(+), 1 deletions(-)\n\ndiff --git a/t/test-lib.sh b/t/test-lib.sh\nindex 7cc9a52..7a56f11 100644\n--- a/t/test-lib.sh\n+++ b/t/test-lib.sh\n@@ -46,7 +46,16 @@ unset VISUAL\n unset EMAIL\n unset $(perl -e '\n \tmy @env = keys %ENV;\n-\tmy @vars = grep(/^GIT_/ && !/^GIT_(TRACE|DEBUG|USE_LOOKUP)/, @env);\n+\tmy $ok = join(\"|\", qw(\n+\t\tTRACE\n+\t\tDEBUG\n+\t\tUSE_LOOKUP\n+\t\tTEST\n+\t\t.*_TEST\n+\t\tPROVE\n+\t\tVALGRIND\n+\t));\n+\tmy @vars = grep(/^GIT_/ && !/^GIT_($ok)/o, @env);\n \tprint join(\"\\n\", @vars);\n ')\n GIT_AUTHOR_EMAIL=author@example.com\n-- \n1.7.4.2.407.g50b80.dirty\n"},{"id":"164483","messageId":"20110328193744.GB13433@elie","threadId":"26882","inReplyTo":"4D90DE79.7000103@web.de","subject":"Re: [PATCH v3] tests: fix overeager scrubbing of environment variables","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2011-03-28T19:37:44Z","receivedAt":"2011-03-28T19:37:44Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Jens Lehmann wrote:\n\n> Acked-by: Jonathan Nieder <jrnieder@gmail.com>\n\nYes, still. :)\n\n> So here is v3 of my patch which\n> just makes these variables work again.\n\nThanks, all.  This looks good for an immediate fix, and I can think\nseparately about how to make downstreams projects suffer less if\nchanging the names of variables like GIT_SKIP_TESTS to follow a\nGIT_TEST_ scheme.\n"},{"id":"164497","messageId":"7vk4fjvtyq.fsf@alter.siamese.dyndns.org","threadId":"26882","inReplyTo":"20110328193744.GB13433@elie","subject":"Re: [PATCH v3] tests: fix overeager scrubbing of environment variables","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-03-28T21:03:09Z","receivedAt":"2011-03-28T21:03:09Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jonathan Nieder <jrnieder@gmail.com> writes:\n\n> Jens Lehmann wrote:\n>\n>> Acked-by: Jonathan Nieder <jrnieder@gmail.com>\n>\n> Yes, still. :)\n>\n>> So here is v3 of my patch which\n>> just makes these variables work again.\n>\n> Thanks, all.  This looks good for an immediate fix, and I can think\n> separately about how to make downstreams projects suffer less if\n> changing the names of variables like GIT_SKIP_TESTS to follow a\n> GIT_TEST_ scheme.\n\nThanks, all.\n"}]}