{"thread":{"id":"26846","subject":"[PATCH] Test failure when spaces in git root","startedAt":"2011-03-24T00:11:46Z","lastAt":"2011-03-24T20:46:02Z","messageCount":2,"participants":["Carl Michael Skog","Thomas Rast"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"164194","messageId":"1300925506-20378-1-git-send-email-cmskog@gmail.com","threadId":"26846","inReplyTo":null,"subject":"[PATCH] Test failure when spaces in git root","fromName":"Carl Michael Skog","fromEmail":"cmskog@gmail.com","sentAt":"2011-03-24T00:11:46Z","receivedAt":"2011-03-24T00:11:46Z","isPatch":true,"sender":{"key":"cmskog@gmail.com","avatar":null},"body":"Some of the svn related tests would break when the git root path had\nspaces in it.\n\nThe test checks in t/t9119-git-svn-info.sh where falsely assuming that\nthe only space where in the path of the generated subversion repository.\nThis will break when the actual git build repository has spaces in it.\nAdd a global modifier to the sed command that generates the expected\nvalue for the tests.\n\nSigned-off-by: Carl Michael Skog <cmskog@gmail.com>\n---\n t/t9119-git-svn-info.sh |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/t/t9119-git-svn-info.sh b/t/t9119-git-svn-info.sh\nindex ff19695..752bf26 100755\n--- a/t/t9119-git-svn-info.sh\n+++ b/t/t9119-git-svn-info.sh\n@@ -28,7 +28,7 @@ test_cmp_info () {\n \trm -f tmp.expect tmp.actual\n }\n \n-quoted_svnrepo=\"$(echo $svnrepo | sed 's/ /%20/')\"\n+quoted_svnrepo=\"$(echo $svnrepo | sed 's/ /%20/g')\"\n \n test_expect_success 'setup repository and import' '\n \tmkdir info &&\n-- \n1.7.4.1.99.g3d9132\n"},{"id":"164254","messageId":"201103242146.02728.trast@student.ethz.ch","threadId":"26846","inReplyTo":"1300925506-20378-1-git-send-email-cmskog@gmail.com","subject":"Re: [PATCH] Test failure when spaces in git root","fromName":"Thomas Rast","fromEmail":"trast@student.ethz.ch","sentAt":"2011-03-24T20:46:02Z","receivedAt":"2011-03-24T20:46:02Z","isPatch":true,"sender":{"key":"tr@thomasrast.ch","avatar":"https://avatars.githubusercontent.com/u/153510?v=4"},"body":"Carl Michael Skog wrote:\n> Some of the svn related tests would break when the git root path had\n> spaces in it.\n[...]\n> -quoted_svnrepo=\"$(echo $svnrepo | sed 's/ /%20/')\"\n> +quoted_svnrepo=\"$(echo $svnrepo | sed 's/ /%20/g')\"\n\nIf you're already fixing this, shouldn't it be\n\n  $(echo \"$svnrepo\" | ...)\n\nto stop the expansion process from converting arbitrary series of\nwhitespace into a single space?\n\nHowever, any other (than space) character that needs %-quoting would\nprobably also break the test.  Maybe some more complicated mangling\nwould be in order.\n\n-- \nThomas Rast\ntrast@{inf,student}.ethz.ch\n"}]}