{"thread":{"id":"26681","subject":"[TopGit PATCH] tg-create: let format.signoff control adding of Signed-off-by","startedAt":"2011-03-07T10:42:46Z","lastAt":"2011-03-07T10:42:46Z","messageCount":1,"participants":["Andrey Borzenkov"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"162900","messageId":"1299494566-13021-1-git-send-email-arvidjaar@gmail.com","threadId":"26681","inReplyTo":null,"subject":"[TopGit PATCH] tg-create: let format.signoff control adding of Signed-off-by","fromName":"Andrey Borzenkov","fromEmail":"arvidjaar@gmail.com","sentAt":"2011-03-07T10:42:46Z","receivedAt":"2011-03-07T10:42:46Z","isPatch":true,"sender":{"key":"arvidjaar@gmail.com","avatar":null},"body":"GIT manual stresses that adding of Signed-off-by should be explicit\nuser decision. Some projects do ask for no Signed-off-by lines. So\nmake sure it is added by tg-create.sh only when explicity requested\nby user.\n\nSigned-off-by: Andrey Borzenkov <arvidjaar@gmail.com>\n\n---\n tg-create.sh |    8 +++-----\n 1 files changed, 3 insertions(+), 5 deletions(-)\n\ndiff --git a/tg-create.sh b/tg-create.sh\nindex 2edd537..617031b 100644\n--- a/tg-create.sh\n+++ b/tg-create.sh\n@@ -129,11 +129,9 @@ author_addr=\"${author%> *}>\"\n \t! subject_prefix=\"$(git config topgit.subjectprefix)\" || subject_prefix=\"$subject_prefix \"\n \techo \"Subject: [${subject_prefix}PATCH] $name\"\n \techo\n-\tcat <<EOT\n-<patch description>\n-\n-Signed-off-by: $author_addr\n-EOT\n+\techo '<patch description>'\n+\techo\n+\t[ \"$(git config --bool format.signoff)\" = true ] && echo \"Signed-off-by: $author_addr\"\n } >\"$root_dir/.topmsg\"\n git add -f \"$root_dir/.topmsg\"\n \n-- \ntg: (d279e29..) u/signed-off-by (depends on: master)\n"}]}