{"thread":{"id":"26649","subject":"Rename/copy detection - options/display improvement proposition","startedAt":"2011-03-03T15:49:02Z","lastAt":"2011-03-03T15:54:23Z","messageCount":2,"participants":["Piotr Krukowiecki"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"162726","messageId":"AANLkTimbvWLCxf6HM-f_z30uUE-Nbpf-tcNzd8GbgK2C@mail.gmail.com","threadId":"26649","inReplyTo":null,"subject":"Rename/copy detection - options/display improvement proposition","fromName":"Piotr Krukowiecki","fromEmail":"piotr.krukowiecki@gmail.com","sentAt":"2011-03-03T15:49:02Z","receivedAt":"2011-03-03T15:49:02Z","isPatch":false,"sender":{"key":"piotr.krukowiecki@gmail.com","avatar":"https://avatars.githubusercontent.com/u/3259959?v=4"},"body":"Hi,\n\nI think that:\n\n   1. git-status should accept -M<n> -C<n>, same as git-diff\n   2. git-diff should have an option to omit diff for deleted files\n\n\n1. git-status incorrectly recognizes some changes as copied, e.g.:\n\n# Changes to be committed:\n#\tcopied:     SimpleMatcher.h -> BSlashMatcher.h\n#\tcopied:     SimpleMatcher.h -> StringMatcher.h\n#\trenamed:  SimpleMatcher.h -> TabMatcher.h\n\n(generally SimpleMatcher.h is recognized as being copied into many\ndifferent headers)\n\ngit-diff shows similarity index 50-60%.\ngit-diff -M80 -C80 correctly stops recognizing this as copies/renames.\n\nI think git-status also should learn -M and -C, as it works the same\nway as git-diff with defaults.\n\n\n2. git-diff does not show diff for copied files. But when a files is\nremoved, the diff is shown.\n\nI think seeing what was deleted is sometimes useful, but sometimes it\nis not and just clutters the\ndiff.\n\n\n\n-- \nPiotrek\n"},{"id":"162727","messageId":"AANLkTin0BJFc1a9SHbou1b=aZA+ta50MAFbFZWYTc8ka@mail.gmail.com","threadId":"26649","inReplyTo":"AANLkTimbvWLCxf6HM-f_z30uUE-Nbpf-tcNzd8GbgK2C@mail.gmail.com","subject":"Re: Rename/copy detection - options/display improvement proposition","fromName":"Piotr Krukowiecki","fromEmail":"piotr.krukowiecki@gmail.com","sentAt":"2011-03-03T15:54:23Z","receivedAt":"2011-03-03T15:54:23Z","isPatch":false,"sender":{"key":"piotr.krukowiecki@gmail.com","avatar":"https://avatars.githubusercontent.com/u/3259959?v=4"},"body":"On Thu, Mar 3, 2011 at 4:49 PM, Piotr Krukowiecki\n<piotr.krukowiecki@gmail.com> wrote:\n> Hi,\n>\n> I think that:\n>\n>   1. git-status should accept -M<n> -C<n>, same as git-diff\n>   2. git-diff should have an option to omit diff for deleted files\n>\n>\n> 1. git-status incorrectly recognizes some changes as copied, e.g.:\n>\n> # Changes to be committed:\n> #       copied:     SimpleMatcher.h -> BSlashMatcher.h\n> #       copied:     SimpleMatcher.h -> StringMatcher.h\n> #       renamed:  SimpleMatcher.h -> TabMatcher.h\n>\n> (generally SimpleMatcher.h is recognized as being copied into many\n> different headers)\n>\n> git-diff shows similarity index 50-60%.\n> git-diff -M80 -C80 correctly stops recognizing this as copies/renames.\n>\n> I think git-status also should learn -M and -C, as it works the same\n> way as git-diff with defaults.\n>\n>\n> 2. git-diff does not show diff for copied files. But when a files is\n> removed, the diff is shown.\n>\n> I think seeing what was deleted is sometimes useful, but sometimes it\n> is not and just clutters the\n> diff.\n\nI have committed the changes and git-commit, git-log--stat output also\nshows the renames - so I suppose this is a global issue\n\n-- \nPiotrek\n"}]}