{"thread":{"id":"26646","subject":"[PATCH] init: remove unnecessary check","startedAt":"2011-03-03T12:34:51Z","lastAt":"2011-03-03T12:34:51Z","messageCount":1,"participants":["Nguyễn Thái Ngọc Duy"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"162718","messageId":"1299155691-11850-1-git-send-email-pclouds@gmail.com","threadId":"26646","inReplyTo":null,"subject":"[PATCH] init: remove unnecessary check","fromName":"Nguyễn Thái Ngọc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2011-03-03T12:34:51Z","receivedAt":"2011-03-03T12:34:51Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"git_dir must always be non-NULL so \"if (git_dir)\" is unnecessary.\nBefore this code, if git_dir == NULL, it will default to\nDEFAULT_GIT_DIR_ENVIRONMENT.\n\nSigned-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>\n---\n builtin/init-db.c |   12 +++++-------\n 1 files changed, 5 insertions(+), 7 deletions(-)\n\ndiff --git a/builtin/init-db.c b/builtin/init-db.c\nindex 4f5348e..fbeb380 100644\n--- a/builtin/init-db.c\n+++ b/builtin/init-db.c\n@@ -498,13 +498,11 @@ int cmd_init_db(int argc, const char **argv, const char *prefix)\n \t\tis_bare_repository_cfg = guess_repository_type(git_dir);\n \n \tif (!is_bare_repository_cfg) {\n-\t\tif (git_dir) {\n-\t\t\tconst char *git_dir_parent = strrchr(git_dir, '/');\n-\t\t\tif (git_dir_parent) {\n-\t\t\t\tchar *rel = xstrndup(git_dir, git_dir_parent - git_dir);\n-\t\t\t\tgit_work_tree_cfg = xstrdup(make_absolute_path(rel));\n-\t\t\t\tfree(rel);\n-\t\t\t}\n+\t\tconst char *git_dir_parent = strrchr(git_dir, '/');\n+\t\tif (git_dir_parent) {\n+\t\t\tchar *rel = xstrndup(git_dir, git_dir_parent - git_dir);\n+\t\t\tgit_work_tree_cfg = xstrdup(make_absolute_path(rel));\n+\t\t\tfree(rel);\n \t\t}\n \t\tif (!git_work_tree_cfg) {\n \t\t\tgit_work_tree_cfg = xcalloc(PATH_MAX, 1);\n-- \n1.7.4.74.g639db\n"}]}