{"thread":{"id":"26467","subject":"recurse_submodules vs recurse-submodules","startedAt":"2011-02-10T22:59:31Z","lastAt":"2011-02-11T01:54:10Z","messageCount":2,"participants":["Chris Packham","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"160850","messageId":"AANLkTimppKC_CsN6hc4xGqtMBk8p2QEFjHYRWesKK8_r@mail.gmail.com","threadId":"26467","inReplyTo":null,"subject":"recurse_submodules vs recurse-submodules","fromName":"Chris Packham","fromEmail":"judge.packham@gmail.com","sentAt":"2011-02-10T22:59:31Z","receivedAt":"2011-02-10T22:59:31Z","isPatch":false,"sender":{"key":"judge.packham@gmail.com","avatar":"https://avatars.githubusercontent.com/u/155667?v=4"},"body":"Hi,\n\nJust noticed this in git 1.7.4\n\n  git clone -h\n  ...\n      --recursive           initialize submodules in the clone\n      --recurse_submodules  initialize submodules in the clone\n\n  git fetch -h\n  ...\n     --recurse-submodules  control recursive fetching of submodules\n\nThe recurse_submodules option for git clone was added in ccdd3da6 I'm\nguessing it wasn't Jens' intention to use an underscore instead of a\nhypen. Also as it is fairly new it should be safe to correct without\nworrying about retaining the incorrect option for backwards\ncompatibility.\n\n\nHere's my attempt at a fix\n\n----8<----\nFrom 24c582c2c9bc4f66980679a20d3eb9de6a031071 Mon Sep 17 00:00:00 2001\nFrom: Chris Packham <chris.packham@alliedtelesis.co.nz>\nDate: Fri, 11 Feb 2011 11:31:06 +1300\nSubject: [PATCH] clone: fixup recurse_submodules option\n\nThe recurse_submodules option was added in ccdd3da6 to bring 'git clone'\ninto line with 'git fetch' and future commands. The correct option should\nhave been \"recurse-submodules\".\n\nSigned-off-by: Chris Packham <judge.packham@gmail.com>\n---\n builtin/clone.c |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/builtin/clone.c b/builtin/clone.c\nindex 61e0989..82a6938 100644\n--- a/builtin/clone.c\n+++ b/builtin/clone.c\n@@ -66,7 +66,7 @@ static struct option builtin_clone_options[] = {\n \t\t    \"setup as shared repository\"),\n \tOPT_BOOLEAN(0, \"recursive\", &option_recursive,\n \t\t    \"initialize submodules in the clone\"),\n-\tOPT_BOOLEAN(0, \"recurse_submodules\", &option_recursive,\n+\tOPT_BOOLEAN(0, \"recurse-submodules\", &option_recursive,\n \t\t    \"initialize submodules in the clone\"),\n \tOPT_STRING(0, \"template\", &option_template, \"path\",\n \t\t   \"path the template repository\"),\n-- \n1.7.4\n"},{"id":"160871","messageId":"7vk4h71gl9.fsf@alter.siamese.dyndns.org","threadId":"26467","inReplyTo":"AANLkTimppKC_CsN6hc4xGqtMBk8p2QEFjHYRWesKK8_r@mail.gmail.com","subject":"Re: recurse_submodules vs recurse-submodules","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-02-11T01:54:10Z","receivedAt":"2011-02-11T01:54:10Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Sounds like a sane thing to do.  Thanks.\n"}]}