{"thread":{"id":"26445","subject":"[PATCH] git-p4: Fix error message crash in P4Sync.commit.","startedAt":"2011-02-08T12:20:10Z","lastAt":"2011-02-11T13:44:43Z","messageCount":2,"participants":["Tor Arvid Lund","Pete Wyckoff"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"160695","messageId":"1297167610-1795-1-git-send-email-torarvid@gmail.com","threadId":"26445","inReplyTo":null,"subject":"[PATCH] git-p4: Fix error message crash in P4Sync.commit.","fromName":"Tor Arvid Lund","fromEmail":"torarvid@gmail.com","sentAt":"2011-02-08T12:20:10Z","receivedAt":"2011-02-08T12:20:10Z","isPatch":true,"sender":{"key":"torarvid@gmail.com","avatar":"https://avatars.githubusercontent.com/u/439758?v=4"},"body":"There is an error message that crashes the script because of an invalid ref\nto the non-existing \"path\" variable. It is almost never printed, which\nwould explain why nobody encountered this problem before... But anyway,\nthis oneliner fixes it.\n---\n contrib/fast-import/git-p4 |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4\nindex ca3cea0..29b9e32 100755\n--- a/contrib/fast-import/git-p4\n+++ b/contrib/fast-import/git-p4\n@@ -1086,7 +1086,7 @@ class P4Sync(Command):\n             if [p for p in branchPrefixes if p4PathStartsWith(f['path'], p)]:\n                 new_files.append (f)\n             else:\n-                sys.stderr.write(\"Ignoring file outside of prefix: %s\\n\" % path)\n+                sys.stderr.write(\"Ignoring file outside of prefix: %s\\n\" % f['path'])\n \n         self.gitStream.write(\"commit %s\\n\" % branch)\n #        gitStream.write(\"mark :%s\\n\" % details[\"change\"])\n-- \n1.7.3.1.68.g06779.dirty\n"},{"id":"160895","messageId":"20110211134443.GA11773@honk.padd.com","threadId":"26445","inReplyTo":"1297167610-1795-1-git-send-email-torarvid@gmail.com","subject":"Re: [PATCH] git-p4: Fix error message crash in P4Sync.commit.","fromName":"Pete Wyckoff","fromEmail":"pw@padd.com","sentAt":"2011-02-11T13:44:43Z","receivedAt":"2011-02-11T13:44:43Z","isPatch":true,"sender":{"key":"pw@padd.com","avatar":null},"body":"torarvid@gmail.com wrote on Tue, 08 Feb 2011 13:20 +0100:\n> There is an error message that crashes the script because of an invalid ref\n> to the non-existing \"path\" variable. It is almost never printed, which\n> would explain why nobody encountered this problem before... But anyway,\n> this oneliner fixes it.\n\nNeeds signoff.\n\nAcked-by: Pete Wyckoff <pw@padd.com>\n\n> ---\n>  contrib/fast-import/git-p4 |    2 +-\n>  1 files changed, 1 insertions(+), 1 deletions(-)\n> \n> diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4\n> index ca3cea0..29b9e32 100755\n> --- a/contrib/fast-import/git-p4\n> +++ b/contrib/fast-import/git-p4\n> @@ -1086,7 +1086,7 @@ class P4Sync(Command):\n>              if [p for p in branchPrefixes if p4PathStartsWith(f['path'], p)]:\n>                  new_files.append (f)\n>              else:\n> -                sys.stderr.write(\"Ignoring file outside of prefix: %s\\n\" % path)\n> +                sys.stderr.write(\"Ignoring file outside of prefix: %s\\n\" % f['path'])\n>  \n>          self.gitStream.write(\"commit %s\\n\" % branch)\n>  #        gitStream.write(\"mark :%s\\n\" % details[\"change\"])\n> -- \n> 1.7.3.1.68.g06779.dirty\n> \n> --\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at  http://vger.kernel.org/majordomo-info.html\n> \n"}]}