{"thread":{"id":"2632","subject":"default update hook broken","startedAt":"2005-11-21T14:09:14Z","lastAt":"2005-11-21T18:08:11Z","messageCount":2,"participants":["Matthew Wilcox","Andreas Ericsson"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"12434","messageId":"20051121140914.GB1598@parisc-linux.org","threadId":"2632","inReplyTo":null,"subject":"default update hook broken","fromName":"Matthew Wilcox","fromEmail":"matthew@wil.cx","sentAt":"2005-11-21T14:09:14Z","receivedAt":"2005-11-21T14:09:14Z","isPatch":false,"sender":{"key":"matthew@wil.cx","avatar":null},"body":"\nThere's two syntax errors and one good-netizen error in the hooks/update\nfile created when cloning Linus' linux-2.6.git repo.  I don't know\nif that file is created fresh or if it gets pulled from Linus' tree.\nHere's a patch to fix it\n\n--- .git/hooks/update\t2005-11-21 06:31:51.000000000 -0700\n+++ /home/willy/replacement-update\t2005-11-21 07:01:37.000000000 -0700\n@@ -8,14 +8,14 @@\n # (2) make this file executable by \"chmod +x update\".\n #\n \n-recipient=\"commit-list@mydomain.xz\"\n+recipient=\"commit-list@example.com\"\n \n if expr \"$2\" : '0*$' >/dev/null\n then\n \techo \"Created a new ref, with the following commits:\"\n \tgit-rev-list --pretty \"$3\"\n else\n-\t$base=$(git-merge-base \"$2\" \"$3\")\n+\tbase=$(git-merge-base \"$2\" \"$3\")\n \tcase \"$base\" in\n \t\"$2\")\n \t\techo \"New commits:\"\n@@ -24,8 +24,7 @@\n \t\techo \"Rebased ref, commits from common ancestor:\"\n \t\t;;\n \tesac\n-fi\n-git-rev-list --pretty \"$3\" \"^$base\"\n+\tgit-rev-list --pretty \"$3\" \"^$base\"\n fi |\n mail -s \"Changes to ref $1\" \"$recipient\"\n exit 0\n"},{"id":"12454","messageId":"43820D0B.6000006@op5.se","threadId":"2632","inReplyTo":"20051121140914.GB1598@parisc-linux.org","subject":"Re: default update hook broken","fromName":"Andreas Ericsson","fromEmail":"ae@op5.se","sentAt":"2005-11-21T18:08:11Z","receivedAt":"2005-11-21T18:08:11Z","isPatch":false,"sender":{"key":"ae@op5.se","avatar":"https://gravatar.com/avatar/426e89595c75a8f5252dd0c989e5fabe5bcac616e68557427ad9aef6b0ca342a?d=mp&s=160"},"body":"Matthew Wilcox wrote:\n> There's two syntax errors and one good-netizen error in the hooks/update\n> file created when cloning Linus' linux-2.6.git repo.  I don't know\n> if that file is created fresh or if it gets pulled from Linus' tree.\n> Here's a patch to fix it\n> \n\nGood thing I read new list entries before I send things. I did this \nexact same patch too. :)\n\n-- \nAndreas Ericsson                   andreas.ericsson@op5.se\nOP5 AB                             www.op5.se\nTel: +46 8-230225                  Fax: +46 8-230231\n"}]}