{"thread":{"id":"26301","subject":"[PATCH 1/3] t/t5400-send-pack.sh: use the canonical test_expect_success syntax","startedAt":"2011-01-18T21:41:34Z","lastAt":"2011-01-18T23:10:57Z","messageCount":4,"participants":["Ævar Arnfjörð Bjarmason","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":3},"messages":[{"id":"159603","messageId":"1295386896-21828-1-git-send-email-avarab@gmail.com","threadId":"26301","inReplyTo":null,"subject":"[PATCH 1/3] t/t5400-send-pack.sh: use the canonical test_expect_success syntax","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2011-01-18T21:41:34Z","receivedAt":"2011-01-18T21:41:34Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"Change t/t5400-send-pack.sh to use the usual test_expect_success\nsyntax, i.e. change:\n\n    test_expect_success \\\n        'description'\n\nTo:\n\n    test_expect_success 'description'\n\nLike the rest of the tests in t/t5400-send-pack.sh do.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n---\n t/t5400-send-pack.sh |    3 +--\n 1 files changed, 1 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t5400-send-pack.sh b/t/t5400-send-pack.sh\nindex b0b2684..656ab1a 100755\n--- a/t/t5400-send-pack.sh\n+++ b/t/t5400-send-pack.sh\n@@ -76,8 +76,7 @@ test_expect_success 'refuse pushing rewound head without --force' '\n \ttest \"$victim_head\" = \"$pushed_head\"\n '\n \n-test_expect_success \\\n-        'push can be used to delete a ref' '\n+test_expect_success 'push can be used to delete a ref' '\n \t( cd victim && git branch extra master ) &&\n \tgit send-pack ./victim :extra master &&\n \t( cd victim &&\n-- \n1.7.2.3\n"},{"id":"159604","messageId":"1295386896-21828-2-git-send-email-avarab@gmail.com","threadId":"26301","inReplyTo":"1295386896-21828-1-git-send-email-avarab@gmail.com","subject":"[PATCH 2/3] t/t5400-send-pack.sh: add test_when_finished commands","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2011-01-18T21:41:35Z","receivedAt":"2011-01-18T21:41:35Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"Change the tests in t/t5400-send-pack.sh to use test_when_finished to\nunset git config variables that were set in the tests, e.g.:\n\n    git config --unset $variable_they_set\n\nThis doesn't change the test behavior, but makes each test more\nself-contained.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n---\n t/t5400-send-pack.sh |    9 ++++++---\n 1 files changed, 6 insertions(+), 3 deletions(-)\n\ndiff --git a/t/t5400-send-pack.sh b/t/t5400-send-pack.sh\nindex 656ab1a..0357610 100755\n--- a/t/t5400-send-pack.sh\n+++ b/t/t5400-send-pack.sh\n@@ -90,7 +90,8 @@ test_expect_success 'refuse deleting push with denyDeletes' '\n \t    git config receive.denyDeletes true &&\n \t    git branch extra master\n \t) &&\n-\ttest_must_fail git send-pack ./victim :extra master\n+\ttest_must_fail git send-pack ./victim :extra master &&\n+\ttest_when_finished \"(cd victim && git config --unset receive.denyDeletes)\"\n '\n \n test_expect_success 'cannot override denyDeletes with git -c send-pack' '\n@@ -101,7 +102,8 @@ test_expect_success 'cannot override denyDeletes with git -c send-pack' '\n \t\tgit branch extra master\n \t) &&\n \ttest_must_fail git -c receive.denyDeletes=false \\\n-\t\t\t\t\tsend-pack ./victim :extra master\n+\t\t\t\t\tsend-pack ./victim :extra master &&\n+\ttest_when_finished \"(cd victim && git config --unset receive.denyDeletes)\"\n '\n \n test_expect_success 'override denyDeletes with git -c receive-pack' '\n@@ -125,7 +127,8 @@ test_expect_success 'denyNonFastforwards trumps --force' '\n \tvictim_orig=$(cd victim && git rev-parse --verify master) &&\n \ttest_must_fail git send-pack --force ./victim master^:master &&\n \tvictim_head=$(cd victim && git rev-parse --verify master) &&\n-\ttest \"$victim_orig\" = \"$victim_head\"\n+\ttest \"$victim_orig\" = \"$victim_head\" &&\n+\ttest_when_finished \"(cd victim && git config --unset receive.denyNonFastforwards)\"\n '\n \n test_expect_success 'push --all excludes remote-tracking hierarchy' '\n-- \n1.7.2.3\n"},{"id":"159605","messageId":"1295386896-21828-3-git-send-email-avarab@gmail.com","threadId":"26301","inReplyTo":"1295386896-21828-1-git-send-email-avarab@gmail.com","subject":"[PATCH 3/3] t/t5400-send-pack.sh: re-indent subshell invocation","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2011-01-18T21:41:36Z","receivedAt":"2011-01-18T21:41:36Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"Change a subshell invocation in t/t5400-send-pack.sh to use one line\nper command in the subshell, that's the usual syntax we use for tests.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n---\n t/t5400-send-pack.sh |    6 +++++-\n 1 files changed, 5 insertions(+), 1 deletions(-)\n\ndiff --git a/t/t5400-send-pack.sh b/t/t5400-send-pack.sh\nindex 0357610..d4db5ac 100755\n--- a/t/t5400-send-pack.sh\n+++ b/t/t5400-send-pack.sh\n@@ -32,7 +32,11 @@ test_expect_success setup '\n \tdone &&\n \tgit update-ref HEAD \"$commit\" &&\n \tgit clone ./. victim &&\n-\t( cd victim && git config receive.denyCurrentBranch warn && git log ) &&\n+\t(\n+\t    cd victim &&\n+\t    git config receive.denyCurrentBranch warn &&\n+\t    git log\n+\t) &&\n \tgit update-ref HEAD \"$zero\" &&\n \tparent=$zero &&\n \ti=0 &&\n-- \n1.7.2.3\n"},{"id":"159611","messageId":"7vfwspkdtq.fsf@alter.siamese.dyndns.org","threadId":"26301","inReplyTo":"1295386896-21828-2-git-send-email-avarab@gmail.com","subject":"Re: [PATCH 2/3] t/t5400-send-pack.sh: add test_when_finished commands","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-01-18T23:10:57Z","receivedAt":"2011-01-18T23:10:57Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:\n\n> diff --git a/t/t5400-send-pack.sh b/t/t5400-send-pack.sh\n> index 656ab1a..0357610 100755\n> --- a/t/t5400-send-pack.sh\n> +++ b/t/t5400-send-pack.sh\n> @@ -90,7 +90,8 @@ test_expect_success 'refuse deleting push with denyDeletes' '\n>  \t    git config receive.denyDeletes true &&\n>  \t    git branch extra master\n>  \t) &&\n> -\ttest_must_fail git send-pack ./victim :extra master\n> +\ttest_must_fail git send-pack ./victim :extra master &&\n> +\ttest_when_finished \"(cd victim && git config --unset receive.denyDeletes)\"\n>  '\n\nI agree that you are trying to do a good thing, but does this\nimplementation work in practice?  If somebody breaks send-pack in such a\nway that this push succeeds, doesn't the &&-chain will prevent your\n\"when-finished\" hook to be registered to begin with?  IOW, wouldn't you\nwant to have when-finished as _early_ as possible, before any test that\nmight fail to help us identify a new breakage?\n\nThe same comment applies to other two hunks in the patch.\n"}]}