{"thread":{"id":"26268","subject":"Git Rebase blows away GIT_AUTHOR_NAME","startedAt":"2011-01-12T16:15:41Z","lastAt":"2011-01-19T01:33:42Z","messageCount":30,"participants":["JT Olds","Jeff King","Erik Faye-Lund","Tor Arntsen","Linus Torvalds","Jay Soffian","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"159406","messageId":"AANLkTinMX0yEPvSc-c=96R42SbFZTjW5Mnveuxk3ZHS=@mail.gmail.com","threadId":"26268","inReplyTo":null,"subject":"Git Rebase blows away GIT_AUTHOR_NAME","fromName":"JT Olds","fromEmail":"jtolds@xnet5.com","sentAt":"2011-01-12T16:15:41Z","receivedAt":"2011-01-12T16:15:41Z","isPatch":false,"sender":{"key":"jtolds@xnet5.com","avatar":"https://gravatar.com/avatar/eb3e48aedf07ef7a47727bd4b9e208ece8860c48c9eccc629e531348edd27fc1?d=mp&s=160"},"body":"I asked this in #git on freenode, and I've also spent a while\nsearching the internet for anyone with any similar issues, but I can't\nseem to find anyone or anything that knows what's going on.\n\nOn every fresh install of Ubuntu that I have used (by default, I use\necryptfs for my home directory, which of course has its own set of\nsilly Git errors right now), when I clone from a remote repository,\nhave changes local to me, and changes on the remote repository, do\n'git pull --rebase', occasionally my GIT_AUTHOR_NAME gets set to my\nGIT_AUTHOR_EMAIL on my changes that get applied on top of the remote\nchanges.\n\nThis is incredibly frustrating, so much so that my workflow now\nincludes running an alias to git filter-branch that fixes this.\n\nNotable things: so far I have only had a remote server hosted by\nGerrit, but I can't imagine how changes on the remote git server could\npossibly affect my local changes. Like I said, I'm using ecryptfs, and\nI'm using vanilla Git from the latest stable Ubuntu, though I've had\nthis problem on Ubuntus for a few releases now.\n\nAnyone have any idea why this might happen?\n\n-JT\n"},{"id":"159411","messageId":"20110112182150.GC31747@sigill.intra.peff.net","threadId":"26268","inReplyTo":"AANLkTinMX0yEPvSc-c=96R42SbFZTjW5Mnveuxk3ZHS=@mail.gmail.com","subject":"Re: Git Rebase blows away GIT_AUTHOR_NAME","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2011-01-12T18:21:50Z","receivedAt":"2011-01-12T18:21:50Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Wed, Jan 12, 2011 at 09:15:41AM -0700, JT Olds wrote:\n\n> On every fresh install of Ubuntu that I have used (by default, I use\n> ecryptfs for my home directory, which of course has its own set of\n> silly Git errors right now), when I clone from a remote repository,\n> have changes local to me, and changes on the remote repository, do\n> 'git pull --rebase', occasionally my GIT_AUTHOR_NAME gets set to my\n> GIT_AUTHOR_EMAIL on my changes that get applied on top of the remote\n> changes.\n\nWeird. I have never heard of anything like it.\n\nSome things off the top of my head: Does your GIT_AUTHOR_NAME or\nGIT_AUTHOR_EMAIL contain any odd characters that might confuse a parser?\nDo you do anything special with setting up those environment variables\nin your shell (e.g., in a .bashrc or .profile; those files _shouldn't_\nbe read by a non-interactive shell, but it's something to investigate)?\nFor that matter, how do you set up your identity in general (by\nenvironment, or in ~/.gitconfig, or a local .git/config in each repo),\nand what does it contain?\n\nCan you try running this in a repo that's giving you problems:\n\n  . git-sh-setup\n  git log --format=%H --author=your.name |\n  while read rev; do\n    get_author_ident_from_commit $rev\n    git format-patch -1 --stdout $rev |\n      git mailinfo /dev/null /dev/null\n  done | less\n\nand check that the output looks sane? I want to make sure there's\nnothing in your commits that is confusing our parser.\n\nIf that doesn't turn up anything, I think the next thing to try would be\nmaking a script that reproduces the problem for you, and see if I can\nreproduce it here.\n\n-Peff\n"},{"id":"159443","messageId":"AANLkTimanDRHwoqSj7i9sVCZkze1L3Qp-zFYwTwHAOHX@mail.gmail.com","threadId":"26268","inReplyTo":"20110112182150.GC31747@sigill.intra.peff.net","subject":"Re: Git Rebase blows away GIT_AUTHOR_NAME","fromName":"JT Olds","fromEmail":"jtolds@xnet5.com","sentAt":"2011-01-13T17:00:45Z","receivedAt":"2011-01-13T17:00:45Z","isPatch":false,"sender":{"key":"jtolds@xnet5.com","avatar":"https://gravatar.com/avatar/eb3e48aedf07ef7a47727bd4b9e208ece8860c48c9eccc629e531348edd27fc1?d=mp&s=160"},"body":"> Some things off the top of my head: Does your GIT_AUTHOR_NAME or\n> GIT_AUTHOR_EMAIL contain any odd characters that might confuse a parser?\n\nNah, from my .git/config\n\n[user]\n\tname = JT\n\temail = jt@instructure.com\n\n> Do you do anything special with setting up those environment variables\n> in your shell (e.g., in a .bashrc or .profile; those files _shouldn't_\n> be read by a non-interactive shell, but it's something to investigate)?\n\nNope, the only place in my entire home directory where those get set\nare in my filter-branch script to fix them, which I only run after the\nproblem manifests itself.\n\n> For that matter, how do you set up your identity in general (by\n> environment, or in ~/.gitconfig, or a local .git/config in each repo),\n> and what does it contain?\n\nI have a global identity in ~/.gitconfig\n\n[user]\n    name = JT\n    email = hello@jtolds.com\n\nand then in particular topic branches in their .git/config like before.\n\n> Can you try running this in a repo that's giving you problems:\n>\n>  . git-sh-setup\n>  git log --format=%H --author=your.name |\n>  while read rev; do\n>    get_author_ident_from_commit $rev\n>    git format-patch -1 --stdout $rev |\n>      git mailinfo /dev/null /dev/null\n>  done | less\n\nI don't have git-sh-setup, which seems like it should be included in\nthe git-core package, but it's not. I have git-core\n1:1.7.1-1.1ubuntu0.1 installed. Obviously this precludes\nget_author_ident_from_commit from working.\n\n> If that doesn't turn up anything, I think the next thing to try would be\n> making a script that reproduces the problem for you, and see if I can\n> reproduce it here.\n\nAlright, I'll see what I can do. Thanks.\n"},{"id":"159444","messageId":"AANLkTimvK3p3M8kbGzLxyhchoFONiD4=FGPWxxs=i0GA@mail.gmail.com","threadId":"26268","inReplyTo":"AANLkTimanDRHwoqSj7i9sVCZkze1L3Qp-zFYwTwHAOHX@mail.gmail.com","subject":"Re: Git Rebase blows away GIT_AUTHOR_NAME","fromName":"JT Olds","fromEmail":"jtolds@xnet5.com","sentAt":"2011-01-13T17:11:04Z","receivedAt":"2011-01-13T17:11:04Z","isPatch":false,"sender":{"key":"jtolds@xnet5.com","avatar":"https://gravatar.com/avatar/eb3e48aedf07ef7a47727bd4b9e208ece8860c48c9eccc629e531348edd27fc1?d=mp&s=160"},"body":"I got a copy of git-sh-setup. All of my commits (that have either\nworked or that I fixed) look like this:\n\nGIT_AUTHOR_NAME='JT'\nGIT_AUTHOR_EMAIL='jt@instructure.com'\nGIT_AUTHOR_DATE='1294756950 -0700'\nAuthor: jt@instructure.com\nEmail: jt@instructure.com\nSubject: removing nondeterminism from test\nDate: Tue, 11 Jan 2011 07:42:30 -0700\n\nShould \"Author\" be my name? Could that be what's going on? I don't\neven know where that gets set. The ones that I failed to notice that\nthey broke before I pushed them look like this:\n\nGIT_AUTHOR_NAME='jt@instructure.com'\nGIT_AUTHOR_EMAIL='jt@instructure.com'\nGIT_AUTHOR_DATE='1294775987 -0700'\nAuthor: jt@instructure.com\nEmail: jt@instructure.com\nSubject: some cleanup\nDate: Tue, 11 Jan 2011 12:59:47 -0700\n\nThanks again for the help. This has been frustrating me for months.\nStill working on a duplicate-the-problem script.\n\n-JT\n\nOn Thu, Jan 13, 2011 at 10:00 AM, JT Olds <jtolds@xnet5.com> wrote:\n>> Some things off the top of my head: Does your GIT_AUTHOR_NAME or\n>> GIT_AUTHOR_EMAIL contain any odd characters that might confuse a parser?\n>\n> Nah, from my .git/config\n>\n> [user]\n>        name = JT\n>        email = jt@instructure.com\n>\n>> Do you do anything special with setting up those environment variables\n>> in your shell (e.g., in a .bashrc or .profile; those files _shouldn't_\n>> be read by a non-interactive shell, but it's something to investigate)?\n>\n> Nope, the only place in my entire home directory where those get set\n> are in my filter-branch script to fix them, which I only run after the\n> problem manifests itself.\n>\n>> For that matter, how do you set up your identity in general (by\n>> environment, or in ~/.gitconfig, or a local .git/config in each repo),\n>> and what does it contain?\n>\n> I have a global identity in ~/.gitconfig\n>\n> [user]\n>    name = JT\n>    email = hello@jtolds.com\n>\n> and then in particular topic branches in their .git/config like before.\n>\n>> Can you try running this in a repo that's giving you problems:\n>>\n>>  . git-sh-setup\n>>  git log --format=%H --author=your.name |\n>>  while read rev; do\n>>    get_author_ident_from_commit $rev\n>>    git format-patch -1 --stdout $rev |\n>>      git mailinfo /dev/null /dev/null\n>>  done | less\n>\n> I don't have git-sh-setup, which seems like it should be included in\n> the git-core package, but it's not. I have git-core\n> 1:1.7.1-1.1ubuntu0.1 installed. Obviously this precludes\n> get_author_ident_from_commit from working.\n>\n>> If that doesn't turn up anything, I think the next thing to try would be\n>> making a script that reproduces the problem for you, and see if I can\n>> reproduce it here.\n>\n> Alright, I'll see what I can do. Thanks.\n>\n"},{"id":"159445","messageId":"AANLkTikqfX3jhSdP5xhFj=VktqW2S6AeGL_MF18g8ZA_@mail.gmail.com","threadId":"26268","inReplyTo":"AANLkTimvK3p3M8kbGzLxyhchoFONiD4=FGPWxxs=i0GA@mail.gmail.com","subject":"Re: Git Rebase blows away GIT_AUTHOR_NAME","fromName":"Erik Faye-Lund","fromEmail":"kusmabite@gmail.com","sentAt":"2011-01-13T17:47:28Z","receivedAt":"2011-01-13T17:47:28Z","isPatch":false,"sender":{"key":"kusmabite@gmail.com","avatar":"https://avatars.githubusercontent.com/u/47073?v=4"},"body":"On Thu, Jan 13, 2011 at 6:11 PM, JT Olds <jtolds@xnet5.com> wrote:\n> I got a copy of git-sh-setup. All of my commits (that have either\n> worked or that I fixed) look like this:\n>\n> GIT_AUTHOR_NAME='JT'\n> GIT_AUTHOR_EMAIL='jt@instructure.com'\n> GIT_AUTHOR_DATE='1294756950 -0700'\n> Author: jt@instructure.com\n> Email: jt@instructure.com\n> Subject: removing nondeterminism from test\n> Date: Tue, 11 Jan 2011 07:42:30 -0700\n>\n> Should \"Author\" be my name? Could that be what's going on? I don't\n> even know where that gets set. The ones that I failed to notice that\n> they broke before I pushed them look like this:\n>\n\n\"git am\" (which git rebase builds on) requires the author name to be\nat least three characters long. This is a problem that has been\ndiscussed before, see\n<AANLkTinqTL7gH4CHEfy8UrhK13xcO_3UzgIyQka00MAh@mail.gmail.com>:\n\nhttp://mid.gmane.org/AANLkTinqTL7gH4CHEfy8UrhK13xcO_3UzgIyQka00MAh@mail.gmail.com\n"},{"id":"159446","messageId":"AANLkTimf2rwKqyWwQbdj7cjS8YcQwCXYGRCvQbZ5HZ19@mail.gmail.com","threadId":"26268","inReplyTo":"AANLkTikqfX3jhSdP5xhFj=VktqW2S6AeGL_MF18g8ZA_@mail.gmail.com","subject":"Re: Git Rebase blows away GIT_AUTHOR_NAME","fromName":"JT Olds","fromEmail":"jtolds@xnet5.com","sentAt":"2011-01-13T17:52:48Z","receivedAt":"2011-01-13T17:52:48Z","isPatch":false,"sender":{"key":"jtolds@xnet5.com","avatar":"https://gravatar.com/avatar/eb3e48aedf07ef7a47727bd4b9e208ece8860c48c9eccc629e531348edd27fc1?d=mp&s=160"},"body":"Oh thank you Erik, it's great to just know what the problem is. I've\nbeen feeling like some voodoo was happening.\n\nWhat are the chances of decreasing that lower bound of author name size? :)\n\n-JT\n\nOn Thu, Jan 13, 2011 at 10:47 AM, Erik Faye-Lund <kusmabite@gmail.com> wrote:\n> On Thu, Jan 13, 2011 at 6:11 PM, JT Olds <jtolds@xnet5.com> wrote:\n>> I got a copy of git-sh-setup. All of my commits (that have either\n>> worked or that I fixed) look like this:\n>>\n>> GIT_AUTHOR_NAME='JT'\n>> GIT_AUTHOR_EMAIL='jt@instructure.com'\n>> GIT_AUTHOR_DATE='1294756950 -0700'\n>> Author: jt@instructure.com\n>> Email: jt@instructure.com\n>> Subject: removing nondeterminism from test\n>> Date: Tue, 11 Jan 2011 07:42:30 -0700\n>>\n>> Should \"Author\" be my name? Could that be what's going on? I don't\n>> even know where that gets set. The ones that I failed to notice that\n>> they broke before I pushed them look like this:\n>>\n>\n> \"git am\" (which git rebase builds on) requires the author name to be\n> at least three characters long. This is a problem that has been\n> discussed before, see\n> <AANLkTinqTL7gH4CHEfy8UrhK13xcO_3UzgIyQka00MAh@mail.gmail.com>:\n>\n> http://mid.gmane.org/AANLkTinqTL7gH4CHEfy8UrhK13xcO_3UzgIyQka00MAh@mail.gmail.com\n>\n"},{"id":"159447","messageId":"AANLkTik15iV9SOv6rRL5+DQkAZ4JwBGTS+gqS3nXy2hN@mail.gmail.com","threadId":"26268","inReplyTo":"AANLkTimf2rwKqyWwQbdj7cjS8YcQwCXYGRCvQbZ5HZ19@mail.gmail.com","subject":"Re: Git Rebase blows away GIT_AUTHOR_NAME","fromName":"Erik Faye-Lund","fromEmail":"kusmabite@gmail.com","sentAt":"2011-01-13T18:20:38Z","receivedAt":"2011-01-13T18:20:38Z","isPatch":false,"sender":{"key":"kusmabite@gmail.com","avatar":"https://avatars.githubusercontent.com/u/47073?v=4"},"body":"In the future please don't top-post, as it makes the discussion harder\nfor other people to follow. I've fixed the quoting for now, though.\n\nOn Thu, Jan 13, 2011 at 6:52 PM, JT Olds <jtolds@xnet5.com> wrote:\n> On Thu, Jan 13, 2011 at 10:47 AM, Erik Faye-Lund <kusmabite@gmail.com> wrote:\n>> On Thu, Jan 13, 2011 at 6:11 PM, JT Olds <jtolds@xnet5.com> wrote:\n>>> I got a copy of git-sh-setup. All of my commits (that have either\n>>> worked or that I fixed) look like this:\n>>>\n>>> GIT_AUTHOR_NAME='JT'\n>>> GIT_AUTHOR_EMAIL='jt@instructure.com'\n>>> GIT_AUTHOR_DATE='1294756950 -0700'\n>>> Author: jt@instructure.com\n>>> Email: jt@instructure.com\n>>> Subject: removing nondeterminism from test\n>>> Date: Tue, 11 Jan 2011 07:42:30 -0700\n>>>\n>>> Should \"Author\" be my name? Could that be what's going on? I don't\n>>> even know where that gets set. The ones that I failed to notice that\n>>> they broke before I pushed them look like this:\n>>>\n>>\n>> \"git am\" (which git rebase builds on) requires the author name to be\n>> at least three characters long. This is a problem that has been\n>> discussed before, see\n>> <AANLkTinqTL7gH4CHEfy8UrhK13xcO_3UzgIyQka00MAh@mail.gmail.com>:\n>>\n>> http://mid.gmane.org/AANLkTinqTL7gH4CHEfy8UrhK13xcO_3UzgIyQka00MAh@mail.gmail.com\n>>\n>\n> Oh thank you Erik, it's great to just know what the problem is. I've\n> been feeling like some voodoo was happening.\n>\n> What are the chances of decreasing that lower bound of author name size? :)\n>\n\nIt's a matter of editing the function called \"get_sane_name\" in\nbuiltin/mailinfo.c.\n\nBut simply changing the bound doesn't mean you're in the clear. If any\nother people you work with end up rebasing any patches you've written,\nthe same problem will manifest. There's a lot of people using some\nreally old versions of Git.\n\nAnd then it's the question of why this is done in the first place. I\ndon't know, but I suspect Linus has his reasons. Besides, a name of\ntwo characters aren't really sane. You'd need at least three\ncharacters to form a first/last name pair.\n\nI'd recommend that you use a longer name, really.\n"},{"id":"159448","messageId":"20110113184739.GA7785@sigill.intra.peff.net","threadId":"26268","inReplyTo":"AANLkTimvK3p3M8kbGzLxyhchoFONiD4=FGPWxxs=i0GA@mail.gmail.com","subject":"Re: Git Rebase blows away GIT_AUTHOR_NAME","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2011-01-13T18:47:39Z","receivedAt":"2011-01-13T18:47:39Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Thu, Jan 13, 2011 at 10:00:45AM -0700, JT Olds wrote:\n\n> I don't have git-sh-setup, which seems like it should be included in\n> the git-core package, but it's not. I have git-core\n> 1:1.7.1-1.1ubuntu0.1 installed. Obviously this precludes\n> get_author_ident_from_commit from working.\n\nOops, sorry about that. It ships in the /usr/lib/git-core directory\nthese days (it _used_ to ship in /usr/bin, so \".\" would find it\nautomatically). And when I did my test, I was using the git repository\nitself, so of course it was in my current directory then. :)\n\nBut it looks like you found it.\n\n> Author: jt@instructure.com\n> Email: jt@instructure.com\n> Subject: removing nondeterminism from test\n> Date: Tue, 11 Jan 2011 07:42:30 -0700\n> \n> Should \"Author\" be my name? Could that be what's going on? I don't\n> even know where that gets set. The ones that I failed to notice that\n> they broke before I pushed them look like this:\n\nYep, it should be your name. So my next to suspect would be the\ngit-mailinfo parser, and indeed, that's the thing that has the\n3-character limit that Erik mentioned.\n\nSo that's definitely the problem.\n\n-Peff\n"},{"id":"159466","messageId":"AANLkTikk7Xdiey76Dmy848_B4qNX2-Vbis7p=E8vtNL9@mail.gmail.com","threadId":"26268","inReplyTo":"AANLkTik15iV9SOv6rRL5+DQkAZ4JwBGTS+gqS3nXy2hN@mail.gmail.com","subject":"Re: Git Rebase blows away GIT_AUTHOR_NAME","fromName":"Tor Arntsen","fromEmail":"tor@spacetec.no","sentAt":"2011-01-14T08:45:40Z","receivedAt":"2011-01-14T08:45:40Z","isPatch":false,"sender":{"key":"tor@spacetec.no","avatar":null},"body":"On Thu, Jan 13, 2011 at 19:20, Erik Faye-Lund <kusmabite@gmail.com> wrote:\n>[..] Besides, a name of\n> two characters aren't really sane. You'd need at least three\n> characters to form a first/last name pair.\n\nI think I've mentioned this before in another thread, but first/last\nname isn't universal, not even within countries where it's the common\nform. When I was as student there was a fellow student from another\nscandinavian country and his legal, full name consisted of a single\nletter.\n\n-Tor\n"},{"id":"159468","messageId":"AANLkTimONqL4=E4Unrsj9PU5u57KGXrmO6xWUOCLorgs@mail.gmail.com","threadId":"26268","inReplyTo":"AANLkTikk7Xdiey76Dmy848_B4qNX2-Vbis7p=E8vtNL9@mail.gmail.com","subject":"Re: Git Rebase blows away GIT_AUTHOR_NAME","fromName":"Erik Faye-Lund","fromEmail":"kusmabite@gmail.com","sentAt":"2011-01-14T08:56:01Z","receivedAt":"2011-01-14T08:56:01Z","isPatch":false,"sender":{"key":"kusmabite@gmail.com","avatar":"https://avatars.githubusercontent.com/u/47073?v=4"},"body":"On Fri, Jan 14, 2011 at 9:45 AM, Tor Arntsen <tor@spacetec.no> wrote:\n> On Thu, Jan 13, 2011 at 19:20, Erik Faye-Lund <kusmabite@gmail.com> wrote:\n>>[..] Besides, a name of\n>> two characters aren't really sane. You'd need at least three\n>> characters to form a first/last name pair.\n>\n> I think I've mentioned this before in another thread, but first/last\n> name isn't universal, not even within countries where it's the common\n> form. When I was as student there was a fellow student from another\n> scandinavian country and his legal, full name consisted of a single\n> letter.\n>\n\nI'm curious, what Scandinavian country was this? Because as a\nNorwegian, I know a lot of people from all Scandinavian country, yet\nI've never heard of such names. In Norway, I the shortest legal name\nI've ever heard of was five characters.\n"},{"id":"159472","messageId":"AANLkTi=PTgmOSC7pRLjujO5fi9Wdp69Jmj4zCkhGSYSz@mail.gmail.com","threadId":"26268","inReplyTo":"AANLkTimONqL4=E4Unrsj9PU5u57KGXrmO6xWUOCLorgs@mail.gmail.com","subject":"Re: Git Rebase blows away GIT_AUTHOR_NAME","fromName":"Tor Arntsen","fromEmail":"tor@spacetec.no","sentAt":"2011-01-14T09:24:47Z","receivedAt":"2011-01-14T09:24:47Z","isPatch":false,"sender":{"key":"tor@spacetec.no","avatar":null},"body":"On Fri, Jan 14, 2011 at 09:56, Erik Faye-Lund <kusmabite@gmail.com> wrote:\n> On Fri, Jan 14, 2011 at 9:45 AM, Tor Arntsen <tor@spacetec.no> wrote:\n>> I think I've mentioned this before in another thread, but first/last\n>> name isn't universal, not even within countries where it's the common\n>> form. When I was as student there was a fellow student from another\n>> scandinavian country and his legal, full name consisted of a single\n>> letter.\n>>\n>\n> I'm curious, what Scandinavian country was this? Because as a\n> Norwegian, I know a lot of people from all Scandinavian country, yet\n> I've never heard of such names. In Norway, I the shortest legal name\n> I've ever heard of was five characters.\n\nSweden (I'm Norwegian too - this guy was a Swede studying in Norway).\nAdmittedly I have only that single example, and it was back in the\nlate seventies. His name was accepted as legal by Statens Lånekasse\n(bank for students) and when the loans arrived his single-letter name\nwould be found at the very end of the long lists of wide listing-paper\nprintouts from the bank that was stiched up on the billboard wall\noutside the administration offices. The loans arrived a couple of\ntimes per year but we always had to go looking - the rest of us were\njust amazed that we could really find that single letter down there\nand he wasn't bs'ing the rest of us about his name.\n\nI'm not sure why there's a 3-letter limit on git author names.. but I\nwould suggest it should be set down to 1 letter minimum.. below that\nwould, I think, be overdoing it..\n\n-Tor\n"},{"id":"159473","messageId":"AANLkTiksAZSi-Yo8yJv5ca9XWWvB3iVQhZOJtTs-F8gk@mail.gmail.com","threadId":"26268","inReplyTo":"AANLkTi=PTgmOSC7pRLjujO5fi9Wdp69Jmj4zCkhGSYSz@mail.gmail.com","subject":"Re: Git Rebase blows away GIT_AUTHOR_NAME","fromName":"Erik Faye-Lund","fromEmail":"kusmabite@gmail.com","sentAt":"2011-01-14T09:53:25Z","receivedAt":"2011-01-14T09:53:25Z","isPatch":false,"sender":{"key":"kusmabite@gmail.com","avatar":"https://avatars.githubusercontent.com/u/47073?v=4"},"body":"(CC'ed Linus, as he wrote mailinfo's sanity-checking)\n\nOn Fri, Jan 14, 2011 at 10:24 AM, Tor Arntsen <tor@spacetec.no> wrote:\n> On Fri, Jan 14, 2011 at 09:56, Erik Faye-Lund <kusmabite@gmail.com> wrote:\n>> On Fri, Jan 14, 2011 at 9:45 AM, Tor Arntsen <tor@spacetec.no> wrote:\n>>> I think I've mentioned this before in another thread, but first/last\n>>> name isn't universal, not even within countries where it's the common\n>>> form. When I was as student there was a fellow student from another\n>>> scandinavian country and his legal, full name consisted of a single\n>>> letter.\n>>>\n>>\n>> I'm curious, what Scandinavian country was this? Because as a\n>> Norwegian, I know a lot of people from all Scandinavian country, yet\n>> I've never heard of such names. In Norway, I the shortest legal name\n>> I've ever heard of was five characters.\n>\n> Sweden (I'm Norwegian too - this guy was a Swede studying in Norway).\n> Admittedly I have only that single example, and it was back in the\n> late seventies. His name was accepted as legal by Statens Lånekasse\n> (bank for students) and when the loans arrived his single-letter name\n> would be found at the very end of the long lists of wide listing-paper\n> printouts from the bank that was stiched up on the billboard wall\n> outside the administration offices. The loans arrived a couple of\n> times per year but we always had to go looking - the rest of us were\n> just amazed that we could really find that single letter down there\n> and he wasn't bs'ing the rest of us about his name.\n>\n> I'm not sure why there's a 3-letter limit on git author names.. but I\n> would suggest it should be set down to 1 letter minimum.. below that\n> would, I think, be overdoing it..\n>\n\nLinus, you wrote sanity_check (from 2744b23). Do you remember if there\nwere any specific reason for the minimum length of 3 of an\nauthor-name? It seems that in Sweden, legal names can be even a single\nletter (see Tor's comment)...\n"},{"id":"159474","messageId":"AANLkTi=P8DXNa5b0iZV+A3Sx0bKNSG+fsViQgid5ovo3@mail.gmail.com","threadId":"26268","inReplyTo":"AANLkTi=PTgmOSC7pRLjujO5fi9Wdp69Jmj4zCkhGSYSz@mail.gmail.com","subject":"Re: Git Rebase blows away GIT_AUTHOR_NAME","fromName":"Erik Faye-Lund","fromEmail":"kusmabite@gmail.com","sentAt":"2011-01-14T09:55:37Z","receivedAt":"2011-01-14T09:55:37Z","isPatch":false,"sender":{"key":"kusmabite@gmail.com","avatar":"https://avatars.githubusercontent.com/u/47073?v=4"},"body":"(CC'ed Linus, as he wrote mailinfo's sanity-checking -- sorry, forgot\nto actually CC him the first time)\nOn Fri, Jan 14, 2011 at 10:24 AM, Tor Arntsen <tor@spacetec.no> wrote:\n> On Fri, Jan 14, 2011 at 09:56, Erik Faye-Lund <kusmabite@gmail.com> wrote:\n>> On Fri, Jan 14, 2011 at 9:45 AM, Tor Arntsen <tor@spacetec.no> wrote:\n>>> I think I've mentioned this before in another thread, but first/last\n>>> name isn't universal, not even within countries where it's the common\n>>> form. When I was as student there was a fellow student from another\n>>> scandinavian country and his legal, full name consisted of a single\n>>> letter.\n>>>\n>>\n>> I'm curious, what Scandinavian country was this? Because as a\n>> Norwegian, I know a lot of people from all Scandinavian country, yet\n>> I've never heard of such names. In Norway, I the shortest legal name\n>> I've ever heard of was five characters.\n>\n> Sweden (I'm Norwegian too - this guy was a Swede studying in Norway).\n> Admittedly I have only that single example, and it was back in the\n> late seventies. His name was accepted as legal by Statens Lånekasse\n> (bank for students) and when the loans arrived his single-letter name\n> would be found at the very end of the long lists of wide listing-paper\n> printouts from the bank that was stiched up on the billboard wall\n> outside the administration offices. The loans arrived a couple of\n> times per year but we always had to go looking - the rest of us were\n> just amazed that we could really find that single letter down there\n> and he wasn't bs'ing the rest of us about his name.\n>\n> I'm not sure why there's a 3-letter limit on git author names.. but I\n> would suggest it should be set down to 1 letter minimum.. below that\n> would, I think, be overdoing it..\n>\n\nLinus, you wrote sanity_check (from 2744b23). Do you remember if there\nwere any specific reason for the minimum length of 3 of an\nauthor-name? It seems that in Sweden, legal names can be even a single\nletter (see Tor's comment)...\n"},{"id":"159490","messageId":"AANLkTin-xtAX3X0vqiSTXYZPgK3Yj_R7toX8neuNu-uD@mail.gmail.com","threadId":"26268","inReplyTo":"AANLkTiksAZSi-Yo8yJv5ca9XWWvB3iVQhZOJtTs-F8gk@mail.gmail.com","subject":"Re: Git Rebase blows away GIT_AUTHOR_NAME","fromName":"JT Olds","fromEmail":"jtolds@xnet5.com","sentAt":"2011-01-14T14:51:10Z","receivedAt":"2011-01-14T14:51:10Z","isPatch":false,"sender":{"key":"jtolds@xnet5.com","avatar":"https://gravatar.com/avatar/eb3e48aedf07ef7a47727bd4b9e208ece8860c48c9eccc629e531348edd27fc1?d=mp&s=160"},"body":"On Fri, Jan 14, 2011 at 2:53 AM, Erik Faye-Lund <kusmabite@gmail.com> wrote:\n> (CC'ed Linus, as he wrote mailinfo's sanity-checking)\n>\n> On Fri, Jan 14, 2011 at 10:24 AM, Tor Arntsen <tor@spacetec.no> wrote:\n>> On Fri, Jan 14, 2011 at 09:56, Erik Faye-Lund <kusmabite@gmail.com> wrote:\n>>> On Fri, Jan 14, 2011 at 9:45 AM, Tor Arntsen <tor@spacetec.no> wrote:\n>>>> I think I've mentioned this before in another thread, but first/last\n>>>> name isn't universal, not even within countries where it's the common\n>>>> form. When I was as student there was a fellow student from another\n>>>> scandinavian country and his legal, full name consisted of a single\n>>>> letter.\n>>>>\n>>>\n>>> I'm curious, what Scandinavian country was this? Because as a\n>>> Norwegian, I know a lot of people from all Scandinavian country, yet\n>>> I've never heard of such names. In Norway, I the shortest legal name\n>>> I've ever heard of was five characters.\n>>\n>> Sweden (I'm Norwegian too - this guy was a Swede studying in Norway).\n>> Admittedly I have only that single example, and it was back in the\n>> late seventies. His name was accepted as legal by Statens Lånekasse\n>> (bank for students) and when the loans arrived his single-letter name\n>> would be found at the very end of the long lists of wide listing-paper\n>> printouts from the bank that was stiched up on the billboard wall\n>> outside the administration offices. The loans arrived a couple of\n>> times per year but we always had to go looking - the rest of us were\n>> just amazed that we could really find that single letter down there\n>> and he wasn't bs'ing the rest of us about his name.\n>>\n>> I'm not sure why there's a 3-letter limit on git author names.. but I\n>> would suggest it should be set down to 1 letter minimum.. below that\n>> would, I think, be overdoing it..\n>>\n>\n> Linus, you wrote sanity_check (from 2744b23). Do you remember if there\n> were any specific reason for the minimum length of 3 of an\n> author-name? It seems that in Sweden, legal names can be even a single\n> letter (see Tor's comment)...\n>\n\nThanks all.\n\nI suppose another question, regardless of the outcome of following up\non the name limit, is how come this is silently swallowed?\n"},{"id":"159492","messageId":"AANLkTi=Z6Dx6m68zi7Q1eRVxX3DXOyKj+Ff177UCQrAj@mail.gmail.com","threadId":"26268","inReplyTo":"AANLkTiksAZSi-Yo8yJv5ca9XWWvB3iVQhZOJtTs-F8gk@mail.gmail.com","subject":"Re: Git Rebase blows away GIT_AUTHOR_NAME","fromName":"Linus Torvalds","fromEmail":"torvalds@linux-foundation.org","sentAt":"2011-01-14T15:41:43Z","receivedAt":"2011-01-14T15:41:43Z","isPatch":false,"sender":{"key":"torvalds@linux-foundation.org","avatar":"https://avatars.githubusercontent.com/u/1024025?v=4"},"body":"On Fri, Jan 14, 2011 at 1:53 AM, Erik Faye-Lund <kusmabite@gmail.com> wrote:\n>\n> Linus, you wrote sanity_check (from 2744b23). Do you remember if there\n> were any specific reason for the minimum length of 3 of an\n> author-name? It seems that in Sweden, legal names can be even a single\n> letter (see Tor's comment)...\n\nEven if the legal name would be a single letter, you'd still need to\nhave a surname.\n\nThe three-letter minimum is just a sanity check. If your name really\nis even just three letters, I suspect you're just lying. I don't know\nof anybody named \"A B\".\n\nThat thing is supposed to be a *NAME*. Not shorthand. Not your first\nname. Not your nickname. If you have a nickname, put it in quotes\ninside the real name.\n\nI've seen too many broken source control systems that just take your\nlogin as a name *cough*CVS*cough*, and then people think it's\n\"convenient\" and \"cool\" to have a short name.\n\nIt's not convenient. It's not cool. It's just shorthand where\nshorthand doesn't help. Then you end up using it in a public setting,\nand suddenly your cool shorthand or nickname isn't even remotely\nunique.\n\nNo, there is no uniquness \"requirements\" for the name, but come on.\nLook at shortlog output some day. We try to use just the name because\nit looks better. But if people don't use their full name, it just\nlooks _stupid_\n\n                                    Linus\n"},{"id":"159493","messageId":"AANLkTimZF+r2aNzrXsUuHVZR65N5wpOYLutFgGAGoci_@mail.gmail.com","threadId":"26268","inReplyTo":"AANLkTi=Z6Dx6m68zi7Q1eRVxX3DXOyKj+Ff177UCQrAj@mail.gmail.com","subject":"Re: Git Rebase blows away GIT_AUTHOR_NAME","fromName":"Erik Faye-Lund","fromEmail":"kusmabite@gmail.com","sentAt":"2011-01-14T16:13:59Z","receivedAt":"2011-01-14T16:13:59Z","isPatch":false,"sender":{"key":"kusmabite@gmail.com","avatar":"https://avatars.githubusercontent.com/u/47073?v=4"},"body":"On Fri, Jan 14, 2011 at 4:41 PM, Linus Torvalds\n<torvalds@linux-foundation.org> wrote:\n> On Fri, Jan 14, 2011 at 1:53 AM, Erik Faye-Lund <kusmabite@gmail.com> wrote:\n>>\n>> Linus, you wrote sanity_check (from 2744b23). Do you remember if there\n>> were any specific reason for the minimum length of 3 of an\n>> author-name? It seems that in Sweden, legal names can be even a single\n>> letter (see Tor's comment)...\n>\n> Even if the legal name would be a single letter, you'd still need to\n> have a surname.\n>\n\nI think Tor pointed out that he knew a swede with his full legal name\nto be only one letter long. I would suppose that meant that he didn't\nhave a surename?\n\n> The three-letter minimum is just a sanity check. If your name really\n> is even just three letters, I suspect you're just lying. I don't know\n> of anybody named \"A B\".\n>\n\nThanks for clarifying that it's not there for a technical reason. The\nthing is, git-am seems to be the only place where such a sanity-check\nis performed. Shouldn't git-commit rather perform such checks also (if\nsuch a check should be done at all), perhaps with an override similar\nto --allow-empty? And on top of all it doesn't barf, it just silently\nreplace the name with the e-mail...\n\n> That thing is supposed to be a *NAME*. Not shorthand. Not your first\n> name. Not your nickname. If you have a nickname, put it in quotes\n> inside the real name.\n>\n> I've seen too many broken source control systems that just take your\n> login as a name *cough*CVS*cough*, and then people think it's\n> \"convenient\" and \"cool\" to have a short name.\n>\n> It's not convenient. It's not cool. It's just shorthand where\n> shorthand doesn't help. Then you end up using it in a public setting,\n> and suddenly your cool shorthand or nickname isn't even remotely\n> unique.\n>\n> No, there is no uniquness \"requirements\" for the name, but come on.\n> Look at shortlog output some day. We try to use just the name because\n> it looks better. But if people don't use their full name, it just\n> looks _stupid_\n\nI agree with you that using nicknames etc as author-name is a bit\nsilly, but I'm not sure if I want my version control system to tell me\nthat it thinks my author-name looks stupid :)\n\nIMO, we should probably just remove the check altogether.\n\nThere's also an upper-bound of 60 characters. I'm wondering if this\ncould be hit by valid names, especially with non-western UTF-8\ncharacters. Perhaps this should be removed also. The check for '@',\n'<' and '>' is probably still OK.\n"},{"id":"159496","messageId":"4D3077FE.9090407@spacetec.no","threadId":"26268","inReplyTo":"AANLkTi=Z6Dx6m68zi7Q1eRVxX3DXOyKj+Ff177UCQrAj@mail.gmail.com","subject":"Re: Git Rebase blows away GIT_AUTHOR_NAME","fromName":"Tor Arntsen","fromEmail":"tor@spacetec.no","sentAt":"2011-01-14T16:21:18Z","receivedAt":"2011-01-14T16:21:18Z","isPatch":false,"sender":{"key":"tor@spacetec.no","avatar":null},"body":"On 14/01/2011 17:13, Erik Faye-Lund wrote:\n\n> I think Tor pointed out that he knew a swede with his full legal name\n> to be only one letter long. I would suppose that meant that he didn't\n> have a surename?\n\nExactly. He didn't. Bank printouts etc. would only have that single\nletter, he didn't use a nickname - that letter was his legal name.\n\nAs for the rest of the world - I don't think the first name/last name combo\n(almost) everyone in the west use is necessarily a universal rule.\n\n-Tor\n"},{"id":"159494","messageId":"20110114162144.GA867@sigill.intra.peff.net","threadId":"26268","inReplyTo":"AANLkTimZF+r2aNzrXsUuHVZR65N5wpOYLutFgGAGoci_@mail.gmail.com","subject":"Re: Git Rebase blows away GIT_AUTHOR_NAME","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2011-01-14T16:21:45Z","receivedAt":"2011-01-14T16:21:45Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Jan 14, 2011 at 05:13:59PM +0100, Erik Faye-Lund wrote:\n\n> > The three-letter minimum is just a sanity check. If your name really\n> > is even just three letters, I suspect you're just lying. I don't know\n> > of anybody named \"A B\".\n> >\n> Thanks for clarifying that it's not there for a technical reason. The\n> thing is, git-am seems to be the only place where such a sanity-check\n> is performed. Shouldn't git-commit rather perform such checks also (if\n> such a check should be done at all), perhaps with an override similar\n> to --allow-empty? And on top of all it doesn't barf, it just silently\n> replace the name with the e-mail...\n\nI tend to agree with Linus on the stupidity issue, but I do worry about\nthe subtlety of the results. It causes silent data corruption during a\nrebase (or when somebody is applying an emailed patch). On the other\nhand, I do understand why Linus made a sanity check in the first place;\nhis use case is to deal with whatever crap people happen to mail him,\nwhether they have used git or not.\n\nSo we should probably do one or both of:\n\n  1. Make an --allow-any-name option to mailinfo, and use it when we\n     invoke mailinfo internally for rebasing. That still doesn't solve\n     the emailed patch problem, but at least keeps purely internal\n     operations sane.\n\n  2. Bump the check up to git-commit time, which is the best place to\n     catch and tell somebody that their name is too short, because they\n     can actually fix it.\n\nEven if we dropped the check now, option (2) is still useful, because\nyou have no idea which version of git the other end will use to apply\nyour patch.\n\n-Peff\n"},{"id":"159495","messageId":"AANLkTimkROu7W1DDueiaBRgCQuhT=7-vH5n1km65gpq4@mail.gmail.com","threadId":"26268","inReplyTo":"4D3077FE.9090407@spacetec.no","subject":"Re: Git Rebase blows away GIT_AUTHOR_NAME","fromName":"Erik Faye-Lund","fromEmail":"kusmabite@gmail.com","sentAt":"2011-01-14T16:26:39Z","receivedAt":"2011-01-14T16:26:39Z","isPatch":false,"sender":{"key":"kusmabite@gmail.com","avatar":"https://avatars.githubusercontent.com/u/47073?v=4"},"body":"On Fri, Jan 14, 2011 at 5:21 PM, Tor Arntsen <tor@spacetec.no> wrote:\n> On 14/01/2011 17:13, Erik Faye-Lund wrote:\n>\n>> I think Tor pointed out that he knew a swede with his full legal name\n>> to be only one letter long. I would suppose that meant that he didn't\n>> have a surename?\n>\n> Exactly. He didn't. Bank printouts etc. would only have that single\n> letter, he didn't use a nickname - that letter was his legal name.\n>\n\nPerhaps he could have spelled it out like he usually have to do:\n\"The artist formerly known as Prince\" ;)\n"},{"id":"159497","messageId":"AANLkTimcQq++CLv66AyTve+PiXBhYdUPk2epCyOXX1c0@mail.gmail.com","threadId":"26268","inReplyTo":"20110114162144.GA867@sigill.intra.peff.net","subject":"Re: Git Rebase blows away GIT_AUTHOR_NAME","fromName":"Erik Faye-Lund","fromEmail":"kusmabite@gmail.com","sentAt":"2011-01-14T16:30:51Z","receivedAt":"2011-01-14T16:30:51Z","isPatch":false,"sender":{"key":"kusmabite@gmail.com","avatar":"https://avatars.githubusercontent.com/u/47073?v=4"},"body":"On Fri, Jan 14, 2011 at 5:21 PM, Jeff King <peff@peff.net> wrote:\n> On Fri, Jan 14, 2011 at 05:13:59PM +0100, Erik Faye-Lund wrote:\n>\n>> > The three-letter minimum is just a sanity check. If your name really\n>> > is even just three letters, I suspect you're just lying. I don't know\n>> > of anybody named \"A B\".\n>> >\n>> Thanks for clarifying that it's not there for a technical reason. The\n>> thing is, git-am seems to be the only place where such a sanity-check\n>> is performed. Shouldn't git-commit rather perform such checks also (if\n>> such a check should be done at all), perhaps with an override similar\n>> to --allow-empty? And on top of all it doesn't barf, it just silently\n>> replace the name with the e-mail...\n>\n> I tend to agree with Linus on the stupidity issue, but I do worry about\n> the subtlety of the results. It causes silent data corruption during a\n> rebase (or when somebody is applying an emailed patch). On the other\n> hand, I do understand why Linus made a sanity check in the first place;\n> his use case is to deal with whatever crap people happen to mail him,\n> whether they have used git or not.\n>\n> So we should probably do one or both of:\n>\n>  1. Make an --allow-any-name option to mailinfo, and use it when we\n>     invoke mailinfo internally for rebasing. That still doesn't solve\n>     the emailed patch problem, but at least keeps purely internal\n>     operations sane.\n>\n>  2. Bump the check up to git-commit time, which is the best place to\n>     catch and tell somebody that their name is too short, because they\n>     can actually fix it.\n>\n\nThe problem with (2) is that git-am uses git-commit-tree rather than\ngit-commit. But I do think that adding the same checks to git-commit\nwould make sense. Unless we decide to remove the checks, that is...\n"},{"id":"159498","messageId":"20110114163333.GA1230@sigill.intra.peff.net","threadId":"26268","inReplyTo":"AANLkTimcQq++CLv66AyTve+PiXBhYdUPk2epCyOXX1c0@mail.gmail.com","subject":"Re: Git Rebase blows away GIT_AUTHOR_NAME","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2011-01-14T16:33:33Z","receivedAt":"2011-01-14T16:33:33Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Jan 14, 2011 at 05:30:51PM +0100, Erik Faye-Lund wrote:\n\n> >  2. Bump the check up to git-commit time, which is the best place to\n> >     catch and tell somebody that their name is too short, because they\n> >     can actually fix it.\n> >\n> \n> The problem with (2) is that git-am uses git-commit-tree rather than\n> git-commit. But I do think that adding the same checks to git-commit\n> would make sense. Unless we decide to remove the checks, that is...\n\nYeah, I didn't say it very clearly, but I meant to factor the check out\nand use it also in git-commit (probably as a warning, the same way we do\nwith other ident verification in print_summary().\n\nEven if we remove the check, it may still be worthwhile to say \"Just so\nyou know, older versions of git may mangle the name you have chosen\".\n\n-Peff\n"},{"id":"159499","messageId":"AANLkTi=3Z5Wnh_s3S10fDn26dypbt9aG93nOKan_8c4d@mail.gmail.com","threadId":"26268","inReplyTo":"4D3077FE.9090407@spacetec.no","subject":"Re: Git Rebase blows away GIT_AUTHOR_NAME","fromName":"Linus Torvalds","fromEmail":"torvalds@linux-foundation.org","sentAt":"2011-01-14T17:18:59Z","receivedAt":"2011-01-14T17:18:59Z","isPatch":false,"sender":{"key":"torvalds@linux-foundation.org","avatar":"https://avatars.githubusercontent.com/u/1024025?v=4"},"body":"On Fri, Jan 14, 2011 at 8:21 AM, Tor Arntsen <tor@spacetec.no> wrote:\n> On 14/01/2011 17:13, Erik Faye-Lund wrote:\n>\n>> I think Tor pointed out that he knew a swede with his full legal name\n>> to be only one letter long. I would suppose that meant that he didn't\n>> have a surename?\n>\n> Exactly. He didn't. Bank printouts etc. would only have that single\n> letter, he didn't use a nickname - that letter was his legal name.\n>\n> As for the rest of the world - I don't think the first name/last name combo\n> (almost) everyone in the west use is necessarily a universal rule.\n\nQuite frankly, I'd suggest that person then use \"The letter 'G'\" as\nhis/her git name.\n\ngit names aren't \"legal names\". They are for informational purposes.\n\nAnd a single letter just isn't informational.\n\n                Linus\n"},{"id":"159501","messageId":"AANLkTikM5cX1Jbo8m6bwoUPq1q-BLQ5VL_L=1QspE=Xj@mail.gmail.com","threadId":"26268","inReplyTo":"20110114163333.GA1230@sigill.intra.peff.net","subject":"Re: Git Rebase blows away GIT_AUTHOR_NAME","fromName":"Jay Soffian","fromEmail":"jaysoffian@gmail.com","sentAt":"2011-01-14T18:02:48Z","receivedAt":"2011-01-14T18:02:48Z","isPatch":false,"sender":{"key":"jaysoffian@gmail.com","avatar":"https://avatars.githubusercontent.com/u/155970?v=4"},"body":"On Fri, Jan 14, 2011 at 11:33 AM, Jeff King <peff@peff.net> wrote:\n> Even if we remove the check, it may still be worthwhile to say \"Just so\n> you know, older versions of git may mangle the name you have chosen\".\n\nI knew this conversation sounded familiar. It came up before in a\ndifferent context:\n\nhttp://thread.gmane.org/gmane.comp.version-control.git/150871/focus=150902\n\nj.\n"},{"id":"159502","messageId":"7vhbdbnxud.fsf@alter.siamese.dyndns.org","threadId":"26268","inReplyTo":"20110114162144.GA867@sigill.intra.peff.net","subject":"Re: Git Rebase blows away GIT_AUTHOR_NAME","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-01-14T18:28:58Z","receivedAt":"2011-01-14T18:28:58Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeff King <peff@peff.net> writes:\n\n> So we should probably do one or both of:\n>\n>   1. Make an --allow-any-name option to mailinfo, and use it when we\n>      invoke mailinfo internally for rebasing. That still doesn't solve\n>      the emailed patch problem, but at least keeps purely internal\n>      operations sane.\n>\n>   2. Bump the check up to git-commit time, which is the best place to\n>      catch and tell somebody that their name is too short, because they\n>      can actually fix it.\n>\n> Even if we dropped the check now, option (2) is still useful, because\n> you have no idea which version of git the other end will use to apply\n> your patch.\n\nI am perfectly Ok with making the check looser in \"am\" when $rebasing is\nin effect.  Wouldn't that solve the issue?\n"},{"id":"159505","messageId":"20110114200705.GA3316@sigill.intra.peff.net","threadId":"26268","inReplyTo":"7vhbdbnxud.fsf@alter.siamese.dyndns.org","subject":"Re: Git Rebase blows away GIT_AUTHOR_NAME","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2011-01-14T20:07:06Z","receivedAt":"2011-01-14T20:07:06Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Jan 14, 2011 at 10:28:58AM -0800, Junio C Hamano wrote:\n\n> Jeff King <peff@peff.net> writes:\n> \n> > So we should probably do one or both of:\n> >\n> >   1. Make an --allow-any-name option to mailinfo, and use it when we\n> >      invoke mailinfo internally for rebasing. That still doesn't solve\n> >      the emailed patch problem, but at least keeps purely internal\n> >      operations sane.\n> >\n> >   2. Bump the check up to git-commit time, which is the best place to\n> >      catch and tell somebody that their name is too short, because they\n> >      can actually fix it.\n> >\n> > Even if we dropped the check now, option (2) is still useful, because\n> > you have no idea which version of git the other end will use to apply\n> > your patch.\n> \n> I am perfectly Ok with making the check looser in \"am\" when $rebasing is\n> in effect.  Wouldn't that solve the issue?\n\nMore or less. You would still have some lossiness when emailing your\npatch. Do we want to warn about that?\n\n-Peff\n"},{"id":"159512","messageId":"7v4o9bnmno.fsf@alter.siamese.dyndns.org","threadId":"26268","inReplyTo":"20110114200705.GA3316@sigill.intra.peff.net","subject":"Re: Git Rebase blows away GIT_AUTHOR_NAME","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-01-14T22:30:35Z","receivedAt":"2011-01-14T22:30:35Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeff King <peff@peff.net> writes:\n\n> More or less. You would still have some lossiness when emailing your\n> patch. Do we want to warn about that?\n\nProbably not.\n\nThere will only be less than hundred people with a single letter name in\nthe world (I was tempted to say 26 but decided to be generous ;-) like\nthat, and you will much more likely to see an overly short \"name\" part\nfrom a misconfiguration or misparsing than from receiving a real patch\nfrom people with such a name.\n\nBut I haven't thought the issues, possible improvements and pros-and-cons\nthrough.\n"},{"id":"159568","messageId":"20110117222128.GA30869@sigill.intra.peff.net","threadId":"26268","inReplyTo":"20110114162144.GA867@sigill.intra.peff.net","subject":"Re: Git Rebase blows away GIT_AUTHOR_NAME","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2011-01-17T22:21:28Z","receivedAt":"2011-01-17T22:21:28Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Jan 14, 2011 at 11:21:45AM -0500, Jeff King wrote:\n\n> So we should probably do one or both of:\n> \n>   1. Make an --allow-any-name option to mailinfo, and use it when we\n>      invoke mailinfo internally for rebasing. That still doesn't solve\n>      the emailed patch problem, but at least keeps purely internal\n>      operations sane.\n\nSo I wrote up a nice tidy patch series with mailinfo changes and tests,\nand then am/rebase changes and tests on top of that. And guess what I\nnoticed? My rebase tests didn't actually fail with stock git.\n\nI bisected to 43c2325 (am: use get_author_ident_from_commit instead of\nmailinfo when rebasing, 2010-06-16), which was written to handle exactly\nthis sort of thing.\n\nThat commit made it into v1.7.2. JT, which version of git are you\nrunning? Do you still see any problems with v1.7.2 and above? I can't\nreplicate your issue with more recent versions.\n\nSo unless we want to do any sort of commit-time warning, I don't think\nthere is anything left to be done on this topic.\n\n-Peff\n"},{"id":"159569","messageId":"AANLkTinyteSHE6DpBi6mXLW7HpgXkEZL8HBeSuFyw+v2@mail.gmail.com","threadId":"26268","inReplyTo":"20110117222128.GA30869@sigill.intra.peff.net","subject":"Re: Git Rebase blows away GIT_AUTHOR_NAME","fromName":"Erik Faye-Lund","fromEmail":"kusmabite@gmail.com","sentAt":"2011-01-17T22:29:53Z","receivedAt":"2011-01-17T22:29:53Z","isPatch":false,"sender":{"key":"kusmabite@gmail.com","avatar":"https://avatars.githubusercontent.com/u/47073?v=4"},"body":"On Mon, Jan 17, 2011 at 11:21 PM, Jeff King <peff@peff.net> wrote:\n> On Fri, Jan 14, 2011 at 11:21:45AM -0500, Jeff King wrote:\n>\n>> So we should probably do one or both of:\n>>\n>>   1. Make an --allow-any-name option to mailinfo, and use it when we\n>>      invoke mailinfo internally for rebasing. That still doesn't solve\n>>      the emailed patch problem, but at least keeps purely internal\n>>      operations sane.\n>\n> So I wrote up a nice tidy patch series with mailinfo changes and tests,\n> and then am/rebase changes and tests on top of that. And guess what I\n> noticed? My rebase tests didn't actually fail with stock git.\n>\n> I bisected to 43c2325 (am: use get_author_ident_from_commit instead of\n> mailinfo when rebasing, 2010-06-16), which was written to handle exactly\n> this sort of thing.\n>\n\nHeh, same story bro :(\n\nJust for reference, my patch can be found at\nhttp://repo.or.cz/w/git/kusma.git work/rebase-keep-name\n"},{"id":"159571","messageId":"AANLkTinY1Wcirxi2bRUv+GuTG9eWczd-T1o0Mmx8VFdA@mail.gmail.com","threadId":"26268","inReplyTo":"20110117222128.GA30869@sigill.intra.peff.net","subject":"Re: Git Rebase blows away GIT_AUTHOR_NAME","fromName":"JT Olds","fromEmail":"jtolds@xnet5.com","sentAt":"2011-01-18T03:55:42Z","receivedAt":"2011-01-18T03:55:42Z","isPatch":false,"sender":{"key":"jtolds@xnet5.com","avatar":"https://gravatar.com/avatar/eb3e48aedf07ef7a47727bd4b9e208ece8860c48c9eccc629e531348edd27fc1?d=mp&s=160"},"body":"On Mon, Jan 17, 2011 at 3:21 PM, Jeff King <peff@peff.net> wrote:\n> On Fri, Jan 14, 2011 at 11:21:45AM -0500, Jeff King wrote:\n>\n>> So we should probably do one or both of:\n>>\n>>   1. Make an --allow-any-name option to mailinfo, and use it when we\n>>      invoke mailinfo internally for rebasing. That still doesn't solve\n>>      the emailed patch problem, but at least keeps purely internal\n>>      operations sane.\n>\n> So I wrote up a nice tidy patch series with mailinfo changes and tests,\n> and then am/rebase changes and tests on top of that. And guess what I\n> noticed? My rebase tests didn't actually fail with stock git.\n>\n> I bisected to 43c2325 (am: use get_author_ident_from_commit instead of\n> mailinfo when rebasing, 2010-06-16), which was written to handle exactly\n> this sort of thing.\n>\n> That commit made it into v1.7.2. JT, which version of git are you\n> running? Do you still see any problems with v1.7.2 and above? I can't\n> replicate your issue with more recent versions.\n>\n> So unless we want to do any sort of commit-time warning, I don't think\n> there is anything left to be done on this topic.\n>\n> -Peff\n>\n\nOh ho! No, I am running 1.7.1. I was so pleased to find out what the\nroot of the problem was, though, that I did go and add my last name\nand haven't had any trouble since.\n\nThanks for all your help everyone.\n\n-JT\n"},{"id":"159615","messageId":"AANLkTi=aTbm_Wic=7sMuz1rTd69enRUioX13kWuJJoEF@mail.gmail.com","threadId":"26268","inReplyTo":"20110117222128.GA30869@sigill.intra.peff.net","subject":"Re: Git Rebase blows away GIT_AUTHOR_NAME","fromName":"Jay Soffian","fromEmail":"jaysoffian@gmail.com","sentAt":"2011-01-19T01:33:42Z","receivedAt":"2011-01-19T01:33:42Z","isPatch":false,"sender":{"key":"jaysoffian@gmail.com","avatar":"https://avatars.githubusercontent.com/u/155970?v=4"},"body":"On Mon, Jan 17, 2011 at 5:21 PM, Jeff King <peff@peff.net> wrote:\n> I bisected to 43c2325 (am: use get_author_ident_from_commit instead of\n> mailinfo when rebasing, 2010-06-16), which was written to handle exactly\n> this sort of thing.\n\nWow. Well, I apologize for not short-circuiting this thread much\nsooner, but believe it or not, I didn't even remember writing that\ntill you just pointed it out. I'm too young to be losing my memory.\n:-(\n\nj.\n"}]}