{"thread":{"id":"26255","subject":"[PATCH] userdiff: match Pascal class methods","startedAt":"2011-01-11T08:53:59Z","lastAt":"2011-01-11T19:50:59Z","messageCount":3,"participants":["Alexey Shumkin","Junio C Hamano","Алексей Шумкин"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"159313","messageId":"1294736039-5912-1-git-send-email-zapped@mail.ru","threadId":"26255","inReplyTo":null,"subject":"[PATCH] userdiff: match Pascal class methods","fromName":"Alexey Shumkin","fromEmail":"zapped@mail.ru","sentAt":"2011-01-11T08:53:59Z","receivedAt":"2011-01-11T08:53:59Z","isPatch":true,"sender":{"key":"alex.crezoff@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1183752?v=4"},"body":"Class declarations were already covered by the second pattern, but class methods have the 'class' keyword in front too. Account for it.\n\nSigned-off-by: Alexey Shumkin <zapped@mail.ru>\nAcked-by: Thomas Rast <trast@student.ethz.ch>\n---\n userdiff.c |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/userdiff.c b/userdiff.c\nindex f9e05b5..259a382 100644\n--- a/userdiff.c\n+++ b/userdiff.c\n@@ -52,7 +52,7 @@ PATTERNS(\"objc\",\n \t \"|[-+*/<>%&^|=!]=|--|\\\\+\\\\+|<<=?|>>=?|&&|\\\\|\\\\||::|->\"\n \t \"|[^[:space:]]|[\\x80-\\xff]+\"),\n PATTERNS(\"pascal\",\n-\t \"^((procedure|function|constructor|destructor|interface|\"\n+\t \"^(((class[ \\t]+)?(procedure|function)|constructor|destructor|interface|\"\n \t\t\"implementation|initialization|finalization)[ \\t]*.*)$\"\n \t \"\\n\"\n \t \"^(.*=[ \\t]*(class|record).*)$\",\n-- \n1.7.3.4.3.g3f811\n"},{"id":"159367","messageId":"7vipxv45ky.fsf@alter.siamese.dyndns.org","threadId":"26255","inReplyTo":"1294736039-5912-1-git-send-email-zapped@mail.ru","subject":"Re: [PATCH] userdiff: match Pascal class methods","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-01-11T19:13:01Z","receivedAt":"2011-01-11T19:13:01Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Alexey Shumkin <zapped@mail.ru> writes:\n\n> Class declarations were already covered by the second pattern, but class methods have the 'class' keyword in front too. Account for it.\n\nToo long a line (which I could re-wrap locally but I'd rather not be in\nthe business of doing that for everybody).\n\n>  PATTERNS(\"pascal\",\n> -\t \"^((procedure|function|constructor|destructor|interface|\"\n> +\t \"^(((class[ \\t]+)?(procedure|function)|constructor|destructor|interface|\"\n>  \t\t\"implementation|initialization|finalization)[ \\t]*.*)$\"\n\nEarlier we took \"^procedure frotz\", \"^function frotz\", etc. and now we\nalso take \"^class procedure frotz\", \"^class function frotz\", but not\n\"^class constructor frotz\"---am I reading the patterns correctly?\n"},{"id":"159374","messageId":"1093185322.20110111225059@mail.ru","threadId":"26255","inReplyTo":"7vipxv45ky.fsf@alter.siamese.dyndns.org","subject":"Re[2]: [PATCH] userdiff: match Pascal class methods","fromName":"Алексей Шумкин","fromEmail":"zapped@mail.ru","sentAt":"2011-01-11T19:50:59Z","receivedAt":"2011-01-11T19:50:59Z","isPatch":true,"sender":{"key":"alex.crezoff@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1183752?v=4"},"body":"JCH> Alexey Shumkin <zapped@mail.ru> writes:\n\n>> Class declarations were already covered by the second pattern, but class methods have the 'class' keyword in front too. Account for it.\n\nJCH> Too long a line (which I could re-wrap locally but I'd rather not be in\nJCH> the business of doing that for everybody).\nOoh, I'm sorry\n\n>>  PATTERNS(\"pascal\",\n>> -      \"^((procedure|function|constructor|destructor|interface|\"\n>> +      \"^(((class[ \\t]+)?(procedure|function)|constructor|destructor|interface|\"\n>>               \"implementation|initialization|finalization)[ \\t]*.*)$\"\nJCH> Earlier we took \"^procedure frotz\", \"^function frotz\", etc. and now we\nJCH> also take \"^class procedure frotz\", \"^class function frotz\", but not\nJCH> \"^class constructor frotz\"---am I reading the patterns correctly?\nYes, you're reading correctly. 'class' keyword might precede only\n'procedure' or 'function' keyword but not the other ones\n"}]}