{"thread":{"id":"2623","subject":"git daemon broken?","startedAt":"2005-11-21T06:47:33Z","lastAt":"2005-11-21T07:30:12Z","messageCount":2,"participants":["YOSHIFUJI Hideaki / 吉藤英明","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"12415","messageId":"20051121.154733.64482215.yoshfuji@linux-ipv6.org","threadId":"2623","inReplyTo":null,"subject":"git daemon broken?","fromName":"YOSHIFUJI Hideaki / 吉藤英明","fromEmail":"yoshfuji@linux-ipv6.org","sentAt":"2005-11-21T06:47:33Z","receivedAt":"2005-11-21T06:47:33Z","isPatch":false,"sender":{"key":"yoshfuji@linux-ipv6.org","avatar":"https://gravatar.com/avatar/92c288bb8d3e34afd7bb1574cc1079a3d0aa6d36d80955d1ec6a1cea2868d392?d=mp&s=160"},"body":"Hello.\n\nIt seems that git-daemon is broken.\n\n(On server side)\n% git daemon --verbose\n(On client side)\n% git pull git://git.skbuff.net/gitroot/yoshfuji/x.git\n\nThen, we get on the server side,\n:\n[16660] Request for '/gitroot/yoshfuji/x.git'\nfatal: '.': unable to chdir or not a git archive\n[16660] Disconnected (with error)\n\nIt works if I remove \"--strict\" from daemon.c.\n\n% git daemon --verbose\n:\n[16723] Request for '/gitroot/yoshfuji/x.git'\nPacking 21 objects\n[16723] Disconnected\n\n-- \nYOSHIFUJI Hideaki @ USAGI Project  <yoshfuji@linux-ipv6.org>\nGPG-FP  : 9022 65EB 1ECF 3AD1 0BDF  80D8 4807 F894 E062 0EEA\n"},{"id":"12416","messageId":"7vpsouwj97.fsf@assigned-by-dhcp.cox.net","threadId":"2623","inReplyTo":"20051121.154733.64482215.yoshfuji@linux-ipv6.org","subject":"Re: git daemon broken?","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-11-21T07:30:12Z","receivedAt":"2005-11-21T07:30:12Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"I think this should fix it; the problem analysis I did in my\nprevious mail was half-baked, and the thing about '||' vs '&&'\nwas completely faulty.  Obviously I am not thinking straight\ntonight, so I'll go to bed.\n\n---\n\ndiff --git a/path.c b/path.c\nindex 84b3272..4d88947 100644\n--- a/path.c\n+++ b/path.c\n@@ -181,7 +181,7 @@ char *enter_repo(char *path, int strict)\n \t\treturn NULL;\n \n \tif (strict) {\n-\t\tif((path[0] != '/') || chdir(path) < 0)\n+\t\tif (chdir(path) < 0)\n \t\t\treturn NULL;\n \t}\n \telse {\n"}]}