{"thread":{"id":"26215","subject":"Repeatable test t9010-svn-fe.sh failure w/ master (685e9d9, 1.7.4.rc1)","startedAt":"2011-01-06T16:04:40Z","lastAt":"2011-01-07T18:54:18Z","messageCount":13,"participants":["A Large Angry SCM","Jonathan Nieder","Junio C Hamano","Ramkumar Ramachandra"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"159033","messageId":"4D25E818.5050909@gmail.com","threadId":"26215","inReplyTo":null,"subject":"Repeatable test t9010-svn-fe.sh failure w/ master (685e9d9, 1.7.4.rc1)","fromName":"A Large Angry SCM","fromEmail":"gitzilla@gmail.com","sentAt":"2011-01-06T16:04:40Z","receivedAt":"2011-01-06T16:04:40Z","isPatch":false,"sender":{"key":"gitzilla@gmail.com","avatar":"https://gravatar.com/avatar/354625c442439908ff3dd99757dee330e29e9df7847472384faf7a00add247fb?d=mp&s=160"},"body":"System:\n\tLinux debian 2.6.32-5-amd64 #1 SMP Fri Dec 10 15:35:08 UTC 2010 x86_64 \nGNU/Linux\n\tAll installed packages up-to-date as of 2011-01-06 15:55 UTC\n\nGit:\n\tLatest master (685e9d9)\n\t$ ./git --version\n\tgit version 1.7.4.rc1\n\nSvn:\n\tlibsvn-perl\t1.6.12dfsg-3\n\tlibsvn1\t\t1.6.12dfsg-3\n\tsubversion\t1.6.12dfsg-3\n\nInvocation:\n\t(make NO_OPENSSL=1 'gitexecdir=$(bindir)' all test strip)\n\n\n\n*** t9010-svn-fe.sh ***\nok 1 - empty dump\nok 2 - v3 dumps not supported\nnot ok - 3 t9135/svn.dump\n#\n#               svnadmin create simple-svn &&\n#               svnadmin load simple-svn \n<\"$TEST_DIRECTORY/t9135/svn.dump\" &&\n#               svn_cmd export \"file://$PWD/simple-svn\" simple-svnco &&\n#               git init simple-git &&\n#               test-svn-fe \"$TEST_DIRECTORY/t9135/svn.dump\" >simple.fe &&\n#               (\n#                       cd simple-git &&\n#                       git fast-import <../simple.fe\n#               ) &&\n#               (\n#                       cd simple-svnco &&\n#                       git init &&\n#                       git add . &&\n#                       git fetch ../simple-git master &&\n#                       git diff --exit-code FETCH_HEAD\n#               )\n#\n# failed 1 among 3 test(s)\n1..3\n"},{"id":"159037","messageId":"20110106165958.GA11190@burratino","threadId":"26215","inReplyTo":"4D25E818.5050909@gmail.com","subject":"Re: Repeatable test t9010-svn-fe.sh failure w/ master (685e9d9, 1.7.4.rc1)","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2011-01-06T16:59:58Z","receivedAt":"2011-01-06T16:59:58Z","isPatch":false,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"A Large Angry SCM wrote:\n\n> *** t9010-svn-fe.sh ***\n> ok 1 - empty dump\n> ok 2 - v3 dumps not supported\n> not ok - 3 t9135/svn.dump\n\nThanks for reporting.  Unfortunately I haven't been able to reproduce\nthis on the machines I have access to (amd64 with svn 1.5.0 and i386\nwith svn 1.6.15).\n\nDoes running\n\n\tsh t9010-svn-fe.sh -v\n\nfrom the t/ directory give an error message?  If not, how about\n\n\tGIT_TRACE=1 sh -x t9010-svn-fe.sh -v\n\n?\n"},{"id":"159041","messageId":"4D25F9C5.6030503@gmail.com","threadId":"26215","inReplyTo":"20110106165958.GA11190@burratino","subject":"Re: Repeatable test t9010-svn-fe.sh failure w/ master (685e9d9, 1.7.4.rc1)","fromName":"A Large Angry SCM","fromEmail":"gitzilla@gmail.com","sentAt":"2011-01-06T17:20:05Z","receivedAt":"2011-01-06T17:20:05Z","isPatch":false,"sender":{"key":"gitzilla@gmail.com","avatar":"https://gravatar.com/avatar/354625c442439908ff3dd99757dee330e29e9df7847472384faf7a00add247fb?d=mp&s=160"},"body":"On 01/06/2011 11:59 AM, Jonathan Nieder wrote:\n> A Large Angry SCM wrote:\n>\n>> *** t9010-svn-fe.sh ***\n>> ok 1 - empty dump\n>> ok 2 - v3 dumps not supported\n>> not ok - 3 t9135/svn.dump\n>\n> Thanks for reporting.  Unfortunately I haven't been able to reproduce\n> this on the machines I have access to (amd64 with svn 1.5.0 and i386\n> with svn 1.6.15).\n>\n> Does running\n>\n> \tsh t9010-svn-fe.sh -v\n>\n> from the t/ directory give an error message?  If not, how about\n>\n> \tGIT_TRACE=1 sh -x t9010-svn-fe.sh -v\n>\n> ?\n>\n\nSee the attached typescript files from the above runs.\n\n\nScript started on Thu 06 Jan 2011 12:11:03 PM EST\nXXXXXXXX@debian:~/GIT/git/t$ sh t9010-svn-fe.sh -v\nInitialized empty Git repository in /home/XXXXXXXX/GIT/git/t/trash directory.t9010-svn-fe/.git/\n\u001b[33mexpecting success: \n\treinit_git &&\n\techo \"SVN-fs-dump-format-version: 2\" >input &&\n\ttest-svn-fe input >stream &&\n\tgit fast-import <stream\n\u001b(B\u001b[m\nInitialized empty Git repository in /home/XXXXXXXX/GIT/git/t/trash directory.t9010-svn-fe/.git/\ngit-fast-import statistics:\n---------------------------------------------------------------------\nAlloc'd objects:       5000\nTotal objects:            0 (         0 duplicates                  )\n      blobs  :            0 (         0 duplicates          0 deltas)\n      trees  :            0 (         0 duplicates          0 deltas)\n      commits:            0 (         0 duplicates          0 deltas)\n      tags   :            0 (         0 duplicates          0 deltas)\nTotal branches:           0 (         0 loads     )\n      marks:           1024 (         0 unique    )\n      atoms:              0\nMemory total:          2282 KiB\n       pools:          2048 KiB\n     objects:           234 KiB\n---------------------------------------------------------------------\npack_report: getpagesize()            =       4096\npack_report: core.packedGitWindowSize = 1073741824\npack_report: core.packedGitLimit      = 8589934592\npack_report: pack_used_ctr            =          0\npack_report: pack_mmap_calls          =          0\npack_report: pack_open_windows        =          0 /          0\npack_report: pack_mapped              =          0 /          0\n---------------------------------------------------------------------\n\nok 1 - empty dump\u001b(B\u001b[m\n\n\u001b[33mexpecting success: \n\treinit_git &&\n\techo \"SVN-fs-dump-format-version: 3\" >input &&\n\ttest_must_fail test-svn-fe input >stream &&\n\ttest_cmp empty stream\n\u001b(B\u001b[m\nInitialized empty Git repository in /home/XXXXXXXX/GIT/git/t/trash directory.t9010-svn-fe/.git/\nfatal: expected svn dump format version <= 2, found 3\nok 2 - v3 dumps not supported\u001b(B\u001b[m\n\n\u001b[33mexpecting success: \n\tsvnadmin create simple-svn &&\n\tsvnadmin load simple-svn <\"$TEST_DIRECTORY/t9135/svn.dump\" &&\n\tsvn_cmd export \"file://$PWD/simple-svn\" simple-svnco &&\n\tgit init simple-git &&\n\ttest-svn-fe \"$TEST_DIRECTORY/t9135/svn.dump\" >simple.fe &&\n\t(\n\t\tcd simple-git &&\n\t\tgit fast-import <../simple.fe\n\t) &&\n\t(\n\t\tcd simple-svnco &&\n\t\tgit init &&\n\t\tgit add . &&\n\t\tgit fetch ../simple-git master &&\n\t\tgit diff --exit-code FETCH_HEAD\n\t)\n\u001b(B\u001b[m\n<<< Started new transaction, based on original revision 1\n     * adding path : branches ... done.\n     * adding path : trunk ... done.\nsvnadmin: Couldn't perform atomic initialization\nsvnadmin: Couldn't perform atomic initialization\nsvnadmin: SQLite compiled for 3.7.4, but running with 3.7.3\n\u001b[1m\u001b[31mnot ok - 3 t9135/svn.dump\u001b(B\u001b[m\n#\t\n#\t\tsvnadmin create simple-svn &&\n#\t\tsvnadmin load simple-svn <\"$TEST_DIRECTORY/t9135/svn.dump\" &&\n#\t\tsvn_cmd export \"file://$PWD/simple-svn\" simple-svnco &&\n#\t\tgit init simple-git &&\n#\t\ttest-svn-fe \"$TEST_DIRECTORY/t9135/svn.dump\" >simple.fe &&\n#\t\t(\n#\t\t\tcd simple-git &&\n#\t\t\tgit fast-import <../simple.fe\n#\t\t) &&\n#\t\t(\n#\t\t\tcd simple-svnco &&\n#\t\t\tgit init &&\n#\t\t\tgit add . &&\n#\t\t\tgit fetch ../simple-git master &&\n#\t\t\tgit diff --exit-code FETCH_HEAD\n#\t\t)\n#\t\n\n\u001b[1m\u001b[31m# failed 1 among 3 test(s)\u001b(B\u001b[m\n\u001b[33m1..3\u001b(B\u001b[m\nXXXXXXXX@debian:~/GIT/git/t$ exit\n\nScript done on Thu 06 Jan 2011 12:11:16 PM EST\n\n\nScript started on Thu 06 Jan 2011 12:11:40 PM EST\nXXXXXXXX@debian:~/GIT/git/t$ GIT_TRACE=1 sh -x t9010-svn-fe.sh -v\n+ test_description=check svn dumpfile importer\n+ . ./test-lib.sh\n+ ORIGINAL_TERM=xterm\n+ LANG=C\n+ LC_ALL=C\n+ PAGER=cat\n+ TZ=UTC\n+ TERM=dumb\n+ export LANG LC_ALL PAGER TERM TZ\n+ EDITOR=:\n+ unset VISUAL\n+ unset GIT_EDITOR\n+ unset AUTHOR_DATE\n+ unset AUTHOR_EMAIL\n+ unset AUTHOR_NAME\n+ unset COMMIT_AUTHOR_EMAIL\n+ unset COMMIT_AUTHOR_NAME\n+ unset EMAIL\n+ unset GIT_ALTERNATE_OBJECT_DIRECTORIES\n+ unset GIT_AUTHOR_DATE\n+ GIT_AUTHOR_EMAIL=author@example.com\n+ GIT_AUTHOR_NAME=A U Thor\n+ unset GIT_COMMITTER_DATE\n+ GIT_COMMITTER_EMAIL=committer@example.com\n+ GIT_COMMITTER_NAME=C O Mitter\n+ unset GIT_DIFF_OPTS\n+ unset GIT_DIR\n+ unset GIT_WORK_TREE\n+ unset GIT_EXTERNAL_DIFF\n+ unset GIT_INDEX_FILE\n+ unset GIT_OBJECT_DIRECTORY\n+ unset GIT_CEILING_DIRECTORIES\n+ unset SHA1_FILE_DIRECTORIES\n+ unset SHA1_FILE_DIRECTORY\n+ unset GIT_NOTES_REF\n+ unset GIT_NOTES_DISPLAY_REF\n+ unset GIT_NOTES_REWRITE_REF\n+ unset GIT_NOTES_REWRITE_MODE\n+ GIT_MERGE_VERBOSITY=5\n+ export GIT_MERGE_VERBOSITY\n+ export GIT_AUTHOR_EMAIL GIT_AUTHOR_NAME\n+ export GIT_COMMITTER_EMAIL GIT_COMMITTER_NAME\n+ export EDITOR\n+ unset CDPATH\n+ unset GREP_OPTIONS\n+ echo 1\n+ tr [A-Z] [a-z]\n+ echo * warning: Some tests will not work if GIT_TRACE is set as to trace on STDERR ! *\n* warning: Some tests will not work if GIT_TRACE is set as to trace on STDERR ! *\n+ echo * warning: Please set GIT_TRACE to something other than 1, 2 or true ! *\n* warning: Please set GIT_TRACE to something other than 1, 2 or true ! *\n+ _x05=[0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f]\n+ _x40=[0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f]\n+ [ xxterm != xdumb ]\n+ TERM=xterm\n+ export TERM\n+ [ -t 1 ]\n+ tput bold\n+ tput setaf 1\n+ tput sgr0\n+ color=t\n+ test 1 -ne 0\n+ verbose=t\n+ shift\n+ test 0 -ne 0\n+ test -n t\n+ test check svn dumpfile importer != \n+ test  = t\n+ exec\n+ test t = t\n+ exec\n+ test_failure=0\n+ test_count=0\n+ test_fixed=0\n+ test_broken=0\n+ test_success=0\n+ test_external_has_tap=0\n+ GIT_EXIT_OK=\n+ trap die EXIT\n+ satisfied= \n+ test -z \n+ pwd\n+ TEST_DIRECTORY=/home/XXXXXXXX/GIT/git/t\n+ GIT_BUILD_DIR=/home/XXXXXXXX/GIT/git/t/..\n+ test -n \n+ test -n \n+ git_bin_dir=/home/XXXXXXXX/GIT/git/t/../bin-wrappers\n+ test -x /home/XXXXXXXX/GIT/git/t/../bin-wrappers/git\n+ PATH=/home/XXXXXXXX/GIT/git/t/../bin-wrappers:/home/XXXXXXXX/bin:/usr/local/bin:/usr/bin:/bin:/usr/games\n+ GIT_EXEC_PATH=/home/XXXXXXXX/GIT/git/t/..\n+ test -n \n+ GIT_TEMPLATE_DIR=/home/XXXXXXXX/GIT/git/t/../templates/blt\n+ unset GIT_CONFIG\n+ GIT_CONFIG_NOSYSTEM=1\n+ GIT_CONFIG_NOGLOBAL=1\n+ export PATH GIT_EXEC_PATH GIT_TEMPLATE_DIR GIT_CONFIG_NOSYSTEM GIT_CONFIG_NOGLOBAL\n+ . /home/XXXXXXXX/GIT/git/t/../GIT-BUILD-OPTIONS\n+ SHELL_PATH=/bin/sh\n+ PERL_PATH=/usr/bin/perl\n+ DIFF=diff\n+ PYTHON_PATH=/usr/bin/python\n+ TAR=tar\n+ NO_CURL=\n+ NO_PERL=\n+ NO_PYTHON=\n+ test -z \n+ test -n \n+ GIT_TEST_CMP=diff -u\n+ GITPERLLIB=/home/XXXXXXXX/GIT/git/t/../perl/blib/lib:/home/XXXXXXXX/GIT/git/t/../perl/blib/arch/auto/Git\n+ export GITPERLLIB\n+ test -d /home/XXXXXXXX/GIT/git/t/../templates/blt\n+ test -z \n+ test -z \n+ GITPYTHONLIB=/home/XXXXXXXX/GIT/git/t/../git_remote_helpers/build/lib\n+ export GITPYTHONLIB\n+ test -d /home/XXXXXXXX/GIT/git/t/../git_remote_helpers/build\n+ test -x /home/XXXXXXXX/GIT/git/t/../test-chmtime\n+ basename t9010-svn-fe.sh .sh\n+ test=trash directory.t9010-svn-fe\n+ test -n \n+ TRASH_DIRECTORY=/home/XXXXXXXX/GIT/git/t/trash directory.t9010-svn-fe\n+ test ! -z \n+ remove_trash=/home/XXXXXXXX/GIT/git/t/trash directory.t9010-svn-fe\n+ rm -fr trash directory.t9010-svn-fe\n+ test_create_repo trash directory.t9010-svn-fe\n+ test 1 = 1\n+ repo=trash directory.t9010-svn-fe\n+ mkdir -p trash directory.t9010-svn-fe\n+ cd trash directory.t9010-svn-fe\n+ /home/XXXXXXXX/GIT/git/t/../git-init --template=/home/XXXXXXXX/GIT/git/t/../templates/blt/\ntrace: built-in: git 'init' '--template=/home/XXXXXXXX/GIT/git/t/../templates/blt/'\nInitialized empty Git repository in /home/XXXXXXXX/GIT/git/t/trash directory.t9010-svn-fe/.git/\n+ mv .git/hooks .git/hooks-disabled\n+ cd -P trash directory.t9010-svn-fe\n+ pwd\n+ HOME=/home/XXXXXXXX/GIT/git/t/trash directory.t9010-svn-fe\n+ export HOME\n+ this_test=t9010-svn-fe.sh\n+ this_test=t9010\n+ uname -s\n+ test_set_prereq POSIXPERM\n+ satisfied= POSIXPERM \n+ test_set_prereq BSLASHPSPEC\n+ satisfied= POSIXPERM BSLASHPSPEC \n+ test_set_prereq EXECKEEPSPID\n+ satisfied= POSIXPERM BSLASHPSPEC EXECKEEPSPID \n+ test_set_prereq NOT_MINGW\n+ satisfied= POSIXPERM BSLASHPSPEC EXECKEEPSPID NOT_MINGW \n+ test -z \n+ test_set_prereq PERL\n+ satisfied= POSIXPERM BSLASHPSPEC EXECKEEPSPID NOT_MINGW PERL \n+ test -z \n+ test_set_prereq PYTHON\n+ satisfied= POSIXPERM BSLASHPSPEC EXECKEEPSPID NOT_MINGW PERL PYTHON \n+ ln -s x y\n+ test -h y\n+ test_set_prereq SYMLINKS\n+ satisfied= POSIXPERM BSLASHPSPEC EXECKEEPSPID NOT_MINGW PERL PYTHON SYMLINKS \n+ rm -f y\n+ test -w /\n+ test_set_prereq SANITY\n+ satisfied= POSIXPERM BSLASHPSPEC EXECKEEPSPID NOT_MINGW PERL PYTHON SYMLINKS SANITY \n+ svnadmin -h\n+ svnconf=/home/XXXXXXXX/GIT/git/t/trash directory.t9010-svn-fe/svnconf\n+ export svnconf\n+ \n+ test_expect_success empty dump \n\treinit_git &&\n\techo \"SVN-fs-dump-format-version: 2\" >input &&\n\ttest-svn-fe input >stream &&\n\tgit fast-import <stream\n\n+ test 2 = 3\n+ test_prereq=\n+ test 2 = 2\n+ export test_prereq\n+ test_skip empty dump \n\treinit_git &&\n\techo \"SVN-fs-dump-format-version: 2\" >input &&\n\ttest-svn-fe input >stream &&\n\tgit fast-import <stream\n\n+ test_count=1\n+ to_skip=\n+ test -z \n+ test -n \n+ false\n+ say expecting success: \n\treinit_git &&\n\techo \"SVN-fs-dump-format-version: 2\" >input &&\n\ttest-svn-fe input >stream &&\n\tgit fast-import <stream\n\n+ say_color info expecting success: \n\treinit_git &&\n\techo \"SVN-fs-dump-format-version: 2\" >input &&\n\ttest-svn-fe input >stream &&\n\tgit fast-import <stream\n\n+ TERM=xterm\n+ export TERM\n+ tput setaf 3\n\u001b[33m+ shift\n+ printf %s expecting success: \n\treinit_git &&\n\techo \"SVN-fs-dump-format-version: 2\" >input &&\n\ttest-svn-fe input >stream &&\n\tgit fast-import <stream\n\nexpecting success: \n\treinit_git &&\n\techo \"SVN-fs-dump-format-version: 2\" >input &&\n\ttest-svn-fe input >stream &&\n\tgit fast-import <stream\n+ tput sgr0\n\u001b(B\u001b[m+ echo\n\n+ test_run_ \n\treinit_git &&\n\techo \"SVN-fs-dump-format-version: 2\" >input &&\n\ttest-svn-fe input >stream &&\n\tgit fast-import <stream\n\n+ test_cleanup=:\n+ eval \n\treinit_git &&\n\techo \"SVN-fs-dump-format-version: 2\" >input &&\n\ttest-svn-fe input >stream &&\n\tgit fast-import <stream\n\n+ reinit_git\n+ rm -fr .git\n+ git init\ntrace: built-in: git 'init'\nInitialized empty Git repository in /home/XXXXXXXX/GIT/git/t/trash directory.t9010-svn-fe/.git/\n+ echo SVN-fs-dump-format-version: 2\n+ test-svn-fe input\n+ git fast-import\ntrace: exec: 'git-fast-import'\ntrace: run_command: 'git-fast-import'\ngit-fast-import statistics:\n---------------------------------------------------------------------\nAlloc'd objects:       5000\nTotal objects:            0 (         0 duplicates                  )\n      blobs  :            0 (         0 duplicates          0 deltas)\n      trees  :            0 (         0 duplicates          0 deltas)\n      commits:            0 (         0 duplicates          0 deltas)\n      tags   :            0 (         0 duplicates          0 deltas)\nTotal branches:           0 (         0 loads     )\n      marks:           1024 (         0 unique    )\n      atoms:              0\nMemory total:          2282 KiB\n       pools:          2048 KiB\n     objects:           234 KiB\n---------------------------------------------------------------------\npack_report: getpagesize()            =       4096\npack_report: core.packedGitWindowSize = 1073741824\npack_report: core.packedGitLimit      = 8589934592\npack_report: pack_used_ctr            =          0\npack_report: pack_mmap_calls          =          0\npack_report: pack_open_windows        =          0 /          0\npack_report: pack_mapped              =          0 /          0\n---------------------------------------------------------------------\n\n+ eval_ret=0\n+ eval :\n+ :\n+ test t = t\n+ test -n \n+ return 0\n+ [ 0 = 0 -a 0 = 0 ]\n+ test_ok_ empty dump\n+ test_success=1\n+ say_color  ok 1 - empty dump\n+ TERM=xterm\n+ export TERM\n+ test -n \n+ shift\n+ printf %s ok 1 - empty dump\nok 1 - empty dump+ tput sgr0\n\u001b(B\u001b[m+ echo\n\n+ echo \n\n+ test_expect_success v3 dumps not supported \n\treinit_git &&\n\techo \"SVN-fs-dump-format-version: 3\" >input &&\n\ttest_must_fail test-svn-fe input >stream &&\n\ttest_cmp empty stream\n\n+ test 2 = 3\n+ test_prereq=\n+ test 2 = 2\n+ export test_prereq\n+ test_skip v3 dumps not supported \n\treinit_git &&\n\techo \"SVN-fs-dump-format-version: 3\" >input &&\n\ttest_must_fail test-svn-fe input >stream &&\n\ttest_cmp empty stream\n\n+ test_count=2\n+ to_skip=\n+ test -z \n+ test -n \n+ false\n+ say expecting success: \n\treinit_git &&\n\techo \"SVN-fs-dump-format-version: 3\" >input &&\n\ttest_must_fail test-svn-fe input >stream &&\n\ttest_cmp empty stream\n\n+ say_color info expecting success: \n\treinit_git &&\n\techo \"SVN-fs-dump-format-version: 3\" >input &&\n\ttest_must_fail test-svn-fe input >stream &&\n\ttest_cmp empty stream\n\n+ TERM=xterm\n+ export TERM\n+ tput setaf 3\n\u001b[33m+ shift\n+ printf %s expecting success: \n\treinit_git &&\n\techo \"SVN-fs-dump-format-version: 3\" >input &&\n\ttest_must_fail test-svn-fe input >stream &&\n\ttest_cmp empty stream\n\nexpecting success: \n\treinit_git &&\n\techo \"SVN-fs-dump-format-version: 3\" >input &&\n\ttest_must_fail test-svn-fe input >stream &&\n\ttest_cmp empty stream\n+ tput sgr0\n\u001b(B\u001b[m+ echo\n\n+ test_run_ \n\treinit_git &&\n\techo \"SVN-fs-dump-format-version: 3\" >input &&\n\ttest_must_fail test-svn-fe input >stream &&\n\ttest_cmp empty stream\n\n+ test_cleanup=:\n+ eval \n\treinit_git &&\n\techo \"SVN-fs-dump-format-version: 3\" >input &&\n\ttest_must_fail test-svn-fe input >stream &&\n\ttest_cmp empty stream\n\n+ reinit_git\n+ rm -fr .git\n+ git init\ntrace: built-in: git 'init'\nInitialized empty Git repository in /home/XXXXXXXX/GIT/git/t/trash directory.t9010-svn-fe/.git/\n+ echo SVN-fs-dump-format-version: 3\n+ test_must_fail test-svn-fe input\n+ test-svn-fe input\nfatal: expected svn dump format version <= 2, found 3\n+ exit_code=128\n+ test 128 = 0\n+ test 128 -gt 129 -a 128 -le 192\n+ test 128 = 127\n+ return 0\n+ test_cmp empty stream\n+ diff -u empty stream\n+ eval_ret=0\n+ eval :\n+ :\n+ test t = t\n+ test -n \n+ return 0\n+ [ 0 = 0 -a 0 = 0 ]\n+ test_ok_ v3 dumps not supported\n+ test_success=2\n+ say_color  ok 2 - v3 dumps not supported\n+ TERM=xterm\n+ export TERM\n+ test -n \n+ shift\n+ printf %s ok 2 - v3 dumps not supported\nok 2 - v3 dumps not supported+ tput sgr0\n\u001b(B\u001b[m+ echo\n\n+ echo \n\n+ test_expect_success t9135/svn.dump \n\tsvnadmin create simple-svn &&\n\tsvnadmin load simple-svn <\"$TEST_DIRECTORY/t9135/svn.dump\" &&\n\tsvn_cmd export \"file://$PWD/simple-svn\" simple-svnco &&\n\tgit init simple-git &&\n\ttest-svn-fe \"$TEST_DIRECTORY/t9135/svn.dump\" >simple.fe &&\n\t(\n\t\tcd simple-git &&\n\t\tgit fast-import <../simple.fe\n\t) &&\n\t(\n\t\tcd simple-svnco &&\n\t\tgit init &&\n\t\tgit add . &&\n\t\tgit fetch ../simple-git master &&\n\t\tgit diff --exit-code FETCH_HEAD\n\t)\n\n+ test 2 = 3\n+ test_prereq=\n+ test 2 = 2\n+ export test_prereq\n+ test_skip t9135/svn.dump \n\tsvnadmin create simple-svn &&\n\tsvnadmin load simple-svn <\"$TEST_DIRECTORY/t9135/svn.dump\" &&\n\tsvn_cmd export \"file://$PWD/simple-svn\" simple-svnco &&\n\tgit init simple-git &&\n\ttest-svn-fe \"$TEST_DIRECTORY/t9135/svn.dump\" >simple.fe &&\n\t(\n\t\tcd simple-git &&\n\t\tgit fast-import <../simple.fe\n\t) &&\n\t(\n\t\tcd simple-svnco &&\n\t\tgit init &&\n\t\tgit add . &&\n\t\tgit fetch ../simple-git master &&\n\t\tgit diff --exit-code FETCH_HEAD\n\t)\n\n+ test_count=3\n+ to_skip=\n+ test -z \n+ test -n \n+ false\n+ say expecting success: \n\tsvnadmin create simple-svn &&\n\tsvnadmin load simple-svn <\"$TEST_DIRECTORY/t9135/svn.dump\" &&\n\tsvn_cmd export \"file://$PWD/simple-svn\" simple-svnco &&\n\tgit init simple-git &&\n\ttest-svn-fe \"$TEST_DIRECTORY/t9135/svn.dump\" >simple.fe &&\n\t(\n\t\tcd simple-git &&\n\t\tgit fast-import <../simple.fe\n\t) &&\n\t(\n\t\tcd simple-svnco &&\n\t\tgit init &&\n\t\tgit add . &&\n\t\tgit fetch ../simple-git master &&\n\t\tgit diff --exit-code FETCH_HEAD\n\t)\n\n+ say_color info expecting success: \n\tsvnadmin create simple-svn &&\n\tsvnadmin load simple-svn <\"$TEST_DIRECTORY/t9135/svn.dump\" &&\n\tsvn_cmd export \"file://$PWD/simple-svn\" simple-svnco &&\n\tgit init simple-git &&\n\ttest-svn-fe \"$TEST_DIRECTORY/t9135/svn.dump\" >simple.fe &&\n\t(\n\t\tcd simple-git &&\n\t\tgit fast-import <../simple.fe\n\t) &&\n\t(\n\t\tcd simple-svnco &&\n\t\tgit init &&\n\t\tgit add . &&\n\t\tgit fetch ../simple-git master &&\n\t\tgit diff --exit-code FETCH_HEAD\n\t)\n\n+ TERM=xterm\n+ export TERM\n+ tput setaf 3\n\u001b[33m+ shift\n+ printf %s expecting success: \n\tsvnadmin create simple-svn &&\n\tsvnadmin load simple-svn <\"$TEST_DIRECTORY/t9135/svn.dump\" &&\n\tsvn_cmd export \"file://$PWD/simple-svn\" simple-svnco &&\n\tgit init simple-git &&\n\ttest-svn-fe \"$TEST_DIRECTORY/t9135/svn.dump\" >simple.fe &&\n\t(\n\t\tcd simple-git &&\n\t\tgit fast-import <../simple.fe\n\t) &&\n\t(\n\t\tcd simple-svnco &&\n\t\tgit init &&\n\t\tgit add . &&\n\t\tgit fetch ../simple-git master &&\n\t\tgit diff --exit-code FETCH_HEAD\n\t)\n\nexpecting success: \n\tsvnadmin create simple-svn &&\n\tsvnadmin load simple-svn <\"$TEST_DIRECTORY/t9135/svn.dump\" &&\n\tsvn_cmd export \"file://$PWD/simple-svn\" simple-svnco &&\n\tgit init simple-git &&\n\ttest-svn-fe \"$TEST_DIRECTORY/t9135/svn.dump\" >simple.fe &&\n\t(\n\t\tcd simple-git &&\n\t\tgit fast-import <../simple.fe\n\t) &&\n\t(\n\t\tcd simple-svnco &&\n\t\tgit init &&\n\t\tgit add . &&\n\t\tgit fetch ../simple-git master &&\n\t\tgit diff --exit-code FETCH_HEAD\n\t)\n+ tput sgr0\n\u001b(B\u001b[m+ echo\n\n+ test_run_ \n\tsvnadmin create simple-svn &&\n\tsvnadmin load simple-svn <\"$TEST_DIRECTORY/t9135/svn.dump\" &&\n\tsvn_cmd export \"file://$PWD/simple-svn\" simple-svnco &&\n\tgit init simple-git &&\n\ttest-svn-fe \"$TEST_DIRECTORY/t9135/svn.dump\" >simple.fe &&\n\t(\n\t\tcd simple-git &&\n\t\tgit fast-import <../simple.fe\n\t) &&\n\t(\n\t\tcd simple-svnco &&\n\t\tgit init &&\n\t\tgit add . &&\n\t\tgit fetch ../simple-git master &&\n\t\tgit diff --exit-code FETCH_HEAD\n\t)\n\n+ test_cleanup=:\n+ eval \n\tsvnadmin create simple-svn &&\n\tsvnadmin load simple-svn <\"$TEST_DIRECTORY/t9135/svn.dump\" &&\n\tsvn_cmd export \"file://$PWD/simple-svn\" simple-svnco &&\n\tgit init simple-git &&\n\ttest-svn-fe \"$TEST_DIRECTORY/t9135/svn.dump\" >simple.fe &&\n\t(\n\t\tcd simple-git &&\n\t\tgit fast-import <../simple.fe\n\t) &&\n\t(\n\t\tcd simple-svnco &&\n\t\tgit init &&\n\t\tgit add . &&\n\t\tgit fetch ../simple-git master &&\n\t\tgit diff --exit-code FETCH_HEAD\n\t)\n\n+ svnadmin create simple-svn\n+ svnadmin load simple-svn\n<<< Started new transaction, based on original revision 1\n     * adding path : branches ... done.\n     * adding path : trunk ... done.\nsvnadmin: Couldn't perform atomic initialization\nsvnadmin: Couldn't perform atomic initialization\nsvnadmin: SQLite compiled for 3.7.4, but running with 3.7.3\n+ eval_ret=1\n+ eval :\n+ :\n+ test t = t\n+ test -n \n+ return 0\n+ [ 0 = 0 -a 1 = 0 ]\n+ test_failure_ t9135/svn.dump \n\tsvnadmin create simple-svn &&\n\tsvnadmin load simple-svn <\"$TEST_DIRECTORY/t9135/svn.dump\" &&\n\tsvn_cmd export \"file://$PWD/simple-svn\" simple-svnco &&\n\tgit init simple-git &&\n\ttest-svn-fe \"$TEST_DIRECTORY/t9135/svn.dump\" >simple.fe &&\n\t(\n\t\tcd simple-git &&\n\t\tgit fast-import <../simple.fe\n\t) &&\n\t(\n\t\tcd simple-svnco &&\n\t\tgit init &&\n\t\tgit add . &&\n\t\tgit fetch ../simple-git master &&\n\t\tgit diff --exit-code FETCH_HEAD\n\t)\n\n+ test_failure=1\n+ say_color error not ok - 3 t9135/svn.dump\n+ TERM=xterm\n+ export TERM\n+ tput bold\n\u001b[1m+ tput setaf 1\n\u001b[31m+ shift\n+ printf %s not ok - 3 t9135/svn.dump\nnot ok - 3 t9135/svn.dump+ tput sgr0\n\u001b(B\u001b[m+ echo\n\n+ shift\n+ echo \n\tsvnadmin create simple-svn &&\n\tsvnadmin load simple-svn <\"$TEST_DIRECTORY/t9135/svn.dump\" &&\n\tsvn_cmd export \"file://$PWD/simple-svn\" simple-svnco &&\n\tgit init simple-git &&\n\ttest-svn-fe \"$TEST_DIRECTORY/t9135/svn.dump\" >simple.fe &&\n\t(\n\t\tcd simple-git &&\n\t\tgit fast-import <../simple.fe\n\t) &&\n\t(\n\t\tcd simple-svnco &&\n\t\tgit init &&\n\t\tgit add . &&\n\t\tgit fetch ../simple-git master &&\n\t\tgit diff --exit-code FETCH_HEAD\n\t)\n\n+ sed -e s/^/#\t/\n#\t\n#\t\tsvnadmin create simple-svn &&\n#\t\tsvnadmin load simple-svn <\"$TEST_DIRECTORY/t9135/svn.dump\" &&\n#\t\tsvn_cmd export \"file://$PWD/simple-svn\" simple-svnco &&\n#\t\tgit init simple-git &&\n#\t\ttest-svn-fe \"$TEST_DIRECTORY/t9135/svn.dump\" >simple.fe &&\n#\t\t(\n#\t\t\tcd simple-git &&\n#\t\t\tgit fast-import <../simple.fe\n#\t\t) &&\n#\t\t(\n#\t\t\tcd simple-svnco &&\n#\t\t\tgit init &&\n#\t\t\tgit add . &&\n#\t\t\tgit fetch ../simple-git master &&\n#\t\t\tgit diff --exit-code FETCH_HEAD\n#\t\t)\n#\t\n+ test  = \n+ echo \n\n+ test_done\n+ GIT_EXIT_OK=t\n+ test -z \n+ test_results_dir=/home/XXXXXXXX/GIT/git/t/test-results\n+ mkdir -p /home/XXXXXXXX/GIT/git/t/test-results\n+ test_results_path=/home/XXXXXXXX/GIT/git/t/test-results/t9010-svn-fe-14042.counts\n+ echo total 3\n+ echo success 2\n+ echo fixed 0\n+ echo broken 0\n+ echo failed 1\n+ echo \n+ test 0 != 0\n+ test 0 != 0\n+ msg=3 test(s)\n+ test 0 -eq 0\n+ say_color error # failed 1 among 3 test(s)\n+ TERM=xterm\n+ export TERM\n+ tput bold\n\u001b[1m+ tput setaf 1\n\u001b[31m+ shift\n+ printf %s # failed 1 among 3 test(s)\n# failed 1 among 3 test(s)+ tput sgr0\n\u001b(B\u001b[m+ echo\n\n+ say 1..3\n+ say_color info 1..3\n+ TERM=xterm\n+ export TERM\n+ tput setaf 3\n\u001b[33m+ shift\n+ printf %s 1..3\n1..3+ tput sgr0\n\u001b(B\u001b[m+ echo\n\n+ exit 1\n+ die\n+ code=1\n+ test -n t\n+ exit 1\nXXXXXXXX@debian:~/GIT/git/t$ exit\n\nScript done on Thu 06 Jan 2011 12:12:07 PM EST\n"},{"id":"159046","messageId":"20110106180051.GC11346@burratino","threadId":"26215","inReplyTo":"4D25F9C5.6030503@gmail.com","subject":"[PATCH] t9010: svnadmin can fail even if available","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2011-01-06T18:00:51Z","receivedAt":"2011-01-06T18:00:51Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"If svn is built against one version of SQLite and run against\nanother, svnadmin (needlessly) errors out during t9010:\n\n <<< Started new transaction, based on original revision 1\n      * adding path : branches ... done.\n      * adding path : trunk ... done.\n svnadmin: Couldn't perform atomic initialization\n svnadmin: Couldn't perform atomic initialization\n svnadmin: SQLite compiled for 3.7.4, but running with 3.7.3\n\nWork around this by putting the svn invocations into a single test\nthat builds a repo to compare the test-svn-fe result against.  This\ntest would always pass but only set the new SVNREPO test prereq if svn\nsucceeds; and the test using that repo gets an SVNREPO prerequisite so\nit only runs with working svn installations.\n\nThis seems like the right thing to, anyway: the test script is meant\nto test the version of git just built, not the installed svn.\n\nAs a side effect, earlier tests will run now even if svn is not\ninstalled.  Remove the svn_cmd () helper to decrease the temptation to\nrun svn from those tests.\n\nWorks-around: http://bugs.debian.org/608925\nReported-by: A Large Angry SCM <gitzilla@gmail.com>\nSigned-off-by: Jonathan Nieder <jrnieder@gmail.com>\n---\nThanks.  Does this patch work for you?\n\n t/t9010-svn-fe.sh |   35 +++++++++++++++--------------------\n 1 files changed, 15 insertions(+), 20 deletions(-)\n\ndiff --git a/t/t9010-svn-fe.sh b/t/t9010-svn-fe.sh\nindex c96bf2f..88a9751 100755\n--- a/t/t9010-svn-fe.sh\n+++ b/t/t9010-svn-fe.sh\n@@ -4,22 +4,6 @@ test_description='check svn dumpfile importer'\n \n . ./test-lib.sh\n \n-if ! svnadmin -h >/dev/null 2>&1\n-then\n-\tskip_all='skipping svn-fe tests, svn not available'\n-\ttest_done\n-fi\n-\n-svnconf=$PWD/svnconf\n-export svnconf\n-\n-svn_cmd () {\n-\tsubcommand=$1 &&\n-\tshift &&\n-\tmkdir -p \"$svnconf\" &&\n-\tsvn \"$subcommand\" --config-dir \"$svnconf\" \"$@\"\n-}\n-\n reinit_git () {\n \trm -fr .git &&\n \tgit init\n@@ -41,10 +25,21 @@ test_expect_success 'v3 dumps not supported' '\n \ttest_cmp empty stream\n '\n \n-test_expect_success 't9135/svn.dump' '\n-\tsvnadmin create simple-svn &&\n-\tsvnadmin load simple-svn <\"$TEST_DIRECTORY/t9135/svn.dump\" &&\n-\tsvn_cmd export \"file://$PWD/simple-svn\" simple-svnco &&\n+test_expect_success 'set up svn repo' '\n+\tsvnconf=$PWD/svnconf &&\n+\tmkdir -p \"$svnconf\" &&\n+\n+\tif\n+\t\tsvnadmin -h >/dev/null 2>&1 &&\n+\t\tsvnadmin create simple-svn &&\n+\t\tsvnadmin load simple-svn <\"$TEST_DIRECTORY/t9135/svn.dump\" &&\n+\t\tsvn export --config-dir \"$svnconf\" \"file://$PWD/simple-svn\" simple-svnco\n+\tthen\n+\t\ttest_set_prereq SVNREPO\n+\tfi\n+'\n+\n+test_expect_success SVNREPO 't9135/svn.dump' '\n \tgit init simple-git &&\n \ttest-svn-fe \"$TEST_DIRECTORY/t9135/svn.dump\" >simple.fe &&\n \t(\n-- \n1.7.4.rc1\n"},{"id":"159047","messageId":"7vipy1c313.fsf@alter.siamese.dyndns.org","threadId":"26215","inReplyTo":"4D25F9C5.6030503@gmail.com","subject":"Re: Repeatable test t9010-svn-fe.sh failure w/ master (685e9d9, 1.7.4.rc1)","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-01-06T18:15:04Z","receivedAt":"2011-01-06T18:15:04Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"A Large Angry SCM <gitzilla@gmail.com> writes:\n\n> + svnadmin load simple-svn\n> <<< Started new transaction, based on original revision 1\n>      * adding path : branches ... done.\n>      * adding path : trunk ... done.\n> svnadmin: Couldn't perform atomic initialization\n> svnadmin: Couldn't perform atomic initialization\n> svnadmin: SQLite compiled for 3.7.4, but running with 3.7.3\n> + eval_ret=1\n\nHmm.  Do any other svn related tests that use \"svnadmin load\" work in your\nenvironment?\n\n    $ cd t/\n    $ git grep -l 'svnadmin load'\n    t9010-svn-fe.sh\n    t9110-git-svn-use-svm-props.sh\n    t9111-git-svn-use-svnsync-props.sh\n    t9112-git-svn-md5less-file.sh\n    t9115-git-svn-dcommit-funky-renames.sh\n    t9121-git-svn-fetch-renamed-dir.sh\n    t9126-git-svn-follow-deleted-readded-directory.sh\n    t9131-git-svn-empty-symlink.sh\n    t9132-git-svn-broken-symlink.sh\n    t9135-git-svn-moved-branch-empty-file.sh\n    t9136-git-svn-recreated-branch-empty-file.sh\n    t9150-svk-mergetickets.sh\n    t9151-svn-mergeinfo.sh\n    t9153-git-svn-rewrite-uuid.sh\n    t9154-git-svn-fancy-glob.sh\n\nWeb searching for \"svnadmin: SQLite compiled for\" seems to give a handful\nof hits, even though I don't see anything from Debian offhand.\n"},{"id":"159049","messageId":"4D260AB9.2060406@gmail.com","threadId":"26215","inReplyTo":"20110106180051.GC11346@burratino","subject":"Re: [PATCH] t9010: svnadmin can fail even if available","fromName":"A Large Angry SCM","fromEmail":"gitzilla@gmail.com","sentAt":"2011-01-06T18:32:25Z","receivedAt":"2011-01-06T18:32:25Z","isPatch":true,"sender":{"key":"gitzilla@gmail.com","avatar":"https://gravatar.com/avatar/354625c442439908ff3dd99757dee330e29e9df7847472384faf7a00add247fb?d=mp&s=160"},"body":"On 01/06/2011 01:00 PM, Jonathan Nieder wrote:\n> If svn is built against one version of SQLite and run against\n> another, svnadmin (needlessly) errors out during t9010:\n>\n>   <<<  Started new transaction, based on original revision 1\n>        * adding path : branches ... done.\n>        * adding path : trunk ... done.\n>   svnadmin: Couldn't perform atomic initialization\n>   svnadmin: Couldn't perform atomic initialization\n>   svnadmin: SQLite compiled for 3.7.4, but running with 3.7.3\n>\n> Work around this by putting the svn invocations into a single test\n> that builds a repo to compare the test-svn-fe result against.  This\n> test would always pass but only set the new SVNREPO test prereq if svn\n> succeeds; and the test using that repo gets an SVNREPO prerequisite so\n> it only runs with working svn installations.\n>\n> This seems like the right thing to, anyway: the test script is meant\n> to test the version of git just built, not the installed svn.\n>\n> As a side effect, earlier tests will run now even if svn is not\n> installed.  Remove the svn_cmd () helper to decrease the temptation to\n> run svn from those tests.\n>\n> Works-around: http://bugs.debian.org/608925\n> Reported-by: A Large Angry SCM<gitzilla@gmail.com>\n> Signed-off-by: Jonathan Nieder<jrnieder@gmail.com>\n> ---\n> Thanks.  Does this patch work for you?\n\n$ sh t9010-svn-fe.sh\nok 1 - empty dump\nok 2 - v3 dumps not supported\nok 3 - set up svn repo\nok 4 # skip t9135/svn.dump (missing SVNREPO)\n# passed all 4 test(s)\n1..4\n\nRerunning the full test suite now ...\n"},{"id":"159051","messageId":"4D2612C0.6000309@gmail.com","threadId":"26215","inReplyTo":"7vipy1c313.fsf@alter.siamese.dyndns.org","subject":"Re: Repeatable test t9010-svn-fe.sh failure w/ master (685e9d9, 1.7.4.rc1)","fromName":"A Large Angry SCM","fromEmail":"gitzilla@gmail.com","sentAt":"2011-01-06T19:06:40Z","receivedAt":"2011-01-06T19:06:40Z","isPatch":false,"sender":{"key":"gitzilla@gmail.com","avatar":"https://gravatar.com/avatar/354625c442439908ff3dd99757dee330e29e9df7847472384faf7a00add247fb?d=mp&s=160"},"body":"On 01/06/2011 01:15 PM, Junio C Hamano wrote:\n> A Large Angry SCM<gitzilla@gmail.com>  writes:\n>\n>> + svnadmin load simple-svn\n>> <<<  Started new transaction, based on original revision 1\n>>       * adding path : branches ... done.\n>>       * adding path : trunk ... done.\n>> svnadmin: Couldn't perform atomic initialization\n>> svnadmin: Couldn't perform atomic initialization\n>> svnadmin: SQLite compiled for 3.7.4, but running with 3.7.3\n>> + eval_ret=1\n>\n> Hmm.  Do any other svn related tests that use \"svnadmin load\" work in your\n> environment?\n>\n>      $ cd t/\n>      $ git grep -l 'svnadmin load'\n>      t9010-svn-fe.sh\n>      t9110-git-svn-use-svm-props.sh\n>      t9111-git-svn-use-svnsync-props.sh\n>      t9112-git-svn-md5less-file.sh\n>      t9115-git-svn-dcommit-funky-renames.sh\n>      t9121-git-svn-fetch-renamed-dir.sh\n>      t9126-git-svn-follow-deleted-readded-directory.sh\n>      t9131-git-svn-empty-symlink.sh\n>      t9132-git-svn-broken-symlink.sh\n>      t9135-git-svn-moved-branch-empty-file.sh\n>      t9136-git-svn-recreated-branch-empty-file.sh\n>      t9150-svk-mergetickets.sh\n>      t9151-svn-mergeinfo.sh\n>      t9153-git-svn-rewrite-uuid.sh\n>      t9154-git-svn-fancy-glob.sh\n>\n> Web searching for \"svnadmin: SQLite compiled for\" seems to give a handful\n> of hits, even though I don't see anything from Debian offhand.\n>\n\nIt looks like all of the svn tests are failing.\n\nI checked out the last version I built and tested, f2665ec, and it's \nfailing the svn tests also. So, it looks like the current Debian \n(Squeeze) svn package is broken. And the following seems to confirm that.\n\n\thttp://bugs.debian.org/cgi-bin/bugreport.cgi?bug=608925\n"},{"id":"159062","messageId":"7vpqs9aiul.fsf@alter.siamese.dyndns.org","threadId":"26215","inReplyTo":"20110106180051.GC11346@burratino","subject":"Re: [PATCH] t9010: svnadmin can fail even if available","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-01-06T20:16:18Z","receivedAt":"2011-01-06T20:16:18Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jonathan Nieder <jrnieder@gmail.com> writes:\n\n> If svn is built against one version of SQLite and run against\n> another, svnadmin (needlessly) errors out during t9010:\n>\n>  <<< Started new transaction, based on original revision 1\n>       * adding path : branches ... done.\n>       * adding path : trunk ... done.\n>  svnadmin: Couldn't perform atomic initialization\n>  svnadmin: Couldn't perform atomic initialization\n>  svnadmin: SQLite compiled for 3.7.4, but running with 3.7.3\n>\n> Work around this by putting the svn invocations into a single test\n> that builds a repo to compare the test-svn-fe result against.  This\n> test would always pass but only set the new SVNREPO test prereq if svn\n> succeeds; and the test using that repo gets an SVNREPO prerequisite so\n> it only runs with working svn installations.\n>\n> This seems like the right thing to, anyway: the test script is meant\n> to test the version of git just built, not the installed svn.\n\nYes, and I understand that this will prevent the mailing list from getting\nspammed by useless \"bug reports\" that should have been directed to distros\nthat packaged broken subversion, which is a plus.\n\nBut I am somewhat unhappy because I do not think we want to cater to all\nthe broken installations of system tools.  When tests fail because\nsomebody's \"mkdir -p\" (just a random example I picked from your patch)\ndoes not work correctly, we would just say \"Your system is broken, and\nhere is a nickle; get a better computer\".  Why is svnadmin so special?\n\nAlso isn't the breakage not just this test, but also in all the tests that\ntry to run \"svnadmin load\"?  Shouldn't we somehow hoist this logic out of\nt9010 and put it in t/lib-vcs-svn.sh or somewhere?\n\nAs far as I understand, svn interoperability bits (git-svn and vcs-svn) do\nnot rely on svnadmin at runtime, so a breakage in the system's svnadmin\nwould not be a reason to omit building and installing them.  It however\nsomehow feels wrong to install something we cannot even test.  I do not\nhave a good solution to this offhand, though.\n"},{"id":"159067","messageId":"20110106204605.GA15090@burratino","threadId":"26215","inReplyTo":"7vpqs9aiul.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] t9010: svnadmin can fail even if available","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2011-01-06T20:46:05Z","receivedAt":"2011-01-06T20:46:05Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Junio C Hamano wrote:\n\n> But I am somewhat unhappy because I do not think we want to cater to all\n> the broken installations of system tools.  When tests fail because\n> somebody's \"mkdir -p\" (just a random example I picked from your patch)\n> does not work correctly, we would just say \"Your system is broken, and\n> here is a nickle; get a better computer\".  Why is svnadmin so special?\n> \n> Also isn't the breakage not just this test, but also in all the tests that\n> try to run \"svnadmin load\"?  Shouldn't we somehow hoist this logic out of\n> t9010 and put it in t/lib-vcs-svn.sh or somewhere?\n>\n> As far as I understand, svn interoperability bits (git-svn and vcs-svn) do\n> not rely on svnadmin at runtime, so a breakage in the system's svnadmin\n> would not be a reason to omit building and installing them.\n\nYou're right, I did not do a good job of selling the patch.  I should\nhave said:\n\n\tSubject: t9010: svnadmin can fail even if available\n\n\tIf svn is built against one version of SQLite and run against\n\tanother, libsvn_subr needlessly errors out in operations that\n\tneed to make a commit.\n\n\tThat is clearly not a bug in git but let us consider the\n\tramifications for the test suite.  git-svn uses libsvn directly\n\tand is probably broken by that bug; it is right for git-svn\n\ttests to fail.  The vcs-svn lib, on the other hand, does not use\n\tlibsvn and the test t9010 only uses svn to check its work.  This\n\tpoints to two possible improvements:\n\n\t - do not disable most vcs-svn tests if svn is missing.\n\t - skip validation rather than failing it when svn fails.\n\n\tBring about both by putting the svn invocations into a single\n\ttest that builds a repo to compare the test-svn-fe result\n\tagainst.  The test will always pass but only will set the new\n\tSVNREPO test prereq if svn succeeds; and validation using that\n\trepo gets an SVNREPO prerequisite so it only runs with working\n\tsvn installations.\n\n\tWorks-around: http://bugs.debian.org/608925\n\tNoticed-by: A Large Angry SCM <gitzilla@gmail.com>\n\tSigned-off-by: Jonathan Nieder <jrnieder@gmail.com>\n"},{"id":"159085","messageId":"7vpqs98qti.fsf@alter.siamese.dyndns.org","threadId":"26215","inReplyTo":"20110106204605.GA15090@burratino","subject":"Re: [PATCH] t9010: svnadmin can fail even if available","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-01-07T01:07:05Z","receivedAt":"2011-01-07T01:07:05Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jonathan Nieder <jrnieder@gmail.com> writes:\n\n>> Also isn't the breakage not just this test, but also in all the tests that\n>> try to run \"svnadmin load\"?  Shouldn't we somehow hoist this logic out of\n>> t9010 and put it in t/lib-vcs-svn.sh or somewhere?\n\nAm I mistaken and t9010 is the only one that needs the fix in your patch?\n"},{"id":"159088","messageId":"20110107013159.GA23280@burratino","threadId":"26215","inReplyTo":"7vpqs98qti.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] t9010: svnadmin can fail even if available","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2011-01-07T01:31:59Z","receivedAt":"2011-01-07T01:31:59Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Junio C Hamano wrote:\n> Jonathan Nieder <jrnieder@gmail.com> writes:\n\n>>> Also isn't the breakage not just this test, but also in all the tests that\n>>> try to run \"svnadmin load\"?  Shouldn't we somehow hoist this logic out of\n>>> t9010 and put it in t/lib-vcs-svn.sh or somewhere?\n>\n> Am I mistaken and t9010 is the only one that needs the fix in your patch?\n\nEverything except t9010 is testing git-svn.  My argument before was\nthat this libsvn_subr breakage is going to leave git-svn broken\nanyway, so why bother guarding against it in tests?\n\nThat precise argument is broken in at least three ways:\n\n - the libsvn_subr breakage would only breaks \"git svn dcommit\" (and\n   \"git svn set-tree\") and only when the remote svn repo is actually a\n   local svn repo using the FSFS backend.\n\n - maybe the next time \"svnadmin load\" breaks it will not break\n   git svn\n\n - this particular breakage seems especially unworthy of workarounds\n   because it is so easy to fix on the svn side.\n\nSo why do I like the patch to t9010?  Two reasons: first, it means\nt9010 could run on systems without svn installed at all, and second,\nit means that there is one less test to worry about if svn fails in\nsome other way in the future.\n\nTo do the same for t91* would be impossible.  If svn is broken or not\ninstalled, svn-fe will run fine, but \"git svn\" will not.  On the other\nhand, if svnadmin were broken but svn still worked, \"git svn\" would be\nfine but that would be quite strange and I do not think it is worth\nspending time to prepare for.\n"},{"id":"159115","messageId":"20110107165837.GA8062@kytes","threadId":"26215","inReplyTo":"20110107013159.GA23280@burratino","subject":"Re: [PATCH] t9010: svnadmin can fail even if available","fromName":"Ramkumar Ramachandra","fromEmail":"artagnon@gmail.com","sentAt":"2011-01-07T16:58:40Z","receivedAt":"2011-01-07T16:58:40Z","isPatch":true,"sender":{"key":"r@artagnon.com","avatar":"https://avatars.githubusercontent.com/u/37226?v=4"},"body":"Hi,\n\nJonathan Nieder writes:\n> To do the same for t91* would be impossible.  If svn is broken or not\n> installed, svn-fe will run fine, but \"git svn\" will not.  On the other\n> hand, if svnadmin were broken but svn still worked, \"git svn\" would be\n> fine but that would be quite strange and I do not think it is worth\n> spending time to prepare for.\n\nI don't think it's worth spending time preparing for every concievable\nbreakage. The patch A few more examples of possible breakages I've\nencountered:\n- APR compiled without threading support, SVN compiled with it, or\n  viceversa.\n- SVN is compiled against GNU iconv, but apr-iconv installed, or\n  viceversa.\n- Two different versions of a dependent library are installed, and SVN\n  links to a different version in a different location.\n\nOne or many components of SVN may fail. So, I'm in favor of the\ncurrent approach: if SVN is installed, attempt to run all the t91*\ntests. Any failure can either be interpreted as a real test failure or\nmalformed SVN installation.\n\n-- Ram\n"},{"id":"159136","messageId":"7vfwt47det.fsf@alter.siamese.dyndns.org","threadId":"26215","inReplyTo":"20110107165837.GA8062@kytes","subject":"Re: [PATCH] t9010: svnadmin can fail even if available","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-01-07T18:54:18Z","receivedAt":"2011-01-07T18:54:18Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ramkumar Ramachandra <artagnon@gmail.com> writes:\n\n> Jonathan Nieder writes:\n>> To do the same for t91* would be impossible.  If svn is broken or not\n>> installed, svn-fe will run fine, but \"git svn\" will not.  On the other\n>> hand, if svnadmin were broken but svn still worked, \"git svn\" would be\n>> fine but that would be quite strange and I do not think it is worth\n>> spending time to prepare for.\n>\n> I don't think it's worth spending time preparing for every concievable\n> breakage. The patch A few more examples of possible breakages I've\n> encountered:\n> - APR compiled without threading support, SVN compiled with it, or\n>   viceversa.\n> - SVN is compiled against GNU iconv, but apr-iconv installed, or\n>   viceversa.\n> - Two different versions of a dependent library are installed, and SVN\n>   links to a different version in a different location.\n>\n> One or many components of SVN may fail. So, I'm in favor of the\n> current approach: if SVN is installed, attempt to run all the t91*\n> tests. Any failure can either be interpreted as a real test failure or\n> malformed SVN installation.\n\nThat was what I was alluding to earlier, but ...\n\n (1) the patch has already been written and it looks obviously correct;\n\n (2) the code after the patch is shorter and more readable; and\n\n (3) this will prevent the mailing list from getting spammed by useless\n     \"bug reports\" that should have been directed to distros that packaged\n     subversion in one broken way.\n\nAdmittedly, it may only catch a breakage in one particular way and not\nother ways, so we cannot put too much weight on (3), but I would say (2)\nabove alone is a merit enough for us to have this.\n"}]}