{"thread":{"id":"26208","subject":"[PATCH 3/3] t3032: limit sed branch labels to 8 characters","startedAt":"2011-01-06T00:30:01Z","lastAt":"2011-01-06T21:39:26Z","messageCount":5,"participants":["Brandon Casey","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":3},"messages":[{"id":"159010","messageId":"gmeXEearzUOUEst4-B2b8sVUo0XhywYUDm7rCJikom1xi9tIroh9GnJRv-bJTzbCbvqI-4DOU3A@cipher.nrlssc.navy.mil","threadId":"26208","inReplyTo":null,"subject":"[PATCH 1/3] trace.c: ensure NULL is not passed to printf","fromName":"Brandon Casey","fromEmail":"casey@nrlssc.navy.mil","sentAt":"2011-01-06T00:30:01Z","receivedAt":"2011-01-06T00:30:01Z","isPatch":true,"sender":{"key":"drafnel@gmail.com","avatar":"https://avatars.githubusercontent.com/u/921167?v=4"},"body":"From: Brandon Casey <drafnel@gmail.com>\n\nGNU printf, and many others, will print the string \"(null)\" if a NULL\npointer is passed as the argument to a \"%s\" format specifier.  Some\nimplementations (like on Solaris) do not detect a NULL pointer and will\nproduce a segfault in this case.\n\nSo, fix this by ensuring that pointer variables do not contain the value\nNULL.  Assign the string \"(null)\" to the variables are NULL.\n\nSigned-off-by: Brandon Casey <casey@nrlssc.navy.mil>\n---\n trace.c |    9 ++++++++-\n 1 files changed, 8 insertions(+), 1 deletions(-)\n\ndiff --git a/trace.c b/trace.c\nindex 02279b8..35d388d 100644\n--- a/trace.c\n+++ b/trace.c\n@@ -154,6 +154,7 @@ static const char *quote_crnl(const char *path)\n /* FIXME: move prefix to startup_info struct and get rid of this arg */\n void trace_repo_setup(const char *prefix)\n {\n+\tconst char *git_work_tree;\n \tchar cwd[PATH_MAX];\n \tchar *trace = getenv(\"GIT_TRACE\");\n \n@@ -164,8 +165,14 @@ void trace_repo_setup(const char *prefix)\n \tif (!getcwd(cwd, PATH_MAX))\n \t\tdie(\"Unable to get current working directory\");\n \n+\tif (!(git_work_tree = get_git_work_tree()))\n+\t\tgit_work_tree = \"(null)\";\n+\n+\tif (!prefix)\n+\t\tprefix = \"(null)\";\n+\n \ttrace_printf(\"setup: git_dir: %s\\n\", quote_crnl(get_git_dir()));\n-\ttrace_printf(\"setup: worktree: %s\\n\", quote_crnl(get_git_work_tree()));\n+\ttrace_printf(\"setup: worktree: %s\\n\", quote_crnl(git_work_tree));\n \ttrace_printf(\"setup: cwd: %s\\n\", quote_crnl(cwd));\n \ttrace_printf(\"setup: prefix: %s\\n\", quote_crnl(prefix));\n }\n-- \n1.7.3.1\n"},{"id":"159009","messageId":"gmeXEearzUOUEst4-B2b8nKnIcuDy8iOxR9s9wmOFYzBZT5rwFSFsnedLx8orqTDP1ztkJap7K8@cipher.nrlssc.navy.mil","threadId":"26208","inReplyTo":"gmeXEearzUOUEst4-B2b8sVUo0XhywYUDm7rCJikom1xi9tIroh9GnJRv-bJTzbCbvqI-4DOU3A@cipher.nrlssc.navy.mil","subject":"[PATCH 2/3] t0001,t1510,t3301: use sane_unset which always returns with status 0","fromName":"Brandon Casey","fromEmail":"casey@nrlssc.navy.mil","sentAt":"2011-01-06T00:30:02Z","receivedAt":"2011-01-06T00:30:02Z","isPatch":true,"sender":{"key":"drafnel@gmail.com","avatar":"https://avatars.githubusercontent.com/u/921167?v=4"},"body":"From: Brandon Casey <drafnel@gmail.com>\n\nOn some shells (like /usr/xpg4/bin/sh on Solaris), unset will exit\nnon-zero when passed the name of a variable that has not been set.  Use\nsane_unset instead so that the return value of unset can be ignored while\nthe && linkage of the test script can be preserved.\n\nSigned-off-by: Brandon Casey <casey@nrlssc.navy.mil>\n---\n t/t0001-init.sh       |    8 +++---\n t/t1510-repo-setup.sh |   64 ++++++++++++++++++++++++------------------------\n t/t3301-notes.sh      |    2 +-\n 3 files changed, 37 insertions(+), 37 deletions(-)\n\ndiff --git a/t/t0001-init.sh b/t/t0001-init.sh\nindex af8b9c5..f684993 100755\n--- a/t/t0001-init.sh\n+++ b/t/t0001-init.sh\n@@ -35,7 +35,7 @@ test_expect_success 'plain' '\n \n test_expect_success 'plain nested in bare' '\n \t(\n-\t\tunset GIT_DIR GIT_WORK_TREE &&\n+\t\tsane_unset GIT_DIR GIT_WORK_TREE &&\n \t\tgit init --bare bare-ancestor.git &&\n \t\tcd bare-ancestor.git &&\n \t\tmkdir plain-nested &&\n@@ -47,7 +47,7 @@ test_expect_success 'plain nested in bare' '\n \n test_expect_success 'plain through aliased command, outside any git repo' '\n \t(\n-\t\tunset GIT_DIR GIT_WORK_TREE GIT_CONFIG_NOGLOBAL &&\n+\t\tsane_unset GIT_DIR GIT_WORK_TREE GIT_CONFIG_NOGLOBAL &&\n \t\tHOME=$(pwd)/alias-config &&\n \t\texport HOME &&\n \t\tmkdir alias-config &&\n@@ -65,7 +65,7 @@ test_expect_success 'plain through aliased command, outside any git repo' '\n \n test_expect_failure 'plain nested through aliased command' '\n \t(\n-\t\tunset GIT_DIR GIT_WORK_TREE &&\n+\t\tsane_unset GIT_DIR GIT_WORK_TREE &&\n \t\tgit init plain-ancestor-aliased &&\n \t\tcd plain-ancestor-aliased &&\n \t\techo \"[alias] aliasedinit = init\" >>.git/config &&\n@@ -78,7 +78,7 @@ test_expect_failure 'plain nested through aliased command' '\n \n test_expect_failure 'plain nested in bare through aliased command' '\n \t(\n-\t\tunset GIT_DIR GIT_WORK_TREE &&\n+\t\tsane_unset GIT_DIR GIT_WORK_TREE &&\n \t\tgit init --bare bare-ancestor-aliased.git &&\n \t\tcd bare-ancestor-aliased.git &&\n \t\techo \"[alias] aliasedinit = init\" >>config &&\ndiff --git a/t/t1510-repo-setup.sh b/t/t1510-repo-setup.sh\nindex 500ffaf..c3798ce 100755\n--- a/t/t1510-repo-setup.sh\n+++ b/t/t1510-repo-setup.sh\n@@ -80,7 +80,7 @@ test_repo() {\n #  - cwd can't be outside worktree\n \n test_expect_success '#0: setup' '\n-\tunset GIT_DIR GIT_WORK_TREE &&\n+\tsane_unset GIT_DIR GIT_WORK_TREE &&\n \tmkdir 0 0/sub &&\n \tcd 0 && git init && cd ..\n '\n@@ -123,7 +123,7 @@ EOF\n # GIT_WORK_TREE is ignored -> #0\n \n test_expect_success '#1: setup' '\n-\tunset GIT_DIR GIT_WORK_TREE &&\n+\tsane_unset GIT_DIR GIT_WORK_TREE &&\n \tmkdir 1 1/sub 1.wt 1.wt/sub 1/wt 1/wt/sub &&\n \tcd 1 &&\n \tgit init &&\n@@ -174,7 +174,7 @@ EOF\n #  - cwd can't be outside worktree\n \n test_expect_success '#2: setup' '\n-\tunset GIT_DIR GIT_WORK_TREE &&\n+\tsane_unset GIT_DIR GIT_WORK_TREE &&\n \tmkdir 2 2/sub &&\n \tcd 2 && git init && cd ..\n '\n@@ -241,7 +241,7 @@ EOF\n #  - cwd can be outside worktree\n \n test_expect_success '#3: setup' '\n-\tunset GIT_DIR GIT_WORK_TREE &&\n+\tsane_unset GIT_DIR GIT_WORK_TREE &&\n \tmkdir 3 3/sub 3/sub/sub 3.wt 3.wt/sub 3/wt 3/wt/sub &&\n \tcd 3 && git init && cd ..\n '\n@@ -504,7 +504,7 @@ EOF\n # core.worktree is ignored -> #0\n \n test_expect_success '#4: setup' '\n-\tunset GIT_DIR GIT_WORK_TREE &&\n+\tsane_unset GIT_DIR GIT_WORK_TREE &&\n \tmkdir 4 4/sub &&\n \tcd 4 &&\n \tgit init &&\n@@ -550,7 +550,7 @@ EOF\n # GIT_WORK_TREE/core.worktree are ignored -> #0\n \n test_expect_success '#5: setup' '\n-\tunset GIT_DIR GIT_WORK_TREE &&\n+\tsane_unset GIT_DIR GIT_WORK_TREE &&\n \tmkdir 5 5/sub &&\n \tcd 5 &&\n \tgit init &&\n@@ -602,7 +602,7 @@ EOF\n #  - cwd can be outside worktree\n \n test_expect_success '#6: setup' '\n-\tunset GIT_DIR GIT_WORK_TREE &&\n+\tsane_unset GIT_DIR GIT_WORK_TREE &&\n \tmkdir 6 6/sub 6/sub/sub 6.wt 6.wt/sub 6/wt 6/wt/sub &&\n \tcd 6 && git init && cd ..\n '\n@@ -889,7 +889,7 @@ EOF\n # core.worktree is overridden by GIT_WORK_TREE -> #3\n \n test_expect_success '#7: setup' '\n-\tunset GIT_DIR GIT_WORK_TREE &&\n+\tsane_unset GIT_DIR GIT_WORK_TREE &&\n \tmkdir 7 7/sub 7/sub/sub 7.wt 7.wt/sub 7/wt 7/wt/sub &&\n \tcd 7 &&\n \tgit init &&\n@@ -1155,7 +1155,7 @@ EOF\n # #0 except that git_dir is set by .git file\n \n test_expect_success '#8: setup' '\n-\tunset GIT_DIR GIT_WORK_TREE &&\n+\tsane_unset GIT_DIR GIT_WORK_TREE &&\n \tmkdir 8 8/sub &&\n \tcd 8 &&\n \tgit init &&\n@@ -1202,7 +1202,7 @@ EOF\n # #1 except that git_dir is set by .git file\n \n test_expect_success '#9: setup' '\n-\tunset GIT_DIR GIT_WORK_TREE &&\n+\tsane_unset GIT_DIR GIT_WORK_TREE &&\n \tmkdir 9 9/sub 9.wt 9.wt/sub 9/wt 9/wt/sub &&\n \tcd 9 &&\n \tgit init &&\n@@ -1251,7 +1251,7 @@ EOF\n # #2 except that git_dir is set by .git file\n \n test_expect_success '#10: setup' '\n-\tunset GIT_DIR GIT_WORK_TREE &&\n+\tsane_unset GIT_DIR GIT_WORK_TREE &&\n \tmkdir 10 10/sub &&\n \tcd 10 &&\n \tgit init &&\n@@ -1318,7 +1318,7 @@ EOF\n # #3 except that git_dir is set by .git file\n \n test_expect_success '#11: setup' '\n-\tunset GIT_DIR GIT_WORK_TREE &&\n+\tsane_unset GIT_DIR GIT_WORK_TREE &&\n \tmkdir 11 11/sub 11/sub/sub 11.wt 11.wt/sub 11/wt 11/wt/sub &&\n \tcd 11 &&\n \tgit init &&\n@@ -1586,7 +1586,7 @@ EOF\n \n \n test_expect_success '#12: setup' '\n-\tunset GIT_DIR GIT_WORK_TREE &&\n+\tsane_unset GIT_DIR GIT_WORK_TREE &&\n \tmkdir 12 12/sub 12/sub/sub 12.wt 12.wt/sub 12/wt 12/wt/sub &&\n \tcd 12 &&\n \tgit init &&\n@@ -1634,7 +1634,7 @@ EOF\n # #5 except that git_dir is set by .git file\n \n test_expect_success '#13: setup' '\n-\tunset GIT_DIR GIT_WORK_TREE &&\n+\tsane_unset GIT_DIR GIT_WORK_TREE &&\n \tmkdir 13 13/sub 13/sub/sub 13.wt 13.wt/sub 13/wt 13/wt/sub &&\n \tcd 13 &&\n \tgit init &&\n@@ -1684,7 +1684,7 @@ EOF\n # #6 except that git_dir is set by .git file\n \n test_expect_success '#14: setup' '\n-\tunset GIT_DIR GIT_WORK_TREE &&\n+\tsane_unset GIT_DIR GIT_WORK_TREE &&\n \tmkdir 14 14/sub 14/sub/sub 14.wt 14.wt/sub 14/wt 14/wt/sub &&\n \tcd 14 &&\n \tgit init &&\n@@ -1975,7 +1975,7 @@ EOF\n # #7 except that git_dir is set by .git file\n \n test_expect_success '#15: setup' '\n-\tunset GIT_DIR GIT_WORK_TREE &&\n+\tsane_unset GIT_DIR GIT_WORK_TREE &&\n \tmkdir 15 15/sub 15/sub/sub 15.wt 15.wt/sub 15/wt 15/wt/sub &&\n \tcd 15 &&\n \tgit init &&\n@@ -2247,7 +2247,7 @@ EOF\n #  - cwd can't be outside worktree\n \n test_expect_success '#16.1: setup' '\n-\tunset GIT_DIR GIT_WORK_TREE &&\n+\tsane_unset GIT_DIR GIT_WORK_TREE &&\n \tmkdir 16 16/sub &&\n \tcd 16 &&\n \tgit init &&\n@@ -2378,7 +2378,7 @@ EOF\n # GIT_WORK_TREE is ignored -> #16.1 (with warnings perhaps)\n \n test_expect_success '#17.1: setup' '\n-\tunset GIT_DIR GIT_WORK_TREE &&\n+\tsane_unset GIT_DIR GIT_WORK_TREE &&\n \tmkdir 17 17/sub &&\n \tcd 17 &&\n \tgit init &&\n@@ -2511,7 +2511,7 @@ EOF\n #  - cwd can't be outside worktree\n \n test_expect_success '#18: setup' '\n-\tunset GIT_DIR GIT_WORK_TREE &&\n+\tsane_unset GIT_DIR GIT_WORK_TREE &&\n \tmkdir 18 18/sub &&\n \tcd 18 &&\n \tgit init &&\n@@ -2578,7 +2578,7 @@ EOF\n # bare repo is overridden by GIT_WORK_TREE -> #3\n \n test_expect_success '#19: setup' '\n-\tunset GIT_DIR GIT_WORK_TREE &&\n+\tsane_unset GIT_DIR GIT_WORK_TREE &&\n \tmkdir 19 19/sub 19/sub/sub 19.wt 19.wt/sub 19/wt 19/wt/sub &&\n \tcd 19 &&\n \tgit init &&\n@@ -2844,7 +2844,7 @@ EOF\n # core.worktree is ignored -> #16.1\n \n test_expect_success '#20.1: setup' '\n-\tunset GIT_DIR GIT_WORK_TREE &&\n+\tsane_unset GIT_DIR GIT_WORK_TREE &&\n \tmkdir 20 20/sub &&\n \tcd 20 &&\n \tgit init &&\n@@ -2972,7 +2972,7 @@ EOF\n # GIT_WORK_TREE/core.worktree are ignored -> #20.1\n \n test_expect_success '#21.1: setup' '\n-\tunset GIT_DIR GIT_WORK_TREE &&\n+\tsane_unset GIT_DIR GIT_WORK_TREE &&\n \tmkdir 21 21/sub &&\n \tcd 21 &&\n \tgit init &&\n@@ -3108,7 +3108,7 @@ EOF\n #  - cwd can be outside worktree\n \n test_expect_success '#22.1: setup' '\n-\tunset GIT_DIR GIT_WORK_TREE &&\n+\tsane_unset GIT_DIR GIT_WORK_TREE &&\n \tmkdir 22 &&\n \tcd 22 &&\n \tgit init &&\n@@ -3439,7 +3439,7 @@ test_expect_success '#22.2: at root' '\n # core.worktree is overridden by GIT_WORK_TREE -> #19\n \n test_expect_success '#23: setup' '\n-\tunset GIT_DIR GIT_WORK_TREE &&\n+\tsane_unset GIT_DIR GIT_WORK_TREE &&\n \tmkdir 23 23/sub 23/sub/sub 23.wt 23.wt/sub 23/wt 23/wt/sub &&\n \tcd 23 &&\n \tgit init &&\n@@ -3706,7 +3706,7 @@ EOF\n # #16.2 except git_dir is set according to .git file\n \n test_expect_success '#24: setup' '\n-\tunset GIT_DIR GIT_WORK_TREE &&\n+\tsane_unset GIT_DIR GIT_WORK_TREE &&\n \tmkdir 24 24/sub &&\n \tcd 24 &&\n \tgit init &&\n@@ -3754,7 +3754,7 @@ EOF\n # #17.2 except git_dir is set according to .git file\n \n test_expect_success '#25: setup' '\n-\tunset GIT_DIR GIT_WORK_TREE &&\n+\tsane_unset GIT_DIR GIT_WORK_TREE &&\n \tmkdir 25 25/sub &&\n \tcd 25 &&\n \tgit init &&\n@@ -3804,7 +3804,7 @@ EOF\n # #18 except git_dir is set according to .git file\n \n test_expect_success '#26: setup' '\n-\tunset GIT_DIR GIT_WORK_TREE &&\n+\tsane_unset GIT_DIR GIT_WORK_TREE &&\n \tmkdir 26 26/sub &&\n \tcd 26 &&\n \tgit init &&\n@@ -3872,7 +3872,7 @@ EOF\n # #19 except git_dir is set according to .git file\n \n test_expect_success '#27: setup' '\n-\tunset GIT_DIR GIT_WORK_TREE &&\n+\tsane_unset GIT_DIR GIT_WORK_TREE &&\n \tmkdir 27 27/sub 27/sub/sub 27.wt 27.wt/sub 27/wt 27/wt/sub &&\n \tcd 27 &&\n \tgit init &&\n@@ -4140,7 +4140,7 @@ EOF\n # core.worktree is ignored -> #24\n \n test_expect_success '#28: setup' '\n-\tunset GIT_DIR GIT_WORK_TREE &&\n+\tsane_unset GIT_DIR GIT_WORK_TREE &&\n \tmkdir 28 28/sub &&\n \tcd 28 &&\n \tgit init &&\n@@ -4189,7 +4189,7 @@ EOF\n # GIT_WORK_TREE/core.worktree are ignored -> #28\n \n test_expect_success '#29: setup' '\n-\tunset GIT_DIR GIT_WORK_TREE &&\n+\tsane_unset GIT_DIR GIT_WORK_TREE &&\n \tmkdir 29 29/sub &&\n \tcd 29 &&\n \tgit init &&\n@@ -4239,7 +4239,7 @@ EOF\n # core.worktree and core.bare conflict, won't fly.\n \n test_expect_success '#30: setup' '\n-\tunset GIT_DIR GIT_WORK_TREE &&\n+\tsane_unset GIT_DIR GIT_WORK_TREE &&\n \tmkdir 30 &&\n \tcd 30 &&\n \tgit init &&\n@@ -4278,7 +4278,7 @@ test_expect_success '#30: at root' '\n # #23 except git_dir is set according to .git file\n \n test_expect_success '#31: setup' '\n-\tunset GIT_DIR GIT_WORK_TREE &&\n+\tsane_unset GIT_DIR GIT_WORK_TREE &&\n \tmkdir 31 31/sub 31/sub/sub 31.wt 31.wt/sub 31/wt 31/wt/sub &&\n \tcd 31 &&\n \tgit init &&\ndiff --git a/t/t3301-notes.sh b/t/t3301-notes.sh\nindex dc2e04a..1921ca3 100755\n--- a/t/t3301-notes.sh\n+++ b/t/t3301-notes.sh\n@@ -1067,7 +1067,7 @@ test_expect_success 'git notes copy diagnoses too many or too few parameters' '\n \n test_expect_success 'git notes get-ref (no overrides)' '\n \tgit config --unset core.notesRef &&\n-\tunset GIT_NOTES_REF &&\n+\tsane_unset GIT_NOTES_REF &&\n \ttest \"$(git notes get-ref)\" = \"refs/notes/commits\"\n '\n \n-- \n1.7.3.1\n"},{"id":"159008","messageId":"gmeXEearzUOUEst4-B2b8mMW8OqKObIqeN20uJhfiKbKa9JUYsiz4cHx7ViGaJpP8z4W9bjGjNI@cipher.nrlssc.navy.mil","threadId":"26208","inReplyTo":"gmeXEearzUOUEst4-B2b8sVUo0XhywYUDm7rCJikom1xi9tIroh9GnJRv-bJTzbCbvqI-4DOU3A@cipher.nrlssc.navy.mil","subject":"[PATCH 3/3] t3032: limit sed branch labels to 8 characters","fromName":"Brandon Casey","fromEmail":"casey@nrlssc.navy.mil","sentAt":"2011-01-06T00:30:03Z","receivedAt":"2011-01-06T00:30:03Z","isPatch":true,"sender":{"key":"drafnel@gmail.com","avatar":"https://avatars.githubusercontent.com/u/921167?v=4"},"body":"From: Brandon Casey <drafnel@gmail.com>\n\nPOSIX leaves as unspecified the handling of labels greater than 8\ncharacters.  Apparently, Sun decided to treat them as errors.  Make sed on\nSolaris happy by trimming the length of labels to 8 characters.\n\nSigned-off-by: Brandon Casey <casey@nrlssc.navy.mil>\n---\n t/t3032-merge-recursive-options.sh |    6 +++---\n 1 files changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/t/t3032-merge-recursive-options.sh b/t/t3032-merge-recursive-options.sh\nindex 2293797..de9ff89 100755\n--- a/t/t3032-merge-recursive-options.sh\n+++ b/t/t3032-merge-recursive-options.sh\n@@ -16,13 +16,13 @@ test_description='merge-recursive options\n test_expect_success 'setup' '\n \tconflict_hunks () {\n \t\tsed -n -e \"\n-\t\t\t/^<<<</ b inconflict\n+\t\t\t/^<<<</ b conflict\n \t\t\tb\n-\t\t\t: inconflict\n+\t\t\t: conflict\n \t\t\tp\n \t\t\t/^>>>>/ b\n \t\t\tn\n-\t\t\tb inconflict\n+\t\t\tb conflict\n \t\t\" \"$@\"\n \t} &&\n \n-- \n1.7.3.1\n"},{"id":"159064","messageId":"7vlj2xai2v.fsf@alter.siamese.dyndns.org","threadId":"26208","inReplyTo":"gmeXEearzUOUEst4-B2b8nKnIcuDy8iOxR9s9wmOFYzBZT5rwFSFsnedLx8orqTDP1ztkJap7K8@cipher.nrlssc.navy.mil","subject":"Re: [PATCH 2/3] t0001,t1510,t3301: use sane_unset which always returns with status 0","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-01-06T20:32:56Z","receivedAt":"2011-01-06T20:32:56Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks; there are a bit more from \n\n $git grep -n -e '^[ \t]*unset[ \t].*&&' t\n\n* t/t4150-am.sh:132:\tunset test_tick &&\n\nThis should be safe, as we have already run test_tick to set it earlier.\n\n* t/t5560-http-backend-noserver.sh:20:\tunset REQUEST_METHOD &&\n* t/t5560-http-backend-noserver.sh:33:\tunset REQUEST_METHOD &&\n* t/t5560-http-backend-noserver.sh:34:\tunset CONTENT_TYPE &&\n\nThe varilable was earlier set inside the same function; safe.\n\n* t/t5601-clone.sh:167:\t\tunset GIT_CONFIG_NOGLOBAL &&\n\ntest-lib.sh sets this for us and this unsets it inside a subshell; safe.\n\n* t/t6032-merge-large-rename.sh:98:\tunset GIT_MERGE_VERBOSITY &&\n\ntest-lib.sh sets this for us and this unsets it; safe.\n\nHowever, this unsets the variable permanently, damaging the environment\nfor tests other people later may add at the end of the script, which is\nbad.  But that is outside the scope of your fix.\n\n* t/t9130-git-svn-authors-file.sh:99:\t\tunset GIT_CONFIG_NOGLOBAL &&\n* t/t9130-git-svn-authors-file.sh:100:\t\tunset GIT_DIR &&\n\ntest-lib.sh and then lib-git-svn.sh set these for us and this unsets them\ninside a subshell; safe.\n\n* t/t9130-git-svn-authors-file.sh:101:\t\tunset GIT_CONFIG &&\n\nAs far as I can tell, this is unsafe; nobody has set GIT_CONFIG up to this\npoint.\n\n* t/t9200-git-cvsexportcommit.sh:324:\t unset GIT_DIR &&\n\ntest-lib.sh sets this for us and this unsets it inside a subshell; safe.\n"},{"id":"159072","messageId":"ma1kTwntNDX512DVaUWbBvJaymY_6kS-s_jNuypXDSaVoyGytOK_DA@cipher.nrlssc.navy.mil","threadId":"26208","inReplyTo":"7vlj2xai2v.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH 2/3] t0001,t1510,t3301: use sane_unset which always returns with status 0","fromName":"Brandon Casey","fromEmail":"casey@nrlssc.navy.mil","sentAt":"2011-01-06T21:39:26Z","receivedAt":"2011-01-06T21:39:26Z","isPatch":true,"sender":{"key":"drafnel@gmail.com","avatar":"https://avatars.githubusercontent.com/u/921167?v=4"},"body":"On 01/06/2011 02:32 PM, Junio C Hamano wrote:\n> Thanks; there are a bit more from \n> \n>  $git grep -n -e '^[ \t]*unset[ \t].*&&' t\n> \n> * t/t9130-git-svn-authors-file.sh:101:\t\tunset GIT_CONFIG &&\n> \n> As far as I can tell, this is unsafe; nobody has set GIT_CONFIG up to this\n> point.\n\nAh, svn isn't installed on the Solaris box I tested on, so\nthis test wasn't run.\n\n-Brandon\n"}]}