{"thread":{"id":"26193","subject":"[PATCH v2] t/t9001-send-email.sh: fix '&&' chain in some tests","startedAt":"2011-01-04T20:56:58Z","lastAt":"2011-01-04T23:56:31Z","messageCount":2,"participants":["Antonio Ospite","Junio C Hamano"],"isPatch":true,"patchVersion":2,"patchTotal":null},"messages":[{"id":"158914","messageId":"1294174618-14571-1-git-send-email-ospite@studenti.unina.it","threadId":"26193","inReplyTo":null,"subject":"[PATCH v2] t/t9001-send-email.sh: fix '&&' chain in some tests","fromName":"Antonio Ospite","fromEmail":"ospite@studenti.unina.it","sentAt":"2011-01-04T20:56:58Z","receivedAt":"2011-01-04T20:56:58Z","isPatch":true,"sender":{"key":"ospite@studenti.unina.it","avatar":"https://gravatar.com/avatar/ea788baa2a3a207a84097c6f4f7b11d4201a80060933ef67584f648f17005552?d=mp&s=160"},"body":"t/README recommends chaining test assertions.\n\nSigned-off-by: Antonio Ospite <ospite@studenti.unina.it>\n---\n\nHi sorry for the delay,\n\nthe only change wrt. v1 is the use of test_might_fail with\ngit config --unset as requested by Jonathan.\n\nNote that in t9001-send-email.sh and other tests git config --unset is used\nwithout the test_might_fail handler some other times, you might wat to check\nthis.\n\nThanks and best regards,\n   Antonio Ospite\n   http://ao2.it\n\n t/t9001-send-email.sh |    8 ++++----\n 1 files changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh\nindex 1dc4a92..ace3c78 100755\n--- a/t/t9001-send-email.sh\n+++ b/t/t9001-send-email.sh\n@@ -265,7 +265,7 @@ test_expect_success $PREREQ 'Author From: in message body' '\n \t\t--to=nobody@example.com \\\n \t\t--smtp-server=\"$(pwd)/fake.sendmail\" \\\n \t\t$patches &&\n-\tsed \"1,/^\\$/d\" < msgtxt1 > msgbody1\n+\tsed \"1,/^\\$/d\" < msgtxt1 > msgbody1 &&\n \tgrep \"From: A <author@example.com>\" msgbody1\n '\n \n@@ -276,7 +276,7 @@ test_expect_success $PREREQ 'Author From: not in message body' '\n \t\t--to=nobody@example.com \\\n \t\t--smtp-server=\"$(pwd)/fake.sendmail\" \\\n \t\t$patches &&\n-\tsed \"1,/^\\$/d\" < msgtxt1 > msgbody1\n+\tsed \"1,/^\\$/d\" < msgtxt1 > msgbody1 &&\n \t! grep \"From: A <author@example.com>\" msgbody1\n '\n \n@@ -298,7 +298,7 @@ test_expect_success $PREREQ 'Invalid In-Reply-To' '\n \t\t--in-reply-to=\" \" \\\n \t\t--smtp-server=\"$(pwd)/fake.sendmail\" \\\n \t\t$patches \\\n-\t\t2>errors\n+\t\t2>errors &&\n \t! grep \"^In-Reply-To: < *>\" msgtxt1\n '\n \n@@ -617,7 +617,7 @@ EOF\n \"\n \n test_expect_success $PREREQ '--suppress-cc=sob' '\n-\tgit config --unset sendemail.cccmd\n+\ttest_might_fail git config --unset sendemail.cccmd &&\n \ttest_suppression sob\n '\n \n-- \n1.7.2.3\n"},{"id":"158924","messageId":"7vei8sdxzk.fsf@alter.siamese.dyndns.org","threadId":"26193","inReplyTo":"1294174618-14571-1-git-send-email-ospite@studenti.unina.it","subject":"Re: [PATCH v2] t/t9001-send-email.sh: fix '&&' chain in some tests","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-01-04T23:56:31Z","receivedAt":"2011-01-04T23:56:31Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks.\n"}]}