{"thread":{"id":"26183","subject":"[PATCH 0/2] gitweb: make logo optional","startedAt":"2011-01-04T05:02:06Z","lastAt":"2011-01-05T00:45:48Z","messageCount":8,"participants":["Jonathan Nieder","Jakub Narebski","Eric Wong","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"158871","messageId":"20110104050206.GA8280@burratino","threadId":"26183","inReplyTo":null,"subject":"[PATCH 0/2] gitweb: make logo optional","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2011-01-04T05:02:06Z","receivedAt":"2011-01-04T05:02:06Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"These patches were last seen in the instaweb 1.7.1 maintenance\nthread[1] but I believe they are independently useful.  The\nidea is to allow disabling the logo in gitweb.\n\nJonathan Nieder (2):\n  gitweb: skip logo in atom feed when there is none\n  gitweb: make logo optional\n\n gitweb/gitweb.perl |   15 ++++++++++-----\n 1 files changed, 10 insertions(+), 5 deletions(-)\n\n[1] http://thread.gmane.org/gmane.comp.version-control.git/155224\n"},{"id":"158872","messageId":"20110104050247.GB8280@burratino","threadId":"26183","inReplyTo":"20110104050206.GA8280@burratino","subject":"[PATCH 1/2] gitweb: skip logo in atom feed when there is none","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2011-01-04T05:02:47Z","receivedAt":"2011-01-04T05:02:47Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Date: Fri, 3 Sep 2010 19:44:39 -0500\n\nWith v1.5.0-rc0~169 (gitweb: Fix Atom feed <logo>: it is $logo,\nnot $logo_url, 2006-12-04), the logo URI to be written to Atom\nfeeds was corrected but the case of no logo forgotten.\n\nAcked-by: Eric Wong <normalperson@yhbt.net>\nSigned-off-by: Jonathan Nieder <jrnieder@gmail.com>\n---\n gitweb/gitweb.perl |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 4779618..c65af1a 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -7169,7 +7169,7 @@ XML\n \t\tif (defined $favicon) {\n \t\t\tprint \"<icon>\" . esc_url($favicon) . \"</icon>\\n\";\n \t\t}\n-\t\tif (defined $logo_url) {\n+\t\tif (defined $logo) {\n \t\t\t# not twice as wide as tall: 72 x 27 pixels\n \t\t\tprint \"<logo>\" . esc_url($logo) . \"</logo>\\n\";\n \t\t}\n-- \n1.7.4.rc0\n"},{"id":"158873","messageId":"20110104050555.GC8280@burratino","threadId":"26183","inReplyTo":"20110104050206.GA8280@burratino","subject":"[PATCH 2/2] gitweb: make logo optional","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2011-01-04T05:05:55Z","receivedAt":"2011-01-04T05:05:55Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Date: Fri, 3 Sep 2010 19:45:09 -0500\n\nSome sites may not want to have a logo at all.  In particular, git\ninstaweb can benefit from this.\n\nWhile at it, use $cgi->img to simplify this code.  (CGI.pm learned\nmost HTML4 tags by version 2.79, so this should be portable to perl\n5.8, though I haven't tested.)\n\nSigned-off-by: Jonathan Nieder <jrnieder@gmail.com>\n---\nEric liked an earlier version of this patch that did not use\n$cgi->img.\n\n gitweb/gitweb.perl |   13 +++++++++----\n 1 files changed, 9 insertions(+), 4 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex c65af1a..064697c 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -3601,10 +3601,15 @@ EOF\n \t\tinsert_file($site_header);\n \t}\n \n-\tprint \"<div class=\\\"page_header\\\">\\n\" .\n-\t      $cgi->a({-href => esc_url($logo_url),\n-\t               -title => $logo_label},\n-\t              qq(<img src=\").esc_url($logo).qq(\" width=\"72\" height=\"27\" alt=\"git\" class=\"logo\"/>));\n+\tprint \"<div class=\\\"page_header\\\">\\n\";\n+\tif (defined $logo) {\n+\t\tprint $cgi->a({-href => esc_url($logo_url),\n+\t\t               -title => $logo_label},\n+\t\t              $cgi->img({-src => esc_url($logo),\n+\t\t                         -width => 72, -height => 27,\n+\t\t                         -alt => \"git\",\n+\t\t                         -class => \"logo\"}));\n+\t}\n \tprint $cgi->a({-href => esc_url($home_link)}, $home_link_str) . \" / \";\n \tif (defined $project) {\n \t\tprint $cgi->a({-href => href(action=>\"summary\")}, esc_html($project));\n-- \n1.7.4.rc0\n"},{"id":"158880","messageId":"201101041252.40254.jnareb@gmail.com","threadId":"26183","inReplyTo":"20110104050555.GC8280@burratino","subject":"Re: [PATCH 2/2] gitweb: make logo optional","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2011-01-04T11:52:39Z","receivedAt":"2011-01-04T11:52:39Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"On Tue, 4 Dec 2011, Jonathan Nieder wrote:\n\n> Some sites may not want to have a logo at all.  In particular, git\n> instaweb can benefit from this.\n\nWhy do you think that git-instaweb can benefit from not having logo?\nYou need gitweb.css anyway, so it is not much more trouble to serve\nadditional static file, git-logo.png.\n\n> \n> While at it, use $cgi->img to simplify this code.  (CGI.pm learned\n> most HTML4 tags by version 2.79, so this should be portable to perl\n> 5.8, though I haven't tested.)\n\ncorelist (Module::CoreList) says that Perl 5.8.0 has CGI.pm version 2.81;\nIIRC gitweb requires something later than 5.8.0 for good support of\nUnicode (Encode module).\n\n> \n> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>\n\nFor what it is worth it:\n\nAcked-by: Jakub Narebski <jnareb@gmail.com>\n\n-- \nJakub Narebski\nPoland\n"},{"id":"158896","messageId":"20110104162918.GA30141@burratino","threadId":"26183","inReplyTo":"201101041252.40254.jnareb@gmail.com","subject":"Re: [PATCH 2/2] gitweb: make logo optional","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2011-01-04T16:29:18Z","receivedAt":"2011-01-04T16:29:18Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Jakub Narebski wrote:\n> On Tue, 4 Dec 2011, Jonathan Nieder wrote:\n\n>> Some sites may not want to have a logo at all.  In particular, git\n>> instaweb can benefit from this.\n>\n> Why do you think that git-instaweb can benefit from not having logo?\n> You need gitweb.css anyway, so it is not much more trouble to serve\n> additional static file, git-logo.png.\n\nYep, that sentence is stale (it only applied in 1.7.1.x days) and\nshould have been removed.\n\n> corelist (Module::CoreList) says that Perl 5.8.0 has CGI.pm version 2.81;\n> IIRC gitweb requires something later than 5.8.0 for good support of\n> Unicode (Encode module).\n>\n>>\n>> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>\n>\n> For what it is worth it:\n>\n> Acked-by: Jakub Narebski <jnareb@gmail.com>\n\nThanks for looking it over.\n"},{"id":"158921","messageId":"20110104232430.GB15889@dcvr.yhbt.net","threadId":"26183","inReplyTo":"20110104050206.GA8280@burratino","subject":"Re: [PATCH 0/2] gitweb: make logo optional","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2011-01-04T23:24:30Z","receivedAt":"2011-01-04T23:24:30Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Jonathan Nieder <jrnieder@gmail.com> wrote:\n> These patches were last seen in the instaweb 1.7.1 maintenance\n> thread[1] but I believe they are independently useful.  The\n> idea is to allow disabling the logo in gitweb.\n> \n> Jonathan Nieder (2):\n>   gitweb: skip logo in atom feed when there is none\n>   gitweb: make logo optional\n\nThis series looks good to me (especially considering my strong\ndislike of logos/icons on the web :>)\n\nAcked-by: Eric Wong <normalperson@yhbt.net>\n\n-- \nEric Wong\n"},{"id":"158927","messageId":"201101050125.52824.jnareb@gmail.com","threadId":"26183","inReplyTo":"20110104050247.GB8280@burratino","subject":"Re: [PATCH 1/2] gitweb: skip logo in atom feed when there is none","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2011-01-05T00:25:52Z","receivedAt":"2011-01-05T00:25:52Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Jonathan Nieder wrote:\n> Date: Fri, 3 Sep 2010 19:44:39 -0500\n> \n> With v1.5.0-rc0~169 (gitweb: Fix Atom feed <logo>: it is $logo,\n> not $logo_url, 2006-12-04), the logo URI to be written to Atom\n> feeds was corrected but the case of no logo forgotten.\n> \n> Acked-by: Eric Wong <normalperson@yhbt.net>\n> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>\n\nGood catch.  As an obvious bugfix:\n\nAcked-by: Jakub Narebski <jnareb@gmail.com>\n\n> ---\n>  gitweb/gitweb.perl |    2 +-\n>  1 files changed, 1 insertions(+), 1 deletions(-)\n> \n> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\n> index 4779618..c65af1a 100755\n> --- a/gitweb/gitweb.perl\n> +++ b/gitweb/gitweb.perl\n> @@ -7169,7 +7169,7 @@ XML\n>  \t\tif (defined $favicon) {\n>  \t\t\tprint \"<icon>\" . esc_url($favicon) . \"</icon>\\n\";\n>  \t\t}\n> -\t\tif (defined $logo_url) {\n> +\t\tif (defined $logo) {\n>  \t\t\t# not twice as wide as tall: 72 x 27 pixels\n>  \t\t\tprint \"<logo>\" . esc_url($logo) . \"</logo>\\n\";\n>  \t\t}\n> -- \n> 1.7.4.rc0\n> \n> \n\n-- \nJakub Narebski\nPoland\n"},{"id":"158929","messageId":"7v62u4dvpf.fsf@alter.siamese.dyndns.org","threadId":"26183","inReplyTo":"201101050125.52824.jnareb@gmail.com","subject":"Re: [PATCH 1/2] gitweb: skip logo in atom feed when there is none","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-01-05T00:45:48Z","receivedAt":"2011-01-05T00:45:48Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks, all.\n"}]}