{"thread":{"id":"26136","subject":"[PATCH] close file on error in read_mmfile()","startedAt":"2010-12-25T12:38:46Z","lastAt":"2010-12-26T19:18:28Z","messageCount":3,"participants":["René Scharfe","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"158572","messageId":"4D15E5D6.2040800@lsrfire.ath.cx","threadId":"26136","inReplyTo":null,"subject":"[PATCH] close file on error in read_mmfile()","fromName":"René Scharfe","fromEmail":"rene.scharfe@lsrfire.ath.cx","sentAt":"2010-12-25T12:38:46Z","receivedAt":"2010-12-25T12:38:46Z","isPatch":true,"sender":{"key":"l.s.r@web.de","avatar":"https://avatars.githubusercontent.com/u/26122331?v=4"},"body":"Reported in http://qa.debian.org/daca/cppcheck/sid/git_1.7.2.3-2.2.html.\n\nSigned-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>\n---\n xdiff-interface.c |    4 +++-\n 1 files changed, 3 insertions(+), 1 deletions(-)\n\ndiff --git a/xdiff-interface.c b/xdiff-interface.c\nindex cd2285d..cd9fa33 100644\n--- a/xdiff-interface.c\n+++ b/xdiff-interface.c\n@@ -212,8 +212,10 @@ int read_mmfile(mmfile_t *ptr, const char *filename)\n \t\treturn error(\"Could not open %s\", filename);\n \tsz = xsize_t(st.st_size);\n \tptr->ptr = xmalloc(sz ? sz : 1);\n-\tif (sz && fread(ptr->ptr, sz, 1, f) != 1)\n+\tif (sz && fread(ptr->ptr, sz, 1, f) != 1) {\n+\t\tfclose(f);\n \t\treturn error(\"Could not read %s\", filename);\n+\t}\n \tfclose(f);\n \tptr->size = sz;\n \treturn 0;\n-- \n1.7.3.4\n"},{"id":"158573","messageId":"4D15E748.8020102@lsrfire.ath.cx","threadId":"26136","inReplyTo":"4D15E5D6.2040800@lsrfire.ath.cx","subject":"Re: [PATCH] close file on error in read_mmfile()","fromName":"René Scharfe","fromEmail":"rene.scharfe@lsrfire.ath.cx","sentAt":"2010-12-25T12:44:56Z","receivedAt":"2010-12-25T12:44:56Z","isPatch":true,"sender":{"key":"l.s.r@web.de","avatar":"https://avatars.githubusercontent.com/u/26122331?v=4"},"body":"Am 25.12.2010 13:38, schrieb René Scharfe:\n> Reported in http://qa.debian.org/daca/cppcheck/sid/git_1.7.2.3-2.2.html.\n\nOh, and also in http://thread.gmane.org/gmane.comp.version-control.git/123042.\n\nRené\n"},{"id":"158596","messageId":"7v8vzcz6kb.fsf@alter.siamese.dyndns.org","threadId":"26136","inReplyTo":"4D15E5D6.2040800@lsrfire.ath.cx","subject":"Re: [PATCH] close file on error in read_mmfile()","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-12-26T19:18:28Z","receivedAt":"2010-12-26T19:18:28Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks.\n"}]}