{"thread":{"id":"26128","subject":"[PATCH 1/3] Makefile: add NO_FNMATCH_CASEFOLD to IRIX sections","startedAt":"2010-12-22T23:58:51Z","lastAt":"2010-12-23T16:45:56Z","messageCount":7,"participants":["Brandon Casey","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":3},"messages":[{"id":"158513","messageId":"jpN7nm-rtl4sNXi5qt9pXMafcDOI0AxF95o77x_r5JQwZeaH94BApUuIwonUaYfzmYTgqeFNpSm6S7VFnIZVag@cipher.nrlssc.navy.mil","threadId":"26128","inReplyTo":null,"subject":"[PATCH 1/3] Makefile: add NO_FNMATCH_CASEFOLD to IRIX sections","fromName":"Brandon Casey","fromEmail":"casey@nrlssc.navy.mil","sentAt":"2010-12-22T23:58:51Z","receivedAt":"2010-12-22T23:58:51Z","isPatch":true,"sender":{"key":"drafnel@gmail.com","avatar":"https://avatars.githubusercontent.com/u/921167?v=4"},"body":"From: Brandon Casey \n\nIRIX's fnmatch() does not support the GNU FNM_CASEFOLD extension, so set\nNO_FNMATCH_CASEFOLD so that the internal fnmatch implementation will be\nused.\n\nSigned-off-by: Brandon Casey \n---\n Makefile | 2 ++\n 1 files changed, 2 insertions(+), 0 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 57d9c65..ff35154 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1003,6 +1003,7 @@ ifeq ($(uname_S),IRIX)\n \t# issue, comment out the NO_MMAP statement.\n \tNO_MMAP = YesPlease\n \tNO_REGEX = YesPlease\n+\tNO_FNMATCH_CASEFOLD = YesPlease\n \tSNPRINTF_RETURNS_BOGUS = YesPlease\n \tSHELL_PATH = /usr/gnu/bin/bash\n \tNEEDS_LIBGEN = YesPlease\n@@ -1022,6 +1023,7 @@ ifeq ($(uname_S),IRIX64)\n \t# issue, comment out the NO_MMAP statement.\n \tNO_MMAP = YesPlease\n \tNO_REGEX = YesPlease\n+\tNO_FNMATCH_CASEFOLD = YesPlease\n \tSNPRINTF_RETURNS_BOGUS = YesPlease\n \tSHELL_PATH=/usr/gnu/bin/bash\n \tNEEDS_LIBGEN = YesPlease\n-- \n1.7.3.1\n"},{"id":"158514","messageId":"jpN7nm-rtl4sNXi5qt9pXMHyBTgpDCv8-V01kCtiJEBPqOcDSM23hxN4tPbRHKxs9OccFdSHwdWDxm1VEOf_Ag@cipher.nrlssc.navy.mil","threadId":"26128","inReplyTo":"jpN7nm-rtl4sNXi5qt9pXMafcDOI0AxF95o77x_r5JQwZeaH94BApUuIwonUaYfzmYTgqeFNpSm6S7VFnIZVag@cipher.nrlssc.navy.mil","subject":"[PATCH 2/3] test-lib.sh/test_decode_color(): use octal not hex in awk script","fromName":"Brandon Casey","fromEmail":"casey@nrlssc.navy.mil","sentAt":"2010-12-22T23:58:52Z","receivedAt":"2010-12-22T23:58:52Z","isPatch":true,"sender":{"key":"drafnel@gmail.com","avatar":"https://avatars.githubusercontent.com/u/921167?v=4"},"body":"From: Brandon Casey \n\nPOSIX awk seems to explicitly not support hexadecimal escape sequences.\n\n>From http://pubs.opengroup.org/onlinepubs/009695399/:\n\n Regular expressions in awk have been extended somewhat...\n One sequence that is not supported is hexadecimal value escapes\n beginning with '\\x'.\n\nThis affects the awk on IRIX 6.5, and causes t4015.56 to fail.\nUse octal instead.\n\nSigned-off-by: Brandon Casey \n---\n t/test-lib.sh | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/t/test-lib.sh b/t/test-lib.sh\nindex 48fa516..cb1ca97 100644\n--- a/t/test-lib.sh\n+++ b/t/test-lib.sh\n@@ -260,7 +260,7 @@ test_decode_color () {\n \t\t\tif (n == 47) return \"BWHITE\";\n \t\t}\n \t\t{\n-\t\t\twhile (match($0, /\\x1b\\[[0-9;]*m/) != 0) {\n+\t\t\twhile (match($0, /\\033\\[[0-9;]*m/) != 0) {\n \t\t\t\tprintf \"%s<\", substr($0, 1, RSTART-1);\n \t\t\t\tcodes = substr($0, RSTART+2, RLENGTH-3);\n \t\t\t\tif (length(codes) == 0)\n-- \n1.7.3.1\n"},{"id":"158515","messageId":"jpN7nm-rtl4sNXi5qt9pXHOvlLOZP9xRq2h9eZev444l6GTi02jDn5C-Llxwsz3_tVhVKGvU5Vryto5cM6uchw@cipher.nrlssc.navy.mil","threadId":"26128","inReplyTo":"jpN7nm-rtl4sNXi5qt9pXMafcDOI0AxF95o77x_r5JQwZeaH94BApUuIwonUaYfzmYTgqeFNpSm6S7VFnIZVag@cipher.nrlssc.navy.mil","subject":"[PATCH 3/3] t9001: use older Getopt::Long boolean prefix '--no' rather than '--no-'","fromName":"Brandon Casey","fromEmail":"casey@nrlssc.navy.mil","sentAt":"2010-12-22T23:58:53Z","receivedAt":"2010-12-22T23:58:53Z","isPatch":true,"sender":{"key":"drafnel@gmail.com","avatar":"https://avatars.githubusercontent.com/u/921167?v=4"},"body":"From: Brandon Casey \n\nThe '--no-chain-reply-to' option is a Getopt::Long boolean option. The\n'--no-' prefix (as in --no-chain-reply-to) for boolean options is not\nsupported in Getopt::Long version 2.32 which was released with Perl 5.8.0.\nThis version only supports '--no' as in '--nochain-reply-to'. More recent\nversions of Getopt::Long, such as version 2.34, support either prefix. So\nuse the older form in the tests.\n\nSee also:\n\n907a0b1e04ea31cb368e9422df93d8ebb0187914\n84eeb687de7a6c7c42af3fb51b176e0f412a979e\n3fee1fe87144360a1913eab86af9ad136c810076\n\nSigned-off-by: Brandon Casey \n---\n t/t9001-send-email.sh | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh\nindex 5e48318..1dc4a92 100755\n--- a/t/t9001-send-email.sh\n+++ b/t/t9001-send-email.sh\n@@ -319,7 +319,7 @@ test_expect_success $PREREQ 'In-Reply-To without --chain-reply-to' '\n \tgit send-email \\\n \t\t--from=\"Example \" \\\n \t\t--to=nobody@example.com \\\n-\t\t--no-chain-reply-to \\\n+\t\t--nochain-reply-to \\\n \t\t--in-reply-to=\"$(cat expect)\" \\\n \t\t--smtp-server=\"$(pwd)/fake.sendmail\" \\\n \t\t$patches $patches $patches \\\n-- \n1.7.3.1\n"},{"id":"158519","messageId":"7v1v593zqm.fsf@alter.siamese.dyndns.org","threadId":"26128","inReplyTo":"jpN7nm-rtl4sNXi5qt9pXMafcDOI0AxF95o77x_r5JQwZeaH94BApUuIwonUaYfzmYTgqeFNpSm6S7VFnIZVag@cipher.nrlssc.navy.mil","subject":"Re: [PATCH 1/3] Makefile: add NO_FNMATCH_CASEFOLD to IRIX sections","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-12-23T04:00:17Z","receivedAt":"2010-12-23T04:00:17Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks; I am unsure about the third one, though (see a separate message).\n"},{"id":"158524","messageId":"zy7kxYe02EOMfCsGsVyjMzgieNRubObUixqwhn2X3w5mEIOhOfAbzQ@cipher.nrlssc.navy.mil","threadId":"26128","inReplyTo":"7v1v593zqm.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH 1/3] Makefile: add NO_FNMATCH_CASEFOLD to IRIX sections","fromName":"Brandon Casey","fromEmail":"casey@nrlssc.navy.mil","sentAt":"2010-12-23T15:33:38Z","receivedAt":"2010-12-23T15:33:38Z","isPatch":true,"sender":{"key":"drafnel@gmail.com","avatar":"https://avatars.githubusercontent.com/u/921167?v=4"},"body":"On 12/22/2010 10:00 PM, Junio C Hamano wrote:\n> Thanks; I am unsure about the third one, though (see a separate message).\n\nI haven't received a separate message about the 3rd patch.\nNot sure if you sent it out yet, but fyi.\n\n-Brandon\n"},{"id":"158527","messageId":"7vlj3g326l.fsf@alter.siamese.dyndns.org","threadId":"26128","inReplyTo":"jpN7nm-rtl4sNXi5qt9pXHOvlLOZP9xRq2h9eZev444l6GTi02jDn5C-Llxwsz3_tVhVKGvU5Vryto5cM6uchw@cipher.nrlssc.navy.mil","subject":"Re: [PATCH 3/3] t9001: use older Getopt::Long boolean prefix '--no' rather than '--no-'","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-12-23T16:05:06Z","receivedAt":"2010-12-23T16:05:06Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"This still leaves --no-bcc, --no-to and --no-cc in \"no-foo overrides\nsendemail.foo\" tests, it seems. Do they also need to be fixed?\n"},{"id":"158529","messageId":"_1hzkErx0quc_gF2Ej78xfngJOZd0RMiZQaYIRcFD87zYn8eAiFJUQ@cipher.nrlssc.navy.mil","threadId":"26128","inReplyTo":"7vlj3g326l.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH 3/3] t9001: use older Getopt::Long boolean prefix '--no' rather than '--no-'","fromName":"Brandon Casey","fromEmail":"casey@nrlssc.navy.mil","sentAt":"2010-12-23T16:45:56Z","receivedAt":"2010-12-23T16:45:56Z","isPatch":true,"sender":{"key":"drafnel@gmail.com","avatar":"https://avatars.githubusercontent.com/u/921167?v=4"},"body":"On 12/23/2010 10:05 AM, Junio C Hamano wrote:\n> This still leaves --no-bcc, --no-to and --no-cc in \"no-foo overrides\n> sendemail.foo\" tests, it seems. Do they also need to be fixed?\n\nNo, those are handled completely separately. The --chainreplyto\noption is a boolean option, and the '--no' prefix is an automatic\nfeature that is provided by Getopt::Long for boolean options (i.e.\nthose suffixed with '!').\n\nThe three options you mentioned are actually distinct options that\nare configured in the call to GetOptions and are named so that they\nappear to be 'no-' prefixed automatic versions of --bcc, --to, and\n--cc, just like the boolean options. But there is really just a\nseparate option named --no-bcc, that sets the variable $no_bcc that\nis distinct from the --bcc option which populates @bcclist.\n\nSo, people with a somewhat old Getopt::Long (or those accustomed\nto prefixing '--no' without the dash) may get confused when they\nhave to leave off the dash when negating --chainreplyto as\n--nochainreplyto, but _must_ use the dash when typing --no-bcc.\nIf we want to be consistent with Getopt::Long which accepts both\n'--no-' and '--no', then we could add --nobcc, --noto, and --nocc.\nNot sure if it's worth the trouble.\n\n-Brandon\n"}]}