{"thread":{"id":"26090","subject":"1.7.3.4 build regression","startedAt":"2010-12-17T03:31:19Z","lastAt":"2010-12-17T04:17:51Z","messageCount":3,"participants":["Jeremy Huddleston","Jonathan Nieder"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"158259","messageId":"8779CB66-03D3-4EC9-8650-521532112CA5@apple.com","threadId":"26090","inReplyTo":null,"subject":"1.7.3.4 build regression","fromName":"Jeremy Huddleston","fromEmail":"jeremyhu@apple.com","sentAt":"2010-12-17T03:31:19Z","receivedAt":"2010-12-17T03:31:19Z","isPatch":false,"sender":{"key":"jeremyhu@apple.com","avatar":"https://avatars.githubusercontent.com/u/1258676?v=4"},"body":"1.7.3.4 seems to have a regression (over 1.7.3.2 ... didn't try 1.7.3.3) building.  I do:\nmake\n(strip the built executables)\nmake install\n\nDuring 'make install', the executables get remade even though they shouldn't be.  My guess is that a Makefile dependency cycle has been added, but I haven't looked into it in detail yet.  Is this a known issue?\n"},{"id":"158261","messageId":"21774743-8BA8-4A1C-BDCF-1E3F7D85EFB5@apple.com","threadId":"26090","inReplyTo":"20101217034123.GA7362@burratino","subject":"Re: 1.7.3.4 build regression","fromName":"Jeremy Huddleston","fromEmail":"jeremyhu@apple.com","sentAt":"2010-12-17T04:02:33Z","receivedAt":"2010-12-17T04:02:33Z","isPatch":false,"sender":{"key":"jeremyhu@apple.com","avatar":"https://avatars.githubusercontent.com/u/1258676?v=4"},"body":"On Dec 16, 2010, at 19:41, Jonathan Nieder wrote:\n\n> Hi Jeremy,\n> \n> Jeremy Huddleston wrote:\n> \n>> 1.7.3.4 seems to have a regression (over 1.7.3.2 ... didn't try 1.7.3.3)\n>> building.  I do:\n>> \n>> make\n>> (strip the built executables)\n>> make install\n>> \n>> During 'make install', the executables get remade even though they\n>> shouldn't be.\n> \n> Just a wild guess: do you pass CC on the \"make\" and not the \"make\n> install\" command line?\n\nYes.  Good guess.  Why would that be affecting it?\n\nSome updates:\n\nIt occurs with 1.7.3.3 as well.\n\n\"make\" line is:\n/Developer/usr/bin/make -C /tmp/Git-16.roots/Git-16~obj/i386/ -j`sysctl -n hw.activecpu` prefix=/usr NO_FINK=YesPlease NO_DARWIN_PORTS=YesPlease RUNTIME_PREFIX=YesPlease GITGUI_VERSION=0.12.0 V=1 CFLAGS='-ggdb3 -Os -pipe -Wall -Wformat-security -D_FORTIFY_SOURCE=2' 'CC=cc -arch i386' 'uname_M=i386' 'uname_P=i386' && touch /tmp/Git-16.roots/Git-16~obj/i386/build.timestamp\n\n\"make install\" line is:\n/Developer/usr/bin/make -C /tmp/Git-16.roots/Git-16~obj/i386 -j`sysctl -n hw.activecpu` prefix=/usr NO_FINK=YesPlease NO_DARWIN_PORTS=YesPlease RUNTIME_PREFIX=YesPlease GITGUI_VERSION=0.12.0 V=1 CFLAGS='-ggdb3 -Os -pipe -Wall -Wformat-security -D_FORTIFY_SOURCE=2' \\          'DESTDIR=/tmp/Git-16.roots/Git-16~dst' \\\n          install\n"},{"id":"158262","messageId":"20101217041750.GA7649@burratino","threadId":"26090","inReplyTo":"21774743-8BA8-4A1C-BDCF-1E3F7D85EFB5@apple.com","subject":"Re: 1.7.3.4 build regression","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2010-12-17T04:17:51Z","receivedAt":"2010-12-17T04:17:51Z","isPatch":false,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Jeremy Huddleston wrote:\n> On Dec 16, 2010, at 19:41, Jonathan Nieder wrote:\n>> Jeremy Huddleston wrote:\n\n>>> make\n>>> (strip the built executables)\n>>> make install\n>>>\n>>> During 'make install', the executables get remade even though they\n>>> shouldn't be.\n>>\n>> Just a wild guess: do you pass CC on the \"make\" and not the \"make\n>> install\" command line?\n>\n> Yes.  Good guess.  Why would that be affecting it?\n\nSee v1.7.3.3~28^2 (Makefile: add CC to TRACK_CFLAGS, 2010-09-12),\nfound with \"git log --no-merges v1.7.3.2..v1.7.3.4 -- Makefile\".\nThat is, now CC is tracked like $prefix and $CFLAGS are.\n\nThe idea of that change was presumably that if you switch CC from,\nsay, \"gcc -m32\" to \"gcc -m64\", then the build result will not be\ncorrect unless you remake things.  I have mixed feelings about it,\nsince from time to time I might want to switch between gcc-4.4 and\ngcc-4.5 without rebuilding everything.\n\n> \"make\" line is:\n> /Developer/usr/bin/make -C /tmp/Git-16.roots/Git-16~obj/i386/ \\\n>\t-j`sysctl -n hw.activecpu` \\\n>\tprefix=/usr NO_FINK=YesPlease NO_DARWIN_PORTS=YesPlease \\\n>\tRUNTIME_PREFIX=YesPlease \\\n>\tGITGUI_VERSION=0.12.0 V=1 \\\n>\tCFLAGS='-ggdb3 -Os -pipe -Wall -Wformat-security -D_FORTIFY_SOURCE=2' \\\n>\t'CC=cc -arch i386' 'uname_M=i386' 'uname_P=i386'\n\nInteresting.  It might be convenient to save these variables in\n/tmp/Git-16.roots/Git-16~obj/i386/config.mak.\n\nThanks for reporting.  Some thinking to do.\n"}]}