{"thread":{"id":"26085","subject":"[PATCH 0/3] minor gitweb modifications","startedAt":"2010-11-16T23:02:47Z","lastAt":"2010-12-20T12:04:42Z","messageCount":12,"participants":["Sylvain Rabot","Jakub Narebski","Drew Northup"],"isPatch":true,"patchVersion":1,"patchTotal":3},"messages":[{"id":"158239","messageId":"201011170002.47678.jnareb@gmail.com","threadId":"26085","inReplyTo":"1292539020.2511.6.camel@kheops","subject":"Re: [PATCH 3/3] gitweb: remove test when closing file descriptor","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2010-11-16T23:02:47Z","receivedAt":"2010-11-16T23:02:47Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"On Thu, 16 Dec 2010, Sylvain Rabot wrote:\n> On Thu, 2010-12-16 at 14:30 -0800, Jakub Narebski wrote:\n> > Sylvain Rabot writes:\n> > \n> > > it happens that closing file descriptor fails whereas\n> > > the blob is perfectly readable.\n> > > \n> > > Signed-off-by: Sylvain Rabot \n> > > ---\n[...]\n> > > -\tclose $fd\n> > > -\t\tor die_error(404, \"Reading blob failed\");\n> > > +\tclose $fd;\n\n[...]\n> > In this place we close read end of pipe after at most reading a few\n> > bytes (what -T test does), so what might happen is that writer got\n> > SIGPIPE and \"failed\". But we are not interested in this, so we can\n> > safely ignore return from 'close'.\n> > \n> > I think that some from above explanation should make it to commit\n> > message.\n> \n> Thanks for explaining it, I did not have any idea why it was failing.\n> Can I use your explanation as commit message ?\n\nOf course.\n\nThough I am not sure if it is really the reason, it looks reasonable.\n\n-- \nJakub Narebski\nPoland\n"},{"id":"158217","messageId":"1292535801-7421-1-git-send-email-sylvain@abstraction.fr","threadId":"26085","inReplyTo":null,"subject":"[PATCH 0/3] minor gitweb modifications","fromName":"Sylvain Rabot","fromEmail":"sylvain@abstraction.fr","sentAt":"2010-12-16T21:43:18Z","receivedAt":"2010-12-16T21:43:18Z","isPatch":true,"sender":{"key":"sylvain@abstraction.fr","avatar":"https://avatars.githubusercontent.com/u/153052?v=4"},"body":"Hi,\n\nhere a three patch serie with minor updates for gitweb based on master.\n\nI'm not really fond of the third patch but it solves a problem\nI've encountered on several files.\n\nRegards.\n\nSylvain Rabot (3):\n gitweb: add extensions to highlight feature\n gitweb: decorate a bit more remotes\n gitweb: remove test when closing file descriptor\n\n gitweb/gitweb.perl | 18 +++++++++---------\n 1 files changed, 9 insertions(+), 9 deletions(-)\n\n-- \n1.7.3.2\n"},{"id":"158219","messageId":"1292535801-7421-2-git-send-email-sylvain@abstraction.fr","threadId":"26085","inReplyTo":"1292535801-7421-1-git-send-email-sylvain@abstraction.fr","subject":"[PATCH 1/3] gitweb: add extensions to highlight feature","fromName":"Sylvain Rabot","fromEmail":"sylvain@abstraction.fr","sentAt":"2010-12-16T21:43:19Z","receivedAt":"2010-12-16T21:43:19Z","isPatch":true,"sender":{"key":"sylvain@abstraction.fr","avatar":"https://avatars.githubusercontent.com/u/153052?v=4"},"body":"added: sql, php5, phps, bash, zsh, mk\n\nSigned-off-by: Sylvain Rabot \n---\n gitweb/gitweb.perl | 7 ++++---\n 1 files changed, 4 insertions(+), 3 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex d521c93..db18d06 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -250,13 +250,14 @@ our %highlight_ext = (\n \t# main extensions, defining name of syntax;\n \t# see files in /usr/share/highlight/langDefs/ directory\n \tmap { $_ => $_ }\n-\t\tqw(py c cpp rb java css php sh pl js tex bib xml awk bat ini spec tcl),\n+\t\tqw(py c cpp rb java css php pl js tex bib xml awk bat ini spec tcl sql),\n \t# alternate extensions, see /etc/highlight/filetypes.conf\n \t'h' => 'c',\n+\tmap { $_ => 'sh' } qw(bash zsh),\n \tmap { $_ => 'cpp' } qw(cxx c++ cc),\n-\tmap { $_ => 'php' } qw(php3 php4),\n+\tmap { $_ => 'php' } qw(php3 php4 php5 phps),\n \tmap { $_ => 'pl' } qw(perl pm), # perhaps also 'cgi'\n-\t'mak' => 'make',\n+\tmap { $_ => 'make'} qw(mak mk),\n \tmap { $_ => 'xml' } qw(xhtml html htm),\n );\n \n-- \n1.7.3.2\n"},{"id":"158220","messageId":"1292535801-7421-3-git-send-email-sylvain@abstraction.fr","threadId":"26085","inReplyTo":"1292535801-7421-1-git-send-email-sylvain@abstraction.fr","subject":"[PATCH 2/3] gitweb: decorate a bit more remotes","fromName":"Sylvain Rabot","fromEmail":"sylvain@abstraction.fr","sentAt":"2010-12-16T21:43:20Z","receivedAt":"2010-12-16T21:43:20Z","isPatch":true,"sender":{"key":"sylvain@abstraction.fr","avatar":"https://avatars.githubusercontent.com/u/153052?v=4"},"body":"Signed-off-by: Sylvain Rabot \n---\n gitweb/gitweb.perl | 8 ++++----\n 1 files changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex db18d06..9398475 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -5127,13 +5127,13 @@ sub git_remote_block {\n \n \tif (defined $fetch) {\n \t\tif ($fetch eq $push) {\n-\t\t\t$urls_table .= format_repo_url(\"URL\", $fetch);\n+\t\t\t$urls_table .= format_repo_url(\"URL:\", $fetch);\n \t\t} else {\n-\t\t\t$urls_table .= format_repo_url(\"Fetch URL\", $fetch);\n-\t\t\t$urls_table .= format_repo_url(\"Push URL\", $push) if defined $push;\n+\t\t\t$urls_table .= format_repo_url(\"Fetch URL:\", $fetch);\n+\t\t\t$urls_table .= format_repo_url(\"Push URL:\", $push) if defined $push;\n \t\t}\n \t} elsif (defined $push) {\n-\t\t$urls_table .= format_repo_url(\"Push URL\", $push);\n+\t\t$urls_table .= format_repo_url(\"Push URL:\", $push);\n \t} else {\n \t\t$urls_table .= format_repo_url(\"\", \"No remote URL\");\n \t}\n-- \n1.7.3.2\n"},{"id":"158218","messageId":"1292535801-7421-4-git-send-email-sylvain@abstraction.fr","threadId":"26085","inReplyTo":"1292535801-7421-1-git-send-email-sylvain@abstraction.fr","subject":"[PATCH 3/3] gitweb: remove test when closing file descriptor","fromName":"Sylvain Rabot","fromEmail":"sylvain@abstraction.fr","sentAt":"2010-12-16T21:43:21Z","receivedAt":"2010-12-16T21:43:21Z","isPatch":true,"sender":{"key":"sylvain@abstraction.fr","avatar":"https://avatars.githubusercontent.com/u/153052?v=4"},"body":"it happens that closing file descriptor fails whereas\nthe blob is perfectly readable.\n\nSigned-off-by: Sylvain Rabot \n---\n gitweb/gitweb.perl | 3 +--\n 1 files changed, 1 insertions(+), 2 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 9398475..9a885b1 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -3450,8 +3450,7 @@ sub run_highlighter {\n \tmy ($fd, $highlight, $syntax) = @_;\n \treturn $fd unless ($highlight && defined $syntax);\n \n-\tclose $fd\n-\t\tor die_error(404, \"Reading blob failed\");\n+\tclose $fd;\n \topen $fd, quote_command(git_cmd(), \"cat-file\", \"blob\", $hash).\" | \".\n \t quote_command($highlight_bin).\n \t \" --xhtml --fragment --syntax $syntax |\"\n-- \n1.7.3.2\n"},{"id":"158225","messageId":"m3y68slxj9.fsf@localhost.localdomain","threadId":"26085","inReplyTo":"1292535801-7421-2-git-send-email-sylvain@abstraction.fr","subject":"Re: [PATCH 1/3] gitweb: add extensions to highlight feature","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2010-12-16T22:22:37Z","receivedAt":"2010-12-16T22:22:37Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Sylvain Rabot writes:\n\n> added: sql, php5, phps, bash, zsh, mk\n> \n\nThere is one issue with this patch (see below), but otherwise I like\nit.\n\n> Signed-off-by: Sylvain Rabot \n> ---\n> gitweb/gitweb.perl | 7 ++++---\n> 1 files changed, 4 insertions(+), 3 deletions(-)\n> \n> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\n> index d521c93..db18d06 100755\n> --- a/gitweb/gitweb.perl\n> +++ b/gitweb/gitweb.perl\n> @@ -250,13 +250,14 @@ our %highlight_ext = (\n> \t# main extensions, defining name of syntax;\n> \t# see files in /usr/share/highlight/langDefs/ directory\n> \tmap { $_ => $_ }\n> -\t\tqw(py c cpp rb java css php sh pl js tex bib xml awk bat ini spec tcl),\n> +\t\tqw(py c cpp rb java css php pl js tex bib xml awk bat ini spec tcl sql),\n\nWhy did you remove 'sh' => 'sh' mapping? Shouldn't it be\n\n -\t\tqw(py c cpp rb java css php sh pl js tex bib xml awk bat ini spec tcl),\n +\t\tqw(py c cpp rb java css php sh pl js tex bib xml awk bat ini spec tcl sql),\n\n> \t# alternate extensions, see /etc/highlight/filetypes.conf\n> \t'h' => 'c',\n> +\tmap { $_ => 'sh' } qw(bash zsh),\n\nGood idea.\n\n> \tmap { $_ => 'cpp' } qw(cxx c++ cc),\n> -\tmap { $_ => 'php' } qw(php3 php4),\n> +\tmap { $_ => 'php' } qw(php3 php4 php5 phps),\n\nGood idea.\n\n> \tmap { $_ => 'pl' } qw(perl pm), # perhaps also 'cgi'\n> -\t'mak' => 'make',\n> +\tmap { $_ => 'make'} qw(mak mk),\n\nGood idea.\n\nSidenote: git itself uses *.mak extension. Is *.mk popular?\n\n> \tmap { $_ => 'xml' } qw(xhtml html htm),\n> );\n> \n> -- \n> 1.7.3.2\n> \n\n-- \nJakub Narebski\nPoland\nShadeHawk on #git\n"},{"id":"158226","messageId":"m3tyjglxi0.fsf@localhost.localdomain","threadId":"26085","inReplyTo":"1292535801-7421-3-git-send-email-sylvain@abstraction.fr","subject":"Re: [PATCH 2/3] gitweb: decorate a bit more remotes","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2010-12-16T22:23:32Z","receivedAt":"2010-12-16T22:23:32Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Sylvain Rabot writes:\n\n> Signed-off-by: Sylvain Rabot \n> ---\n> gitweb/gitweb.perl | 8 ++++----\n> 1 files changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\n> index db18d06..9398475 100755\n> --- a/gitweb/gitweb.perl\n> +++ b/gitweb/gitweb.perl\n> @@ -5127,13 +5127,13 @@ sub git_remote_block {\n> \n> \tif (defined $fetch) {\n> \t\tif ($fetch eq $push) {\n> -\t\t\t$urls_table .= format_repo_url(\"URL\", $fetch);\n> +\t\t\t$urls_table .= format_repo_url(\"URL:\", $fetch);\n\nI would really prefer to use CSS for that...\n\n-- \nJakub Narebski\nPoland\nShadeHawk on #git\n"},{"id":"158227","messageId":"m3pqu4lx6n.fsf@localhost.localdomain","threadId":"26085","inReplyTo":"1292535801-7421-4-git-send-email-sylvain@abstraction.fr","subject":"Re: [PATCH 3/3] gitweb: remove test when closing file descriptor","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2010-12-16T22:30:05Z","receivedAt":"2010-12-16T22:30:05Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Sylvain Rabot writes:\n\n> it happens that closing file descriptor fails whereas\n> the blob is perfectly readable.\n> \n> Signed-off-by: Sylvain Rabot \n> ---\n> gitweb/gitweb.perl | 3 +--\n> 1 files changed, 1 insertions(+), 2 deletions(-)\n> \n> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\n> index 9398475..9a885b1 100755\n> --- a/gitweb/gitweb.perl\n> +++ b/gitweb/gitweb.perl\n> @@ -3450,8 +3450,7 @@ sub run_highlighter {\n> \tmy ($fd, $highlight, $syntax) = @_;\n> \treturn $fd unless ($highlight && defined $syntax);\n> \n> -\tclose $fd\n> -\t\tor die_error(404, \"Reading blob failed\");\n> +\tclose $fd;\n\nActually what I think happens is the following. \"close $fh\" cannot\nusually fail, unless (`perldoc -f close`):\n\n If the file handle came from a piped open, \"close\" will additionally\n return false if one of the other system calls involved fails, or if the\n program exits with non-zero status. (If the only problem was that the\n program exited non-zero, $! will be set to 0.) Closing a pipe also waits\n for the process executing on the pipe to complete, in case you want to\n look at the output of the pipe afterwards, and implicitly puts the exit\n status value of that command into $?.\n\n Prematurely closing the read end of a pipe (i.e. before the process writ-\n ing to it at the other end has closed it) will result in a SIGPIPE being\n delivered to the writer. If the other end can't handle that, be sure to\n read all the data before closing the pipe.\n\nIn this place we close read end of pipe after at most reading a few\nbytes (what -T test does), so what might happen is that writer got\nSIGPIPE and \"failed\". But we are not interested in this, so we can\nsafely ignore return from 'close'.\n\nI think that some from above explanation should make it to commit\nmessage.\n\n> \topen $fd, quote_command(git_cmd(), \"cat-file\", \"blob\", $hash).\" | \".\n> \t quote_command($highlight_bin).\n> \t \" --xhtml --fragment --syntax $syntax |\"\n\nP.S. A better solution would be to redirect opened $fd to highlighter,\ninstead of closing and reopening a pipe... but I'm not sure how it\ncould be implemented.\n\n-- \nJakub Narebski\nPoland\nShadeHawk on #git\n"},{"id":"158228","messageId":"1292538804.2511.4.camel@kheops","threadId":"26085","inReplyTo":"m3y68slxj9.fsf@localhost.localdomain","subject":"Re: [PATCH 1/3] gitweb: add extensions to highlight feature","fromName":"Sylvain Rabot","fromEmail":"sylvain@abstraction.fr","sentAt":"2010-12-16T22:33:24Z","receivedAt":"2010-12-16T22:33:24Z","isPatch":true,"sender":{"key":"sylvain@abstraction.fr","avatar":"https://avatars.githubusercontent.com/u/153052?v=4"},"body":"On Thu, 2010-12-16 at 14:22 -0800, Jakub Narebski wrote:\n> Sylvain Rabot writes:\n> \n> > added: sql, php5, phps, bash, zsh, mk\n> > \n> \n> There is one issue with this patch (see below), but otherwise I like\n> it.\n> \n> > Signed-off-by: Sylvain Rabot \n> > ---\n> > gitweb/gitweb.perl | 7 ++++---\n> > 1 files changed, 4 insertions(+), 3 deletions(-)\n> > \n> > diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\n> > index d521c93..db18d06 100755\n> > --- a/gitweb/gitweb.perl\n> > +++ b/gitweb/gitweb.perl\n> > @@ -250,13 +250,14 @@ our %highlight_ext = (\n> > \t# main extensions, defining name of syntax;\n> > \t# see files in /usr/share/highlight/langDefs/ directory\n> > \tmap { $_ => $_ }\n> > -\t\tqw(py c cpp rb java css php sh pl js tex bib xml awk bat ini spec tcl),\n> > +\t\tqw(py c cpp rb java css php pl js tex bib xml awk bat ini spec tcl sql),\n> \n> Why did you remove 'sh' => 'sh' mapping? Shouldn't it be\n> \n> -\t\tqw(py c cpp rb java css php sh pl js tex bib xml awk bat ini spec tcl),\n> +\t\tqw(py c cpp rb java css php sh pl js tex bib xml awk bat ini spec tcl sql),\n> \n\nI removed it on purpose but should have not, I was thinking\nthe mapping made below would be enough but no, you're right.\n\n> > \t# alternate extensions, see /etc/highlight/filetypes.conf\n> > \t'h' => 'c',\n> > +\tmap { $_ => 'sh' } qw(bash zsh),\n> \n> Good idea.\n\nDoes ksh, csh can be highlighted as sh too ?\n\n> \n> > \tmap { $_ => 'cpp' } qw(cxx c++ cc),\n> > -\tmap { $_ => 'php' } qw(php3 php4),\n> > +\tmap { $_ => 'php' } qw(php3 php4 php5 phps),\n> \n> Good idea.\n> \n> > \tmap { $_ => 'pl' } qw(perl pm), # perhaps also 'cgi'\n> > -\t'mak' => 'make',\n> > +\tmap { $_ => 'make'} qw(mak mk),\n> \n> Good idea.\n> \n> Sidenote: git itself uses *.mak extension. Is *.mk popular?\n\nDon't know but mk is mapped to Makefiles in the gtksourceview lib so I\nadded it here.\n\n> \n> > \tmap { $_ => 'xml' } qw(xhtml html htm),\n> > );\n> > \n> > -- \n> > 1.7.3.2\n> > \n> \n\n\n-- \nSylvain Rabot \n"},{"id":"158229","messageId":"1292539020.2511.6.camel@kheops","threadId":"26085","inReplyTo":"m3pqu4lx6n.fsf@localhost.localdomain","subject":"Re: [PATCH 3/3] gitweb: remove test when closing file descriptor","fromName":"Sylvain Rabot","fromEmail":"sylvain@abstraction.fr","sentAt":"2010-12-16T22:37:00Z","receivedAt":"2010-12-16T22:37:00Z","isPatch":true,"sender":{"key":"sylvain@abstraction.fr","avatar":"https://avatars.githubusercontent.com/u/153052?v=4"},"body":"On Thu, 2010-12-16 at 14:30 -0800, Jakub Narebski wrote:\n> Sylvain Rabot writes:\n> \n> > it happens that closing file descriptor fails whereas\n> > the blob is perfectly readable.\n> > \n> > Signed-off-by: Sylvain Rabot \n> > ---\n> > gitweb/gitweb.perl | 3 +--\n> > 1 files changed, 1 insertions(+), 2 deletions(-)\n> > \n> > diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\n> > index 9398475..9a885b1 100755\n> > --- a/gitweb/gitweb.perl\n> > +++ b/gitweb/gitweb.perl\n> > @@ -3450,8 +3450,7 @@ sub run_highlighter {\n> > \tmy ($fd, $highlight, $syntax) = @_;\n> > \treturn $fd unless ($highlight && defined $syntax);\n> > \n> > -\tclose $fd\n> > -\t\tor die_error(404, \"Reading blob failed\");\n> > +\tclose $fd;\n> \n> Actually what I think happens is the following. \"close $fh\" cannot\n> usually fail, unless (`perldoc -f close`):\n> \n> If the file handle came from a piped open, \"close\" will additionally\n> return false if one of the other system calls involved fails, or if the\n> program exits with non-zero status. (If the only problem was that the\n> program exited non-zero, $! will be set to 0.) Closing a pipe also waits\n> for the process executing on the pipe to complete, in case you want to\n> look at the output of the pipe afterwards, and implicitly puts the exit\n> status value of that command into $?.\n> \n> Prematurely closing the read end of a pipe (i.e. before the process writ-\n> ing to it at the other end has closed it) will result in a SIGPIPE being\n> delivered to the writer. If the other end can't handle that, be sure to\n> read all the data before closing the pipe.\n> \n> In this place we close read end of pipe after at most reading a few\n> bytes (what -T test does), so what might happen is that writer got\n> SIGPIPE and \"failed\". But we are not interested in this, so we can\n> safely ignore return from 'close'.\n> \n> I think that some from above explanation should make it to commit\n> message.\n\nThanks for explaining it, I did not have any idea why it was failing.\nCan I use your explanation as commit message ?\n\n> \n> > \topen $fd, quote_command(git_cmd(), \"cat-file\", \"blob\", $hash).\" | \".\n> > \t quote_command($highlight_bin).\n> > \t \" --xhtml --fragment --syntax $syntax |\"\n> \n> P.S. A better solution would be to redirect opened $fd to highlighter,\n> instead of closing and reopening a pipe... but I'm not sure how it\n> could be implemented.\n\nI don't know either.\n\n> \n\n\n-- \nSylvain Rabot \n"},{"id":"158274","messageId":"201012171217.24350.jnareb@gmail.com","threadId":"26085","inReplyTo":"1292538804.2511.4.camel@kheops","subject":"Re: [PATCH 1/3] gitweb: add extensions to highlight feature","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2010-12-17T11:17:23Z","receivedAt":"2010-12-17T11:17:23Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"On Thu, 16 Dec 2010, Sylvain Rabot wrote:\n> On Thu, 2010-12-16 at 14:22 -0800, Jakub Narebski wrote:\n> > Sylvain Rabot writes:\n\n> > > \t# alternate extensions, see /etc/highlight/filetypes.conf\n> > > \t'h' => 'c',\n> > > +\tmap { $_ => 'sh' } qw(bash zsh),\n> > \n> > Good idea.\n> \n> Does ksh, csh can be highlighted as sh too ?\n\nMy /etc/highlight/filetypes.conf does include only\n\n $ext(sh)=bash\n\nAll of bash, zsh and ksh are POSIX shell (sh) compatibile, so sh syntax\n(which is according to my /usr/share/highlight/langDefs/sh.lang file\n\"Bash script language definition file\" ;-)) should work. csh IIRC isn't.\nSo therefore I am not sure if csh can be highlighted correctly using sh\nsyntax.\n\n-- \nJakub Narebski\nPoland\n"},{"id":"158396","messageId":"1292846682.19322.4.camel@drew-northup.unet.maine.edu","threadId":"26085","inReplyTo":"m3tyjglxi0.fsf@localhost.localdomain","subject":"Re: [PATCH 2/3] gitweb: decorate a bit more remotes","fromName":"Drew Northup","fromEmail":"drew.northup@maine.edu","sentAt":"2010-12-20T12:04:42Z","receivedAt":"2010-12-20T12:04:42Z","isPatch":true,"sender":{"key":"drew.northup@maine.edu","avatar":"https://avatars.githubusercontent.com/u/18331571?v=4"},"body":"\nOn Thu, 2010-12-16 at 14:23 -0800, Jakub Narebski wrote:\n> Sylvain Rabot writes:\n> \n> > Signed-off-by: Sylvain Rabot \n> > ---\n> > gitweb/gitweb.perl | 8 ++++----\n> > 1 files changed, 4 insertions(+), 4 deletions(-)\n> > \n> > diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\n> > index db18d06..9398475 100755\n> > --- a/gitweb/gitweb.perl\n> > +++ b/gitweb/gitweb.perl\n> > @@ -5127,13 +5127,13 @@ sub git_remote_block {\n> > \n> > \tif (defined $fetch) {\n> > \t\tif ($fetch eq $push) {\n> > -\t\t\t$urls_table .= format_repo_url(\"URL\", $fetch);\n> > +\t\t\t$urls_table .= format_repo_url(\"URL:\", $fetch);\n> \n> I would really prefer to use CSS for that...\n\nAgreed; URL: is far more appropriate in my\nopinion.\n\n-- \n-Drew Northup N1XIM\n AKA RvnPhnx on OPN\n________________________________________________\n\"As opposed to vegetable or mineral error?\"\n-John Pescatore, SANS NewsBites Vol. 12 Num. 59\n"}]}