{"thread":{"id":"26059","subject":"[PATCH 06/14] t9501-*.sh: Fix a test failure on Cygwin","startedAt":"2010-12-14T18:26:38Z","lastAt":"2010-12-16T19:25:43Z","messageCount":3,"participants":["Ramsay Jones","Jakub Narebski"],"isPatch":true,"patchVersion":1,"patchTotal":14},"messages":[{"id":"158071","messageId":"4D07B6DE.8080400@ramsay1.demon.co.uk","threadId":"26059","inReplyTo":null,"subject":"[PATCH 06/14] t9501-*.sh: Fix a test failure on Cygwin","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2010-12-14T18:26:38Z","receivedAt":"2010-12-14T18:26:38Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nThe first (setup) test attempts to create a file, using the\ntest_commit function, called 'i can has snapshot?'. On cygwin\n(and MinGW) this fails with a \"No such file or directory\" error.\nIn order to fix the tests, we simply remove the '?' wildcard\nfrom the name, since the purpose of these tests is not about\ncreating funny filenames.\n\nSigned-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>\n---\n t/t9501-gitweb-standalone-http-status.sh |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/t/t9501-gitweb-standalone-http-status.sh b/t/t9501-gitweb-standalone-http-status.sh\nindex 2487da1..18825af 100755\n--- a/t/t9501-gitweb-standalone-http-status.sh\n+++ b/t/t9501-gitweb-standalone-http-status.sh\n@@ -16,7 +16,7 @@ code and message.'\n # snapshot settings\n \n test_expect_success 'setup' \"\n-\ttest_commit 'SnapshotTests' 'i can has snapshot?'\n+\ttest_commit 'SnapshotTests' 'i can has snapshot'\n \"\n \n \n-- \n1.7.3\n"},{"id":"158079","messageId":"201012142004.30322.jnareb@gmail.com","threadId":"26059","inReplyTo":"4D07B6DE.8080400@ramsay1.demon.co.uk","subject":"Re: [PATCH 06/14] t9501-*.sh: Fix a test failure on Cygwin","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2010-12-14T19:04:28Z","receivedAt":"2010-12-14T19:04:28Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Ramsay Jones wrote:\n> \n> The first (setup) test attempts to create a file, using the\n> test_commit function, called 'i can has snapshot?'. On cygwin\n> (and MinGW) this fails with a \"No such file or directory\" error.\n> In order to fix the tests, we simply remove the '?' wildcard\n> from the name, since the purpose of these tests is not about\n> creating funny filenames.\n> \n> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>\n\nAll right.\n\nAcked-by: Jakub Narebski <jnareb@gmail.com>\n\nBTW. if the test was about handling funny filenames (containing\nleading, embedded and trailing space, +&@=<>\"' characters), what\nshould we do instead?\n\n> ---\n>  t/t9501-gitweb-standalone-http-status.sh |    2 +-\n>  1 files changed, 1 insertions(+), 1 deletions(-)\n> \n> diff --git a/t/t9501-gitweb-standalone-http-status.sh b/t/t9501-gitweb-standalone-http-status.sh\n> index 2487da1..18825af 100755\n> --- a/t/t9501-gitweb-standalone-http-status.sh\n> +++ b/t/t9501-gitweb-standalone-http-status.sh\n> @@ -16,7 +16,7 @@ code and message.'\n>  # snapshot settings\n>  \n>  test_expect_success 'setup' \"\n> -\ttest_commit 'SnapshotTests' 'i can has snapshot?'\n> +\ttest_commit 'SnapshotTests' 'i can has snapshot'\n>  \"\n>  \n>  \n> -- \n> 1.7.3\n> \n> \n> \n\n-- \nJakub Narebski\nPoland\n"},{"id":"158230","messageId":"4D0A67B7.5010202@ramsay1.demon.co.uk","threadId":"26059","inReplyTo":"201012142004.30322.jnareb@gmail.com","subject":"Re: [PATCH 06/14] t9501-*.sh: Fix a test failure on Cygwin","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2010-12-16T19:25:43Z","receivedAt":"2010-12-16T19:25:43Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"Jakub Narebski wrote:\n> Ramsay Jones wrote:\n>> The first (setup) test attempts to create a file, using the\n>> test_commit function, called 'i can has snapshot?'. On cygwin\n>> (and MinGW) this fails with a \"No such file or directory\" error.\n>> In order to fix the tests, we simply remove the '?' wildcard\n>> from the name, since the purpose of these tests is not about\n>> creating funny filenames.\n>>\n>> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>\n> \n> All right.\n> \n> Acked-by: Jakub Narebski <jnareb@gmail.com>\n\nThanks.\n\n> BTW. if the test was about handling funny filenames (containing\n> leading, embedded and trailing space, +&@=<>\"' characters), what\n> should we do instead?\n\nHmm... dunno; take a look at t3600-rm.sh and t4135-apply-weird-filenames.sh\nfor inspiration? ;-)\n\nJust FYI the \"illegal\" pathname characters in windows include:\n    < > : \" / \\ | ? *\nalong with control chars from 0 - 31.\nAlso, you can't have any trailing spaces or periods.\n\nATB,\nRamsay Jones\n"}]}