{"thread":{"id":"26004","subject":"[PATCH] t9010 fails when no svn is available","startedAt":"2010-12-09T06:53:59Z","lastAt":"2010-12-09T08:39:40Z","messageCount":2,"participants":["Junio C Hamano","Ramkumar Ramachandra"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"157678","messageId":"7vmxofh1x4.fsf@alter.siamese.dyndns.org","threadId":"26004","inReplyTo":null,"subject":"[PATCH] t9010 fails when no svn is available","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-12-09T06:53:59Z","receivedAt":"2010-12-09T06:53:59Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Running test t9010 without svn currently errors out for no good reason.\n\nThe test uses \"svnadmin\" without checking if svn is available.  This was a\nregression introduced by b0ad24b (t9010 (svn-fe): Eliminate dependency on\nsvn perl bindings, 2010-10-10) when it stopped including ./lib-git-svn.sh\nthat had the safety.\n\nThis should fix it.\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>\n---\n t/t9010-svn-fe.sh |    6 ++++++\n 1 files changed, 6 insertions(+), 0 deletions(-)\n\ndiff --git a/t/t9010-svn-fe.sh b/t/t9010-svn-fe.sh\nindex fd851a4..faf9092 100755\n--- a/t/t9010-svn-fe.sh\n+++ b/t/t9010-svn-fe.sh\n@@ -4,6 +4,12 @@ test_description='check svn dumpfile importer'\n \n . ./test-lib.sh\n \n+if ! svnadmin -h >/dev/null 2>&1\n+then\n+\tskip_all='skipping svn-fe tests, svn not available'\n+\ttest_done\n+fi\n+\n svnconf=$PWD/svnconf\n export svnconf\n \n"},{"id":"157680","messageId":"20101209083938.GC21446@kytes","threadId":"26004","inReplyTo":"7vmxofh1x4.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] t9010 fails when no svn is available","fromName":"Ramkumar Ramachandra","fromEmail":"artagnon@gmail.com","sentAt":"2010-12-09T08:39:40Z","receivedAt":"2010-12-09T08:39:40Z","isPatch":true,"sender":{"key":"r@artagnon.com","avatar":"https://avatars.githubusercontent.com/u/37226?v=4"},"body":"Junio C Hamano writes:\n> Running test t9010 without svn currently errors out for no good reason.\n> \n> The test uses \"svnadmin\" without checking if svn is available.  This was a\n> regression introduced by b0ad24b (t9010 (svn-fe): Eliminate dependency on\n> svn perl bindings, 2010-10-10) when it stopped including ./lib-git-svn.sh\n> that had the safety.\n> \n> This should fix it.\n> \n> Signed-off-by: Junio C Hamano <gitster@pobox.com>\n\nRight. Thanks for catching this.\n\n-- Ram\n"}]}