{"thread":{"id":"26","subject":"Re: Misc fixes for git-pasky","startedAt":"2005-04-14T22:49:34Z","lastAt":"2005-04-14T22:49:34Z","messageCount":1,"participants":["Petr Baudis"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"146","messageId":"20050414224934.GO22699@pasky.ji.cz","threadId":"26","inReplyTo":"1113518277.8609.8.camel@dv","subject":"Re: Misc fixes for git-pasky","fromName":"Petr Baudis","fromEmail":"pasky@ucw.cz","sentAt":"2005-04-14T22:49:34Z","receivedAt":"2005-04-14T22:49:34Z","isPatch":false,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"Dear diary, on Fri, Apr 15, 2005 at 12:37:57AM CEST, I got a letter\nwhere Pavel Roskin <proski@gnu.org> told me that...\n> Hi, Petr!\n> \n> The attached patch against current git-pasky does following:\n\nHum. It does too much at once, that means I cannot apply it easily. :-(\n\n> * README: spell checked\n\nGood. :-)\n\n> * cache.h: Include unistd.h.  Needed for close() definition.  While\n> current zlib.h header includes unistd.h, it's not guaranteed to be so in\n> other zlib versions.\n\nSounds good.\n\n> * read-cache.c: Avoid C++ comments.  C comments are more readable for C\n> programmers.  Besides, we don't want git to be so unportable that \"gcc\n> -pedantic\" cannot compile it.\n\nI don't really care about this too much, although I personally prefer\nthe old-style comments. // comments are C99 so -pedantic by itself\nshould have no right to complain about it.\n\n> * show-diff.c: Fix handling of more than one option of the command line.\n\nWhat exactly does it fix? The current code seems fine to my sleepy\nbrain.\n\n> Add new option \"-c\" to omit checksums for modified files.  Expand help.\n\nHow is the -c option useful?\n\nCould you please send your patch with the correct inline settings on the\nattachment (or just in the mail body) and signed off?\n\nThanks,\n\n-- \n\t\t\t\tPetr \"Pasky\" Baudis\nStuff: http://pasky.or.cz/\nC++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor\n"}]}