{"thread":{"id":"25953","subject":"[PATCH 0/14] misc msvc patches","startedAt":"2010-12-04T18:49:49Z","lastAt":"2010-12-04T18:49:49Z","messageCount":1,"participants":["Ramsay Jones"],"isPatch":true,"patchVersion":1,"patchTotal":14},"messages":[{"id":"157310","messageId":"4CFA8D4D.2020500@ramsay1.demon.co.uk","threadId":"25953","inReplyTo":null,"subject":"[PATCH 0/14] misc msvc patches","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2010-12-04T18:49:49Z","receivedAt":"2010-12-04T18:49:49Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"Hi Junio,\n\nThe msvc build of git.git is currently broken; these patches fix\nthe build and suppress most of the *many* compiler warnings.\n[These patches are based on master @ 94fdb6f from 2 days ago]\n\n[PATCH 01/14] msvc: Fix compilation errors in compat/win32/sys/poll.c\n[PATCH 02/14] msvc: git-daemon.exe: Fix linker \"unresolved externals\" error\n[PATCH 03/14] msvc: Fix build by adding missing INTMAX_MAX define\n\nThese patches actually fix the build. Note that I haven't actually tested\ngit-daemon.exe, but it should behave exactly the same as the MinGW build\n(famous last words).\n\n[PATCH 04/14] msvc: Fix macro redefinition warnings\n\nPrior to this patch, the msvc build spews 1184 warnings. After this patch,\nthe warning count is down to 176! :-P\n\n[PATCH 05/14] run-command.c: Initialise variable to suppress msvc warnings\n[PATCH 06/14] match-trees.c: Initialise variables to suppress msvc warnings\n[PATCH 07/14] fast-import.c: Initialise variables to suppress msvc warnings\n[PATCH 08/14] submodule.c: Initialise variables to suppress msvc warnings\n[PATCH 09/14] merge-recursive.c: Initialise variable to suppress msvc warning\n[PATCH 10/14] fast-export.c: Initialise variable to suppress msvc warning\n[PATCH 11/14] cat-file.c: Initialise variable to suppress msvc warning\n[PATCH 12/14] rev-list.c: Initialise variables to suppress msvc warnings\n[PATCH 13/14] transport.c: Initialise variable to suppress msvc warning\n[PATCH 14/14] wt-status.c: Initialise variable to suppress msvc warning\n\nThese patches were originally a single patch, since they all implement the\nsame fix, and could be squashed back into a single commit.  However, I\ndecided to split it up by file to make it easier to review. Note that the\nwarnings here are issued by the linker, since we have requested link-time\ncode generation, which explains why the one-liner in patch 5 fixes 26\nwarnings (start_command() is linked into 26 executables). These patches\nreduce the warning count to 126.\n\n[The remaining 126 warnings are all very similar, see an up-coming RFC series]\n\nATB,\nRamsay Jones\n"}]}