{"thread":{"id":"25947","subject":"Intermittent failures in t9119","startedAt":"2010-12-04T02:19:16Z","lastAt":"2010-12-31T14:13:56Z","messageCount":8,"participants":["Junio C Hamano","David D. Kilzer","Eric Wong"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"157289","messageId":"7vmxoml1p7.fsf@alter.siamese.dyndns.org","threadId":"25947","inReplyTo":null,"subject":"Intermittent failures in t9119","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-12-04T02:19:16Z","receivedAt":"2010-12-04T02:19:16Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Sorry for bringing up an old story, but since you added \"git svn info\"\nwith e6fefa9 (git-svn info: implement info command, 2007-11-21),...\n\nI am seeing breakages from the said test:\n\n not ok - 6 info file\n #\n # (cd svnwc; svn info file) > expected.info-file &&\n # (cd gitwc; git svn info file) > actual.info-file &&\n # test_cmp expected.info-file actual.info-file\n\n : trash directory.t9119-git-svn-info/master; diff *.info-file\n 12c12\n < Text Last Updated: 2010-12-04 00:34:58 +0000 (Sat, 04 Dec 2010)\n ---\n > Text Last Updated: 2010-12-04 00:34:57 +0000 (Sat, 04 Dec 2010)\n\nI do not know if we should expect output from \"svn info\" to match exactly\nlike the above. Is \"Text Last Updated\" supposed to show the stat\ntimestamp of the working tree (I see \"(stat $path)[9]\" there)? If so,\nunless the checkout/update in svnwc and gitwc prior to this test was done\nwithin the same second, we do not have a good reason to expect that these\nfiles should be identical.\n\nI _think_ \"svn info file\" actually gives the timestamp of the revision\nthat touched the file the last (in their linear worldview of the history),\nso perhaps this is demonstrating the real bug, but only when the test runs\nvery slowly?\n"},{"id":"157332","messageId":"97465.53475.qm@web30008.mail.mud.yahoo.com","threadId":"25947","inReplyTo":"7vmxoml1p7.fsf@alter.siamese.dyndns.org","subject":"Re: Intermittent failures in t9119","fromName":"David D. Kilzer","fromEmail":"ddkilzer@kilzer.net","sentAt":"2010-12-05T01:21:38Z","receivedAt":"2010-12-05T01:21:38Z","isPatch":false,"sender":{"key":"ddkilzer@kilzer.net","avatar":"https://avatars.githubusercontent.com/u/263571?v=4"},"body":"On Fri, December 3, 2010 at 6:19:16 PM, Junio C Hamano wrote:\n\n> I am seeing breakages from the said test:\n> \n> not ok - 6 info file\n> #\n> # (cd svnwc; svn info file) > expected.info-file &&\n> # (cd gitwc; git svn info file) > actual.info-file &&\n> # test_cmp expected.info-file actual.info-file\n> \n> : trash directory.t9119-git-svn-info/master; diff *.info-file\n> 12c12\n> < Text Last Updated: 2010-12-04 00:34:58 +0000 (Sat, 04 Dec 2010)\n> ---\n> > Text Last Updated: 2010-12-04 00:34:57 +0000 (Sat, 04 Dec 2010)\n> \n> I do not know if we should expect output from \"svn info\" to match exactly\n> like the above. Is \"Text Last Updated\" supposed to show the stat\n> timestamp of the working tree (I see \"(stat $path)[9]\" there)? If so,\n> unless the checkout/update in svnwc and gitwc prior to this test was done\n> within the same second, we do not have a good reason to expect that these\n> files should be identical.\n\n\nThe modification timestamp (mtime) for the two files should be in sync due to \nthis line in t9119-git-svn-info.sh in 'setup repository and import':\n\n ptouch gitwc/file svnwc/file &&\n\n> I _think_ \"svn info file\" actually gives the timestamp of the revision\n> that touched the file the last (in their linear worldview of the history),\n> so perhaps this is demonstrating the real bug, but only when the test runs\n> very slowly?\n\n\nWhat platform/OS is the test failing on? I can't reproduce it on an 8-core Mac \nPro with Mac OS X 10.6.5.\n\nDave\n"},{"id":"157335","messageId":"7vwrnox1pi.fsf@alter.siamese.dyndns.org","threadId":"25947","inReplyTo":"97465.53475.qm@web30008.mail.mud.yahoo.com","subject":"Re: Intermittent failures in t9119","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-12-05T04:50:33Z","receivedAt":"2010-12-05T04:50:33Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"David D. Kilzer\" writes:\n\n> The modification timestamp (mtime) for the two files should be in sync due to \n> this line in t9119-git-svn-info.sh in 'setup repository and import':\n>\n> ptouch gitwc/file svnwc/file &&\n\nHmph. One explanation that may make sense is that something else is\ntouching the file in the working tree after you run your ptouch script,\nbut I don't know what it is.\n\n>> I _think_ \"svn info file\" actually gives the timestamp of the revision\n>> that touched the file the last (in their linear worldview of the history),\n>> so perhaps this is demonstrating the real bug, but only when the test runs\n>> very slowly?\n>\n> What platform/OS is the test failing on?\n\nAn FC13 machine at k.org; I see 16 \"Xeon X5550 @ 2.67GHz\" in /proc/cpuinfo\noutput.\n"},{"id":"157369","messageId":"7vy684t0mt.fsf@alter.siamese.dyndns.org","threadId":"25947","inReplyTo":"7vmxoml1p7.fsf@alter.siamese.dyndns.org","subject":"Re: Intermittent failures in t9119","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-12-05T20:39:38Z","receivedAt":"2010-12-05T20:39:38Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Junio C Hamano writes:\n\n> Sorry for bringing up an old story, but since you added \"git svn info\"\n> with e6fefa9 (git-svn info: implement info command, 2007-11-21),...\n>\n> I am seeing breakages from the said test:\n>\n> not ok - 6 info file\n> #\n> # (cd svnwc; svn info file) > expected.info-file &&\n> # (cd gitwc; git svn info file) > actual.info-file &&\n> # test_cmp expected.info-file actual.info-file\n>\n> : trash directory.t9119-git-svn-info/master; diff *.info-file\n> 12c12\n> < Text Last Updated: 2010-12-04 00:34:58 +0000 (Sat, 04 Dec 2010)\n> ---\n> > Text Last Updated: 2010-12-04 00:34:57 +0000 (Sat, 04 Dec 2010)\n>\n> I do not know if we should expect output from \"svn info\" to match exactly\n> like the above. Is \"Text Last Updated\" supposed to show the stat\n> timestamp of the working tree (I see \"(stat $path)[9]\" there)?\n> ...\n>\n> I _think_ \"svn info file\" actually gives the timestamp of the revision\n> that touched the file the last (in their linear worldview of the history),\n> so perhaps this is demonstrating the real bug, but only when the test runs\n> very slowly?\n\nI think we should not expect \"git svn info\" to match \"svn info\" at least\nat the \"Text Last Updated\" line. The former seems to want to report the\ntimestamp of the working tree, but \"svn info\" does not seem to look at the\nfile in the working tree.\n\n $ mkdir svntest\n $ cd svntest\n $ mkdir repo\n $ svnadmin create repo\n $ svn checkout file://$(pwd)/repo work\n Checked out revision 0.\n $ cd work\n $ echo hello >world; svn add world; svn commit -m initial\n A world\n Adding world\n Transmitting file data .\n Committed revision 1.\n $ svn info world | grep 'Text Last'\n Text Last Updated: 2010-12-05 12:24:52 -0800 (Sun, 05 Dec 2010)\n $ touch world\n $ svn info world | grep 'Text Last'\n Text Last Updated: 2010-12-05 12:24:52 -0800 (Sun, 05 Dec 2010)\n $ ls -l world\n -rw-rw-r-- 1 junio junio 6 2010-12-05 12:25 world\n $ rm world\n $ svn info world | grep 'Text Last'\n Text Last Updated: 2010-12-05 12:24:52 -0800 (Sun, 05 Dec 2010)\n\nI have these suspicions:\n\n (1) Somebody may have liked if \"git svn info\" exactly matched \"svn info\"\n in that it would give the timestamp of the commit object that touched\n the path the last in the current history. The current implementation\n in that sense is buggy;\n\n (2) Nobody uses the value from \"Text Last Updated\" field in practice, so\n that bug has been unnoticed so far;\n\n (3) And it is not worth fixing it ;-)\n\nFor now, I would suggest fixing the failing test to ignore the \"Text Last\nUpdated\" field while comparing, and if somebody is inclined to, we would\nupdate the code to match what \"svn info\" does.\n\nThoughts?\n"},{"id":"157423","messageId":"20101206191055.GA9597@dcvr.yhbt.net","threadId":"25947","inReplyTo":"7vy684t0mt.fsf@alter.siamese.dyndns.org","subject":"Re: Intermittent failures in t9119","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2010-12-06T19:10:55Z","receivedAt":"2010-12-06T19:10:55Z","isPatch":false,"sender":{"key":"e@80x24.org","avatar":null},"body":"Junio C Hamano wrote:\n> (2) Nobody uses the value from \"Text Last Updated\" field in practice, so\n> that bug has been unnoticed so far;\n> \n> (3) And it is not worth fixing it ;-)\n> \n> For now, I would suggest fixing the failing test to ignore the \"Text Last\n> Updated\" field while comparing, and if somebody is inclined to, we would\n> update the code to match what \"svn info\" does.\n\nAgreed on both points. I consider \"git svn log\" and \"git svn info\" to\nbe reasonable approximations of svn behavior, not exact replicas.\nExactly matching would be extremely difficult given variations between\ndifferent svn versions, and also svn requiring network access while\ngit svn does not.\n\n-- \nEric Wong\n"},{"id":"157470","messageId":"7vd3pesb99.fsf@alter.siamese.dyndns.org","threadId":"25947","inReplyTo":"20101206191055.GA9597@dcvr.yhbt.net","subject":"Re: Intermittent failures in t9119","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-12-07T00:00:02Z","receivedAt":"2010-12-07T00:00:02Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Eric Wong writes:\n\n> Junio C Hamano wrote:\n>> (2) Nobody uses the value from \"Text Last Updated\" field in practice, so\n>> that bug has been unnoticed so far;\n>> \n>> (3) And it is not worth fixing it ;-)\n>> \n>> For now, I would suggest fixing the failing test to ignore the \"Text Last\n>> Updated\" field while comparing, and if somebody is inclined to, we would\n>> update the code to match what \"svn info\" does.\n>\n> Agreed on both points. I consider \"git svn log\" and \"git svn info\" to\n> be reasonable approximations of svn behavior, not exact replicas.\n> Exactly matching would be extremely difficult given variations between\n> different svn versions, and also svn requiring network access while\n> git svn does not.\n\nOk, here is a minimum patch to do that.\n\n-- >8 --\nSubject: t9119: do not compare \"Text Last Updated\" line from \"svn info\"\n\nOn the \"Text Last Updated\" line, \"git svn info \" does not give the\ntimestamp of the commit that touched the path most recently, unlike \"svn\ninfo \". Do not expect the output from two commands to match on\nthese lines.\n\nThere was a \"ptouch\" attempt to transplant the timestamp from svn working\ntree files to corresponding git working tree files, which mostly hid this\ndifference, but is made pointless now with this change. Remove the helper\nfunction and calls to it.\n\nSigned-off-by: Junio C Hamano \n---\n t/t9119-git-svn-info.sh | 106 +++++++++++++++--------------------------------\n 1 files changed, 34 insertions(+), 72 deletions(-)\n\ndiff --git a/t/t9119-git-svn-info.sh b/t/t9119-git-svn-info.sh\nindex f3f397c..ff19695 100755\n--- a/t/t9119-git-svn-info.sh\n+++ b/t/t9119-git-svn-info.sh\n@@ -18,21 +18,14 @@ case $v in\n \t;;\n esac\n \n-ptouch() {\n-\tperl -w -e '\n-\t\tuse strict;\n-\t\tuse POSIX qw(mktime);\n-\t\tdie \"ptouch requires exactly 2 arguments\" if @ARGV != 2;\n-\t\tmy $text_last_updated = shift @ARGV;\n-\t\tmy $git_file = shift @ARGV;\n-\t\tdie \"\\\"$git_file\\\" does not exist\" if ! -e $git_file;\n-\t\tif ($text_last_updated\n-\t\t =~ /(\\d{4})-(\\d{2})-(\\d{2}) (\\d{2}):(\\d{2}):(\\d{2})/) {\n-\t\t\tmy $mtime = mktime($6, $5, $4, $3, $2 - 1, $1 - 1900);\n-\t\t\tmy $atime = $mtime;\n-\t\t\tutime $atime, $mtime, $git_file;\n-\t\t}\n-\t' \"`svn_cmd info $2 | grep '^Text Last Updated:'`\" \"$1\"\n+# On the \"Text Last Updated\" line, \"git svn info\" does not return the\n+# same value as \"svn info\" (i.e. the commit timestamp that touched the\n+# path most recently); do not expect that field to match.\n+test_cmp_info () {\n+\tsed -e '/^Text Last Updated:/d' \"$1\" >tmp.expect\n+\tsed -e '/^Text Last Updated:/d' \"$2\" >tmp.actual\n+\ttest_cmp tmp.expect tmp.actual &&\n+\trm -f tmp.expect tmp.actual\n }\n \n quoted_svnrepo=\"$(echo $svnrepo | sed 's/ /%20/')\"\n@@ -62,17 +55,13 @@ test_expect_success 'setup repository and import' '\n \t\tcd gitwc &&\n \t\tgit svn init \"$svnrepo\" &&\n \t\tgit svn fetch\n-\t) &&\n-\tptouch gitwc/file svnwc/file &&\n-\tptouch gitwc/directory svnwc/directory &&\n-\tptouch gitwc/symlink-file svnwc/symlink-file &&\n-\tptouch gitwc/symlink-directory svnwc/symlink-directory\n+\t)\n \t'\n \n test_expect_success 'info' \"\n \t(cd svnwc; svn info) > expected.info &&\n \t(cd gitwc; git svn info) > actual.info &&\n-\ttest_cmp expected.info actual.info\n+\ttest_cmp_info expected.info actual.info\n \t\"\n \n test_expect_success 'info --url' '\n@@ -82,7 +71,7 @@ test_expect_success 'info --url' '\n test_expect_success 'info .' \"\n \t(cd svnwc; svn info .) > expected.info-dot &&\n \t(cd gitwc; git svn info .) > actual.info-dot &&\n-\ttest_cmp expected.info-dot actual.info-dot\n+\ttest_cmp_info expected.info-dot actual.info-dot\n \t\"\n \n test_expect_success 'info --url .' '\n@@ -92,7 +81,7 @@ test_expect_success 'info --url .' '\n test_expect_success 'info file' \"\n \t(cd svnwc; svn info file) > expected.info-file &&\n \t(cd gitwc; git svn info file) > actual.info-file &&\n-\ttest_cmp expected.info-file actual.info-file\n+\ttest_cmp_info expected.info-file actual.info-file\n \t\"\n \n test_expect_success 'info --url file' '\n@@ -102,13 +91,13 @@ test_expect_success 'info --url file' '\n test_expect_success 'info directory' \"\n \t(cd svnwc; svn info directory) > expected.info-directory &&\n \t(cd gitwc; git svn info directory) > actual.info-directory &&\n-\ttest_cmp expected.info-directory actual.info-directory\n+\ttest_cmp_info expected.info-directory actual.info-directory\n \t\"\n \n test_expect_success 'info inside directory' \"\n \t(cd svnwc/directory; svn info) > expected.info-inside-directory &&\n \t(cd gitwc/directory; git svn info) > actual.info-inside-directory &&\n-\ttest_cmp expected.info-inside-directory actual.info-inside-directory\n+\ttest_cmp_info expected.info-inside-directory actual.info-inside-directory\n \t\"\n \n test_expect_success 'info --url directory' '\n@@ -118,7 +107,7 @@ test_expect_success 'info --url directory' '\n test_expect_success 'info symlink-file' \"\n \t(cd svnwc; svn info symlink-file) > expected.info-symlink-file &&\n \t(cd gitwc; git svn info symlink-file) > actual.info-symlink-file &&\n-\ttest_cmp expected.info-symlink-file actual.info-symlink-file\n+\ttest_cmp_info expected.info-symlink-file actual.info-symlink-file\n \t\"\n \n test_expect_success 'info --url symlink-file' '\n@@ -131,7 +120,7 @@ test_expect_success 'info symlink-directory' \"\n \t\t> expected.info-symlink-directory &&\n \t(cd gitwc; git svn info symlink-directory) \\\n \t\t> actual.info-symlink-directory &&\n-\ttest_cmp expected.info-symlink-directory actual.info-symlink-directory\n+\ttest_cmp_info expected.info-symlink-directory actual.info-symlink-directory\n \t\"\n \n test_expect_success 'info --url symlink-directory' '\n@@ -146,14 +135,13 @@ test_expect_success 'info added-file' \"\n \t\tgit add added-file\n \t) &&\n \tcp gitwc/added-file svnwc/added-file &&\n-\tptouch gitwc/added-file svnwc/added-file &&\n \t(\n \t\tcd svnwc &&\n \t\tsvn_cmd add added-file > /dev/null\n \t) &&\n \t(cd svnwc; svn info added-file) > expected.info-added-file &&\n \t(cd gitwc; git svn info added-file) > actual.info-added-file &&\n-\ttest_cmp expected.info-added-file actual.info-added-file\n+\ttest_cmp_info expected.info-added-file actual.info-added-file\n \t\"\n \n test_expect_success 'info --url added-file' '\n@@ -163,7 +151,6 @@ test_expect_success 'info --url added-file' '\n \n test_expect_success 'info added-directory' \"\n \tmkdir gitwc/added-directory svnwc/added-directory &&\n-\tptouch gitwc/added-directory svnwc/added-directory &&\n \ttouch gitwc/added-directory/.placeholder &&\n \t(\n \t\tcd svnwc &&\n@@ -177,7 +164,7 @@ test_expect_success 'info added-directory' \"\n \t\t> expected.info-added-directory &&\n \t(cd gitwc; git svn info added-directory) \\\n \t\t> actual.info-added-directory &&\n-\ttest_cmp expected.info-added-directory actual.info-added-directory\n+\ttest_cmp_info expected.info-added-directory actual.info-added-directory\n \t\"\n \n test_expect_success 'info --url added-directory' '\n@@ -196,13 +183,12 @@ test_expect_success 'info added-symlink-file' \"\n \t\tln -s added-file added-symlink-file &&\n \t\tsvn_cmd add added-symlink-file > /dev/null\n \t) &&\n-\tptouch gitwc/added-symlink-file svnwc/added-symlink-file &&\n \t(cd svnwc; svn info added-symlink-file) \\\n \t\t> expected.info-added-symlink-file &&\n \t(cd gitwc; git svn info added-symlink-file) \\\n \t\t> actual.info-added-symlink-file &&\n-\ttest_cmp expected.info-added-symlink-file \\\n-\t\t actual.info-added-symlink-file\n+\ttest_cmp_info expected.info-added-symlink-file \\\n+\t\tactual.info-added-symlink-file\n \t\"\n \n test_expect_success 'info --url added-symlink-file' '\n@@ -221,13 +207,12 @@ test_expect_success 'info added-symlink-directory' \"\n \t\tln -s added-directory added-symlink-directory &&\n \t\tsvn_cmd add added-symlink-directory > /dev/null\n \t) &&\n-\tptouch gitwc/added-symlink-directory svnwc/added-symlink-directory &&\n \t(cd svnwc; svn info added-symlink-directory) \\\n \t\t> expected.info-added-symlink-directory &&\n \t(cd gitwc; git svn info added-symlink-directory) \\\n \t\t> actual.info-added-symlink-directory &&\n-\ttest_cmp expected.info-added-symlink-directory \\\n-\t\t actual.info-added-symlink-directory\n+\ttest_cmp_info expected.info-added-symlink-directory \\\n+\t\tactual.info-added-symlink-directory\n \t\"\n \n test_expect_success 'info --url added-symlink-directory' '\n@@ -235,11 +220,6 @@ test_expect_success 'info --url added-symlink-directory' '\n \t = \"$quoted_svnrepo/added-symlink-directory\"\n \t'\n \n-# The next few tests replace the \"Text Last Updated\" value with a\n-# placeholder since git doesn't have a way to know the date that a\n-# now-deleted file was last checked out locally. Internally it\n-# simply reuses the Last Changed Date.\n-\n test_expect_success 'info deleted-file' \"\n \t(\n \t\tcd gitwc &&\n@@ -249,13 +229,9 @@ test_expect_success 'info deleted-file' \"\n \t\tcd svnwc &&\n \t\tsvn_cmd rm --force file > /dev/null\n \t) &&\n-\t(cd svnwc; svn info file) |\n-\tsed -e 's/^\\(Text Last Updated:\\).*/\\1 TEXT-LAST-UPDATED-STRING/' \\\n-\t\t> expected.info-deleted-file &&\n-\t(cd gitwc; git svn info file) |\n-\tsed -e 's/^\\(Text Last Updated:\\).*/\\1 TEXT-LAST-UPDATED-STRING/' \\\n-\t\t> actual.info-deleted-file &&\n-\ttest_cmp expected.info-deleted-file actual.info-deleted-file\n+\t(cd svnwc; svn info file) >expected.info-deleted-file &&\n+\t(cd gitwc; git svn info file) >actual.info-deleted-file &&\n+\ttest_cmp_info expected.info-deleted-file actual.info-deleted-file\n \t\"\n \n test_expect_success 'info --url file (deleted)' '\n@@ -272,13 +248,9 @@ test_expect_success 'info deleted-directory' \"\n \t\tcd svnwc &&\n \t\tsvn_cmd rm --force directory > /dev/null\n \t) &&\n-\t(cd svnwc; svn info directory) |\n-\tsed -e 's/^\\(Text Last Updated:\\).*/\\1 TEXT-LAST-UPDATED-STRING/' \\\n-\t\t> expected.info-deleted-directory &&\n-\t(cd gitwc; git svn info directory) |\n-\tsed -e 's/^\\(Text Last Updated:\\).*/\\1 TEXT-LAST-UPDATED-STRING/' \\\n-\t\t> actual.info-deleted-directory &&\n-\ttest_cmp expected.info-deleted-directory actual.info-deleted-directory\n+\t(cd svnwc; svn info directory) >expected.info-deleted-directory &&\n+\t(cd gitwc; git svn info directory) >actual.info-deleted-directory &&\n+\ttest_cmp_info expected.info-deleted-directory actual.info-deleted-directory\n \t\"\n \n test_expect_success 'info --url directory (deleted)' '\n@@ -295,14 +267,9 @@ test_expect_success 'info deleted-symlink-file' \"\n \t\tcd svnwc &&\n \t\tsvn_cmd rm --force symlink-file > /dev/null\n \t) &&\n-\t(cd svnwc; svn info symlink-file) |\n-\tsed -e 's/^\\(Text Last Updated:\\).*/\\1 TEXT-LAST-UPDATED-STRING/' \\\n-\t\t> expected.info-deleted-symlink-file &&\n-\t(cd gitwc; git svn info symlink-file) |\n-\tsed -e 's/^\\(Text Last Updated:\\).*/\\1 TEXT-LAST-UPDATED-STRING/' \\\n-\t\t> actual.info-deleted-symlink-file &&\n-\ttest_cmp expected.info-deleted-symlink-file \\\n-\t\t actual.info-deleted-symlink-file\n+\t(cd svnwc; svn info symlink-file) >expected.info-deleted-symlink-file &&\n+\t(cd gitwc; git svn info symlink-file) >actual.info-deleted-symlink-file &&\n+\ttest_cmp_info expected.info-deleted-symlink-file actual.info-deleted-symlink-file\n \t\"\n \n test_expect_success 'info --url symlink-file (deleted)' '\n@@ -319,14 +286,9 @@ test_expect_success 'info deleted-symlink-directory' \"\n \t\tcd svnwc &&\n \t\tsvn_cmd rm --force symlink-directory > /dev/null\n \t) &&\n-\t(cd svnwc; svn info symlink-directory) |\n-\tsed -e 's/^\\(Text Last Updated:\\).*/\\1 TEXT-LAST-UPDATED-STRING/' \\\n-\t\t > expected.info-deleted-symlink-directory &&\n-\t(cd gitwc; git svn info symlink-directory) |\n-\tsed -e 's/^\\(Text Last Updated:\\).*/\\1 TEXT-LAST-UPDATED-STRING/' \\\n-\t\t > actual.info-deleted-symlink-directory &&\n-\ttest_cmp expected.info-deleted-symlink-directory \\\n-\t\t actual.info-deleted-symlink-directory\n+\t(cd svnwc; svn info symlink-directory) >expected.info-deleted-symlink-directory &&\n+\t(cd gitwc; git svn info symlink-directory) >actual.info-deleted-symlink-directory &&\n+\ttest_cmp_info expected.info-deleted-symlink-directory actual.info-deleted-symlink-directory\n \t\"\n \n test_expect_success 'info --url symlink-directory (deleted)' '\n"},{"id":"157705","messageId":"20101209175503.GA16478@dcvr.yhbt.net","threadId":"25947","inReplyTo":"7vd3pesb99.fsf@alter.siamese.dyndns.org","subject":"Re: Intermittent failures in t9119","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2010-12-09T17:55:03Z","receivedAt":"2010-12-09T17:55:03Z","isPatch":false,"sender":{"key":"e@80x24.org","avatar":null},"body":"Junio C Hamano wrote:\n> Eric Wong writes:\n> > Junio C Hamano wrote:\n> >> (2) Nobody uses the value from \"Text Last Updated\" field in practice, so\n> >> that bug has been unnoticed so far;\n> >> \n> >> (3) And it is not worth fixing it ;-)\n> >> \n> >> For now, I would suggest fixing the failing test to ignore the \"Text Last\n> >> Updated\" field while comparing, and if somebody is inclined to, we would\n> >> update the code to match what \"svn info\" does.\n> >\n> > Agreed on both points. I consider \"git svn log\" and \"git svn info\" to\n> > be reasonable approximations of svn behavior, not exact replicas.\n> > Exactly matching would be extremely difficult given variations between\n> > different svn versions, and also svn requiring network access while\n> > git svn does not.\n> \n> Ok, here is a minimum patch to do that.\n\n> Signed-off-by: Junio C Hamano \n\nThanks, Acked-by: Eric Wong \n\n-- \nEric Wong\n"},{"id":"158781","messageId":"190893.69491.qm@web30005.mail.mud.yahoo.com","threadId":"25947","inReplyTo":"20101209175503.GA16478@dcvr.yhbt.net","subject":"Re: Intermittent failures in t9119","fromName":"David D. Kilzer","fromEmail":"ddkilzer@kilzer.net","sentAt":"2010-12-31T14:13:56Z","receivedAt":"2010-12-31T14:13:56Z","isPatch":false,"sender":{"key":"ddkilzer@kilzer.net","avatar":"https://avatars.githubusercontent.com/u/263571?v=4"},"body":"Eric Wong wrote:\n> Junio C Hamano wrote:\n> > Eric Wong writes:\n> > > Junio C Hamano wrote:\n> > >> (2) Nobody uses the value from \"Text Last Updated\" field in practice, \n>so\n> > >> that bug has been unnoticed so far;\n> > >> \n> > >> (3) And it is not worth fixing it ;-)\n> > >> \n> > >> For now, I would suggest fixing the failing test to ignore the \"Text \nLast\n> > >> Updated\" field while comparing, and if somebody is inclined to, we would\n> > >> update the code to match what \"svn info\" does.\n> > >\n> > > Agreed on both points. I consider \"git svn log\" and \"git svn info\" to\n> > > be reasonable approximations of svn behavior, not exact replicas.\n> > > Exactly matching would be extremely difficult given variations between\n> > > different svn versions, and also svn requiring network access while\n> > > git svn does not.\n> > \n> > Ok, here is a minimum patch to do that.\n> \n> > Signed-off-by: Junio C Hamano \n> \n> Thanks, Acked-by: Eric Wong \n\n\nAcked-by: David Kilzer \n\nThanks!\n\nDave\n"}]}