{"thread":{"id":"25854","subject":"Patchbombing or not, that is the question","startedAt":"2010-11-27T17:18:12Z","lastAt":"2010-11-27T18:39:58Z","messageCount":6,"participants":["Giuseppe Bilotta","Jonathan Nieder","Thiago Farina"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"156730","messageId":"AANLkTi=C4opog2SfU9R_=dSOGY_5+0WYtFL8BNqcOwUw@mail.gmail.com","threadId":"25854","inReplyTo":null,"subject":"Patchbombing or not, that is the question","fromName":"Giuseppe Bilotta","fromEmail":"giuseppe.bilotta@gmail.com","sentAt":"2010-11-27T17:18:12Z","receivedAt":"2010-11-27T17:18:12Z","isPatch":false,"sender":{"key":"giuseppe.bilotta@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1464?v=4"},"body":"Hello all,\n\nI prepared a bunch of patches to add support to some other browsers to\ngit-web--browse (opera, seamonkey, elinks). Currently I did one patch\nper browser. Should I squash them all together? (The series will also\ncontain some other patches that will stay separate.)\n\n-- \nGiuseppe \"Oblomov\" Bilotta\n"},{"id":"156731","messageId":"20101127172757.GA1858@burratino","threadId":"25854","inReplyTo":"AANLkTi=C4opog2SfU9R_=dSOGY_5+0WYtFL8BNqcOwUw@mail.gmail.com","subject":"Re: Patchbombing or not, that is the question","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2010-11-27T17:27:57Z","receivedAt":"2010-11-27T17:27:57Z","isPatch":false,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Giuseppe Bilotta wrote:\n\n> I prepared a bunch of patches to add support to some other browsers to\n> git-web--browse (opera, seamonkey, elinks). Currently I did one patch\n> per browser. Should I squash them all together?\n\nYeah, I'd squash them. (But I think either way would be fine.)\n\nCould you support\n\n\t[browser \"chromium-browser\"]\n\t\tcmd=chromium-browser\n\nwhile at it? :)\n"},{"id":"156733","messageId":"AANLkTimKdwrsYQHGL=KaoQEmv3FLJzS+M=5xdQi+A5Ny@mail.gmail.com","threadId":"25854","inReplyTo":"20101127172757.GA1858@burratino","subject":"Re: Patchbombing or not, that is the question","fromName":"Thiago Farina","fromEmail":"tfransosi@gmail.com","sentAt":"2010-11-27T17:40:29Z","receivedAt":"2010-11-27T17:40:29Z","isPatch":false,"sender":{"key":"tfransosi@gmail.com","avatar":"https://avatars.githubusercontent.com/u/970071?v=4"},"body":"On Sat, Nov 27, 2010 at 3:27 PM, Jonathan Nieder wrote:\n> Giuseppe Bilotta wrote:\n>\n>> I prepared a bunch of patches to add support to some other browsers to\n>> git-web--browse (opera, seamonkey, elinks). Currently I did one patch\n>> per browser. Should I squash them all together?\n>\n> Yeah, I'd squash them.  (But I think either way would be fine.)\n>\n> Could you support\n>\n>        [browser \"chromium-browser\"]\n>                cmd=chromium-browser\n>\nYeah, that would be great!\n"},{"id":"156735","messageId":"AANLkTik2WXj3kN2859_iSLQWarkR9ugJQiL2TwiNj109@mail.gmail.com","threadId":"25854","inReplyTo":"AANLkTimKdwrsYQHGL=KaoQEmv3FLJzS+M=5xdQi+A5Ny@mail.gmail.com","subject":"Re: Patchbombing or not, that is the question","fromName":"Giuseppe Bilotta","fromEmail":"giuseppe.bilotta@gmail.com","sentAt":"2010-11-27T18:13:36Z","receivedAt":"2010-11-27T18:13:36Z","isPatch":false,"sender":{"key":"giuseppe.bilotta@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1464?v=4"},"body":"On Sat, Nov 27, 2010 at 6:40 PM, Thiago Farina wrote:\n> On Sat, Nov 27, 2010 at 3:27 PM, Jonathan Nieder wrote:\n>> Giuseppe Bilotta wrote:\n>>\n>>> I prepared a bunch of patches to add support to some other browsers to\n>>> git-web--browse (opera, seamonkey, elinks). Currently I did one patch\n>>> per browser. Should I squash them all together?\n>>\n>> Yeah, I'd squash them.  (But I think either way would be fine.)\n>>\n>> Could you support\n>>\n>>        [browser \"chromium-browser\"]\n>>                cmd=chromium-browser\n>>\n> Yeah, that would be great!\n\nActually I think that in this case the 'chromimu' configuration should\nlook for chromium-browser if chromium is not found.\n\n-- \nGiuseppe \"Oblomov\" Bilotta\n"},{"id":"156736","messageId":"20101127183421.GA2131@burratino","threadId":"25854","inReplyTo":"AANLkTik2WXj3kN2859_iSLQWarkR9ugJQiL2TwiNj109@mail.gmail.com","subject":"Re: Patchbombing or not, that is the question","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2010-11-27T18:34:21Z","receivedAt":"2010-11-27T18:34:21Z","isPatch":false,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Giuseppe Bilotta wrote:\n\n> Actually I think that in this case the 'chromimu' configuration should\n> look for chromium-browser if chromium is not found.\n\nEven better might be to go straight for chromium-browser, to avoid\nconfusion with ancient versions of chromium-bsu.\n\nAnyway, I hadn't noticed the new support for chromium. Thanks for\npointing it out.\n"},{"id":"156738","messageId":"AANLkTinGNURJVdnQjw5BvR1tkoOdCRdgY2poYb8PFH2R@mail.gmail.com","threadId":"25854","inReplyTo":"20101127183421.GA2131@burratino","subject":"Re: Patchbombing or not, that is the question","fromName":"Giuseppe Bilotta","fromEmail":"giuseppe.bilotta@gmail.com","sentAt":"2010-11-27T18:39:58Z","receivedAt":"2010-11-27T18:39:58Z","isPatch":false,"sender":{"key":"giuseppe.bilotta@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1464?v=4"},"body":"On Sat, Nov 27, 2010 at 7:34 PM, Jonathan Nieder wrote:\n> Giuseppe Bilotta wrote:\n>\n>> Actually I think that in this case the 'chromimu' configuration should\n>> look for chromium-browser if chromium is not found.\n>\n> Even better might be to go straight for chromium-browser, to avoid\n> confusion with ancient versions of chromium-bsu.\n\nMore precisely, we should look for chromium-browser first, and if not\nfound then use chromium. The fall-back to chromium is, I think, needed\nbecause I suspect the binary was renamed in Debian only. Can somebody\nwith some other distribution confirm that chromium is called chromium\nthere?\n\n-- \nGiuseppe \"Oblomov\" Bilotta\n"}]}