{"thread":{"id":"25852","subject":"[PATCH] git-web--browse: Add support for opera","startedAt":"2010-11-27T11:15:58Z","lastAt":"2010-11-27T15:19:32Z","messageCount":2,"participants":["Giuseppe Bilotta"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"156722","messageId":"1290856558-6122-1-git-send-email-giuseppe.bilotta@gmail.com","threadId":"25852","inReplyTo":null,"subject":"[PATCH] git-web--browse: Add support for opera","fromName":"Giuseppe Bilotta","fromEmail":"giuseppe.bilotta@gmail.com","sentAt":"2010-11-27T11:15:58Z","receivedAt":"2010-11-27T11:15:58Z","isPatch":true,"sender":{"key":"giuseppe.bilotta@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1464?v=4"},"body":"It's probably not the most widespread browser, it's free as in gratis\nbut not as in libre, but it's worth supporting regardless, especially\nsince it's a trivial addition.\n\nSigned-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>\n---\n git-web--browse.sh |    6 +++---\n 1 files changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/git-web--browse.sh b/git-web--browse.sh\nindex 3fc4166..eb70375 100755\n--- a/git-web--browse.sh\n+++ b/git-web--browse.sh\n@@ -31,7 +31,7 @@ valid_custom_tool()\n \n valid_tool() {\n \tcase \"$1\" in\n-\t\tfirefox | iceweasel | chrome | google-chrome | chromium | konqueror | w3m | links | lynx | dillo | open | start)\n+\t\tfirefox | iceweasel | chrome | google-chrome | chromium | konqueror | opera | w3m | links | lynx | dillo | open | start)\n \t\t\t;; # happy\n \t\t*)\n \t\t\tvalid_custom_tool \"$1\" || return 1\n@@ -103,7 +103,7 @@ fi\n \n if test -z \"$browser\" ; then\n     if test -n \"$DISPLAY\"; then\n-\tbrowser_candidates=\"firefox iceweasel google-chrome chrome chromium konqueror w3m links lynx dillo\"\n+\tbrowser_candidates=\"firefox iceweasel google-chrome chrome chromium konqueror opera w3m links lynx dillo\"\n \tif test \"$KDE_FULL_SESSION\" = \"true\"; then\n \t    browser_candidates=\"konqueror $browser_candidates\"\n \tfi\n@@ -173,7 +173,7 @@ case \"$browser\" in\n     start)\n         exec \"$browser_path\" '\"web-browse\"' \"$@\"\n         ;;\n-    dillo)\n+    opera|dillo)\n \t\"$browser_path\" \"$@\" &\n \t;;\n     *)\n-- \n1.7.3.2.184.gecaee\n"},{"id":"156723","messageId":"AANLkTik-PnsZ7tBEgLixoKOYYrytdOGfDocuMECGn-6O@mail.gmail.com","threadId":"25852","inReplyTo":"1290856558-6122-1-git-send-email-giuseppe.bilotta@gmail.com","subject":"Re: [PATCH] git-web--browse: Add support for opera","fromName":"Giuseppe Bilotta","fromEmail":"giuseppe.bilotta@gmail.com","sentAt":"2010-11-27T15:19:32Z","receivedAt":"2010-11-27T15:19:32Z","isPatch":true,"sender":{"key":"giuseppe.bilotta@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1464?v=4"},"body":"Actually, ignore this patch for the time being, I'm preparing a longer\nset that includes it but might need some discussion. Sorry for the\nnoise.\n\nOn Sat, Nov 27, 2010 at 12:15 PM, Giuseppe Bilotta\n<giuseppe.bilotta@gmail.com> wrote:\n> It's probably not the most widespread browser, it's free as in gratis\n> but not as in libre, but it's worth supporting regardless, especially\n> since it's a trivial addition.\n>\n> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>\n> ---\n>  git-web--browse.sh |    6 +++---\n>  1 files changed, 3 insertions(+), 3 deletions(-)\n>\n> diff --git a/git-web--browse.sh b/git-web--browse.sh\n> index 3fc4166..eb70375 100755\n> --- a/git-web--browse.sh\n> +++ b/git-web--browse.sh\n> @@ -31,7 +31,7 @@ valid_custom_tool()\n>\n>  valid_tool() {\n>        case \"$1\" in\n> -               firefox | iceweasel | chrome | google-chrome | chromium | konqueror | w3m | links | lynx | dillo | open | start)\n> +               firefox | iceweasel | chrome | google-chrome | chromium | konqueror | opera | w3m | links | lynx | dillo | open | start)\n>                        ;; # happy\n>                *)\n>                        valid_custom_tool \"$1\" || return 1\n> @@ -103,7 +103,7 @@ fi\n>\n>  if test -z \"$browser\" ; then\n>     if test -n \"$DISPLAY\"; then\n> -       browser_candidates=\"firefox iceweasel google-chrome chrome chromium konqueror w3m links lynx dillo\"\n> +       browser_candidates=\"firefox iceweasel google-chrome chrome chromium konqueror opera w3m links lynx dillo\"\n>        if test \"$KDE_FULL_SESSION\" = \"true\"; then\n>            browser_candidates=\"konqueror $browser_candidates\"\n>        fi\n> @@ -173,7 +173,7 @@ case \"$browser\" in\n>     start)\n>         exec \"$browser_path\" '\"web-browse\"' \"$@\"\n>         ;;\n> -    dillo)\n> +    opera|dillo)\n>        \"$browser_path\" \"$@\" &\n>        ;;\n>     *)\n> --\n> 1.7.3.2.184.gecaee\n>\n>\n\n\n\n-- \nGiuseppe \"Oblomov\" Bilotta\n"}]}