{"thread":{"id":"25847","subject":"Re: git-gui: commit message box doesn't respond to enter (only return)","startedAt":"2010-11-26T20:38:55Z","lastAt":"2010-12-06T20:55:45Z","messageCount":3,"participants":["Jonathan Nieder","Konstantin Khomoutov","Pat Thoyts"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"156692","messageId":"20101126203855.GA23258@burratino","threadId":"25847","inReplyTo":"20101126170956.25856.63131.reportbug@alsuren-thinkpad.cbg.collabora.co.uk","subject":"Re: git-gui: commit message box doesn't respond to enter (only return)","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2010-11-26T20:38:55Z","receivedAt":"2010-11-26T20:38:55Z","isPatch":false,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Hi Pat,\n\nDavid Laban wrote at http://bugs.debian.org/605041:\n\n> Package: git-gui\n> Version: 1:1.7.2.3-2\n> Severity: minor\n>\n> If I click into the messagebox and hit enter, nothing happens.\n>\n> This is annoying because if I'm adding a new paragraph to my commit message, \n> I will often do \n>\n> Don't ask me why I do this. I think enter is a lighter/easier to press\n> key than return, and is also on the path that my hand takes between the mouse\n> and the rest of the keyboard.\n>\n> I have also provisionally reported the following bug in tk, but I feel like\n> a bit of a n00b for doing so.\n>\n> http://sf.net/tracker/?func=detail&aid=3119824&group_id=12997&atid=112997\n\nI can't reproduce this because this laptop does not have a distinct\n\"numpad enter\" key.\n\nThoughts?\nJonathan\n"},{"id":"156699","messageId":"20101126232825.GE3264@localhost.localdomain","threadId":"25847","inReplyTo":"20101126203855.GA23258@burratino","subject":"Re: git-gui: commit message box doesn't respond to enter (only return)","fromName":"Konstantin Khomoutov","fromEmail":"flatworm@users.sourceforge.net","sentAt":"2010-11-26T23:28:25Z","receivedAt":"2010-11-26T23:28:25Z","isPatch":false,"sender":{"key":"flatworm@users.sourceforge.net","avatar":null},"body":"On Fri, Nov 26, 2010 at 02:38:55PM -0600, Jonathan Nieder wrote:\n\n> David Laban wrote at http://bugs.debian.org/605041:\n> \n> > Package: git-gui\n> > Version: 1:1.7.2.3-2\n> > Severity: minor\n> >\n> > If I click into the messagebox and hit enter, nothing happens.\n> >\n> > This is annoying because if I'm adding a new paragraph to my commit message, \n> > I will often do \n> >\n> > Don't ask me why I do this. I think enter is a lighter/easier to press\n> > key than return, and is also on the path that my hand takes between the mouse\n> > and the rest of the keyboard.\n> >\n> > I have also provisionally reported the following bug in tk, but I feel like\n> > a bit of a n00b for doing so.\n> >\n> > http://sf.net/tracker/?func=detail&aid=3119824&group_id=12997&atid=112997\n> \n> I can't reproduce this because this laptop does not have a distinct\n> \"numpad enter\" key.\nI've tested it on Debian Squeeze and added another comment on the\nupstream bug report. In short: KP_Enter is not bound to any action in\nTk text widgets in X11, at least in 8.5.9.\n\nBut git-gui can be trivially patched to support this; that would be a\none-lineer. So if it is desired and will be accepted, I could prepare a\npatch.\n"},{"id":"157429","messageId":"87mxoiy626.fsf@fox.patthoyts.tk","threadId":"25847","inReplyTo":"20101126232825.GE3264@localhost.localdomain","subject":"Re: git-gui: commit message box doesn't respond to enter (only return)","fromName":"Pat Thoyts","fromEmail":"patthoyts@users.sourceforge.net","sentAt":"2010-12-06T20:55:45Z","receivedAt":"2010-12-06T20:55:45Z","isPatch":false,"sender":{"key":"patthoyts@users.sourceforge.net","avatar":"https://avatars.githubusercontent.com/u/30739?v=4"},"body":"Konstantin Khomoutov writes:\n\n>On Fri, Nov 26, 2010 at 02:38:55PM -0600, Jonathan Nieder wrote:\n>\n>> David Laban wrote at http://bugs.debian.org/605041:\n>> \n>> > Package: git-gui\n>> > Version: 1:1.7.2.3-2\n>> > Severity: minor\n>> >\n>> > If I click into the messagebox and hit enter, nothing happens.\n>> >\n>> > This is annoying because if I'm adding a new paragraph to my commit message, \n>> > I will often do \n>> >\n>> > Don't ask me why I do this. I think enter is a lighter/easier to press\n>> > key than return, and is also on the path that my hand takes between the mouse\n>> > and the rest of the keyboard.\n>> >\n>> > I have also provisionally reported the following bug in tk, but I feel like\n>> > a bit of a n00b for doing so.\n>> >\n>> > http://sf.net/tracker/?func=detail&aid=3119824&group_id=12997&atid=112997\n>> \n>> I can't reproduce this because this laptop does not have a distinct\n>> \"numpad enter\" key.\n>I've tested it on Debian Squeeze and added another comment on the\n>upstream bug report. In short: KP_Enter is not bound to any action in\n>Tk text widgets in X11, at least in 8.5.9.\n>\n>But git-gui can be trivially patched to support this; that would be a\n>one-lineer. So if it is desired and will be accepted, I could prepare a\n>patch.\n>\n\nI've no problem with that. On unix the messagebox bindings are applied\ndirectly to the dialog window (.__tk__messagebox) and it does include\nDialog in the bindtags so you could use\n bind Dialog { .... }\nexcept that might affect other dialogs too. That might not be a\nproblem. On Windows the messagebox is native so the bindings there are\nwhatever are standard.\n\n-- \nPat Thoyts http://www.patthoyts.tk/\nPGP fingerprint 2C 6E 98 07 2C 59 C8 97 10 CE 11 E6 04 E0 B9 DD\n"}]}