{"thread":{"id":"25838","subject":"Breaking t1510-repo-setup.sh tests in pu","startedAt":"2010-11-25T09:56:42Z","lastAt":"2010-11-26T07:51:04Z","messageCount":4,"participants":["Ævar Arnfjörð Bjarmason","Nguyen Thai Ngoc Duy","Johannes Sixt"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"156538","messageId":"AANLkTim=_0WiphBv-RBhJ2i9rGzXvz8yKcZcm_7pYXFc@mail.gmail.com","threadId":"25838","inReplyTo":null,"subject":"Breaking t1510-repo-setup.sh tests in pu","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2010-11-25T09:56:42Z","receivedAt":"2010-11-25T09:56:42Z","isPatch":false,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"I haven't investigated these. But that test is breaking in pu now:\n\n $ prove ./t1510-repo-setup.sh\n ./t1510-repo-setup.sh .. Dubious, test returned 1 (wstat 256, 0x100)\n Failed 244/376 subtests\n\n Test Summary Report\n -------------------\n ./t1510-repo-setup.sh (Wstat: 256 Tests: 376 Failed: 244)\n Failed tests: 8-9, 11, 15-36, 46-67, 71-92, 101, 103\n 113-128, 144-159, 169-184, 207-208, 211-234\n 256-279, 281-282, 284-307, 320-343, 351\n 353-376\n Non-zero exit status: 1\n Files=1, Tests=376, 8 wallclock secs ( 0.23 usr 0.02 sys + 0.85\ncusr 5.26 csys = 6.36 CPU)\n Result: FAIL\n\nAll the breakages seem to be due to path differences:\n\n --- expected 2010-11-25 09:53:46.000000000 +0000\n +++ result 2010-11-25 09:53:46.000000000 +0000\n @@ -1,4 +1,4 @@\n -setup: git_dir: /home/avar/g/git/t/trash directory.t1510-repo-setup/3/.git\n -setup: worktree: /home/avar/g/git/t/trash directory.t1510-repo-setup/3/wt\n +setup: git_dir: .git\n +setup: worktree: /home/avar/g/git/t/trash directory.t1510-repo-setup/3\n setup: cwd: /home/avar/g/git/t/trash directory.t1510-repo-setup/3\n setup: prefix: (null)\n not ok - 24 #3: GIT_DIR, GIT_WORK_TREE=wt at root\n\nThis is probably due to Nguyễn's recent work. But I'm not sure.\n"},{"id":"156544","messageId":"AANLkTikvXhKoRg4a0FuyW8cG45b6AM9+NbbHuJQWtb4L@mail.gmail.com","threadId":"25838","inReplyTo":"AANLkTim=_0WiphBv-RBhJ2i9rGzXvz8yKcZcm_7pYXFc@mail.gmail.com","subject":"Re: Breaking t1510-repo-setup.sh tests in pu","fromName":"Nguyen Thai Ngoc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2010-11-25T11:40:33Z","receivedAt":"2010-11-25T11:40:33Z","isPatch":false,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"2010/11/25 Ævar Arnfjörð Bjarmason :\n> All the breakages seem to be due to path differences:\n>\n>    --- expected    2010-11-25 09:53:46.000000000 +0000\n>    +++ result      2010-11-25 09:53:46.000000000 +0000\n>    @@ -1,4 +1,4 @@\n>    -setup: git_dir: /home/avar/g/git/t/trash directory.t1510-repo-setup/3/.git\n>    -setup: worktree: /home/avar/g/git/t/trash directory.t1510-repo-setup/3/wt\n>    +setup: git_dir: .git\n>    +setup: worktree: /home/avar/g/git/t/trash directory.t1510-repo-setup/3\n>     setup: cwd: /home/avar/g/git/t/trash directory.t1510-repo-setup/3\n>     setup: prefix: (null)\n>    not ok - 24 #3: GIT_DIR, GIT_WORK_TREE=wt at root\n>\n> This is probably due to Nguyễn's recent work. But I'm not sure.\n>\n\nInteresting. That looks like real breakage. I have just run the tests\non pu (f4b0626). It passed. Can you send me the entire log and\n/tmp/t1510-trace.log after applying this patch?\n\ndiff --git a/t/t1510-repo-setup.sh b/t/t1510-repo-setup.sh\nindex 0343045..446eb4d 100755\n--- a/t/t1510-repo-setup.sh\n+++ b/t/t1510-repo-setup.sh\n@@ -4,6 +4,8 @@ test_description='Tests of cwd/prefix/worktree/gitdir\nsetup in all cases'\n\n . ./test-lib.sh\n\n+export GIT_TRACE=/tmp/t1510-trace.log\n+\n #\n # A few rules for repo setup:\n #\n-- \nDuy\n"},{"id":"156597","messageId":"AANLkTim1G__J6KAnd+pNmKWwEDTHexUSJU2E7=7WFZmp@mail.gmail.com","threadId":"25838","inReplyTo":"AANLkTinhgMhrcMtPKL0aOrkeVgo8NE8Sq0fuPuCcbdbq@mail.gmail.com","subject":"Re: Breaking t1510-repo-setup.sh tests in pu","fromName":"Nguyen Thai Ngoc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2010-11-26T02:45:11Z","receivedAt":"2010-11-26T02:45:11Z","isPatch":false,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"On Fri, Nov 26, 2010 at 8:21 AM, Ævar Arnfjörð Bjarmason\n wrote:\n> On Thu, Nov 25, 2010 at 12:40, Nguyen Thai Ngoc Duy wrote:\n>> Interesting. That looks like real breakage. I have just run the tests\n>> on pu (f4b0626). It passed. Can you send me the entire log and\n>> /tmp/t1510-trace.log after applying this patch?\n>\n> Here it is. Hope it's useful.\n>\n\nOK it's probably bashisms. I think it will pass if you run it with\nbash :-P I'll resend the series later without bash specific\nconstructs.\n-- \nDuy\n"},{"id":"156622","messageId":"4CEF66E8.1050806@viscovery.net","threadId":"25838","inReplyTo":"AANLkTim1G__J6KAnd+pNmKWwEDTHexUSJU2E7=7WFZmp@mail.gmail.com","subject":"Re: Breaking t1510-repo-setup.sh tests in pu","fromName":"Johannes Sixt","fromEmail":"j.sixt@viscovery.net","sentAt":"2010-11-26T07:51:04Z","receivedAt":"2010-11-26T07:51:04Z","isPatch":false,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Am 11/26/2010 3:45, schrieb Nguyen Thai Ngoc Duy:\n> OK it's probably bashisms. I think it will pass if you run it with\n> bash :-P I'll resend the series later without bash specific\n> constructs.\n\nSure, it is. This:\n\n GIT_DIR=\"$TRASH_DIRECTORY/2/.git\" test_repo 2/sub\n\ndoes not work the same way in all shells when test_repo is a shell\nfunction. You have to export GIT_DIR explicitly before the function call.\n(But since in this case, test_repo invokes its own subshell anyway, you\nbetter do it in the function.)\n\n-- Hannes\n"}]}