{"thread":{"id":"25806","subject":"[PATCH] t/t9001-send-email.sh: fix '&&' chain in some tests","startedAt":"2010-11-22T12:31:49Z","lastAt":"2010-11-22T17:00:40Z","messageCount":2,"participants":["Antonio Ospite","Jonathan Nieder"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"156308","messageId":"1290429109-2318-1-git-send-email-ospite@studenti.unina.it","threadId":"25806","inReplyTo":null,"subject":"[PATCH] t/t9001-send-email.sh: fix '&&' chain in some tests","fromName":"Antonio Ospite","fromEmail":"ospite@studenti.unina.it","sentAt":"2010-11-22T12:31:49Z","receivedAt":"2010-11-22T12:31:49Z","isPatch":true,"sender":{"key":"ospite@studenti.unina.it","avatar":"https://gravatar.com/avatar/ea788baa2a3a207a84097c6f4f7b11d4201a80060933ef67584f648f17005552?d=mp&s=160"},"body":"t/README recommends chaining test assertions.\n\nSigned-off-by: Antonio Ospite <ospite@studenti.unina.it>\n---\n\nHi,\n\nthere are a couple of tests I didn't fix here, they are storing intermediate\nreturn values, see \"confirm by default (due to cc)\" and following in\nt/t9001-send-email.sh\n\nI don't know if chaining is correct already there.\n\nThanks,\n   Antonio\n\n t/t9001-send-email.sh |    8 ++++----\n 1 files changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh\nindex d1ba252..ac1af86 100755\n--- a/t/t9001-send-email.sh\n+++ b/t/t9001-send-email.sh\n@@ -265,7 +265,7 @@ test_expect_success $PREREQ 'Author From: in message body' '\n \t\t--to=nobody@example.com \\\n \t\t--smtp-server=\"$(pwd)/fake.sendmail\" \\\n \t\t$patches &&\n-\tsed \"1,/^\\$/d\" < msgtxt1 > msgbody1\n+\tsed \"1,/^\\$/d\" < msgtxt1 > msgbody1 &&\n \tgrep \"From: A <author@example.com>\" msgbody1\n '\n \n@@ -276,7 +276,7 @@ test_expect_success $PREREQ 'Author From: not in message body' '\n \t\t--to=nobody@example.com \\\n \t\t--smtp-server=\"$(pwd)/fake.sendmail\" \\\n \t\t$patches &&\n-\tsed \"1,/^\\$/d\" < msgtxt1 > msgbody1\n+\tsed \"1,/^\\$/d\" < msgtxt1 > msgbody1 &&\n \t! grep \"From: A <author@example.com>\" msgbody1\n '\n \n@@ -298,7 +298,7 @@ test_expect_success $PREREQ 'Invalid In-Reply-To' '\n \t\t--in-reply-to=\" \" \\\n \t\t--smtp-server=\"$(pwd)/fake.sendmail\" \\\n \t\t$patches \\\n-\t\t2>errors\n+\t\t2>errors &&\n \t! grep \"^In-Reply-To: < *>\" msgtxt1\n '\n \n@@ -574,7 +574,7 @@ EOF\n \"\n \n test_expect_success $PREREQ '--suppress-cc=sob' '\n-\tgit config --unset sendemail.cccmd\n+\tgit config --unset sendemail.cccmd &&\n \ttest_suppression sob\n '\n \n-- \n1.7.2.3\n"},{"id":"156324","messageId":"20101122170040.GA2084@burratino","threadId":"25806","inReplyTo":"1290429109-2318-1-git-send-email-ospite@studenti.unina.it","subject":"Re: [PATCH] t/t9001-send-email.sh: fix '&&' chain in some tests","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2010-11-22T17:00:40Z","receivedAt":"2010-11-22T17:00:40Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Hi,\n\nAntonio Ospite wrote:\n\n> --- a/t/t9001-send-email.sh\n> +++ b/t/t9001-send-email.sh\n> @@ -261,10 +262,10 @@ test_expect_success $PREREQ 'Author From: in message body' '\n> test_expect_success $PREREQ 'Author From: in message body' '\n> \tclean_fake_sendmail &&\n> \tgit send-email \\\n> \t\t--from=\"Example <nobody@example.com>\" \\\n>  \t\t--to=nobody@example.com \\\n>  \t\t--smtp-server=\"$(pwd)/fake.sendmail\" \\\n>  \t\t$patches &&\n> -\tsed \"1,/^\\$/d\" < msgtxt1 > msgbody1\n> +\tsed \"1,/^\\$/d\" < msgtxt1 > msgbody1 &&\n>  \tgrep \"From: A <author@example.com>\" msgbody1\n>  '\n[...]\n>  \t\t$patches &&\n> -\tsed \"1,/^\\$/d\" < msgtxt1 > msgbody1\n> +\tsed \"1,/^\\$/d\" < msgtxt1 > msgbody1 &&\n[...]\n> @@ -300,5 +300,5 @@ test_expect_success $PREREQ 'Invalid In-Reply-To' '\n>  \t\t$patches \\\n> -\t\t2>errors\n> +\t\t2>errors &&\n\nGood.\n\n> @@ -574,7 +574,7 @@ EOF\n>  \"\n>  \n>  test_expect_success $PREREQ '--suppress-cc=sob' '\n> -\tgit config --unset sendemail.cccmd\n> +\tgit config --unset sendemail.cccmd &&\n\nThis one needs a test_might_fail in front, since \"git config --unset\"\nwould fail if some future change causes the configuration item not to\nbe set in the first place.\n\nThanks.\n"}]}