{"thread":{"id":"25792","subject":"[PATCH] git-gui: fix browsers [Up To Parent] in sub-sub-directories.","startedAt":"2010-11-19T20:43:48Z","lastAt":"2010-11-22T21:58:06Z","messageCount":2,"participants":["Bert Wesarg","Pat Thoyts"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"156209","messageId":"1290199429-30421-1-git-send-email-bert.wesarg@googlemail.com","threadId":"25792","inReplyTo":null,"subject":"[PATCH] git-gui: fix browsers [Up To Parent] in sub-sub-directories.","fromName":"Bert Wesarg","fromEmail":"bert.wesarg@googlemail.com","sentAt":"2010-11-19T20:43:48Z","receivedAt":"2010-11-19T20:43:48Z","isPatch":true,"sender":{"key":"bert.wesarg@googlemail.com","avatar":"https://avatars.githubusercontent.com/u/111934?v=4"},"body":"browser_path used to end with a slash, so the regexp matches the empty string\nand therefore removes nothing.\n\nFix this.\n\nSigned-off-by: Bert Wesarg <bert.wesarg@googlemail.com>\n\n---\n git-gui/lib/browser.tcl |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/git-gui/lib/browser.tcl b/git-gui/lib/browser.tcl\nindex c241572..a8c6223 100644\n--- a/git-gui/lib/browser.tcl\n+++ b/git-gui/lib/browser.tcl\n@@ -121,7 +121,7 @@ method _parent {} {\n \t\tif {$browser_stack eq {}} {\n \t\t\tregsub {:.*$} $browser_path {:} browser_path\n \t\t} else {\n-\t\t\tregsub {/[^/]+$} $browser_path {} browser_path\n+\t\t\tregsub {/[^/]+/$} $browser_path {/} browser_path\n \t\t}\n \t\tset browser_status [mc \"Loading %s...\" $browser_path]\n \t\t_ls $this [lindex $parent 0] [lindex $parent 1]\n-- \ntg: (6f10c41..) bw/git-gui/fix-browser-up (depends on: master)\n"},{"id":"156346","messageId":"87vd3pf2c1.fsf@fox.patthoyts.tk","threadId":"25792","inReplyTo":"1290199429-30421-1-git-send-email-bert.wesarg@googlemail.com","subject":"Re: [PATCH] git-gui: fix browsers [Up To Parent] in sub-sub-directories.","fromName":"Pat Thoyts","fromEmail":"patthoyts@users.sourceforge.net","sentAt":"2010-11-22T21:58:06Z","receivedAt":"2010-11-22T21:58:06Z","isPatch":true,"sender":{"key":"patthoyts@users.sourceforge.net","avatar":"https://avatars.githubusercontent.com/u/30739?v=4"},"body":"Bert Wesarg <bert.wesarg@googlemail.com> writes:\n\n>browser_path used to end with a slash, so the regexp matches the empty string\n>and therefore removes nothing.\n>\n>Fix this.\n>\n>Signed-off-by: Bert Wesarg <bert.wesarg@googlemail.com>\n>\n>---\n> git-gui/lib/browser.tcl |    2 +-\n> 1 files changed, 1 insertions(+), 1 deletions(-)\n>\n>diff --git a/git-gui/lib/browser.tcl b/git-gui/lib/browser.tcl\n>index c241572..a8c6223 100644\n>--- a/git-gui/lib/browser.tcl\n>+++ b/git-gui/lib/browser.tcl\n>@@ -121,7 +121,7 @@ method _parent {} {\n> \t\tif {$browser_stack eq {}} {\n> \t\t\tregsub {:.*$} $browser_path {:} browser_path\n> \t\t} else {\n>-\t\t\tregsub {/[^/]+$} $browser_path {} browser_path\n>+\t\t\tregsub {/[^/]+/$} $browser_path {/} browser_path\n> \t\t}\n> \t\tset browser_status [mc \"Loading %s...\" $browser_path]\n> \t\t_ls $this [lindex $parent 0] [lindex $parent 1]\n\nThanks - applied to git-gui master.\n-- \nPat Thoyts                            http://www.patthoyts.tk/\nPGP fingerprint 2C 6E 98 07 2C 59 C8 97  10 CE 11 E6 04 E0 B9 DD\n"}]}