{"thread":{"id":"25766","subject":"patch for AIX system","startedAt":"2010-11-17T07:29:54Z","lastAt":"2010-11-18T17:44:11Z","messageCount":6,"participants":["Norbert Nemec","Junio C Hamano","Tor Arntsen"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"156034","messageId":"4CE38472.8070206@Nemec-online.de","threadId":"25766","inReplyTo":null,"subject":"patch for AIX system","fromName":"Norbert Nemec","fromEmail":"norbert@nemec-online.de","sentAt":"2010-11-17T07:29:54Z","receivedAt":"2010-11-17T07:29:54Z","isPatch":false,"sender":{"key":"norbert@nemec-online.de","avatar":null},"body":"Find attached a small patch to make git install cleanly on an AIX system\n\n-- \n_______________________________________________Norbert Nemec\n   Lilienstr. 5a ... 12203 Berlin-Lichterfelde ... Germany\n       Tel: +49-30-5483 3143 Mobile: +49-176-5502 5643\n           eMail:<Norbert@Nemec-online.de>\n\n\n\n>From def4428ad827d1e6550634a2fe1f035c1b148426 Mon Sep 17 00:00:00 2001\nFrom: Norbert Nemec <Norbert@Nemec-online.de>\nDate: Wed, 17 Nov 2010 08:25:44 +0100\nSubject: [PATCH] Fix for installation on AIX\n\nThe BSD style 'install' command is call 'installbsd' and does not support the -d option.\nTherefore '$(INSTALL) -d' is replaced by a new variable '$(INSTALLDIR)' in all Makefiles\nwhich can be changed independently of $(INSTALL).\n---\n Documentation/Makefile |   10 +++++-----\n Makefile               |    7 +++++--\n git-gui/Makefile       |    4 ++--\n gitk-git/Makefile      |    2 +-\n gitweb/Makefile        |    4 ++--\n templates/Makefile     |    2 +-\n 6 files changed, 16 insertions(+), 13 deletions(-)\n\ndiff --git a/Documentation/Makefile b/Documentation/Makefile\nindex e117bc4..c2db8db 100644\n--- a/Documentation/Makefile\n+++ b/Documentation/Makefile\n@@ -180,15 +180,15 @@ pdf: user-manual.pdf\n install: install-man\n \n install-man: man\n-\t$(INSTALL) -d -m 755 $(DESTDIR)$(man1dir)\n-\t$(INSTALL) -d -m 755 $(DESTDIR)$(man5dir)\n-\t$(INSTALL) -d -m 755 $(DESTDIR)$(man7dir)\n+\t$(INSTALLDIR) -m 755 $(DESTDIR)$(man1dir)\n+\t$(INSTALLDIR) -m 755 $(DESTDIR)$(man5dir)\n+\t$(INSTALLDIR) -m 755 $(DESTDIR)$(man7dir)\n \t$(INSTALL) -m 644 $(DOC_MAN1) $(DESTDIR)$(man1dir)\n \t$(INSTALL) -m 644 $(DOC_MAN5) $(DESTDIR)$(man5dir)\n \t$(INSTALL) -m 644 $(DOC_MAN7) $(DESTDIR)$(man7dir)\n \n install-info: info\n-\t$(INSTALL) -d -m 755 $(DESTDIR)$(infodir)\n+\t$(INSTALLDIR) -m 755 $(DESTDIR)$(infodir)\n \t$(INSTALL) -m 644 git.info gitman.info $(DESTDIR)$(infodir)\n \tif test -r $(DESTDIR)$(infodir)/dir; then \\\n \t  $(INSTALL_INFO) --info-dir=$(DESTDIR)$(infodir) git.info ;\\\n@@ -198,7 +198,7 @@ install-info: info\n \tfi\n \n install-pdf: pdf\n-\t$(INSTALL) -d -m 755 $(DESTDIR)$(pdfdir)\n+\t$(INSTALLDIR) -m 755 $(DESTDIR)$(pdfdir)\n \t$(INSTALL) -m 644 user-manual.pdf $(DESTDIR)$(pdfdir)\n \n install-html: html\ndiff --git a/Makefile b/Makefile\nindex 1f1ce04..2664d7c 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -308,6 +308,7 @@ DIFF = diff\n TAR = tar\n FIND = find\n INSTALL = install\n+INSTALLDIR = install -d\n RPMBUILD = rpmbuild\n TCL_PATH = tclsh\n TCLTK_PATH = wish\n@@ -953,6 +954,8 @@ ifeq ($(uname_S),AIX)\n \tNO_MKSTEMPS = YesPlease\n \tNO_STRLCPY = YesPlease\n \tNO_NSEC = YesPlease\n+\tINSTALL = installbsd\n+\tINSTALLDIR = mkdir -p\n \tFREAD_READS_DIRECTORIES = UnfortunatelyYes\n \tINTERNAL_QSORT = UnfortunatelyYes\n \tNEEDS_LIBICONV=YesPlease\n@@ -2103,8 +2106,8 @@ export gitexec_instdir\n install_bindir_programs := $(patsubst %,%$X,$(BINDIR_PROGRAMS_NEED_X)) $(BINDIR_PROGRAMS_NO_X)\n \n install: all\n-\t$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(bindir_SQ)'\n-\t$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(gitexec_instdir_SQ)'\n+\t$(INSTALLDIR) -m 755 '$(DESTDIR_SQ)$(bindir_SQ)'\n+\t$(INSTALLDIR) -m 755 '$(DESTDIR_SQ)$(gitexec_instdir_SQ)'\n \t$(INSTALL) $(ALL_PROGRAMS) '$(DESTDIR_SQ)$(gitexec_instdir_SQ)'\n \t$(INSTALL) -m 644 $(SCRIPT_LIB) '$(DESTDIR_SQ)$(gitexec_instdir_SQ)'\n \t$(INSTALL) $(install_bindir_programs) '$(DESTDIR_SQ)$(bindir_SQ)'\ndiff --git a/git-gui/Makefile b/git-gui/Makefile\nindex e22ba5c..b96b3df 100644\n--- a/git-gui/Makefile\n+++ b/git-gui/Makefile\n@@ -48,7 +48,7 @@ endif\n RM_RF     ?= rm -rf\n RMDIR     ?= rmdir\n \n-INSTALL_D0 = $(INSTALL) -d -m 755 # space is required here\n+INSTALL_D0 = $(INSTALLDIR) -m 755 # space is required here\n INSTALL_D1 =\n INSTALL_R0 = $(INSTALL) -m 644 # space is required here\n INSTALL_R1 =\n@@ -76,7 +76,7 @@ ifndef V\n \tQUIET_2DEVNULL = 2>/dev/null\n \n \tINSTALL_D0 = dir=\n-\tINSTALL_D1 = && echo ' ' DEST $$dir && $(INSTALL) -d -m 755 \"$$dir\"\n+\tINSTALL_D1 = && echo ' ' DEST $$dir && $(INSTALLDIR) -m 755 \"$$dir\"\n \tINSTALL_R0 = src=\n \tINSTALL_R1 = && echo '   ' INSTALL 644 `basename $$src` && $(INSTALL) -m 644 $$src\n \tINSTALL_X0 = src=\ndiff --git a/gitk-git/Makefile b/gitk-git/Makefile\nindex e1b6045..b838d87 100644\n--- a/gitk-git/Makefile\n+++ b/gitk-git/Makefile\n@@ -41,7 +41,7 @@ all:: gitk-wish $(ALL_MSGFILES)\n \n install:: all\n \t$(INSTALL) -m 755 gitk-wish '$(DESTDIR_SQ)$(bindir_SQ)'/gitk\n-\t$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(msgsdir_SQ)'\n+\t$(INSTALLDIR) -m 755 '$(DESTDIR_SQ)$(msgsdir_SQ)'\n \t$(foreach p,$(ALL_MSGFILES), $(INSTALL) -m 644 $p '$(DESTDIR_SQ)$(msgsdir_SQ)' &&) true\n \n uninstall::\ndiff --git a/gitweb/Makefile b/gitweb/Makefile\nindex e32ee76..3f1ac82 100644\n--- a/gitweb/Makefile\n+++ b/gitweb/Makefile\n@@ -148,9 +148,9 @@ gitweb.cgi: gitweb.perl GITWEB-BUILD-OPTIONS\n ### Installation rules\n \n install: all\n-\t$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(gitwebdir_SQ)'\n+\t$(INSTALLDIR) -m 755 '$(DESTDIR_SQ)$(gitwebdir_SQ)'\n \t$(INSTALL) -m 755 $(GITWEB_PROGRAMS) '$(DESTDIR_SQ)$(gitwebdir_SQ)'\n-\t$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(gitwebstaticdir_SQ)'\n+\t$(INSTALLDIR) -m 755 '$(DESTDIR_SQ)$(gitwebstaticdir_SQ)'\n \t$(INSTALL) -m 644 $(GITWEB_FILES) '$(DESTDIR_SQ)$(gitwebstaticdir_SQ)'\n \n ### Cleaning rules\ndiff --git a/templates/Makefile b/templates/Makefile\nindex d22a71a..3808b04 100644\n--- a/templates/Makefile\n+++ b/templates/Makefile\n@@ -61,6 +61,6 @@ clean:\n \t$(RM) -r blt boilerplates.made\n \n install: all\n-\t$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(template_instdir_SQ)'\n+\t$(INSTALLDIR) -m 755 '$(DESTDIR_SQ)$(template_instdir_SQ)'\n \t(cd blt && $(TAR) cf - .) | \\\n \t(cd '$(DESTDIR_SQ)$(template_instdir_SQ)' && umask 022 && $(TAR) xof -)\n-- \n1.7.1\n\n"},{"id":"156059","messageId":"7vr5ejg7oi.fsf@alter.siamese.dyndns.org","threadId":"25766","inReplyTo":"4CE38472.8070206@Nemec-online.de","subject":"Re: patch for AIX system","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-11-17T17:51:25Z","receivedAt":"2010-11-17T17:51:25Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Norbert Nemec <Norbert@Nemec-online.de> writes:\n\n> Find attached a small patch to make git install cleanly on an AIX system\n\nA few comments, some from Documentation/SubmittingPatches.\n\n> From def4428ad827d1e6550634a2fe1f035c1b148426 Mon Sep 17 00:00:00 2001\n> From: Norbert Nemec <Norbert@Nemec-online.de>\n> Date: Wed, 17 Nov 2010 08:25:44 +0100\n> Subject: [PATCH] Fix for installation on AIX\n\nPlease don't do this; instead, make sure that From/Date/Subject of your\ne-mail usable as the metainfo for the resulting commit (in this case only\nthe Subject needs a change) and drop these lines, i.e. make the patch\ninline, not an attachment.\n\nAlso make the subject more specific, to make it clear _what_ you fixed;\nphrase it like \"Makefile: On AIX, bsdinstall does not understand -d\" or\nsomething, perhaps.\n\n> The BSD style 'install' command is call 'installbsd' and does not support the -d option.\n> Therefore '$(INSTALL) -d' is replaced by a new variable '$(INSTALLDIR)' in all Makefiles\n> which can be changed independently of $(INSTALL).\n\nThese lines are tad too long; please wrap at around 66-72 cols.\n\nMissing sign-off.\n\n> ---\n>  Documentation/Makefile |   10 +++++-----\n>  Makefile               |    7 +++++--\n>  git-gui/Makefile       |    4 ++--\n>  gitk-git/Makefile      |    2 +-\n>  gitweb/Makefile        |    4 ++--\n>  templates/Makefile     |    2 +-\n>  6 files changed, 16 insertions(+), 13 deletions(-)\n>\n> diff --git a/Documentation/Makefile b/Documentation/Makefile\n> index e117bc4..c2db8db 100644\n> --- a/Documentation/Makefile\n> +++ b/Documentation/Makefile\n> ...\n>  install-pdf: pdf\n> -\t$(INSTALL) -d -m 755 $(DESTDIR)$(pdfdir)\n> +\t$(INSTALLDIR) -m 755 $(DESTDIR)$(pdfdir)\n>  \t$(INSTALL) -m 644 user-manual.pdf $(DESTDIR)$(pdfdir)\n>  \n>  install-html: html\n\nIn the main Makefile, we have this line:\n\n\texport DIFF TAR INSTALL DESTDIR SHELL_PATH\n\nso that they can be used in \"$(MAKE) -C Documentaiton install-frotz\"\ninvocations in subdirectories, but I do not see an addition of export in\nyour patch, and you do not define INSTALLDIR in Documentation/Makefile\neither.  I wonder how this could possibly work...\n\n> diff --git a/Makefile b/Makefile\n> index 1f1ce04..2664d7c 100644\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -953,6 +954,8 @@ ifeq ($(uname_S),AIX)\n>  \tNO_MKSTEMPS = YesPlease\n>  \tNO_STRLCPY = YesPlease\n>  \tNO_NSEC = YesPlease\n> +\tINSTALL = installbsd\n> +\tINSTALLDIR = mkdir -p\n>  \tFREAD_READS_DIRECTORIES = UnfortunatelyYes\n>  \tINTERNAL_QSORT = UnfortunatelyYes\n>  \tNEEDS_LIBICONV=YesPlease\n\nI'd defer this section to AIX experts; I've always assumed that people\non non-gnu platforms used ginstall, but perhaps AIX doesn't have one?\n\nOther changes looked mostly OK, but I am still wondering how your\nINSTALLDIR is passed down to submakes.\n\n ... spends quality 30-minutes digging ...\n\nNo, your patch does not work.  Have you even tested it?\n\nThe attached patch on top of yours makes things working, it seems.\n\nPoints to note:\n\n - People may have already used \"make INSTALL=ginstall\" and been expecting\n   it to work.  Defining \"INSTALLDIR = install -d\" as the default will\n   break them (see how I defined it in the attached);\n\n - \"cd gitweb && make\" is supposed to work, so you would need fallback\n   definitions in Makefiles in subdirectories; and\n\n - When coming from the toplevel make, submakes do want the INSTALLDIR\n   definition passed from it (see how \"export\" is used).\n\nThanks.\n\n Documentation/Makefile |    3 ++-\n Makefile               |    4 ++--\n git-gui/Makefile       |    3 +++\n gitk-git/Makefile      |    1 +\n gitweb/Makefile        |    1 +\n templates/Makefile     |    1 +\n 6 files changed, 10 insertions(+), 3 deletions(-)\n\ndiff --git a/Documentation/Makefile b/Documentation/Makefile\nindex c2db8db..5c8aacc 100644\n--- a/Documentation/Makefile\n+++ b/Documentation/Makefile\n@@ -44,7 +44,8 @@ ASCIIDOC=asciidoc\n ASCIIDOC_EXTRA =\n MANPAGE_XSL = manpage-normal.xsl\n XMLTO_EXTRA =\n-INSTALL?=install\n+INSTALL ?= install\n+INSTALLDIR ?= $(INSTALL) -d\n RM ?= rm -f\n DOC_REF = origin/man\n HTML_REF = origin/html\ndiff --git a/Makefile b/Makefile\nindex 2664d7c..b91de40 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -308,7 +308,7 @@ DIFF = diff\n TAR = tar\n FIND = find\n INSTALL = install\n-INSTALLDIR = install -d\n+INSTALLDIR = $(INSTALL) -d\n RPMBUILD = rpmbuild\n TCL_PATH = tclsh\n TCLTK_PATH = wish\n@@ -1573,7 +1573,7 @@ endif\n ALL_CFLAGS += $(BASIC_CFLAGS)\n ALL_LDFLAGS += $(BASIC_LDFLAGS)\n \n-export DIFF TAR INSTALL DESTDIR SHELL_PATH\n+export DIFF TAR INSTALL INSTALLDIR DESTDIR SHELL_PATH\n \n \n ### Build rules\ndiff --git a/git-gui/Makefile b/git-gui/Makefile\nindex b96b3df..be8bd2d 100644\n--- a/git-gui/Makefile\n+++ b/git-gui/Makefile\n@@ -44,6 +44,9 @@ endif\n ifndef INSTALL\n \tINSTALL = install\n endif\n+ifndef INSTALLDIR\n+\tINSTALLDIR = $(INSTALL) -d\n+endif\n \n RM_RF     ?= rm -rf\n RMDIR     ?= rmdir\ndiff --git a/gitk-git/Makefile b/gitk-git/Makefile\nindex b838d87..473c500 100644\n--- a/gitk-git/Makefile\n+++ b/gitk-git/Makefile\n@@ -11,6 +11,7 @@ msgsdir_SQ  = $(subst ','\\'',$(msgsdir))\n TCL_PATH ?= tclsh\n TCLTK_PATH ?= wish\n INSTALL ?= install\n+INSTALLDIR ?= $(INSTALL) -d\n RM ?= rm -f\n \n DESTDIR_SQ = $(subst ','\\'',$(DESTDIR))\ndiff --git a/gitweb/Makefile b/gitweb/Makefile\nindex 3f1ac82..ee6dcc1 100644\n--- a/gitweb/Makefile\n+++ b/gitweb/Makefile\n@@ -16,6 +16,7 @@ gitwebdir ?= /var/www/cgi-bin\n \n RM ?= rm -f\n INSTALL ?= install\n+INSTALLDIR ?= $(INSTALL) -d\n \n # default configuration for gitweb\n GITWEB_CONFIG = gitweb_config.perl\ndiff --git a/templates/Makefile b/templates/Makefile\nindex 3808b04..953037c 100644\n--- a/templates/Makefile\n+++ b/templates/Makefile\n@@ -5,6 +5,7 @@ ifndef V\n endif\n \n INSTALL ?= install\n+INSTALLDIR ?= $(INSTALL) -d\n TAR ?= tar\n RM ?= rm -f\n prefix ?= $(HOME)\n"},{"id":"156082","messageId":"4CE4D741.2070307@Nemec-online.de","threadId":"25766","inReplyTo":"7vr5ejg7oi.fsf@alter.siamese.dyndns.org","subject":"Re: patch for AIX system","fromName":"Norbert Nemec","fromEmail":"norbert@nemec-online.de","sentAt":"2010-11-18T07:35:29Z","receivedAt":"2010-11-18T07:35:29Z","isPatch":false,"sender":{"key":"norbert@nemec-online.de","avatar":null},"body":"Sorry about that and thanks for the patient reply. I'll crank up my \nstandard of quality and address the issues with another submission.\n\nGreetings,\nNorbert\n\n\nOn 11/17/2010 06:51 PM, Junio C Hamano wrote:\n> Norbert Nemec<Norbert@Nemec-online.de>  writes:\n>\n>> Find attached a small patch to make git install cleanly on an AIX system\n> A few comments, some from Documentation/SubmittingPatches.\n>\n>>  From def4428ad827d1e6550634a2fe1f035c1b148426 Mon Sep 17 00:00:00 2001\n>> From: Norbert Nemec<Norbert@Nemec-online.de>\n>> Date: Wed, 17 Nov 2010 08:25:44 +0100\n>> Subject: [PATCH] Fix for installation on AIX\n> Please don't do this; instead, make sure that From/Date/Subject of your\n> e-mail usable as the metainfo for the resulting commit (in this case only\n> the Subject needs a change) and drop these lines, i.e. make the patch\n> inline, not an attachment.\n>\n> Also make the subject more specific, to make it clear _what_ you fixed;\n> phrase it like \"Makefile: On AIX, bsdinstall does not understand -d\" or\n> something, perhaps.\n>\n>> The BSD style 'install' command is call 'installbsd' and does not support the -d option.\n>> Therefore '$(INSTALL) -d' is replaced by a new variable '$(INSTALLDIR)' in all Makefiles\n>> which can be changed independently of $(INSTALL).\n> These lines are tad too long; please wrap at around 66-72 cols.\n>\n> Missing sign-off.\n>\n>> ---\n>>   Documentation/Makefile |   10 +++++-----\n>>   Makefile               |    7 +++++--\n>>   git-gui/Makefile       |    4 ++--\n>>   gitk-git/Makefile      |    2 +-\n>>   gitweb/Makefile        |    4 ++--\n>>   templates/Makefile     |    2 +-\n>>   6 files changed, 16 insertions(+), 13 deletions(-)\n>>\n>> diff --git a/Documentation/Makefile b/Documentation/Makefile\n>> index e117bc4..c2db8db 100644\n>> --- a/Documentation/Makefile\n>> +++ b/Documentation/Makefile\n>> ...\n>>   install-pdf: pdf\n>> -\t$(INSTALL) -d -m 755 $(DESTDIR)$(pdfdir)\n>> +\t$(INSTALLDIR) -m 755 $(DESTDIR)$(pdfdir)\n>>   \t$(INSTALL) -m 644 user-manual.pdf $(DESTDIR)$(pdfdir)\n>>\n>>   install-html: html\n> In the main Makefile, we have this line:\n>\n> \texport DIFF TAR INSTALL DESTDIR SHELL_PATH\n>\n> so that they can be used in \"$(MAKE) -C Documentaiton install-frotz\"\n> invocations in subdirectories, but I do not see an addition of export in\n> your patch, and you do not define INSTALLDIR in Documentation/Makefile\n> either.  I wonder how this could possibly work...\n>\n>> diff --git a/Makefile b/Makefile\n>> index 1f1ce04..2664d7c 100644\n>> --- a/Makefile\n>> +++ b/Makefile\n>> @@ -953,6 +954,8 @@ ifeq ($(uname_S),AIX)\n>>   \tNO_MKSTEMPS = YesPlease\n>>   \tNO_STRLCPY = YesPlease\n>>   \tNO_NSEC = YesPlease\n>> +\tINSTALL = installbsd\n>> +\tINSTALLDIR = mkdir -p\n>>   \tFREAD_READS_DIRECTORIES = UnfortunatelyYes\n>>   \tINTERNAL_QSORT = UnfortunatelyYes\n>>   \tNEEDS_LIBICONV=YesPlease\n> I'd defer this section to AIX experts; I've always assumed that people\n> on non-gnu platforms used ginstall, but perhaps AIX doesn't have one?\n>\n> Other changes looked mostly OK, but I am still wondering how your\n> INSTALLDIR is passed down to submakes.\n>\n>   ... spends quality 30-minutes digging ...\n>\n> No, your patch does not work.  Have you even tested it?\n>\n> The attached patch on top of yours makes things working, it seems.\n>\n> Points to note:\n>\n>   - People may have already used \"make INSTALL=ginstall\" and been expecting\n>     it to work.  Defining \"INSTALLDIR = install -d\" as the default will\n>     break them (see how I defined it in the attached);\n>\n>   - \"cd gitweb&&  make\" is supposed to work, so you would need fallback\n>     definitions in Makefiles in subdirectories; and\n>\n>   - When coming from the toplevel make, submakes do want the INSTALLDIR\n>     definition passed from it (see how \"export\" is used).\n>\n> Thanks.\n>\n>   Documentation/Makefile |    3 ++-\n>   Makefile               |    4 ++--\n>   git-gui/Makefile       |    3 +++\n>   gitk-git/Makefile      |    1 +\n>   gitweb/Makefile        |    1 +\n>   templates/Makefile     |    1 +\n>   6 files changed, 10 insertions(+), 3 deletions(-)\n>\n> diff --git a/Documentation/Makefile b/Documentation/Makefile\n> index c2db8db..5c8aacc 100644\n> --- a/Documentation/Makefile\n> +++ b/Documentation/Makefile\n> @@ -44,7 +44,8 @@ ASCIIDOC=asciidoc\n>   ASCIIDOC_EXTRA =\n>   MANPAGE_XSL = manpage-normal.xsl\n>   XMLTO_EXTRA =\n> -INSTALL?=install\n> +INSTALL ?= install\n> +INSTALLDIR ?= $(INSTALL) -d\n>   RM ?= rm -f\n>   DOC_REF = origin/man\n>   HTML_REF = origin/html\n> diff --git a/Makefile b/Makefile\n> index 2664d7c..b91de40 100644\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -308,7 +308,7 @@ DIFF = diff\n>   TAR = tar\n>   FIND = find\n>   INSTALL = install\n> -INSTALLDIR = install -d\n> +INSTALLDIR = $(INSTALL) -d\n>   RPMBUILD = rpmbuild\n>   TCL_PATH = tclsh\n>   TCLTK_PATH = wish\n> @@ -1573,7 +1573,7 @@ endif\n>   ALL_CFLAGS += $(BASIC_CFLAGS)\n>   ALL_LDFLAGS += $(BASIC_LDFLAGS)\n>\n> -export DIFF TAR INSTALL DESTDIR SHELL_PATH\n> +export DIFF TAR INSTALL INSTALLDIR DESTDIR SHELL_PATH\n>\n>\n>   ### Build rules\n> diff --git a/git-gui/Makefile b/git-gui/Makefile\n> index b96b3df..be8bd2d 100644\n> --- a/git-gui/Makefile\n> +++ b/git-gui/Makefile\n> @@ -44,6 +44,9 @@ endif\n>   ifndef INSTALL\n>   \tINSTALL = install\n>   endif\n> +ifndef INSTALLDIR\n> +\tINSTALLDIR = $(INSTALL) -d\n> +endif\n>\n>   RM_RF     ?= rm -rf\n>   RMDIR     ?= rmdir\n> diff --git a/gitk-git/Makefile b/gitk-git/Makefile\n> index b838d87..473c500 100644\n> --- a/gitk-git/Makefile\n> +++ b/gitk-git/Makefile\n> @@ -11,6 +11,7 @@ msgsdir_SQ  = $(subst ','\\'',$(msgsdir))\n>   TCL_PATH ?= tclsh\n>   TCLTK_PATH ?= wish\n>   INSTALL ?= install\n> +INSTALLDIR ?= $(INSTALL) -d\n>   RM ?= rm -f\n>\n>   DESTDIR_SQ = $(subst ','\\'',$(DESTDIR))\n> diff --git a/gitweb/Makefile b/gitweb/Makefile\n> index 3f1ac82..ee6dcc1 100644\n> --- a/gitweb/Makefile\n> +++ b/gitweb/Makefile\n> @@ -16,6 +16,7 @@ gitwebdir ?= /var/www/cgi-bin\n>\n>   RM ?= rm -f\n>   INSTALL ?= install\n> +INSTALLDIR ?= $(INSTALL) -d\n>\n>   # default configuration for gitweb\n>   GITWEB_CONFIG = gitweb_config.perl\n> diff --git a/templates/Makefile b/templates/Makefile\n> index 3808b04..953037c 100644\n> --- a/templates/Makefile\n> +++ b/templates/Makefile\n> @@ -5,6 +5,7 @@ ifndef V\n>   endif\n>\n>   INSTALL ?= install\n> +INSTALLDIR ?= $(INSTALL) -d\n>   TAR ?= tar\n>   RM ?= rm -f\n>   prefix ?= $(HOME)\n\n\n-- \n_______________________________________________Norbert Nemec\n   Lilienstr. 5a ... 12203 Berlin-Lichterfelde ... Germany\n       Tel: +49-30-5483 3143 Mobile: +49-176-5502 5643\n           eMail:<Norbert@Nemec-online.de>\n"},{"id":"156085","messageId":"AANLkTi=94zL-nuBeGcrAdWVBu6VTuqX3xcM9oGNNUwvQ@mail.gmail.com","threadId":"25766","inReplyTo":"7vr5ejg7oi.fsf@alter.siamese.dyndns.org","subject":"Re: patch for AIX system","fromName":"Tor Arntsen","fromEmail":"tor@spacetec.no","sentAt":"2010-11-18T09:13:17Z","receivedAt":"2010-11-18T09:13:17Z","isPatch":false,"sender":{"key":"tor@spacetec.no","avatar":null},"body":"On Wed, Nov 17, 2010 at 18:51, Junio C Hamano <gitster@pobox.com> wrote:\n\n> I'd defer this section to AIX experts; I've always assumed that people\n> on non-gnu platforms used ginstall, but perhaps AIX doesn't have one?\n\nAll my AIX systems have the coreutils RPM from the IBM Toolbox\ninstalled (extra CD, or, these days, from ftp.software.ibm.com), so I\nnever ran into the incompatible install issue.\nHowever, for those without coreutils a patch to make installbsd work\n(with comments from Junio taken into account) would be reasonable I\nguess. Particularly if the patch could be made so that it's easy\nenough to switch to coreutils install if you wish to.\n\n-Tor\n"},{"id":"156091","messageId":"4CE503A6.6060208@Nemec-online.de","threadId":"25766","inReplyTo":"AANLkTi=94zL-nuBeGcrAdWVBu6VTuqX3xcM9oGNNUwvQ@mail.gmail.com","subject":"Re: patch for AIX system","fromName":"Norbert Nemec","fromEmail":"norbert@nemec-online.de","sentAt":"2010-11-18T10:44:54Z","receivedAt":"2010-11-18T10:44:54Z","isPatch":false,"sender":{"key":"norbert@nemec-online.de","avatar":null},"body":"On 11/18/2010 10:13 AM, Tor Arntsen wrote:\n> On Wed, Nov 17, 2010 at 18:51, Junio C Hamano<gitster@pobox.com>  wrote:\n>> I'd defer this section to AIX experts; I've always assumed that people\n>> on non-gnu platforms used ginstall, but perhaps AIX doesn't have one?\n> All my AIX systems have the coreutils RPM from the IBM Toolbox\n> installed (extra CD, or, these days, from ftp.software.ibm.com), so I\n> never ran into the incompatible install issue.\n> However, for those without coreutils a patch to make installbsd work\n> (with comments from Junio taken into account) would be reasonable I\n> guess. Particularly if the patch could be made so that it's easy\n> enough to switch to coreutils install if you wish to.\nA new version of the patch is in preparation.\n\nIndeed - I don't have root access on the machine in question, so \ninstalling a RPM is not an option. Apart from that - keeping a \ndependency on coreutils just to have ginstall available does not seem \nsuch a good idea. Anyway - the patch allows changing to ginstall simply \nby changing the INSTALLDIR variable.\n\n-- \n_______________________________________________Norbert Nemec\n   Lilienstr. 5a ... 12203 Berlin-Lichterfelde ... Germany\n       Tel: +49-30-5483 3143 Mobile: +49-176-5502 5643\n           eMail:<Norbert@Nemec-online.de>\n"},{"id":"156119","messageId":"7vaal6cys4.fsf@alter.siamese.dyndns.org","threadId":"25766","inReplyTo":"AANLkTi=94zL-nuBeGcrAdWVBu6VTuqX3xcM9oGNNUwvQ@mail.gmail.com","subject":"Re: patch for AIX system","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-11-18T17:44:11Z","receivedAt":"2010-11-18T17:44:11Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Tor Arntsen <tor@spacetec.no> writes:\n\n> On Wed, Nov 17, 2010 at 18:51, Junio C Hamano <gitster@pobox.com> wrote:\n>\n>> I'd defer this section to AIX experts; I've always assumed that people\n>> on non-gnu platforms used ginstall, but perhaps AIX doesn't have one?\n>\n> All my AIX systems have the coreutils RPM from the IBM Toolbox\n> installed (extra CD, or, these days, from ftp.software.ibm.com), so I\n> never ran into the incompatible install issue.\n> However, for those without coreutils a patch to make installbsd work\n> (with comments from Junio taken into account) would be reasonable I\n> guess. Particularly if the patch could be made so that it's easy\n> enough to switch to coreutils install if you wish to.\n\nHmm, would that suggest that it might be a better idea to just mention\n\"install coreutils RPM from the IBM Toolbox\" somewhere in INSTALL instead\nof the INSTALLDIR patch, i.e. not support \"bsdinstall/mkdir -p\" way but\nrequire \"coreutils\"?  Or is it an unconditionally better way of life for\nAIX folks, even for the ones who do have it installed, not to rely on the\n\"coreutils\" package?\n\nIf the answers to the above two questions are both \"no\", then we would\nneed to make the patch more complicated (i.e. detect if \"coreutils\" is\nthere and if not use \"bsdinstall/mkdir -p\" way), which I'd rather avoid\nif we do not have to.\n"}]}