{"thread":{"id":"25751","subject":"[PATCH] clean: avoid quoting twice","startedAt":"2010-11-15T10:12:44Z","lastAt":"2010-11-15T10:12:44Z","messageCount":1,"participants":["Nguyễn Thái Ngọc Duy"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"155910","messageId":"1289815964-31999-1-git-send-email-pclouds@gmail.com","threadId":"25751","inReplyTo":null,"subject":"[PATCH] clean: avoid quoting twice","fromName":"Nguyễn Thái Ngọc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2010-11-15T10:12:44Z","receivedAt":"2010-11-15T10:12:44Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"qname is the result of quote_path_relative(), which does\nquote_c_style_counted() internally. Remove the hard-coded quotes.\n\nSigned-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>\n---\n builtin/clean.c |    4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/builtin/clean.c b/builtin/clean.c\nindex c8798f5..8f602c9 100644\n--- a/builtin/clean.c\n+++ b/builtin/clean.c\n@@ -153,7 +153,7 @@ int cmd_clean(int argc, const char **argv, const char *prefix)\n \t\t\t\t\tprintf(\"Removing %s\\n\", qname);\n \t\t\t\tif (remove_dir_recursively(&directory,\n \t\t\t\t\t\t\t   rm_flags) != 0) {\n-\t\t\t\t\twarning(\"failed to remove '%s'\", qname);\n+\t\t\t\t\twarning(\"failed to remove %s\", qname);\n \t\t\t\t\terrors++;\n \t\t\t\t}\n \t\t\t} else if (show_only) {\n@@ -173,7 +173,7 @@ int cmd_clean(int argc, const char **argv, const char *prefix)\n \t\t\t\tprintf(\"Removing %s\\n\", qname);\n \t\t\t}\n \t\t\tif (unlink(ent->name) != 0) {\n-\t\t\t\twarning(\"failed to remove '%s'\", qname);\n+\t\t\t\twarning(\"failed to remove %s\", qname);\n \t\t\t\terrors++;\n \t\t\t}\n \t\t}\n-- \n1.7.3.2.210.g045198\n"}]}