{"thread":{"id":"25726","subject":"possible 'git --dirstat=0' buglet in 1.7.0.4?","startedAt":"2010-11-12T14:33:56Z","lastAt":"2010-11-16T18:05:06Z","messageCount":2,"participants":["Mike Coleman","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"155781","messageId":"AANLkTi=wZ8MhU0NUw9as-kw8Lhr=TFBK2BY7MFRQvOct@mail.gmail.com","threadId":"25726","inReplyTo":null,"subject":"possible 'git --dirstat=0' buglet in 1.7.0.4?","fromName":"Mike Coleman","fromEmail":"tutufan@gmail.com","sentAt":"2010-11-12T14:33:56Z","receivedAt":"2010-11-12T14:33:56Z","isPatch":false,"sender":{"key":"tutufan@gmail.com","avatar":null},"body":"I noticed just now that the '--dirstat=0' flag still seems to filter\nout some diffs, even though I would expect the '0' to mean \"don't\nfilter anything\".  If there's another flag that says \"don't filter\", I\nmissed it.  Could this be a rounding or off-by-one error?\n\nMike\n"},{"id":"156007","messageId":"7v7hgdi1pp.fsf@alter.siamese.dyndns.org","threadId":"25726","inReplyTo":"AANLkTi=wZ8MhU0NUw9as-kw8Lhr=TFBK2BY7MFRQvOct@mail.gmail.com","subject":"Re: possible 'git --dirstat=0' buglet in 1.7.0.4?","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-11-16T18:05:06Z","receivedAt":"2010-11-16T18:05:06Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Mike Coleman <tutufan@gmail.com> writes:\n\n> I noticed just now that the '--dirstat=0' flag still seems to filter\n> out some diffs, even though I would expect the '0' to mean \"don't\n> filter anything\".  If there's another flag that says \"don't filter\", I\n> missed it.  Could this be a rounding or off-by-one error?\n\nWe seem to internally compute in per-mille (see gather_dirstat() in diff.c)\nso if your changes are too small to be rounded off to zero there,...\n\nI think you can remove the \"if (permille)\" there to make it not filter at\nall when dir->percent is set to 0, but I didn't look carefully.\n"}]}