{"thread":{"id":"25695","subject":"[PATCH] rebase: only show stat if configured to true","startedAt":"2010-11-09T20:59:00Z","lastAt":"2010-11-29T22:50:34Z","messageCount":2,"participants":["Martin von Zweigbergk","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"155566","messageId":"1289336340-28337-1-git-send-email-martin.von.zweigbergk@gmail.com","threadId":"25695","inReplyTo":null,"subject":"[PATCH] rebase: only show stat if configured to true","fromName":"Martin von Zweigbergk","fromEmail":"martin.von.zweigbergk@gmail.com","sentAt":"2010-11-09T20:59:00Z","receivedAt":"2010-11-09T20:59:00Z","isPatch":true,"sender":{"key":"martinvonz@gmail.com","avatar":"https://avatars.githubusercontent.com/u/891642?v=4"},"body":"If rebase.stat is set to true, a diffstat should be displayed. If it is\nnot set, it should default to false. However, if it is explicitly set to\nfalse (or other value), a diffstat is still displayed, which is probably\nnot what most users would expect. Show diffstat only if it is set\nto true.\n\nSigned-off-by: Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>\n---\n git-rebase.sh |    3 ++-\n 1 files changed, 2 insertions(+), 1 deletions(-)\n\ndiff --git a/git-rebase.sh b/git-rebase.sh\nindex e5df23b..42c0628 100755\n--- a/git-rebase.sh\n+++ b/git-rebase.sh\n@@ -49,7 +49,8 @@ do_merge=\n dotest=\"$GIT_DIR\"/rebase-merge\n prec=4\n verbose=\n-diffstat=$(git config --bool rebase.stat)\n+diffstat=\n+test \"$(git config --bool rebase.stat)\" = true && diffstat=t\n git_am_opt=\n rebase_root=\n force_rebase=\n-- \n1.7.3.2.167.ga361b\n"},{"id":"156849","messageId":"7veia3zqv9.fsf@alter.siamese.dyndns.org","threadId":"25695","inReplyTo":"1289336340-28337-1-git-send-email-martin.von.zweigbergk@gmail.com","subject":"Re: [PATCH] rebase: only show stat if configured to true","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-11-29T22:50:34Z","receivedAt":"2010-11-29T22:50:34Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Martin von Zweigbergk <martin.von.zweigbergk@gmail.com> writes:\n\n> If rebase.stat is set to true, a diffstat should be displayed. If it is\n> not set, it should default to false. However, if it is explicitly set to\n> false (or other value), a diffstat is still displayed, which is probably\n> not what most users would expect. Show diffstat only if it is set\n> to true.\n>\n> Signed-off-by: Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>\n> ---\n\nSounds sensible; it would have been nicer if it came with a test, but this\nparticular change is sort of obvious ;-)\n\nThanks.\n"}]}