{"thread":{"id":"25625","subject":"[PATCH] builtin: make commit_notes function private to notes.c","startedAt":"2010-11-03T04:47:24Z","lastAt":"2010-11-03T04:47:24Z","messageCount":1,"participants":["Thiago Farina"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"155023","messageId":"48613a1a105a7dc6ed1fa76ac3cdae2ed2a859e4.1288759498.git.tfransosi@gmail.com","threadId":"25625","inReplyTo":null,"subject":"[PATCH] builtin: make commit_notes function private to notes.c","fromName":"Thiago Farina","fromEmail":"tfransosi@gmail.com","sentAt":"2010-11-03T04:47:24Z","receivedAt":"2010-11-03T04:47:24Z","isPatch":true,"sender":{"key":"tfransosi@gmail.com","avatar":"https://avatars.githubusercontent.com/u/970071?v=4"},"body":"This function was exported in builtin.h but is only used on notes.c.\n\nSigned-off-by: Thiago Farina <tfransosi@gmail.com>\n---\n builtin.h       |    1 -\n builtin/notes.c |    2 +-\n 2 files changed, 1 insertions(+), 2 deletions(-)\n\ndiff --git a/builtin.h b/builtin.h\nindex f2a25a0..8017ade 100644\n--- a/builtin.h\n+++ b/builtin.h\n@@ -16,7 +16,6 @@ extern const char git_more_info_string[];\n extern void prune_packed_objects(int);\n extern int fmt_merge_msg(struct strbuf *in, struct strbuf *out,\n \t\t\t int merge_title, int shortlog_len);\n-extern int commit_notes(struct notes_tree *t, const char *msg);\n \n struct notes_rewrite_cfg {\n \tstruct notes_tree **trees;\ndiff --git a/builtin/notes.c b/builtin/notes.c\nindex 6d07aac..89fe169 100644\n--- a/builtin/notes.c\n+++ b/builtin/notes.c\n@@ -271,7 +271,7 @@ static int parse_reedit_arg(const struct option *opt, const char *arg, int unset\n \treturn parse_reuse_arg(opt, arg, unset);\n }\n \n-int commit_notes(struct notes_tree *t, const char *msg)\n+static int commit_notes(struct notes_tree *t, const char *msg)\n {\n \tstruct commit_list *parent;\n \tunsigned char tree_sha1[20], prev_commit[20], new_commit[20];\n-- \n1.7.3.2.90.gd4c43\n"}]}