{"thread":{"id":"25566","subject":"[BUG?] t9500 --debug prints \"sh: ++GIT_BINDIR++/git: not found\"","startedAt":"2010-10-27T20:49:54Z","lastAt":"2010-10-27T22:32:01Z","messageCount":4,"participants":["Jonathan Nieder","Jakub Narebski"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"154576","messageId":"20101027204954.GA31386@burratino","threadId":"25566","inReplyTo":null,"subject":"[BUG?] t9500 --debug prints \"sh: ++GIT_BINDIR++/git: not found\"","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2010-10-27T20:49:54Z","receivedAt":"2010-10-27T20:49:54Z","isPatch":false,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Hi,\n\nTrying to run t9500-gitweb-standalone-no-errors.sh, I find:\n\n $ sh t9500-gitweb-standalone-no-errors.sh --debug\n ok 1 - no commits: projects_list (implicit)\n sh: ++GIT_BINDIR++/git: not found\n ok 2 - no commits: projects_index\n sh: ++GIT_BINDIR++/git: not found\n ok 3 - no commits: .git summary (implicit)\n [...]\n\nconfig.mak reads:\n\n CFLAGS = -g -O2 -Wall -Wdeclaration-after-statement\n NO_OPENSSL=1\n NO_EXPAT=1\n COMPUTE_HEADER_DEPENDENCIES=1\n USE_NSEC=1\n ASCIIDOC8=1\n ASCIIDOC_NO_ROFF=1\n\nand there is no config.mak.autogen or other source of build flags.\n\nIdeas?  Is this expected behavior?\n"},{"id":"154578","messageId":"m3ocafib6z.fsf@localhost.localdomain","threadId":"25566","inReplyTo":"20101027204954.GA31386@burratino","subject":"Re: [BUG?] t9500 --debug prints \"sh: ++GIT_BINDIR++/git: not found\"","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2010-10-27T21:21:53Z","receivedAt":"2010-10-27T21:21:53Z","isPatch":false,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Jonathan Nieder <jrnieder@gmail.com> writes:\n\n> Trying to run t9500-gitweb-standalone-no-errors.sh, I find:\n> \n>  $ sh t9500-gitweb-standalone-no-errors.sh --debug\n>  ok 1 - no commits: projects_list (implicit)\n>  sh: ++GIT_BINDIR++/git: not found\n>  ok 2 - no commits: projects_index\n>  sh: ++GIT_BINDIR++/git: not found\n>  ok 3 - no commits: .git summary (implicit)\n>  [...]\n\n> Ideas?  Is this expected behavior?\n\nFixed in 8ff76f4 (gitweb: Move call to evaluate_git_version after\nevaluate_gitweb_config, 2010-09-26):\n\n    gitweb: Move call to evaluate_git_version after evaluate_gitweb_config\n    \n    This means that call to evaluate_git_version() is now inside\n    run_request(), which means that is called for each request instead of\n    once per starting gitweb; this matter currently only when using\n    FastCGI interface (gitweb.fcgi).\n    \n    This change was done becayse evaluate_git_version() uses $GIT\n    variable, which can be set / modified by gitweb config file... and it\n    is modified this way by gitweb config file used in gitweb tests.\n    Without this change there is spurious extra output from t9500 test\n    when tests are run with '--debug' option.\n\nwhich is part of\n\n* jn/gitweb-test (2010-09-26) 4 commits\n - gitweb/Makefile: Include gitweb/config.mak\n - gitweb/Makefile: Add 'test' and 'test-installed' targets\n - t/gitweb-lib.sh: Add support for GITWEB_TEST_INSTALLED\n - gitweb: Move call to evaluate_git_version after evaluate_gitweb_config\n\n-- \nJakub Narebski\nPoland\nShadeHawk on #git\n"},{"id":"154579","messageId":"20101027213405.GA10263@burratino","threadId":"25566","inReplyTo":"m3ocafib6z.fsf@localhost.localdomain","subject":"Re: [BUG?] t9500 --debug prints \"sh: ++GIT_BINDIR++/git: not found\"","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2010-10-27T21:34:05Z","receivedAt":"2010-10-27T21:34:05Z","isPatch":false,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Jakub Narebski wrote:\n> Jonathan Nieder <jrnieder@gmail.com> writes:\n> \n>>  sh: ++GIT_BINDIR++/git: not found\n>>  ok 3 - no commits: .git summary (implicit)\n>>  [...]\n[...]\n> Fixed in 8ff76f4 (gitweb: Move call to evaluate_git_version after\n> evaluate_gitweb_config, 2010-09-26):\n\nOh!  Yes, that works.  Thanks and sorry for the noise.\n"},{"id":"154581","messageId":"m3k4l3i7y9.fsf@localhost.localdomain","threadId":"25566","inReplyTo":"20101027213405.GA10263@burratino","subject":"Re: [BUG?] t9500 --debug prints \"sh: ++GIT_BINDIR++/git: not found\"","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2010-10-27T22:32:01Z","receivedAt":"2010-10-27T22:32:01Z","isPatch":false,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Jonathan Nieder <jrnieder@gmail.com> writes:\n> Jakub Narebski wrote:\n>> Jonathan Nieder <jrnieder@gmail.com> writes:\n>> \n>>>  sh: ++GIT_BINDIR++/git: not found\n>>>  ok 3 - no commits: .git summary (implicit)\n>>>  [...]\n> [...]\n>> Fixed in 8ff76f4 (gitweb: Move call to evaluate_git_version after\n>> evaluate_gitweb_config, 2010-09-26):\n> \n> Oh!  Yes, that works.  Thanks and sorry for the noise.\n\nYou are welcome.\n\nI should have perhaps choose comit title differently, e.g.:\n\n  gitweb: Fix ./t950* --debug\n\nor something like that.\n-- \nJakub Narebski\nPoland\nShadeHawk on #git\n"}]}