{"thread":{"id":"25434","subject":"Problem with git bundle creation","startedAt":"2010-10-13T01:58:20Z","lastAt":"2010-10-15T16:52:56Z","messageCount":2,"participants":["Kris Shannon","Jonathan Nieder"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"153369","messageId":"AANLkTimsMgsuiS4iT2z_ggD8t0V9xj7ezwxRHk9WgaOw@mail.gmail.com","threadId":"25434","inReplyTo":null,"subject":"Problem with git bundle creation","fromName":"Kris Shannon","fromEmail":"kris@shannon.id.au","sentAt":"2010-10-13T01:58:20Z","receivedAt":"2010-10-13T01:58:20Z","isPatch":false,"sender":{"key":"kris@shannon.id.au","avatar":"https://gravatar.com/avatar/13a7c0b3c50ffacf54f456e543023fd702898bb134165fa805f019930524151f?d=mp&s=160"},"body":"git clone git://github.com/freenet/fred-official.git\ngit bundle create bad.gitbundle -1 build01194\nhead -2 bad.gitbundle\n\nProblem manifested by a commit message which happens to have a hyphen\nin just the wrong place such that git rev-list --boundary\n--pretty=oneline has a line which exceeds the 1024 buffer limit that\ngit bundle is using for reading and happens to read in the rest of the\ncommit messsage as a boundary commit.\n\ngit bundle should probably be checking that the fgets buffer actually\nends in a newline and if it doesn't then slurp in more until it does\n(probably discarding it in the process)\n"},{"id":"153590","messageId":"20101015165256.GB10204@burratino","threadId":"25434","inReplyTo":"AANLkTimsMgsuiS4iT2z_ggD8t0V9xj7ezwxRHk9WgaOw@mail.gmail.com","subject":"Re: Problem with git bundle creation","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2010-10-15T16:52:56Z","receivedAt":"2010-10-15T16:52:56Z","isPatch":false,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Kris Shannon wrote:\n\n> git clone git://github.com/freenet/fred-official.git\n> git bundle create bad.gitbundle -1 build01194\n> head -2 bad.gitbundle\n> \n> Problem manifested by a commit message which happens to have a hyphen\n> in just the wrong place such that git rev-list --boundary\n> --pretty=oneline has a line which exceeds the 1024 buffer limit that\n> git bundle is using for reading and happens to read in the rest of the\n> commit messsage as a boundary commit.\n> \n> git bundle should probably be checking that the fgets buffer actually\n> ends in a newline and if it doesn't then slurp in more until it does\n> (probably discarding it in the process)\n\nSounds like you've tracked down the problem.  Care to write a patch?\n(Even a placeholder that die()s would be helpful if you don't have\ntime for the full proposed fix.)\n\nThanks for reporting.\nJonathan\n"}]}