{"thread":{"id":"25413","subject":"[PATCH 1/2] bash: offer refs for 'git bisect start'","startedAt":"2010-10-10T21:39:33Z","lastAt":"2010-10-10T22:14:55Z","messageCount":5,"participants":["SZEDER Gábor","Sverre Rabbelier"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"153185","messageId":"1286746774-7877-1-git-send-email-szeder@ira.uka.de","threadId":"25413","inReplyTo":null,"subject":"[PATCH 1/2] bash: offer refs for 'git bisect start'","fromName":"SZEDER Gábor","fromEmail":"szeder@ira.uka.de","sentAt":"2010-10-10T21:39:33Z","receivedAt":"2010-10-10T21:39:33Z","isPatch":true,"sender":{"key":"szeder.dev@gmail.com","avatar":"https://avatars.githubusercontent.com/u/116324?v=4"},"body":"The completion script only offered path completion after 'git bisect\nstart', although bad and good refs could also be specified before the\ndoubledash.\n\nSigned-off-by: SZEDER Gábor <szeder@ira.uka.de>\n---\n contrib/completion/git-completion.bash |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 6756990..eb8ef47 100755\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -912,7 +912,7 @@ _git_bisect ()\n \tfi\n \n \tcase \"$subcommand\" in\n-\tbad|good|reset|skip)\n+\tbad|good|reset|skip|start)\n \t\t__gitcomp \"$(__git_refs)\"\n \t\t;;\n \t*)\n-- \n1.7.3.1.148.g2fffa\n"},{"id":"153186","messageId":"1286746774-7877-2-git-send-email-szeder@ira.uka.de","threadId":"25413","inReplyTo":"1286746774-7877-1-git-send-email-szeder@ira.uka.de","subject":"[PATCH 2/2] bash: not all 'git bisect' subcommands make sense when not bisecting","fromName":"SZEDER Gábor","fromEmail":"szeder@ira.uka.de","sentAt":"2010-10-10T21:39:34Z","receivedAt":"2010-10-10T21:39:34Z","isPatch":true,"sender":{"key":"szeder.dev@gmail.com","avatar":"https://avatars.githubusercontent.com/u/116324?v=4"},"body":"... but only 'start' and 'replay'.  The other commands will either\nerror out or offer to start bisecting for the user.\n\nSigned-off-by: SZEDER Gábor <szeder@ira.uka.de>\n---\n contrib/completion/git-completion.bash |    6 +++++-\n 1 files changed, 5 insertions(+), 1 deletions(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex eb8ef47..1262f72 100755\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -907,7 +907,11 @@ _git_bisect ()\n \tlocal subcommands=\"start bad good skip reset visualize replay log run\"\n \tlocal subcommand=\"$(__git_find_on_cmdline \"$subcommands\")\"\n \tif [ -z \"$subcommand\" ]; then\n-\t\t__gitcomp \"$subcommands\"\n+\t\tif [ -f \"$(__gitdir)\"/BISECT_START ]; then\n+\t\t\t__gitcomp \"$subcommands\"\n+\t\telse\n+\t\t\t__gitcomp \"replay start\"\n+\t\tfi\n \t\treturn\n \tfi\n \n-- \n1.7.3.1.148.g2fffa\n"},{"id":"153193","messageId":"AANLkTi==oCKgw86fy6sPiPuKuownsbob3xXiY=hHhYrQ@mail.gmail.com","threadId":"25413","inReplyTo":"1286746774-7877-2-git-send-email-szeder@ira.uka.de","subject":"Re: [PATCH 2/2] bash: not all 'git bisect' subcommands make sense when not bisecting","fromName":"Sverre Rabbelier","fromEmail":"srabbelier@gmail.com","sentAt":"2010-10-10T22:05:52Z","receivedAt":"2010-10-10T22:05:52Z","isPatch":true,"sender":{"key":"srabbelier@gmail.com","avatar":"https://avatars.githubusercontent.com/u/3098?v=4"},"body":"Heya,\n\nOn Sun, Oct 10, 2010 at 23:39, SZEDER Gábor <szeder@ira.uka.de> wrote:\n> ... but only 'start' and 'replay'.  The other commands will either\n> error out or offer to start bisecting for the user.\n\nI'm not sure, following the same concept \"git rebase\" should not offer\n\"--continue\" if you're not rebasing. It might just be frustrating for\nthe user since they might not realize they're not bisecting yet.\n\n-- \nCheers,\n\nSverre Rabbelier\n"},{"id":"153195","messageId":"20101010221232.GD12529@neumann","threadId":"25413","inReplyTo":"AANLkTi==oCKgw86fy6sPiPuKuownsbob3xXiY=hHhYrQ@mail.gmail.com","subject":"Re: [PATCH 2/2] bash: not all 'git bisect' subcommands make sense when not bisecting","fromName":"SZEDER Gábor","fromEmail":"szeder@ira.uka.de","sentAt":"2010-10-10T22:12:32Z","receivedAt":"2010-10-10T22:12:32Z","isPatch":true,"sender":{"key":"szeder.dev@gmail.com","avatar":"https://avatars.githubusercontent.com/u/116324?v=4"},"body":"Hi,\n\nOn Mon, Oct 11, 2010 at 12:05:52AM +0200, Sverre Rabbelier wrote:\n> Heya,\n> \n> On Sun, Oct 10, 2010 at 23:39, SZEDER Gábor <szeder@ira.uka.de> wrote:\n> > ... but only 'start' and 'replay'.  The other commands will either\n> > error out or offer to start bisecting for the user.\n> \n> I'm not sure, following the same concept \"git rebase\" should not offer\n> \"--continue\" if you're not rebasing.\n\nActually, my patch follows the same concept of 'git rebase', because\nthat's exactly what the completion function for 'git rebase' does: it\ndoesn't offer '--continue' (nor '--abort' and '--skip') if you're not\nrebasing.\n\nBest,\nGábor\n"},{"id":"153196","messageId":"AANLkTikvSxcjgqmenFDsRuPxcgAse-tJij8R98Wof=JZ@mail.gmail.com","threadId":"25413","inReplyTo":"20101010221232.GD12529@neumann","subject":"Re: [PATCH 2/2] bash: not all 'git bisect' subcommands make sense when not bisecting","fromName":"Sverre Rabbelier","fromEmail":"srabbelier@gmail.com","sentAt":"2010-10-10T22:14:55Z","receivedAt":"2010-10-10T22:14:55Z","isPatch":true,"sender":{"key":"srabbelier@gmail.com","avatar":"https://avatars.githubusercontent.com/u/3098?v=4"},"body":"Heya,\n\n2010/10/11 SZEDER Gábor <szeder@ira.uka.de>:\n> Actually, my patch follows the same concept of 'git rebase', because\n> that's exactly what the completion function for 'git rebase' does: it\n> doesn't offer '--continue' (nor '--abort' and '--skip') if you're not\n> rebasing.\n\nHad you only mentioned that in the commit message... ;).\n\nIn that case, sounds good!\n\n-- \nCheers,\n\nSverre Rabbelier\n"}]}