{"thread":{"id":"25409","subject":"[PATCH] Makefile: dependencies for vcs-svn tests","startedAt":"2010-10-10T05:50:32Z","lastAt":"2010-12-04T19:23:30Z","messageCount":3,"participants":["Jonathan Nieder","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"153116","messageId":"20101010055032.GA23100@burratino","threadId":"25409","inReplyTo":null,"subject":"[PATCH] Makefile: dependencies for vcs-svn tests","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2010-10-10T05:50:32Z","receivedAt":"2010-10-10T05:50:32Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"The vcs-svn tests (test-treap.o et al) depend on the vcs-svn\nheaders for declarations and inline functions.  Declare the\ndependency.  While at it, declare a dependency of the vcs-svn\nobjects (vcs-svn/string_pool.o et al) on $(LIB_H) to reflect use\nwithin the vcs-svn library of git-compat-util.h and cache.h.\n\nWithout this change, tweaks to inline functions in those headers\ndo not provoke rebuilds of the corresponding tests[*], making\nsuch changes unnecessarily difficult to test.\n\nBefore:\n\n $ touch vcs-svn/*.h && make test-treap\n $\n\nAfter:\n\n $ touch vcs-svn/*.h && make test-treap\n CC test-treap.o\n LINK test-treap\n $\n\n[*] unless COMPUTE_HEADER_DEPENDENCIES is enabled\n\nDetected with \"make CHECK_HEADER_DEPENDENCIES=1\".\n\nSigned-off-by: Jonathan Nieder <jrnieder@gmail.com>\n---\nSorry I missed this before.\n\n Makefile |    6 +++++-\n 1 files changed, 5 insertions(+), 1 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex d3dcfb1..1bd1823 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1762,6 +1762,8 @@ XDIFF_OBJS = xdiff/xdiffi.o xdiff/xprepare.o xdiff/xutils.o xdiff/xemit.o \\\n \txdiff/xmerge.o xdiff/xpatience.o\n VCSSVN_OBJS = vcs-svn/string_pool.o vcs-svn/line_buffer.o \\\n \tvcs-svn/repo_tree.o vcs-svn/fast_export.o vcs-svn/svndump.o\n+VCSSVN_TEST_OBJS = test-obj-pool.o test-string-pool.o \\\n+\ttest-line-buffer.o test-treap.o\n OBJECTS := $(GIT_OBJS) $(XDIFF_OBJS) $(VCSSVN_OBJS)\n \n dep_files := $(foreach f,$(OBJECTS),$(dir $f).depend/$(notdir $f).d)\n@@ -1885,10 +1887,12 @@ xdiff-interface.o $(XDIFF_OBJS): \\\n \txdiff/xinclude.h xdiff/xmacros.h xdiff/xdiff.h xdiff/xtypes.h \\\n \txdiff/xutils.h xdiff/xprepare.h xdiff/xdiffi.h xdiff/xemit.h\n \n-$(VCSSVN_OBJS): \\\n+$(VCSSVN_OBJS) $(VCSSVN_TEST_OBJS): $(LIB_H) \\\n \tvcs-svn/obj_pool.h vcs-svn/trp.h vcs-svn/string_pool.h \\\n \tvcs-svn/line_buffer.h vcs-svn/repo_tree.h vcs-svn/fast_export.h \\\n \tvcs-svn/svndump.h\n+\n+test-svn-fe.o: vcs-svn/svndump.h\n endif\n \n exec_cmd.s exec_cmd.o: EXTRA_CPPFLAGS = \\\n-- \n1.7.2.3\n"},{"id":"153363","messageId":"7vmxqjngin.fsf@alter.siamese.dyndns.org","threadId":"25409","inReplyTo":"20101010055032.GA23100@burratino","subject":"Re: [PATCH] Makefile: dependencies for vcs-svn tests","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-10-12T23:22:08Z","receivedAt":"2010-10-12T23:22:08Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jonathan Nieder <jrnieder@gmail.com> writes:\n\n> The vcs-svn tests (test-treap.o et al) depend on the vcs-svn\n> headers for declarations and inline functions.  Declare the\n> dependency.  While at it, declare a dependency of the vcs-svn\n> objects (vcs-svn/string_pool.o et al) on $(LIB_H) to reflect use\n> within the vcs-svn library of git-compat-util.h and cache.h.\n\nThanks.\n\n>\n>  Makefile |    6 +++++-\n>  1 files changed, 5 insertions(+), 1 deletions(-)\n>\n> diff --git a/Makefile b/Makefile\n> index d3dcfb1..1bd1823 100644\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -1762,6 +1762,8 @@ XDIFF_OBJS = xdiff/xdiffi.o xdiff/xprepare.o xdiff/xutils.o xdiff/xemit.o \\\n>  \txdiff/xmerge.o xdiff/xpatience.o\n>  VCSSVN_OBJS = vcs-svn/string_pool.o vcs-svn/line_buffer.o \\\n>  \tvcs-svn/repo_tree.o vcs-svn/fast_export.o vcs-svn/svndump.o\n> +VCSSVN_TEST_OBJS = test-obj-pool.o test-string-pool.o \\\n> +\ttest-line-buffer.o test-treap.o\n>  OBJECTS := $(GIT_OBJS) $(XDIFF_OBJS) $(VCSSVN_OBJS)\n>  \n>  dep_files := $(foreach f,$(OBJECTS),$(dir $f).depend/$(notdir $f).d)\n> @@ -1885,10 +1887,12 @@ xdiff-interface.o $(XDIFF_OBJS): \\\n>  \txdiff/xinclude.h xdiff/xmacros.h xdiff/xdiff.h xdiff/xtypes.h \\\n>  \txdiff/xutils.h xdiff/xprepare.h xdiff/xdiffi.h xdiff/xemit.h\n>  \n> -$(VCSSVN_OBJS): \\\n> +$(VCSSVN_OBJS) $(VCSSVN_TEST_OBJS): $(LIB_H) \\\n>  \tvcs-svn/obj_pool.h vcs-svn/trp.h vcs-svn/string_pool.h \\\n>  \tvcs-svn/line_buffer.h vcs-svn/repo_tree.h vcs-svn/fast_export.h \\\n>  \tvcs-svn/svndump.h\n> +\n> +test-svn-fe.o: vcs-svn/svndump.h\n>  endif\n>  \n>  exec_cmd.s exec_cmd.o: EXTRA_CPPFLAGS = \\\n> -- \n> 1.7.2.3\n"},{"id":"157309","messageId":"20101204192330.GA28181@burratino","threadId":"25409","inReplyTo":"7vmxqjngin.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] Makefile: dependencies for vcs-svn tests","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2010-12-04T19:23:30Z","receivedAt":"2010-12-04T19:23:30Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Junio C Hamano wrote:\n> Jonathan Nieder <jrnieder@gmail.com> writes:\n\n>> The vcs-svn tests (test-treap.o et al) depend on the vcs-svn\n>> headers for declarations and inline functions.  Declare the\n>> dependency.  While at it, declare a dependency of the vcs-svn\n>> objects (vcs-svn/string_pool.o et al) on $(LIB_H) to reflect use\n>> within the vcs-svn library of git-compat-util.h and cache.h.\n>\n> Thanks.\n\nWhat happened with this patch?  It doesn't seem to be applied\nin pu.\n"}]}