{"thread":{"id":"25350","subject":"[PATCH 1/2] diffcore-pickaxe.c: remove unnecessary curly braces","startedAt":"2010-10-04T22:51:47Z","lastAt":"2010-10-04T22:51:48Z","messageCount":2,"participants":["Brandon Casey"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"152617","messageId":"7B67fI3-KUXNMcC63_TwzSz0R5IrKAQx1Xuml4Po0PYEJroaM3Kd71QYcXsJK6NsImqnd3Sd4t0@cipher.nrlssc.navy.mil","threadId":"25350","inReplyTo":null,"subject":"[PATCH 1/2] diffcore-pickaxe.c: remove unnecessary curly braces","fromName":"Brandon Casey","fromEmail":"casey@nrlssc.navy.mil","sentAt":"2010-10-04T22:51:47Z","receivedAt":"2010-10-04T22:51:47Z","isPatch":true,"sender":{"key":"drafnel@gmail.com","avatar":"https://avatars.githubusercontent.com/u/921167?v=4"},"body":"From: Brandon Casey <drafnel@gmail.com>\n\n\nSigned-off-by: Brandon Casey <casey@nrlssc.navy.mil>\n---\n diffcore-pickaxe.c |    3 +--\n 1 files changed, 1 insertions(+), 2 deletions(-)\n\ndiff --git a/diffcore-pickaxe.c b/diffcore-pickaxe.c\nindex 84195e4..3857099 100644\n--- a/diffcore-pickaxe.c\n+++ b/diffcore-pickaxe.c\n@@ -269,9 +269,8 @@ static void diffcore_pickaxe_count(struct diff_options *o)\n \t\t\t\tdiff_free_filepair(p);\n \t\t}\n \n-\tif (opts & DIFF_PICKAXE_REGEX) {\n+\tif (opts & DIFF_PICKAXE_REGEX)\n \t\tregfree(&regex);\n-\t}\n \n \tfree(q->queue);\n \t*q = outq;\n-- \n1.7.3.1\n"},{"id":"152618","messageId":"7B67fI3-KUXNMcC63_TwzWm3yMw3MBsO-UId6DCtnNEi0B_PuBGQVjh0xBHrwD3jb3ptTcw5d38@cipher.nrlssc.navy.mil","threadId":"25350","inReplyTo":"7B67fI3-KUXNMcC63_TwzSz0R5IrKAQx1Xuml4Po0PYEJroaM3Kd71QYcXsJK6NsImqnd3Sd4t0@cipher.nrlssc.navy.mil","subject":"[PATCH 2/2] diffcore-pickaxe.c: a void function shouldn't try to return something","fromName":"Brandon Casey","fromEmail":"casey@nrlssc.navy.mil","sentAt":"2010-10-04T22:51:48Z","receivedAt":"2010-10-04T22:51:48Z","isPatch":true,"sender":{"key":"drafnel@gmail.com","avatar":"https://avatars.githubusercontent.com/u/921167?v=4"},"body":"From: Brandon Casey <drafnel@gmail.com>\n\n\nSigned-off-by: Brandon Casey <casey@nrlssc.navy.mil>\n---\n diffcore-pickaxe.c |    4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/diffcore-pickaxe.c b/diffcore-pickaxe.c\nindex 3857099..ea03b91 100644\n--- a/diffcore-pickaxe.c\n+++ b/diffcore-pickaxe.c\n@@ -281,7 +281,7 @@ void diffcore_pickaxe(struct diff_options *o)\n {\n \t/* Might want to warn when both S and G are on; I don't care... */\n \tif (o->pickaxe_opts & DIFF_PICKAXE_KIND_G)\n-\t\treturn diffcore_pickaxe_grep(o);\n+\t\tdiffcore_pickaxe_grep(o);\n \telse\n-\t\treturn diffcore_pickaxe_count(o);\n+\t\tdiffcore_pickaxe_count(o);\n }\n-- \n1.7.3.1\n"}]}