{"thread":{"id":"25329","subject":"[PATCH] contrib/ciabot: git-describe commit instead of HEAD","startedAt":"2010-10-04T08:02:42Z","lastAt":"2010-10-28T11:16:18Z","messageCount":5,"participants":["Sven Eckelmann","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"152491","messageId":"1286179362-23597-1-git-send-email-sven.eckelmann@gmx.de","threadId":"25329","inReplyTo":null,"subject":"[PATCH] contrib/ciabot: git-describe commit instead of HEAD","fromName":"Sven Eckelmann","fromEmail":"sven.eckelmann@gmx.de","sentAt":"2010-10-04T08:02:42Z","receivedAt":"2010-10-04T08:02:42Z","isPatch":true,"sender":{"key":"sven.eckelmann@gmx.de","avatar":null},"body":"For each commit a shorter version of the name will be generated. This is\neither the truncated hash or the output of git-describe. The\ncall to git-describe was only made with an empty shell variable instead\nof an actual commit hash. Thus it only described the current HEAD and\nnot each commit we want to submit to cia.vc.\n\nSigned-off-by: Sven Eckelmann \n---\nI send this patch already two and four weeks ago and got no reaction.\nThis is a resent in case it was forgotton.\n\n contrib/ciabot/ciabot.py | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/contrib/ciabot/ciabot.py b/contrib/ciabot/ciabot.py\nindex d0627e0..9775dff 100755\n--- a/contrib/ciabot/ciabot.py\n+++ b/contrib/ciabot/ciabot.py\n@@ -122,7 +122,7 @@ def report(refname, merged):\n branch = os.path.basename(refname)\n \n # Compute a shortnane for the revision\n- rev = do(\"git describe ${merged} 2>/dev/null\") or merged[:12]\n+ rev = do(\"git describe '\"+ merged +\"' 2>/dev/null\") or merged[:12]\n \n # Extract the neta-information for the commit\n rawcommit = do(\"git cat-file commit \" + merged)\n-- \n1.7.2.3\n"},{"id":"152551","messageId":"7vd3rp97f7.fsf@alter.siamese.dyndns.org","threadId":"25329","inReplyTo":"1286179362-23597-1-git-send-email-sven.eckelmann@gmx.de","subject":"Re: [PATCH] contrib/ciabot: git-describe commit instead of HEAD","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-10-04T17:47:24Z","receivedAt":"2010-10-04T17:47:24Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Sven Eckelmann writes:\n\n> For each commit a shorter version of the name will be generated. This is\n> either the truncated hash or the output of git-describe. The\n> call to git-describe was only made with an empty shell variable instead\n> of an actual commit hash. Thus it only described the current HEAD and\n> not each commit we want to submit to cia.vc.\n>\n> Signed-off-by: Sven Eckelmann \n> ---\n> I send this patch already two and four weeks ago and got no reaction.\n> This is a resent in case it was forgotton.\n\nAlthough the computation of \"rev\" indeed looks wrong, I do not see it used\nanywhere, so it might be a better patch to remove it ... wait, the code\ndoes something funny to slurp everything into xml via ... \n\n\tcontext = locals()\n context.update(globals())\n out = xml % context\n\nYuck.\n\nEven though it has been my policy not to complain too loudly on stuff in\ncontrib/ part of the tree, I have to say that this is a bit too _cute_ for\nmy taste.\n\nAnyway, Ok, so it _is_ used. And it needs to be fixed.\n\nI was hoping that Eric who took over the maintainership of contrib/ciabot/\ndirectory in April would give his blessing sooner, without me having to\nlook at the script.\n\nAck?\n\n> contrib/ciabot/ciabot.py | 2 +-\n> 1 files changed, 1 insertions(+), 1 deletions(-)\n>\n> diff --git a/contrib/ciabot/ciabot.py b/contrib/ciabot/ciabot.py\n> index d0627e0..9775dff 100755\n> --- a/contrib/ciabot/ciabot.py\n> +++ b/contrib/ciabot/ciabot.py\n> @@ -122,7 +122,7 @@ def report(refname, merged):\n> branch = os.path.basename(refname)\n> \n> # Compute a shortnane for the revision\n> - rev = do(\"git describe ${merged} 2>/dev/null\") or merged[:12]\n> + rev = do(\"git describe '\"+ merged +\"' 2>/dev/null\") or merged[:12]\n> \n> # Extract the neta-information for the commit\n> rawcommit = do(\"git cat-file commit \" + merged)\n> -- \n> 1.7.2.3\n"},{"id":"153227","messageId":"201010111243.25375.sven.eckelmann@gmx.de","threadId":"25329","inReplyTo":"7vd3rp97f7.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] contrib/ciabot: git-describe commit instead of HEAD","fromName":"Sven Eckelmann","fromEmail":"sven.eckelmann@gmx.de","sentAt":"2010-10-11T10:43:24Z","receivedAt":"2010-10-11T10:43:24Z","isPatch":true,"sender":{"key":"sven.eckelmann@gmx.de","avatar":null},"body":"Junio C Hamano wrote:\n> Sven Eckelmann writes:\n> > For each commit a shorter version of the name will be generated. This is\n> > either the truncated hash or the output of git-describe. The\n> > call to git-describe was only made with an empty shell variable instead\n> > of an actual commit hash. Thus it only described the current HEAD and\n> > not each commit we want to submit to cia.vc.\n> > \n> > Signed-off-by: Sven Eckelmann \n> > ---\n> > I send this patch already two and four weeks ago and got no reaction.\n> > This is a resent in case it was forgotton.\n> \n> Although the computation of \"rev\" indeed looks wrong, I do not see it used\n> anywhere, so it might be a better patch to remove it ... wait, the code\n> does something funny to slurp everything into xml via ...\n> \n> \tcontext = locals()\n> context.update(globals())\n> out = xml % context\n> \n> Yuck.\n> \n> Even though it has been my policy not to complain too loudly on stuff in\n> contrib/ part of the tree, I have to say that this is a bit too _cute_ for\n> my taste.\n> \n> Anyway, Ok, so it _is_ used. And it needs to be fixed.\n\nYes, it is a little bit confusing when reading through it, but still it is \nused. :)\n \n> I was hoping that Eric who took over the maintainership of contrib/ciabot/\n> directory in April would give his blessing sooner, without me having to\n> look at the script.\n> \n> Ack?\n\nHm, just be sure, because I saw no other replies since this message: You \nexpected reaction after that \"Ack?\" from Eric Raymond and not from me, or?\n\nAnyway, thanks for answering :)\n\nKind regards,\n\tSven\n"},{"id":"153430","messageId":"7vzkuhlwva.fsf@alter.siamese.dyndns.org","threadId":"25329","inReplyTo":"201010111243.25375.sven.eckelmann@gmx.de","subject":"Re: [PATCH] contrib/ciabot: git-describe commit instead of HEAD","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-10-13T19:24:09Z","receivedAt":"2010-10-13T19:24:09Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Sven Eckelmann writes:\n\n>> Anyway, Ok, so it _is_ used. And it needs to be fixed.\n>\n> Yes, it is a little bit confusing when reading through it, but still it is \n> used. :)\n> \n>> I was hoping that Eric who took over the maintainership of contrib/ciabot/\n>> directory in April would give his blessing sooner, without me having to\n>> look at the script.\n>> \n>> Ack?\n>\n> Hm, just be sure, because I saw no other replies since this message: You \n> expected reaction after that \"Ack?\" from Eric Raymond and not from me, or?\n\nYeah, Pinging ESR again now...\n"},{"id":"154623","messageId":"201010281316.28104.sven.eckelmann@gmx.de","threadId":"25329","inReplyTo":"7vzkuhlwva.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] contrib/ciabot: git-describe commit instead of HEAD","fromName":"Sven Eckelmann","fromEmail":"sven.eckelmann@gmx.de","sentAt":"2010-10-28T11:16:18Z","receivedAt":"2010-10-28T11:16:18Z","isPatch":true,"sender":{"key":"sven.eckelmann@gmx.de","avatar":null},"body":"On Wednesday 13 October 2010 21:24:09 Junio C Hamano wrote:\n> Sven Eckelmann writes:\n> >> Anyway, Ok, so it _is_ used. And it needs to be fixed.\n> > \n> > Yes, it is a little bit confusing when reading through it, but still it\n> > is used. :)\n> > \n> >> I was hoping that Eric who took over the maintainership of\n> >> contrib/ciabot/ directory in April would give his blessing sooner,\n> >> without me having to look at the script.\n> >> \n> >> Ack?\n> > \n> > Hm, just be sure, because I saw no other replies since this message: You\n> > expected reaction after that \"Ack?\" from Eric Raymond and not from me,\n> > or?\n> \n> Yeah, Pinging ESR again now...\n\nI am sure that he is still alive because he writes stuff \nhttp://esr.ibiblio.org/\n... but I am not sure about the rest.\n\nAnd yes, this is just another ping for ESR\n\nthanks,\n\tSven\n"}]}