{"thread":{"id":"25255","subject":"[PATCH] git-send-email.perl: ensure $domain is defined before using it","startedAt":"2010-09-27T03:18:01Z","lastAt":"2010-09-27T22:19:40Z","messageCount":2,"participants":["Brandon Casey","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"151781","messageId":"1285557481-16357-1-git-send-email-drafnel@gmail.com","threadId":"25255","inReplyTo":null,"subject":"[PATCH] git-send-email.perl: ensure $domain is defined before using it","fromName":"Brandon Casey","fromEmail":"drafnel@gmail.com","sentAt":"2010-09-27T03:18:01Z","receivedAt":"2010-09-27T03:18:01Z","isPatch":true,"sender":{"key":"drafnel@gmail.com","avatar":"https://avatars.githubusercontent.com/u/921167?v=4"},"body":"valid_fqdn() may attempt to operate on an undefined value if\nNet::Domain::domainname fails to determine the domain name.  This causes\nperl to emit unpleasant warnings.\n\nSo, add a check for whether $domain has been defined before using it.\n\nSigned-off-by: Brandon Casey <drafnel@gmail.com>\n---\n git-send-email.perl |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/git-send-email.perl b/git-send-email.perl\nindex 6dab3bf..e1f29a7 100755\n--- a/git-send-email.perl\n+++ b/git-send-email.perl\n@@ -895,7 +895,7 @@ sub sanitize_address {\n \n sub valid_fqdn {\n \tmy $domain = shift;\n-\treturn !($^O eq 'darwin' && $domain =~ /\\.local$/) && $domain =~ /\\./;\n+\treturn defined $domain && !($^O eq 'darwin' && $domain =~ /\\.local$/) && $domain =~ /\\./;\n }\n \n sub maildomain_net {\n-- \n1.7.3.1.geb284\n"},{"id":"151859","messageId":"7vhbhax20z.fsf@alter.siamese.dyndns.org","threadId":"25255","inReplyTo":"1285557481-16357-1-git-send-email-drafnel@gmail.com","subject":"Re: [PATCH] git-send-email.perl: ensure $domain is defined before using it","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-09-27T22:19:40Z","receivedAt":"2010-09-27T22:19:40Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks.\n"}]}