{"thread":{"id":"25249","subject":"[PATCH] gitweb: Move call to evaluate_git_version after evaluate_gitweb_config","startedAt":"2010-09-26T11:34:56Z","lastAt":"2010-09-26T11:34:56Z","messageCount":1,"participants":["Jakub Narebski"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"151710","messageId":"20100926113431.28918.53550.stgit@localhost.localdomain","threadId":"25249","inReplyTo":null,"subject":"[PATCH] gitweb: Move call to evaluate_git_version after evaluate_gitweb_config","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2010-09-26T11:34:56Z","receivedAt":"2010-09-26T11:34:56Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"This means that call to evaluate_git_version() is now inside\nrun_request(), which means that is called for each request instead of\nonce per starting gitweb; this matter currently only when using\nFastCGI interface (gitweb.fcgi).\n\nThis change was done becayse evaluate_git_version() uses $GIT\nvariable, which can be set / modified by gitweb config file... and it\nis modified this way by gitweb config file used in gitweb tests.\nWithout this change there is spurious extra output from t9500 test\nwhen tests are run with '--debug' option.\n\nSigned-off-by: Jakub Narebski <jnareb@gmail.com>\n---\n\n gitweb/gitweb.perl |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex a85e2f6..d521b4c 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -1061,6 +1061,7 @@ sub run_request {\n \n \tevaluate_uri();\n \tevaluate_gitweb_config();\n+\tevaluate_git_version();\n \tcheck_loadavg();\n \n \t# $projectroot and $projects_list might be set in gitweb config file\n@@ -1113,7 +1114,6 @@ sub evaluate_argv {\n \n sub run {\n \tevaluate_argv();\n-\tevaluate_git_version();\n \n \t$pre_listen_hook->()\n \t\tif $pre_listen_hook;\n"}]}