{"thread":{"id":"25230","subject":"[RFC PATCH 00/95] Add missing &&'s in the testsuite","startedAt":"2010-09-24T21:06:53Z","lastAt":"2010-09-24T22:02:14Z","messageCount":4,"participants":["Elijah Newren","Brandon Casey","Ævar Arnfjörð Bjarmason"],"isPatch":true,"patchVersion":1,"patchTotal":95},"messages":[{"id":"151550","messageId":"1285362413-18265-1-git-send-email-newren@gmail.com","threadId":"25230","inReplyTo":null,"subject":"[RFC PATCH 00/95] Add missing &&'s in the testsuite","fromName":"Elijah Newren","fromEmail":"newren@gmail.com","sentAt":"2010-09-24T21:06:53Z","receivedAt":"2010-09-24T21:06:53Z","isPatch":true,"sender":{"key":"newren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5455730?v=4"},"body":"I ran across three testfiles which were missing &&s; one was missing\nseveral, while another would no longer pass after adding one and had\nno comment to that effect. So I decided it was time to look through\nthe testsuite. Now I have a 95 patch series, which I'm worried might\nbe a bit too much spam for the mailing list. So the patches are\navailable from\n git://gitorious.org/~newren/git/en.git add-missing-ands\nLet me know if you're fine with mailing list spam, and I'd be happy\nto flood all your inboxes.\n\n80 of the 95 testfiles that needed changes were pretty mechanical --\njust simple additions of '&&' in the appropriate place. 15 needed\nother changes and I'm not entirely sure whether I made the right ones.\nI've moved those 15 to the beginning of the series, so that you won't\nhave to hunt for them. (If it makes sense to send just the first 15\nto the list, let me know, and I'll do that.)\n\n\nElijah Newren (95):\n t6050 (replace): add missing &&\n t1001 (read-tree-m-2way): add missing &&\n t1002 (read-tree-m-u-2way): add missing &&\n t3020 (ls-files-error-unmatch): remove stray '1' from end of file\n t3600 (rm): add lots of missing &&\n t4002 (diff-basic): use test_might_fail for commands that might fail\n t4017 (diff-retval): replace manual exit code check with test_expect_code\n t4019 (diff-wserror): add lots of missing &&\n t4026 (color): add missing &&\n t4202 (log): Replace ' || :' with test_might_fail\n t5602 (clone-remote-exec): add missing &&\n t6016 (rev-list-graph-simplify-history): add missing &&\n t7001 (mv): add missing &&\n t7601 (merge-pull-config): add missing &&\n t7800 (difftool): add missing &&\n t0001 (init): add missing &&\n t0003 (attributes): add missing &&\n t0020 (crlf): add missing &&\n t0024 (crlf-archive): add missing &&\n t0026 (eol-config): add missing &&\n t0050 (filesystem): add missing &&\n t1000 (read-tree-m-3way): add missing &&\n t1302 (repo-version): add missing &&\n t1401 (symbolic-ref): add missing &&\n t1402 (check-ref-format): add missing &&\n t1410 (reflog): add missing &&\n t1501 (worktree): add missing &&\n t1509 (root-worktree): add missing &&\n t2007 (checkout-symlink): add missing &&\n t2016 (checkout-patch): add missing &&\n t2050 (git-dir-relative): add missing &&\n t2103 (update-index-ignore-missing): add missing &&\n t2200 (add-update): add missing &&\n t3001 (ls-files-others-exclude): add missing &&\n t3050 (subprojects-fetch): add missing &&\n t3203 (branch-output): add missing &&\n t3307 (notes-man): add missing &&\n t3406 (rebase-message): add missing &&\n t3408 (rebase-multi-line): add missing &&\n t3504 (cherry-pick-rerere): add missing &&\n t3903 (stash): add missing &&\n t3904 (stash-patch): add missing &&\n t4021 (format-patch-numbered): add missing &&\n t4027 (diff-submodule): add missing &&\n t4103 (apply-binary): add missing &&\n t4104 (apply-boundary): add missing &&\n t4111 (apply-subdir): add missing &&\n t4119 (apply-config): add missing &&\n t4124 (apply-ws-rule): add missing &&\n t4127 (apply-same-fn): add missing &&\n t4130 (apply-criss-cross-rename): add missing &&\n t4133 (apply-filenames): add missing &&\n t4150 (am): add missing &&\n t5300 (pack-object): add missing &&\n t5301 (sliding-window): add missing &&\n t5302 (pack-index): add missing &&\n t5500 (fetch-pack): add missing &&\n t5502 (quickfetch): add missing &&\n t5503 (tagfollow): add missing &&\n t5510 (fetch): add missing &&\n t5516 (fetch-push): add missing &&\n t5517 (push-mirror): add missing &&\n t5519 (push-alternates): add missing &&\n t5531 (deep-submodule-push): add missing &&\n t5541 (http-push): add missing &&\n t5550 (http-fetch): add missing &&\n t5601 (clone): add missing &&\n t5701 (clone-local): add missing &&\n t5705 (clone-2gb): add missing &&\n t6009 (rev-list-parent): add missing &&\n t6010 (merge-base): add missing &&\n t6022 (merge-rename): add a missing &&\n t6024 (recursive-merge): add missing &&\n t6030 (bisect-porcelain): add missing &&\n t6040 (tracking-info): add missing &&\n t7004 (tag): add missing &&\n t7105 (reset-patch): add missing &&\n t7300 (clean): add missing &&\n t7501 (commit): add missing &&\n t7502 (commit): add missing &&\n t7506 (status-submodule): add missing &&\n t7600 (merge): add missing &&\n t7610 (mergetool): add missing &&\n t7700 (repack): add missing &&\n t8003 (blame): add missing &&\n t9122 (git-svn-author): add missing &&\n t9123 (git-svn-rebuild-with-rewriteroot): add missing &&\n t9134 (git-svn-ignore-paths): add missing &&\n t9137 (git-svn-dcommit-clobber-series): add missing &&\n t9138 (git-svn-authors-prog): add missing &&\n t9146 (git-svn-empty-dirs): add missing &&\n t9151 (svn-mergeinfo): add missing &&\n t9200 (git-cvsexportcommit): add missing &&\n t9401 (git-cvsserver-crlf): add missing &&\n t9600 (cvsimport): add missing &&\n\n t/t0001-init.sh | 20 +++++-----\n t/t0003-attributes.sh | 16 ++++----\n t/t0020-crlf.sh | 2 +-\n t/t0024-crlf-archive.sh | 4 +-\n t/t0026-eol-config.sh | 2 +-\n t/t0050-filesystem.sh | 6 ++--\n t/t1000-read-tree-m-3way.sh | 2 +-\n t/t1001-read-tree-m-2way.sh | 18 +++++-----\n t/t1002-read-tree-m-u-2way.sh | 10 +++---\n t/t1302-repo-version.sh | 2 +-\n t/t1401-symbolic-ref.sh | 2 +-\n t/t1402-check-ref-format.sh | 4 +-\n t/t1410-reflog.sh | 8 ++--\n t/t1501-worktree.sh | 2 +-\n t/t1509-root-worktree.sh | 6 ++--\n t/t2007-checkout-symlink.sh | 2 +-\n t/t2016-checkout-patch.sh | 2 +-\n t/t2050-git-dir-relative.sh | 4 +-\n t/t2103-update-index-ignore-missing.sh | 2 +-\n t/t2200-add-update.sh | 2 +-\n t/t3001-ls-files-others-exclude.sh | 2 +-\n t/t3020-ls-files-error-unmatch.sh | 1 -\n t/t3050-subprojects-fetch.sh | 4 +-\n t/t3203-branch-output.sh | 6 ++--\n t/t3307-notes-man.sh | 2 +-\n t/t3406-rebase-message.sh | 6 ++--\n t/t3408-rebase-multi-line.sh | 2 +-\n t/t3504-cherry-pick-rerere.sh | 4 +-\n t/t3600-rm.sh | 38 +++++++++-----------\n t/t3903-stash.sh | 4 +-\n t/t3904-stash-patch.sh | 2 +-\n t/t4002-diff-basic.sh | 12 +++---\n t/t4017-diff-retval.sh | 30 +++++----------\n t/t4019-diff-wserror.sh | 52 +++++++++++++-------------\n t/t4021-format-patch-numbered.sh | 2 +-\n t/t4026-color.sh | 2 +-\n t/t4027-diff-submodule.sh | 2 +-\n t/t4103-apply-binary.sh | 8 ++--\n t/t4104-apply-boundary.sh | 4 +-\n t/t4111-apply-subdir.sh | 4 +-\n t/t4119-apply-config.sh | 2 +-\n t/t4124-apply-ws-rule.sh | 4 +-\n t/t4127-apply-same-fn.sh | 18 +++++-----\n t/t4130-apply-criss-cross-rename.sh | 2 +-\n t/t4133-apply-filenames.sh | 6 ++--\n t/t4150-am.sh | 2 +-\n t/t4202-log.sh | 2 +-\n t/t5300-pack-object.sh | 4 +-\n t/t5301-sliding-window.sh | 2 +-\n t/t5302-pack-index.sh | 2 +-\n t/t5500-fetch-pack.sh | 2 +-\n t/t5502-quickfetch.sh | 2 +-\n t/t5503-tagfollow.sh | 4 +-\n t/t5510-fetch.sh | 2 +-\n t/t5516-fetch-push.sh | 20 +++++-----\n t/t5517-push-mirror.sh | 10 +++---\n t/t5519-push-alternates.sh | 2 +-\n t/t5531-deep-submodule-push.sh | 2 +-\n t/t5541-http-push.sh | 2 +-\n t/t5550-http-fetch.sh | 6 ++--\n t/t5601-clone.sh | 6 ++--\n t/t5602-clone-remote-exec.sh | 14 ++++----\n t/t5701-clone-local.sh | 8 ++--\n t/t5705-clone-2gb.sh | 2 +-\n t/t6009-rev-list-parent.sh | 2 +-\n t/t6010-merge-base.sh | 2 +-\n t/t6016-rev-list-graph-simplify-history.sh | 24 +++---------\n t/t6022-merge-rename.sh | 2 +-\n t/t6024-recursive-merge.sh | 2 +-\n t/t6030-bisect-porcelain.sh | 8 ++--\n t/t6040-tracking-info.sh | 2 +-\n t/t6050-replace.sh | 4 +-\n t/t7001-mv.sh | 2 +-\n t/t7004-tag.sh | 14 ++++----\n t/t7105-reset-patch.sh | 6 ++--\n t/t7300-clean.sh | 6 ++--\n t/t7501-commit.sh | 2 +-\n t/t7502-commit.sh | 2 +-\n t/t7506-status-submodule.sh | 2 +-\n t/t7600-merge.sh | 2 +-\n t/t7601-merge-pull-config.sh | 12 +++---\n t/t7610-mergetool.sh | 2 +-\n t/t7700-repack.sh | 2 +-\n t/t7800-difftool.sh | 12 +++---\n t/t8003-blame.sh | 6 ++--\n t/t9122-git-svn-author.sh | 4 +-\n t/t9123-git-svn-rebuild-with-rewriteroot.sh | 2 +-\n t/t9134-git-svn-ignore-paths.sh | 6 ++--\n t/t9137-git-svn-dcommit-clobber-series.sh | 2 +-\n t/t9138-git-svn-authors-prog.sh | 6 ++--\n t/t9146-git-svn-empty-dirs.sh | 6 ++--\n t/t9151-svn-mergeinfo.sh | 22 ++++++------\n t/t9200-git-cvsexportcommit.sh | 4 +-\n t/t9401-git-cvsserver-crlf.sh | 2 +-\n t/t9600-cvsimport.sh | 2 +-\n 95 files changed, 287 insertions(+), 314 deletions(-)\n\n-- \n1.7.3.95.g14291\n"},{"id":"151553","messageId":"UA25cdpM3towJy13l2VNc8pgKHGybUWr88Zc0C9kQjUCExhj5gXkCQ@cipher.nrlssc.navy.mil","threadId":"25230","inReplyTo":"1285362413-18265-1-git-send-email-newren@gmail.com","subject":"Re: [RFC PATCH 00/95] Add missing &&'s in the testsuite","fromName":"Brandon Casey","fromEmail":"brandon.casey.ctr@nrlssc.navy.mil","sentAt":"2010-09-24T21:32:30Z","receivedAt":"2010-09-24T21:32:30Z","isPatch":true,"sender":{"key":"brandon.casey.ctr@nrlssc.navy.mil","avatar":null},"body":"On 09/24/2010 04:06 PM, Elijah Newren wrote:\n> I ran across three testfiles which were missing &&s; one was missing\n> several, while another would no longer pass after adding one and had\n> no comment to that effect. So I decided it was time to look through\n> the testsuite. Now I have a 95 patch series, which I'm worried might\n> be a bit too much spam for the mailing list. So the patches are\n> available from\n> git://gitorious.org/~newren/git/en.git add-missing-ands\n> Let me know if you're fine with mailing list spam, and I'd be happy\n> to flood all your inboxes.\n> \n> 80 of the 95 testfiles that needed changes were pretty mechanical --\n> just simple additions of '&&' in the appropriate place. 15 needed\n> other changes and I'm not entirely sure whether I made the right ones.\n> I've moved those 15 to the beginning of the series, so that you won't\n> have to hunt for them. (If it makes sense to send just the first 15\n> to the list, let me know, and I'll do that.)\n\nSounds like it should be about a 16 patch series.\n\nThe first 15 patches should rework the tests that will fail when\nthey are hooked together properly with &&'s.\n\nAnd then one patch to mechanically add the missing &&'s.\n\nMaybe even some of the first 15 patches could be squashed if any of\nthem apply the same fix, just to different test files.\n\n-Brandon\n"},{"id":"151558","messageId":"AANLkTimdp1+urRt5kwo=1OEg5X-2mAZ6OWQvdyyAWZRt@mail.gmail.com","threadId":"25230","inReplyTo":"UA25cdpM3towJy13l2VNc8pgKHGybUWr88Zc0C9kQjUCExhj5gXkCQ@cipher.nrlssc.navy.mil","subject":"Re: [RFC PATCH 00/95] Add missing &&'s in the testsuite","fromName":"Elijah Newren","fromEmail":"newren@gmail.com","sentAt":"2010-09-24T21:54:50Z","receivedAt":"2010-09-24T21:54:50Z","isPatch":true,"sender":{"key":"newren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5455730?v=4"},"body":"On Fri, Sep 24, 2010 at 3:32 PM, Brandon Casey\n wrote:\n> Sounds like it should be about a 16 patch series.\n>\n> The first 15 patches should rework the tests that will fail when\n> they are hooked together properly with &&'s.\n\nActually, only 9 of the tests fail when hooked together with &&'s and\nneeded extra fixes because of this. 4 of the tests modify the code\nslightly in order to chain it together (e.g. replacing \"a_command ||\nreturn 1; command_that_fails\" with \"a_command && test_might_fail\ncommand_that_fails &&\"), 1 removes a stray \"1\" at the end of the file,\nand one fixes lack of chaining by modifying tests to use\ntest_exit_code instead of test_expect_success (namely tests that did\nnothing but check the exit code of a single command).\n\n> And then one patch to mechanically add the missing &&'s.\n\nSure, I can include that change for the next round.\n\n\nThanks for the feedback.\n\nElijah\n"},{"id":"151559","messageId":"AANLkTimMrw-QgFPy=EjNciLSGBicrwE-Gi8CxbmVWX+i@mail.gmail.com","threadId":"25230","inReplyTo":"1285362413-18265-1-git-send-email-newren@gmail.com","subject":"Re: [RFC PATCH 00/95] Add missing &&'s in the testsuite","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2010-09-24T22:02:14Z","receivedAt":"2010-09-24T22:02:14Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"On Fri, Sep 24, 2010 at 21:06, Elijah Newren wrote:\n\n>   git://gitorious.org/~newren/git/en.git   add-missing-ands\n> Let me know if you're fine with mailing list spam, and I'd be happy\n> to flood all your inboxes.\n\nI'd be fine with it on list. But maybe you can fold it all into one\nE-Mail and send it to list. I'd like to comment on some of them.\n\nIt's probably best not to squash it too hard, at least not the ones\nwith TODO and FIXME comments. It'll also be easier for you to manage\nthis if you don't squash it prematurely.\n"}]}