{"thread":{"id":"25216","subject":"[PATCH] git-svn: fix processing of decorated commit hashes","startedAt":"2010-09-23T22:05:03Z","lastAt":"2010-09-24T16:28:38Z","messageCount":2,"participants":["Mathias Lafeldt","Eric Wong"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"151409","messageId":"4C9BCF0F.5020101@debugon.org","threadId":"25216","inReplyTo":null,"subject":"[PATCH] git-svn: fix processing of decorated commit hashes","fromName":"Mathias Lafeldt","fromEmail":"misfire@debugon.org","sentAt":"2010-09-23T22:05:03Z","receivedAt":"2010-09-23T22:05:03Z","isPatch":true,"sender":{"key":"misfire@debugon.org","avatar":"https://avatars.githubusercontent.com/u/158074?v=4"},"body":"The function working_head_info() fails to parse commit hashes if they\nare decorated (i.e. log.decorate is true), causing dcommit, rebase, and\nother vital git-svn commands to malfunction.\n\nThis patch disables decorated log output with --no-decorate.\n\nSigned-off-by: Mathias Lafeldt <misfire@debugon.org>\n---\n git-svn.perl |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/git-svn.perl b/git-svn.perl\nindex 9b046b6..90e1236 100755\n--- a/git-svn.perl\n+++ b/git-svn.perl\n@@ -1513,7 +1513,7 @@ sub cmt_sha2rev_batch {\n \n sub working_head_info {\n \tmy ($head, $refs) = @_;\n-\tmy @args = ('log', '--no-color', '--first-parent', '--pretty=medium');\n+\tmy @args = qw/log --no-color --no-decorate --first-parent --pretty=medium/;\n \tmy ($fh, $ctx) = command_output_pipe(@args, $head);\n \tmy $hash;\n \tmy %max;\n-- \n1.7.3\n"},{"id":"151511","messageId":"20100924162838.GB4513@dcvr.yhbt.net","threadId":"25216","inReplyTo":"4C9BCF0F.5020101@debugon.org","subject":"Re: [PATCH] git-svn: fix processing of decorated commit hashes","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2010-09-24T16:28:38Z","receivedAt":"2010-09-24T16:28:38Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Mathias Lafeldt <misfire@debugon.org> wrote:\n> The function working_head_info() fails to parse commit hashes if they\n> are decorated (i.e. log.decorate is true), causing dcommit, rebase, and\n> other vital git-svn commands to malfunction.\n> \n> This patch disables decorated log output with --no-decorate.\n> \n> Signed-off-by: Mathias Lafeldt <misfire@debugon.org>\n\nThanks Mathias,\n\nI wrapped the long line to 80 chars but otherwise everything is good.\n\nAcked-by: Eric Wong <normalperson@yhbt.net>\n\n> ---\n>  git-svn.perl |    2 +-\n>  1 files changed, 1 insertions(+), 1 deletions(-)\n> \n> diff --git a/git-svn.perl b/git-svn.perl\n> index 9b046b6..90e1236 100755\n> --- a/git-svn.perl\n> +++ b/git-svn.perl\n> @@ -1513,7 +1513,7 @@ sub cmt_sha2rev_batch {\n>  \n>  sub working_head_info {\n>  \tmy ($head, $refs) = @_;\n> -\tmy @args = ('log', '--no-color', '--first-parent', '--pretty=medium');\n> +\tmy @args = qw/log --no-color --no-decorate --first-parent --pretty=medium/;\n>  \tmy ($fh, $ctx) = command_output_pipe(@args, $head);\n>  \tmy $hash;\n>  \tmy %max;\n> -- \n> 1.7.3\n"}]}