{"thread":{"id":"25132","subject":"[PATCHv2] remote-helpers: build in platform independent directory","startedAt":"2010-09-17T21:00:53Z","lastAt":"2010-09-18T12:36:56Z","messageCount":3,"participants":["Michael J Gruber","Sverre Rabbelier"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"150906","messageId":"705f70e3df519fc28e551b4c0bd7512277e7a190.1284757060.git.git@drmicha.warpmail.net","threadId":"25132","inReplyTo":null,"subject":"[PATCHv2] remote-helpers: build in platform independent directory","fromName":"Michael J Gruber","fromEmail":"git@drmicha.warpmail.net","sentAt":"2010-09-17T21:00:53Z","receivedAt":"2010-09-17T21:00:53Z","isPatch":false,"sender":{"key":"git@grubix.eu","avatar":"https://avatars.githubusercontent.com/u/233215?v=4"},"body":"The build directory which is used by distutils depends on the platform\n(e.g. build/lib on Fedora 13, build/lib.linux-i686-2.6 on Ubuntu 9.04).\nBut test-lib.sh expects to find the build in build/lib which can cause\nt5800-remote-helpers.sh to fail early.\n\nOverride distutils' choice so that the build is always in build/lib.\n\nSigned-off-by: Michael J Gruber <git@drmicha.warpmail.net>\n---\nSorry for the v2 so soon. With the previous version, the \"make install\" step\nwould still possibly create a platform dependent build dir. This works but\ncreates two lib dirs within build, which is unnecessary and confusing.\nThe solution with setup.cfg avoids this and is cleaner anyways.\n\n git_remote_helpers/setup.cfg |    3 +++\n 1 files changed, 3 insertions(+), 0 deletions(-)\n create mode 100644 git_remote_helpers/setup.cfg\n\ndiff --git a/git_remote_helpers/setup.cfg b/git_remote_helpers/setup.cfg\nnew file mode 100644\nindex 0000000..4bff887\n--- /dev/null\n+++ b/git_remote_helpers/setup.cfg\n@@ -0,0 +1,3 @@\n+[build]\n+build_purelib = build/lib\n+build_platlib = build/lib\n-- \n1.7.3.rc2.221.gbf93f\n"},{"id":"150907","messageId":"AANLkTi=ye=Xkz2XaiBaqX3NsZOe0N1NRTaVpPcsSM8o9@mail.gmail.com","threadId":"25132","inReplyTo":"705f70e3df519fc28e551b4c0bd7512277e7a190.1284757060.git.git@drmicha.warpmail.net","subject":"Re: [PATCHv2] remote-helpers: build in platform independent directory","fromName":"Sverre Rabbelier","fromEmail":"srabbelier@gmail.com","sentAt":"2010-09-17T21:07:49Z","receivedAt":"2010-09-17T21:07:49Z","isPatch":false,"sender":{"key":"srabbelier@gmail.com","avatar":"https://avatars.githubusercontent.com/u/3098?v=4"},"body":"Heya,\n\n[+Jonathan again]\n\nOn Fri, Sep 17, 2010 at 23:00, Michael J Gruber\n<git@drmicha.warpmail.net> wrote:\n> The solution with setup.cfg avoids this and is cleaner anyways.\n\nThis does feel a lot cleaner, I like this approach better than the v1\none. I suspect Junio's question still stands though:\n\nOn Fri, Sep 17, 2010 at 20:41, Junio C Hamano <gitster@pobox.com> wrote:\n> Hmm, wouldn't this interfere with the install target if you do not tell\n> the \"setup.py install\" where your built stuff lives?\n\n-- \nCheers,\n\nSverre Rabbelier\n"},{"id":"150947","messageId":"4C94B268.2050904@drmicha.warpmail.net","threadId":"25132","inReplyTo":"AANLkTi=ye=Xkz2XaiBaqX3NsZOe0N1NRTaVpPcsSM8o9@mail.gmail.com","subject":"Re: [PATCHv2] remote-helpers: build in platform independent directory","fromName":"Michael J Gruber","fromEmail":"git@drmicha.warpmail.net","sentAt":"2010-09-18T12:36:56Z","receivedAt":"2010-09-18T12:36:56Z","isPatch":false,"sender":{"key":"git@grubix.eu","avatar":"https://avatars.githubusercontent.com/u/233215?v=4"},"body":"Sverre Rabbelier venit, vidit, dixit 17.09.2010 23:07:\n> Heya,\n> \n> [+Jonathan again]\n> \n> On Fri, Sep 17, 2010 at 23:00, Michael J Gruber\n> <git@drmicha.warpmail.net> wrote:\n>> The solution with setup.cfg avoids this and is cleaner anyways.\n> \n> This does feel a lot cleaner, I like this approach better than the v1\n> one. I suspect Junio's question still stands though:\n> \n> On Fri, Sep 17, 2010 at 20:41, Junio C Hamano <gitster@pobox.com> wrote:\n>> Hmm, wouldn't this interfere with the install target if you do not tell\n>> the \"setup.py install\" where your built stuff lives?\n> \n\nNo, it addresses that also. Maybe my note after the boiler plate was not\nclear enough, but the \"build\" setting in setup.cfg also governs the\nbuild phase of \"setup.py install\". Install would work with v1 also but\nwould possibly create another dir during the build phase, with v2 both\nbuild phases (that of the build subcommand as well as that of the\ninstall subcommand) use the same setting.\n\nMichael\n"}]}